coreboot-gerrit June 2014

coreboot-gerrit@coreboot.org

1 participants
922 discussions

Patch set updated for coreboot: 1ba8588 build: Use clang driver to invocate linker and link compiler-rt
by Edward O'Callaghan 27 Jun '14

27 Jun '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5823 -gerrit commit 1ba8588a17ddfac58c7d70fe0400f68d5e663c51 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Fri May 23 10:57:52 2014 +1000 build: Use clang driver to invocate linker and link compiler-rt NOTFORMERGE: This does not _yet_ work with the current clang driver, pending upstream fixes. Let the Clang driver frontend invocate the correct target linker and runtime symbols from compiler-rt. Change-Id: I8b5a824eab98568a77df82596c175a8f0129c5e7 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- Makefile | 2 +- src/arch/x86/Makefile.inc | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index 195bfe6..f9cacfc 100644 --- a/Makefile +++ b/Makefile @@ -109,7 +109,7 @@ include $(HAVE_DOTCONFIG) ifeq ($(CONFIG_COMPILER_LLVM_CLANG),y) # FIXME: armv7/aarch64 won't build right now -CFLAGS_x86_32 = -no-integrated-as -Qunused-arguments -target i386-elf -m32 +CFLAGS_x86_32 = -no-integrated-as -Qunused-arguments -target i386-elf -m32 -rtlib=compiler-rt CC_x86_32:=clang ifneq ($(CONFIG_MMX),y) diff --git a/src/arch/x86/Makefile.inc b/src/arch/x86/Makefile.inc index 125e9de..ab71838 100644 --- a/src/arch/x86/Makefile.inc +++ b/src/arch/x86/Makefile.inc @@ -209,7 +209,7 @@ romstage-libs ?= $(objcbfs)/romstage_null.debug: $$(romstage-objs) $(objgenerated)/romstage_null.ld $$(romstage-libs) @printf " LINK $(subst $(obj)/,,$(@))\n" ifeq ($(CONFIG_COMPILER_LLVM_CLANG),y) - $(LD_romstage) -nostdlib -nostartfiles -static -o $@ -L$(obj) --start-group $(romstage-objs) $(romstage-libs) $(LIBGCC_FILE_NAME_romstage) --end-group -T $(objgenerated)/romstage_null.ld + $(CC_romstage) $(CFLAGS_romstage) -nostdlib -nostartfiles -static -o $@ -L$(obj) -Wl,--start-group $(romstage-objs) $(romstage-libs) -Wl,--end-group -T $(objgenerated)/romstage_null.ld else $(CC_romstage) $(CFLAGS_romstage) -nostdlib -nostartfiles -static -o $@ -L$(obj) -T $(objgenerated)/romstage_null.ld -Wl,--wrap,__divdi3 -Wl,--wrap,__udivdi3 -Wl,--wrap,__moddi3 -Wl,--wrap,__umoddi3 -Wl,--start-group $(romstage-objs) $(romstage-libs) $(LIBGCC_FILE_NAME_romstage) -Wl,--end-group endif @@ -221,7 +221,7 @@ endif $(objcbfs)/romstage_xip.debug: $$(romstage-objs) $(objgenerated)/romstage_xip.ld $$(romstage-libs) @printf " LINK $(subst $(obj)/,,$(@))\n" ifeq ($(CONFIG_COMPILER_LLVM_CLANG),y) - $(LD_romstage) -nostdlib -nostartfiles -static -o $@ -L$(obj) --start-group $(romstage-objs) $(romstage-libs) $(LIBGCC_FILE_NAME_romstage) --end-group -T $(objgenerated)/romstage_xip.ld + $(CC_romstage) $(CFLAGS_romstage) -nostdlib -nostartfiles -static -o $@ -L$(obj) -Wl,--start-group $(romstage-objs) $(romstage-libs) -Wl,--end-group -T $(objgenerated)/romstage_xip.ld else $(CC_romstage) $(CFLAGS_romstage) -nostdlib -nostartfiles -static -o $@ -L$(obj) -T $(objgenerated)/romstage_xip.ld -Wl,--wrap,__divdi3 -Wl,--wrap,__udivdi3 -Wl,--wrap,__moddi3 -Wl,--wrap,__umoddi3 -Wl,--start-group $(romstage-objs) $(romstage-libs) $(LIBGCC_FILE_NAME_romstage) -Wl,--end-group endif @@ -332,7 +332,7 @@ endif $(objgenerated)/ramstage.o: $$(ramstage-objs) $(LIBGCC_FILE_NAME_ramstage) $$(ramstage-libs) @printf " CC $(subst $(obj)/,,$(@))\n" ifeq ($(CONFIG_COMPILER_LLVM_CLANG),y) - $(LD_ramstage) -m elf_i386 -r -o $@ --start-group $(ramstage-objs) $(ramstage-libs) $(LIBGCC_FILE_NAME_ramstage) --end-group + $(CC_ramstage) $(CFLAGS_ramstage) -nostdlib -r -o $@ -Wl,--start-group $(ramstage-objs) $(ramstage-libs) -Wl,--end-group else $(CC_ramstage) $(CFLAGS_ramstage) -nostdlib -r -o $@ -Wl,--wrap,__divdi3 -Wl,--wrap,__udivdi3 -Wl,--wrap,__moddi3 -Wl,--wrap,__umoddi3 -Wl,--start-group $(ramstage-objs) $(ramstage-libs) $(LIBGCC_FILE_NAME_ramstage) -Wl,--end-group endif

1 0

Patch merged into coreboot/master: 0ae068e src/console/post.c: Sanitize headers from preprocessor abuse
by gerrit＠coreboot.org 27 Jun '14

27 Jun '14

the following patch was just integrated into master: commit 0ae068efdb23fa07293dcd55b48d25a095aa062c Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Sat Jun 21 21:42:25 2014 +1000 src/console/post.c: Sanitize headers from preprocessor abuse Continuing on from the rational given in: a173a62 Remove guarding #includes by CONFIG_FOO combinations Change-Id: I524713b21684f6fa99355614a1ab38aee9975790 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Reviewed-on: http://review.coreboot.org/6091 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth <gaumless(a)gmail.com> See http://review.coreboot.org/6091 for details. -gerrit

1 0

Patch merged into coreboot/master: 5e19650 include/device/device.h: Header is ROMCC tentative
by gerrit＠coreboot.org 27 Jun '14

27 Jun '14

the following patch was just integrated into master: commit 5e196506860889c9ef19c048e20cd68e55edb885 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Tue Jun 24 17:35:02 2014 +1000 include/device/device.h: Header is ROMCC tentative This header is incompatible with ROMCC and its inclusion leads to 'odd' build failures. Change-Id: If31d774385796dcafe2fd48151e424b4c872aec3 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Reviewed-on: http://review.coreboot.org/6103 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth <gaumless(a)gmail.com> See http://review.coreboot.org/6103 for details. -gerrit

1 0

New patch to review for coreboot: 4396eaa intel: Make monotonic timer a first class citizen
by Edward O'Callaghan 27 Jun '14

27 Jun '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6135 -gerrit commit 4396eaaef426882737656f078888707a27f3758e Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Fri Jun 27 12:13:30 2014 +1000 intel: Make monotonic timer a first class citizen NOTFORMERGE Change-Id: I4e43d2680bf84bc525138f71c2b813b0f6be5265 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/cpu/intel/model_206ax/Kconfig | 2 ++ src/mainboard/intel/baskingridge/Kconfig | 1 + 2 files changed, 3 insertions(+) diff --git a/src/cpu/intel/model_206ax/Kconfig b/src/cpu/intel/model_206ax/Kconfig index a679e00..1456f94 100644 --- a/src/cpu/intel/model_206ax/Kconfig +++ b/src/cpu/intel/model_206ax/Kconfig @@ -19,6 +19,8 @@ config CPU_SPECIFIC_OPTIONS select PARALLEL_CPU_INIT #select AP_IN_SIPI_WAIT select TSC_SYNC_MFENCE + select HAVE_MONOTONIC_TIMER + select LAPIC_MONOTONIC_TIMER config BOOTBLOCK_CPU_INIT string diff --git a/src/mainboard/intel/baskingridge/Kconfig b/src/mainboard/intel/baskingridge/Kconfig index b52df97..051072a 100644 --- a/src/mainboard/intel/baskingridge/Kconfig +++ b/src/mainboard/intel/baskingridge/Kconfig @@ -12,6 +12,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy select HAVE_SMI_HANDLER select MAINBOARD_HAS_CHROMEOS select LAPIC_MONOTONIC_TIMER + select MONOTONIC_TIMER_MSR config MAINBOARD_DIR string

1 0

Patch set updated for coreboot: 3f19d9e drivers/pc80/mc146818rtc_early.c: Silence unused func complaints
by Edward O'Callaghan 27 Jun '14

27 Jun '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6122 -gerrit commit 3f19d9e42f635f639f0bf270b43a8a2c1332bbd2 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Thu Jun 26 18:14:04 2014 +1000 drivers/pc80/mc146818rtc_early.c: Silence unused func complaints Clang complains these functions are unused since they find their way into the bootblock of ROMCC boards by #including the .c file. These static inlines should probably be moved into a header in reality. Change-Id: I9d82a6befb0ac99afab6265f9d3649e419f2887d Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/drivers/pc80/mc146818rtc_early.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/drivers/pc80/mc146818rtc_early.c b/src/drivers/pc80/mc146818rtc_early.c index 0652f27..145fe21 100644 --- a/src/drivers/pc80/mc146818rtc_early.c +++ b/src/drivers/pc80/mc146818rtc_early.c @@ -42,14 +42,14 @@ static int cmos_chksum_valid(void) } -static inline int last_boot_normal(void) +static inline __attribute__((unused)) int last_boot_normal(void) { unsigned char byte; byte = cmos_read(RTC_BOOT_BYTE); return (byte & (1 << 1)); } -static inline int do_normal_boot(void) +static inline __attribute__((unused)) int do_normal_boot(void) { unsigned char byte;

1 0

Patch set updated for coreboot: f0bebe6 lib/Makefile.inc: Stop gcc.c getting into SMM clang builds
by Edward O'Callaghan 27 Jun '14

27 Jun '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6121 -gerrit commit f0bebe6f1113fc5f16e1cc192c8f6155b86ce265 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Thu Jun 26 18:12:11 2014 +1000 lib/Makefile.inc: Stop gcc.c getting into SMM clang builds The libgcc runtime workarounds found in gcc.c are not needed for compiler-rt used by the Clang toolchain. Stop gcc.c from sneaking into Clang builds while processing boards that use SMM code. Change-Id: I51e8d517784721d28b4d951bd0bebc8b52682a8e Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/lib/Makefile.inc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/lib/Makefile.inc b/src/lib/Makefile.inc index 522f43a..5298bbe 100644 --- a/src/lib/Makefile.inc +++ b/src/lib/Makefile.inc @@ -88,7 +88,7 @@ ramstage-$(CONFIG_REG_SCRIPT) += reg_script.c romstage-$(CONFIG_CACHE_RELOCATED_RAMSTAGE_OUTSIDE_CBMEM) += ramstage_cache.c smm-y += cbfs.c memcmp.c -smm-y += gcc.c +smm-$(CONFIG_COMPILER_GCC) += gcc.c $(obj)/lib/version.ramstage.o : $(obj)/build.h @@ -118,4 +118,3 @@ $(strip $(1)).rmod: $(strip $(1)) endef endif -

1 0

Patch set updated for coreboot: 8b4c4bc AMD boards: Fix comment style and typos
by Kyösti Mälkki 26 Jun '14

26 Jun '14

Kyösti Mälkki (kyosti.malkki(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6118 -gerrit commit 8b4c4bcaf7e49c6ca8301830217b063583131142 Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Date: Thu Jun 26 05:30:54 2014 +0300 AMD boards: Fix comment style and typos Change-Id: Id630cc46b79a39e1786d42adbc21f3b9c3a051aa Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- src/northbridge/amd/agesa/family10/northbridge.c | 4 +++- src/northbridge/amd/agesa/family12/northbridge.c | 5 +++-- src/northbridge/amd/agesa/family14/northbridge.c | 4 ++-- src/northbridge/amd/agesa/family15/northbridge.c | 5 ++++- src/northbridge/amd/agesa/family15tn/northbridge.c | 5 ++++- src/northbridge/amd/agesa/family16kb/northbridge.c | 5 ++++- src/northbridge/amd/amdfam10/northbridge.c | 4 +++- src/northbridge/amd/amdk8/northbridge.c | 4 +++- 8 files changed, 26 insertions(+), 10 deletions(-) diff --git a/src/northbridge/amd/agesa/family10/northbridge.c b/src/northbridge/amd/agesa/family10/northbridge.c index 886d112..7a990d9 100644 --- a/src/northbridge/amd/agesa/family10/northbridge.c +++ b/src/northbridge/amd/agesa/family10/northbridge.c @@ -881,7 +881,9 @@ static struct hw_mem_hole_info get_hw_mem_hole_info(void) } } - //We need to double check if there is speical set on base reg and limit reg are not continous instead of hole, it will find out it's hole_startk + /* We need to double check if there is special set on base reg and limit reg + * are not continuous instead of hole, it will find out its hole_startk. + */ if (mem_hole.node_id == -1) { resource_t limitk_pri = 0; for (i=0; i<sysconf.nodes; i++) { diff --git a/src/northbridge/amd/agesa/family12/northbridge.c b/src/northbridge/amd/agesa/family12/northbridge.c index 5701ed0..7d71624 100644 --- a/src/northbridge/amd/agesa/family12/northbridge.c +++ b/src/northbridge/amd/agesa/family12/northbridge.c @@ -315,8 +315,9 @@ static struct hw_mem_hole_info get_hw_mem_hole_info(void) } #if 0 - // We need to double check if there is speical set on base reg and limit reg - // are not continous instead of hole, it will find out it's hole_startk + /* We need to double check if there is special set on base reg and limit reg + * are not continuous instead of hole, it will find out its hole_startk. + */ if(mem_hole.node_id==-1) { resource_t limitk_pri = 0; struct dram_base_mask_t d; diff --git a/src/northbridge/amd/agesa/family14/northbridge.c b/src/northbridge/amd/agesa/family14/northbridge.c index 75ea76d..41de9cc 100644 --- a/src/northbridge/amd/agesa/family14/northbridge.c +++ b/src/northbridge/amd/agesa/family14/northbridge.c @@ -302,8 +302,8 @@ static struct hw_mem_hole_info get_hw_mem_hole_info(void) } } #if 0 - /* We need to double check if there is speical set on base reg and limit reg - * are not continous instead of hole, it will find out it's hole_startk + /* We need to double check if there is special set on base reg and limit reg + * are not continuous instead of hole, it will find out its hole_startk. */ if (mem_hole.node_id == -1) { resource_t limitk_pri = 0; diff --git a/src/northbridge/amd/agesa/family15/northbridge.c b/src/northbridge/amd/agesa/family15/northbridge.c index 05acf96..eada06f 100644 --- a/src/northbridge/amd/agesa/family15/northbridge.c +++ b/src/northbridge/amd/agesa/family15/northbridge.c @@ -622,7 +622,10 @@ static struct hw_mem_hole_info get_hw_mem_hole_info(void) break; // only one hole } } - //We need to double check if there is speical set on base reg and limit reg are not continous instead of hole, it will find out it's hole_startk + + /* We need to double check if there is special set on base reg and limit reg + * are not continuous instead of hole, it will find out its hole_startk. + */ if (mem_hole.node_id == -1) { resource_t limitk_pri = 0; for (i=0; i<node_nums; i++) { diff --git a/src/northbridge/amd/agesa/family15tn/northbridge.c b/src/northbridge/amd/agesa/family15tn/northbridge.c index 51df5ee..49f3610 100644 --- a/src/northbridge/amd/agesa/family15tn/northbridge.c +++ b/src/northbridge/amd/agesa/family15tn/northbridge.c @@ -596,7 +596,10 @@ static struct hw_mem_hole_info get_hw_mem_hole_info(void) break; // only one hole } } - //We need to double check if there is speical set on base reg and limit reg are not continous instead of hole, it will find out it's hole_startk + + /* We need to double check if there is special set on base reg and limit reg + * are not continuous instead of hole, it will find out its hole_startk. + */ if (mem_hole.node_id == -1) { resource_t limitk_pri = 0; for (i=0; i<node_nums; i++) { diff --git a/src/northbridge/amd/agesa/family16kb/northbridge.c b/src/northbridge/amd/agesa/family16kb/northbridge.c index f421413..5b43141 100644 --- a/src/northbridge/amd/agesa/family16kb/northbridge.c +++ b/src/northbridge/amd/agesa/family16kb/northbridge.c @@ -600,7 +600,10 @@ static struct hw_mem_hole_info get_hw_mem_hole_info(void) break; // only one hole } } - //We need to double check if there is speical set on base reg and limit reg are not continous instead of hole, it will find out it's hole_startk + + /* We need to double check if there is special set on base reg and limit reg + * are not continuous instead of hole, it will find out its hole_startk. + */ if (mem_hole.node_id == -1) { resource_t limitk_pri = 0; for (i=0; i<node_nums; i++) { diff --git a/src/northbridge/amd/amdfam10/northbridge.c b/src/northbridge/amd/amdfam10/northbridge.c index 223cd9f..529dc0a 100644 --- a/src/northbridge/amd/amdfam10/northbridge.c +++ b/src/northbridge/amd/amdfam10/northbridge.c @@ -735,7 +735,9 @@ static struct hw_mem_hole_info get_hw_mem_hole_info(void) } } - //We need to double check if there is speical set on base reg and limit reg are not continous instead of hole, it will find out it's hole_startk + /* We need to double check if there is special set on base reg and limit reg + * are not continuous instead of hole, it will find out its hole_startk. + */ if(mem_hole.node_id==-1) { resource_t limitk_pri = 0; for(i=0; i<sysconf.nodes; i++) { diff --git a/src/northbridge/amd/amdk8/northbridge.c b/src/northbridge/amd/amdk8/northbridge.c index ee5dfd2..2c19b3a 100644 --- a/src/northbridge/amd/amdk8/northbridge.c +++ b/src/northbridge/amd/amdk8/northbridge.c @@ -698,7 +698,9 @@ static struct hw_mem_hole_info get_hw_mem_hole_info(void) } } - //We need to double check if there is speical set on base reg and limit reg are not continous instead of hole, it will find out it's hole_startk + /* We need to double check if there is special set on base reg and limit reg + * are not continuous instead of hole, it will find out its hole_startk. + */ if(mem_hole.node_id==-1) { u32 limitk_pri = 0; for(i=0; i<8; i++) {

1 0

Patch merged into coreboot/master: faaa253 amd/persimmon jetway/nf81-t56n-lf: Fix whitespace and alignment
by gerrit＠coreboot.org 26 Jun '14

26 Jun '14

the following patch was just integrated into master: commit faaa25366030e8a02c21e0eb0c96d839ad535232 Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Date: Thu Jun 26 07:11:22 2014 +0300 amd/persimmon jetway/nf81-t56n-lf: Fix whitespace and alignment Change-Id: I76f017b0919e301eeb84e73eff21170bbc921ae2 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Reviewed-on: http://review.coreboot.org/6113 Tested-by: build bot (Jenkins) Reviewed-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> See http://review.coreboot.org/6113 for details. -gerrit

1 0

Patch merged into coreboot/master: 26c6543 AMD boards: Fix typos
by gerrit＠coreboot.org 26 Jun '14

26 Jun '14

the following patch was just integrated into master: commit 26c6543c351b6b03b77d6f262cca812b270ecdfc Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Date: Thu Jun 26 05:30:54 2014 +0300 AMD boards: Fix typos Change-Id: I5df80e6445f390060372be8760c9b5e960e4a6e5 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Reviewed-on: http://review.coreboot.org/6117 Tested-by: build bot (Jenkins) Reviewed-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> See http://review.coreboot.org/6117 for details. -gerrit

1 0

Patch merged into coreboot/master: 8f87c3f AMD boards: Fix typos
by gerrit＠coreboot.org 26 Jun '14

26 Jun '14

the following patch was just integrated into master: commit 8f87c3f3970745ef1f5928d91c45711cd0fd6f36 Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Date: Thu Jun 26 05:30:54 2014 +0300 AMD boards: Fix typos Change-Id: If1dc4fd2204a2e4b6f84c75f385b8ff958d2251d Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Reviewed-on: http://review.coreboot.org/6112 Tested-by: build bot (Jenkins) Reviewed-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> See http://review.coreboot.org/6112 for details. -gerrit

1 0

← Newer
1
...
8
9
10
11
12
13
14
...
93
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2014