Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3240
-gerrit
commit 8a6cf817fc03888ddb773f8037eb1fee7de92478
Author: Vladimir Serbinenko <phcoder(a)gmail.com>
Date: Sun Mar 31 22:22:10 2013 +0200
intel/bd82x6x: Add Kconfig options for USB debug port
Nowadays, chipsets or boards do not only have one USB port with
the capabilities of a debug port but several ones. Some of these
ports are easier accessible than others, so making them configurable
is quite useful.
This applies also to the Intel BD82x6x chipset.
For example on the Lenovo X201 with a Mobile Intel QM57 Express
Chipset [1][2], the yellow, always powered port on the left under the
PCMCIA card slot is D26:F0 is easier accesible than device D29:F7.
[1] http://thinkwiki.de/X201
[2] http://en.wikipedia.org/wiki/Intel_5_Series
Change-Id: I7447114a03eb0e98caaaf42ddfe3c678601e6c66
Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com>
Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
---
src/southbridge/intel/bd82x6x/Kconfig | 8 ++++++++
src/southbridge/intel/bd82x6x/usb_debug.c | 2 +-
src/southbridge/intel/bd82x6x/usb_ehci.c | 26 ++++++++++++++++----------
3 files changed, 25 insertions(+), 11 deletions(-)
diff --git a/src/southbridge/intel/bd82x6x/Kconfig b/src/southbridge/intel/bd82x6x/Kconfig
index 5dd492c..56471bc 100644
--- a/src/southbridge/intel/bd82x6x/Kconfig
+++ b/src/southbridge/intel/bd82x6x/Kconfig
@@ -72,4 +72,12 @@ config LOCK_MANAGEMENT_ENGINE
If unsure, say N.
+config USBDEBUG_DEV
+ int
+ default 29
+
+config USBDEBUG_FUNC
+ int
+ default 7
+
endif
diff --git a/src/southbridge/intel/bd82x6x/usb_debug.c b/src/southbridge/intel/bd82x6x/usb_debug.c
index 79a43bd..706b97c 100644
--- a/src/southbridge/intel/bd82x6x/usb_debug.c
+++ b/src/southbridge/intel/bd82x6x/usb_debug.c
@@ -28,7 +28,7 @@
void enable_usbdebug(unsigned int port)
{
u32 dbgctl;
- device_t dev = PCI_DEV(0, 0x1d, 7); /* USB EHCI, D29:F7 */
+ device_t dev = PCI_DEV(0, CONFIG_USBDEBUG_DEV, CONFIG_USBDEBUG_FUNC);
/* Set the EHCI BAR address. */
pci_write_config32(dev, EHCI_BAR_INDEX, CONFIG_EHCI_BAR);
diff --git a/src/southbridge/intel/bd82x6x/usb_ehci.c b/src/southbridge/intel/bd82x6x/usb_ehci.c
index aec230c..ead2ccb 100644
--- a/src/southbridge/intel/bd82x6x/usb_ehci.c
+++ b/src/southbridge/intel/bd82x6x/usb_ehci.c
@@ -68,22 +68,28 @@ static void usb_ehci_set_subsystem(device_t dev, unsigned vendor, unsigned devic
static void usb_ehci_set_resources(struct device *dev)
{
#if CONFIG_USBDEBUG
- struct resource *res;
- u32 base;
u32 usb_debug;
- usb_debug = get_ehci_debug();
- set_ehci_debug(0);
+ if (dev->path.pci.devfn == PCI_DEVFN (CONFIG_USBDEBUG_DEV, CONFIG_USBDEBUG_FUNC))
+ {
+ usb_debug = get_ehci_debug();
+ set_ehci_debug(0);
+ }
#endif
pci_dev_set_resources(dev);
#if CONFIG_USBDEBUG
- res = find_resource(dev, 0x10);
- set_ehci_debug(usb_debug);
- if (!res) return;
- base = res->base;
- set_ehci_base(base);
- report_resource_stored(dev, res, "");
+ if (dev->path.pci.devfn == PCI_DEVFN (CONFIG_USBDEBUG_DEV, CONFIG_USBDEBUG_FUNC))
+ {
+ struct resource *res;
+ u32 base;
+ res = find_resource(dev, 0x10);
+ if (!res) return;
+ base = res->base;
+ set_ehci_debug(usb_debug);
+ set_ehci_base(base);
+ report_resource_stored(dev, res, "");
+ }
#endif
}
Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3242
-gerrit
commit c8b294704731134a951b7fafabbbe176d37ed624
Author: Paul Menzel <paulepanter(a)users.sourceforge.net>
Date: Wed May 8 17:08:55 2013 +0200
Intel Sandy Bridge: udelay.c: Add secunet’s copyright
Add secunet’s copyright to `udelay.c` as this was added to
`udelay.c` of the i945 northbridge when adding the function
`multiply_to_tsc()` in the following commit.
commit 8bacc40fc7bd07365c2992b260ddbd45cd6e4518
Author: Nico Huber <nico.huber(a)secunet.com>
Date: Thu Jul 19 16:16:59 2012 +0200
Fix udelay() implementation for i945 romstage
Reviewed-on: http://review.coreboot.org/1254
Change-Id: Ied0013ad4b1a9e5e2b330614bb867fd806f9a407
Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
---
src/northbridge/intel/sandybridge/udelay.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/northbridge/intel/sandybridge/udelay.c b/src/northbridge/intel/sandybridge/udelay.c
index 3edd69d..5bbc383 100644
--- a/src/northbridge/intel/sandybridge/udelay.c
+++ b/src/northbridge/intel/sandybridge/udelay.c
@@ -2,6 +2,7 @@
* This file is part of the coreboot project.
*
* Copyright (C) 2007-2008 coresystems GmbH
+ * 2012 secunet Security Networks AG
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3241
-gerrit
commit 2b9cf02a379f63c9b180073fcc8058a0e523fe99
Author: Paul Menzel <paulepanter(a)users.sourceforge.net>
Date: Wed May 8 17:08:55 2013 +0200
Intel 5000: udelay.c: Remove redundant `tsc = rdtsc();`
Remove the `tsc = rdtsc();` line which is in the do-while-loop
already.
The `udelay.c` files of the northbridges i945 and Sandy Bridge
do not have that line either.
Change-Id: I5cff424110d2d6cd6a26b63e59c03c61da8af7b3
Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
---
src/northbridge/intel/i5000/udelay.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/northbridge/intel/i5000/udelay.c b/src/northbridge/intel/i5000/udelay.c
index caee73f..3768e16 100644
--- a/src/northbridge/intel/i5000/udelay.c
+++ b/src/northbridge/intel/i5000/udelay.c
@@ -87,8 +87,6 @@ void udelay(u32 us)
tsc1.lo = dword;
tsc1.hi += tscd.hi;
- tsc = rdtsc();
-
do {
tsc = rdtsc();
} while ((tsc.hi < tsc1.hi)