- flashrom-gerrit - mail.coreboot.org

[M] Change in flashrom[master]: asm106x: add programmer for ASM106x SATA controllers
by Alex Badea (Code Review) 14 Feb '23

14 Feb '23

Attention is currently required from: Felix Singer, Thomas Heijligen. Alex Badea has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73037 ) Change subject: asm106x: add programmer for ASM106x SATA controllers ...................................................................... Patch Set 3: (7 comments) Patchset: PS3: > Hi Alex, thank you for the contribution! […] Ack File asm106x.c: https://review.coreboot.org/c/flashrom/+/73037/comment/d300626b_1b94e31e PS3, Line 35: {PCI_VENDOR_ID_ASMEDIA, 0x0612, OK, "ASMedia", "ASM106x"}, > This PCI-Id is assigned to the ASM1062 Serial ATA Controller, […] Well, it's interesting. From driver blobs[1] linked from forums[2] it looks like this: $ grep -rh VEN.*DeviceDesc.*\" . | sort -u PCI\VEN_1B21&DEV_0601.DeviceDesc ="Asmedia 106x SATA Controller" PCI\VEN_1B21&DEV_0602.DeviceDesc ="Asmedia 106x SATA Controller" PCI\VEN_1B21&DEV_0611.DeviceDesc ="Asmedia 106x SATA Controller" PCI\VEN_1B21&DEV_0612.DeviceDesc ="Asmedia 106x SATA Controller" PCI\VEN_1B21&DEV_0614.DeviceDesc ="Asmedia SATA Express Controller" PCI\VEN_1B21&DEV_0615.DeviceDesc ="Asmedia SATA Express Controller" PCI\VEN_1B21&DEV_0620.DeviceDesc ="Asmedia 106x SATA Controller" PCI\VEN_1B21&DEV_0621.DeviceDesc ="Asmedia 106x SATA/RAID Controller" PCI\VEN_1B21&DEV_0622.DeviceDesc ="Asmedia 106x SATA/RAID Controller" PCI\VEN_1B21&DEV_0624.DeviceDesc ="Asmedia 106x SATA/RAID Controller" PCI\VEN_1B21&DEV_0625.DeviceDesc ="Asmedia 106x SATA/RAID Controller" This kernel patch[3] suggests 0x0611 and 0x0612 are both ASM1061. Either way, I'm not sure if driver compatibility translates into SPI interface compatibility as well. My boards have ASM1061 chips on them and they both report 0x0612, which is what I've declared here. Let me know if I should add the others too (as "NT"). [1] http://ableconn.com/support_1.php?gid=120 [2] https://www.techpowerup.com/forums/threads/latest-driver-and-firmware-for-a… [3] https://patchwork.kernel.org/project/linux-pci/patch/1315453426-8796-1-git-… https://review.coreboot.org/c/flashrom/+/73037/comment/7de74237_a053f99b PS3, Line 51: programmer_delay(flash, 10); > `programmer_delay()` should be used outside of the programmer. […] Done https://review.coreboot.org/c/flashrom/+/73037/comment/40a74070_b8aac08b PS3, Line 59: if (pval) > You could move this 'if, assignment, return' where the break is. […] Done https://review.coreboot.org/c/flashrom/+/73037/comment/f442be14_de7d0d7d PS3, Line 74: writecnt, readcnt); > This can be moved in the line above. Done https://review.coreboot.org/c/flashrom/+/73037/comment/fea7da31_c0a735e9 PS3, Line 115: ctrl | ASM106X_CTRL_CSN); > This function call can be in one line Done File meson.build: https://review.coreboot.org/c/flashrom/+/73037/comment/f8b28cb2_e1d6fbbb PS3, Line 152: 'cpu_families' : cpus_port_io, > This line should be removed. […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/73037 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I591b117be911bdb8249247c20530c1cf70f6e70d Gerrit-Change-Number: 73037 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Badea <vamposdecampos(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Wed, 15 Feb 2023 02:47:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: asm106x: add programmer for ASM106x SATA controllers
by Alex Badea (Code Review) 14 Feb '23

14 Feb '23

Attention is currently required from: Felix Singer, Alex Badea. Hello Felix Singer, build bot (Jenkins), Thomas Heijligen, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/73037 to look at the new patch set (#4). Change subject: asm106x: add programmer for ASM106x SATA controllers ...................................................................... asm106x: add programmer for ASM106x SATA controllers The ASMedia ASM106x series is a PCIe-SATA controller chip. It supports an attached SPI flash chip that can contain configuration and PCI option ROM. The interface is a simple shifter accessed via PCI config space, up to 4 bytes at a time. Add a programmer driver for it. Tested on a PCIe and a mini-PCIe card, both with chips marked ASM1061, both enumerate as: 01:00.0 SATA controller [0106]: ASMedia Technology Inc. ASM1062 Serial ATA Controller [1b21:0612] (rev 02) (prog-if 01 [AHCI 1.0]) Subsystem: ASMedia Technology Inc. ASM1062 Serial ATA Controller [1b21:1060] Change-Id: I591b117be911bdb8249247c20530c1cf70f6e70d Signed-off-by: Alex Badea <vamposdecampos(a)gmail.com> --- M Makefile A asm106x.c M flashrom.8.tmpl M include/programmer.h M meson.build M meson_options.txt M programmer_table.c M test_build.sh 8 files changed, 212 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/37/73037/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/73037 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I591b117be911bdb8249247c20530c1cf70f6e70d Gerrit-Change-Number: 73037 Gerrit-PatchSet: 4 Gerrit-Owner: Alex Badea <vamposdecampos(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Alex Badea <vamposdecampos(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[master]: writeprotect: Add function to get register values and WP bit masks
by Nikolai Artemiev (Code Review) 14 Feb '23

14 Feb '23

Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk, Sergii Dmytruk. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69847 ) Change subject: writeprotect: Add function to get register values and WP bit masks ...................................................................... Patch Set 8: (3 comments) This change is ready for review. Commit Message: https://review.coreboot.org/c/flashrom/+/69847/comment/9b51163e_7656cb26 PS5, Line 7: writeprotect: Add function to get register values and WP bit masks > Is this to allow updating WP registers via some non-standard method? Would be nice to have outline […] It will allow us to more thoroughly qualify flash chips once flashrom_tester is able to query the register values during testing. I've uploaded a WIP commit to add a libflashrom interface as well in CB:73053. File tests/chip_wp.c: https://review.coreboot.org/c/flashrom/+/69847/comment/4e669625_91f5162f PS5, Line 363: strdup( > you do not need a heap allocation, just a `const char *` Done https://review.coreboot.org/c/flashrom/+/69847/comment/1020316e_60eb7497 PS5, Line 396: free(param_dup); > drop Done -- To view, visit https://review.coreboot.org/c/flashrom/+/69847 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib2a47153b230c9f82bb4eca357c335f2abbacc20 Gerrit-Change-Number: 69847 Gerrit-PatchSet: 8 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Tue, 14 Feb 2023 23:50:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Comment-In-Reply-To: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: Add support for VIA VL805 USB Controller flashing
by ChrisEric1 CECL (Code Review) 14 Feb '23

14 Feb '23

Attention is currently required from: Thomas Heijligen, Nicholas Chin. ChrisEric1 CECL has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72057 ) Change subject: Add support for VIA VL805 USB Controller flashing ...................................................................... Patch Set 15: (1 comment) File vl805.c: https://review.coreboot.org/c/flashrom/+/72057/comment/42f67230_98f40e3c PS15, Line 43: > Should this be static struct instead? "No, as this is just a type declaration and thus static doesn't have an effect If it were struct vl805_spi_data { struct pci_dev *dev; } vl805_data; then that would define a variable called vl805_data of type struct vl805_spi_data (similar to something like int i = 1; and then the static keyword would make a difference. But vl805_data would be global which we're trying to avoid" -- To view, visit https://review.coreboot.org/c/flashrom/+/72057 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I71435afcacdf97e14d627e35bce3d29de9657f38 Gerrit-Change-Number: 72057 Gerrit-PatchSet: 15 Gerrit-Owner: ChrisEric1 CECL <christopherericlentocha(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Tue, 14 Feb 2023 19:46:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: ChrisEric1 CECL <christopherericlentocha(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: Add support for VIA VL805 USB Controller flashing
by ChrisEric1 CECL (Code Review) 14 Feb '23

14 Feb '23

Attention is currently required from: Thomas Heijligen, Nicholas Chin. ChrisEric1 CECL has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72057 ) Change subject: Add support for VIA VL805 USB Controller flashing ...................................................................... Patch Set 15: (1 comment) File vl805.c: https://review.coreboot.org/c/flashrom/+/72057/comment/f5bbc19f_5e5a4637 PS15, Line 43: Should this be static struct instead? -- To view, visit https://review.coreboot.org/c/flashrom/+/72057 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I71435afcacdf97e14d627e35bce3d29de9657f38 Gerrit-Change-Number: 72057 Gerrit-PatchSet: 15 Gerrit-Owner: ChrisEric1 CECL <christopherericlentocha(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Tue, 14 Feb 2023 18:53:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: Add support for VIA VL805 USB Controller flashing
by ChrisEric1 CECL (Code Review) 14 Feb '23

14 Feb '23

Attention is currently required from: Thomas Heijligen, Nicholas Chin. Hello build bot (Jenkins), Thomas Heijligen, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/72057 to look at the new patch set (#15). Change subject: Add support for VIA VL805 USB Controller flashing ...................................................................... Add support for VIA VL805 USB Controller flashing It works fine for me on my Raspberry Pi 4 Model B. Was able read read, erase, write, verify. Only thing is the WP with the W25X10 gives a untested warning. Change-Id: I71435afcacdf97e14d627e35bce3d29de9657f38 Signed-off-by: Christopher Lentocha <christopherericlentocha(a)gmail.com> --- M Makefile M flashrom.8.tmpl M include/programmer.h M meson.build M meson_options.txt M programmer_table.c A vl805.c 7 files changed, 232 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/57/72057/15 -- To view, visit https://review.coreboot.org/c/flashrom/+/72057 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I71435afcacdf97e14d627e35bce3d29de9657f38 Gerrit-Change-Number: 72057 Gerrit-PatchSet: 15 Gerrit-Owner: ChrisEric1 CECL <christopherericlentocha(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[master]: Add support for VIA VL805 USB 3 XHCI flashing
by ChrisEric1 CECL (Code Review) 14 Feb '23

14 Feb '23

Attention is currently required from: Thomas Heijligen, Nicholas Chin. ChrisEric1 CECL has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72057 ) Change subject: Add support for VIA VL805 USB 3 XHCI flashing ...................................................................... Patch Set 14: (10 comments) File vl805.c: https://review.coreboot.org/c/flashrom/+/72057/comment/0364b529_77a15288 PS12, Line 69: struct pci_dev *dev > This is still wrong. it must be […] Done https://review.coreboot.org/c/flashrom/+/72057/comment/f75c77c9_38440eef PS12, Line 76: dev > And here […] Done https://review.coreboot.org/c/flashrom/+/72057/comment/b77e6c8c_f89af3ca PS12, Line 85: dev > `data->dev` Done https://review.coreboot.org/c/flashrom/+/72057/comment/2c4ad1b1_d2c32e95 PS12, Line 86: dev > `data->dev` Done https://review.coreboot.org/c/flashrom/+/72057/comment/a1784228_fc3ad1a6 PS12, Line 90: dev > `data->dev` Done https://review.coreboot.org/c/flashrom/+/72057/comment/cd5c77de_68bc4b77 PS12, Line 94: dev > `data->dev` Done https://review.coreboot.org/c/flashrom/+/72057/comment/ed47d9c6_4407cde4 PS12, Line 95: dev > `data->dev` Done https://review.coreboot.org/c/flashrom/+/72057/comment/88aba5a2_18ea7087 PS12, Line 102: dev > `data->dev` Done https://review.coreboot.org/c/flashrom/+/72057/comment/e1150590_f62593e1 PS12, Line 140: struct vl805_spi_data *data = calloc(1, sizeof(*data)); > Please tests if the allocation was successful. […] Done https://review.coreboot.org/c/flashrom/+/72057/comment/3381dfcd_681ced49 PS12, Line 140: struct vl805_spi_data *data = calloc(1, sizeof(*data)); > Please move the allocation of vl805_spi_data below […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/72057 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I71435afcacdf97e14d627e35bce3d29de9657f38 Gerrit-Change-Number: 72057 Gerrit-PatchSet: 14 Gerrit-Owner: ChrisEric1 CECL <christopherericlentocha(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Tue, 14 Feb 2023 18:35:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: Add support for VIA VL805 USB 3 XHCI flashing
by ChrisEric1 CECL (Code Review) 14 Feb '23

14 Feb '23

Attention is currently required from: ChrisEric1 CECL, Nicholas Chin. Hello build bot (Jenkins), Thomas Heijligen, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/72057 to look at the new patch set (#14). Change subject: Add support for VIA VL805 USB 3 XHCI flashing ...................................................................... Add support for VIA VL805 USB 3 XHCI flashing It works fine for me on my Raspberry Pi 4 Model B. Was able read read, erase, write, verify. Only thing is the WP with the W25X10 gives a untested warning. Change-Id: I71435afcacdf97e14d627e35bce3d29de9657f38 Signed-off-by: Christopher Lentocha <christopherericlentocha(a)gmail.com> --- M Makefile M flashrom.8.tmpl M include/programmer.h M meson.build M meson_options.txt M programmer_table.c A vl805.c 7 files changed, 232 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/57/72057/14 -- To view, visit https://review.coreboot.org/c/flashrom/+/72057 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I71435afcacdf97e14d627e35bce3d29de9657f38 Gerrit-Change-Number: 72057 Gerrit-PatchSet: 14 Gerrit-Owner: ChrisEric1 CECL <christopherericlentocha(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: ChrisEric1 CECL <christopherericlentocha(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[master]: Add support for VIA VL805 USB 3 XHCI flashing
by ChrisEric1 CECL (Code Review) 14 Feb '23

14 Feb '23

Attention is currently required from: ChrisEric1 CECL, Nicholas Chin. Hello build bot (Jenkins), Thomas Heijligen, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/72057 to look at the new patch set (#13). Change subject: Add support for VIA VL805 USB 3 XHCI flashing ...................................................................... Add support for VIA VL805 USB 3 XHCI flashing It works fine for me on my Raspberry Pi 4 Model B. Was able read read, erase, write, verify. Only thing is the WP with the W25X10 gives a untested warning. Change-Id: I71435afcacdf97e14d627e35bce3d29de9657f38 Signed-off-by: Christopher Lentocha <christopherericlentocha(a)gmail.com> --- M Makefile M flashrom.8.tmpl M include/programmer.h M meson.build M meson_options.txt M programmer_table.c A vl805.c 7 files changed, 226 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/57/72057/13 -- To view, visit https://review.coreboot.org/c/flashrom/+/72057 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I71435afcacdf97e14d627e35bce3d29de9657f38 Gerrit-Change-Number: 72057 Gerrit-PatchSet: 13 Gerrit-Owner: ChrisEric1 CECL <christopherericlentocha(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: ChrisEric1 CECL <christopherericlentocha(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[master]: Add support for VIA VL805 USB 3 XHCI flashing
by Thomas Heijligen (Code Review) 14 Feb '23

14 Feb '23

Attention is currently required from: ChrisEric1 CECL, Nicholas Chin. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72057 ) Change subject: Add support for VIA VL805 USB 3 XHCI flashing ...................................................................... Patch Set 12: (11 comments) Patchset: PS12: Great work. Nearly complete 🎉 File vl805.c: https://review.coreboot.org/c/flashrom/+/72057/comment/474557df_49be5a42 PS12, Line 69: struct pci_dev *dev This is still wrong. it must be ``` struct vl805_spi_data *data = (struct vl805_spi_data *)flash->mst->spi.data; ``` https://review.coreboot.org/c/flashrom/+/72057/comment/8e7dbf05_6ed50e54 PS12, Line 76: dev And here ``` data->dev ``` https://review.coreboot.org/c/flashrom/+/72057/comment/e71ed9b8_31f81b9d PS12, Line 85: dev `data->dev` https://review.coreboot.org/c/flashrom/+/72057/comment/2daeed4d_3dee60c5 PS12, Line 86: dev `data->dev` https://review.coreboot.org/c/flashrom/+/72057/comment/14b00d98_395b051a PS12, Line 90: dev `data->dev` https://review.coreboot.org/c/flashrom/+/72057/comment/3c943c81_f5412440 PS12, Line 94: dev `data->dev` https://review.coreboot.org/c/flashrom/+/72057/comment/fdb45233_b997c24b PS12, Line 95: dev `data->dev` https://review.coreboot.org/c/flashrom/+/72057/comment/7fd61094_ea8832f4 PS12, Line 102: dev `data->dev` https://review.coreboot.org/c/flashrom/+/72057/comment/635ad350_af1b28d1 PS12, Line 140: struct vl805_spi_data *data = calloc(1, sizeof(*data)); Please move the allocation of vl805_spi_data below ``` pcidev_init(...); if(!dev) return 1; ``` https://review.coreboot.org/c/flashrom/+/72057/comment/993180ae_11e5cd98 PS12, Line 140: struct vl805_spi_data *data = calloc(1, sizeof(*data)); Please tests if the allocation was successful. ``` truct vl805_spi_data *data = calloc(1, sizeof(*data)); if (!data) { msg_perr("cannot allocate memory for vl805_data\n"); return 1; } ``` -- To view, visit https://review.coreboot.org/c/flashrom/+/72057 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I71435afcacdf97e14d627e35bce3d29de9657f38 Gerrit-Change-Number: 72057 Gerrit-PatchSet: 12 Gerrit-Owner: ChrisEric1 CECL <christopherericlentocha(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: ChrisEric1 CECL <christopherericlentocha(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Tue, 14 Feb 2023 18:16:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit