- flashrom-gerrit - mail.coreboot.org

[M] Change in flashrom[master]: flashrom.c:Add function to get a flattened view of the chip erase blocks
by Thomas Heijligen (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Felix Singer, Simon Buhrow, Nico Huber, Paul Menzel, Aarya. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/65879 ) Change subject: flashrom.c:Add function to get a flattened view of the chip erase blocks ...................................................................... Patch Set 36: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/65879 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iafe78de00daa55f7114bd4ce09465dd88074ece4 Gerrit-Change-Number: 65879 Gerrit-PatchSet: 36 Gerrit-Owner: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Simon Buhrow Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Comment-Date: Tue, 29 Nov 2022 17:57:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashrom.c: Update check_block_eraser function to use probe opcode
by Thomas Heijligen (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Simon Buhrow, Nico Huber, Aarya. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66717 ) Change subject: flashrom.c: Update check_block_eraser function to use probe opcode ...................................................................... Patch Set 17: Code-Review+2 (6 comments) Patchset: PS3: > Maybe add the `const` in a separate commit ahead. . File dummyflasher.c: https://review.coreboot.org/c/flashrom/+/66717/comment/204c542e_6cec248a PS17, Line 125: const This should not be done in this patch File ichspi.c: https://review.coreboot.org/c/flashrom/+/66717/comment/0e01d523_e52ef6ab PS17, Line 1652: const this File include/programmer.h: https://review.coreboot.org/c/flashrom/+/66717/comment/9152b137_c66bbcc0 PS17, Line 316: const this https://review.coreboot.org/c/flashrom/+/66717/comment/b7fc4709_e80fc20c PS17, Line 326: const this File spi.c: https://review.coreboot.org/c/flashrom/+/66717/comment/d26a9121_81fbd715 PS17, Line 137: const this -- To view, visit https://review.coreboot.org/c/flashrom/+/66717 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6591a84ae1fe5bc1648051cc30b9393450033852 Gerrit-Change-Number: 66717 Gerrit-PatchSet: 17 Gerrit-Owner: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Simon Buhrow Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Comment-Date: Tue, 29 Nov 2022 17:55:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: spi.c: Add AT45 & SF25F erasefn opcode mapping
by Thomas Heijligen (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Simon Buhrow, Aarya. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67717 ) Change subject: spi.c: Add AT45 & SF25F erasefn opcode mapping ...................................................................... Patch Set 4: Code-Review+2 (1 comment) File spi.c: https://review.coreboot.org/c/flashrom/+/67717/comment/e87467cf_7f80ac14 PS4, Line 231: require newline -- To view, visit https://review.coreboot.org/c/flashrom/+/67717 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I798a91f1e20b63662715c68e6d43d03fc6005d51 Gerrit-Change-Number: 67717 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Simon Buhrow Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Comment-Date: Tue, 29 Nov 2022 17:51:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: spi25.c: Rename spi_get_erasefn_from_opcode to spi25_get_erasefn_from...
by Thomas Heijligen (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Simon Buhrow, Aarya. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67716 ) Change subject: spi25.c: Rename spi_get_erasefn_from_opcode to spi25_get_erasefn_from_opcode ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/67716 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie054160b0fdd34bcb128285c6a047e3a3fa8be0c Gerrit-Change-Number: 67716 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Simon Buhrow Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Comment-Date: Tue, 29 Nov 2022 17:50:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: spi25.c: Move spi_get_opcode_from_erasefn() to spi.c
by Thomas Heijligen (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Simon Buhrow, Aarya. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67715 ) Change subject: spi25.c: Move spi_get_opcode_from_erasefn() to spi.c ...................................................................... Patch Set 4: Code-Review+2 (1 comment) File spi.c: https://review.coreboot.org/c/flashrom/+/67715/comment/ea24f1ec_148cdc56 PS4, Line 202: } Need newline at the end -- To view, visit https://review.coreboot.org/c/flashrom/+/67715 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id654e998d0af2d3f5845336bb98b38d724519038 Gerrit-Change-Number: 67715 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Simon Buhrow Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Comment-Date: Tue, 29 Nov 2022 17:49:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: util: add bash completion script
by Thomas Heijligen (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Felix Singer, Alexander Goncharov. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68247 ) Change subject: util: add bash completion script ...................................................................... Patch Set 9: Code-Review+1 (3 comments) File Makefile: https://review.coreboot.org/c/flashrom/+/68247/comment/e0dc52d7_29d87f82 PS9, Line 1041: .bash IIRC there should be no `.bash` suffix File meson.build: https://review.coreboot.org/c/flashrom/+/68247/comment/03a7a3c0_be91b777 PS9, Line 624: if get_option('classic_cli').disabled() When `get_option('bash_completion').auto()` and `get_option('classic_cli').disabled()` are true, there should be no action. `get_option('bash_completion').auto()` equals `get_option('classic_cli').auto()` in the behavior. So if I disable the cli, the bash_completion is also disabled. https://review.coreboot.org/c/flashrom/+/68247/comment/5bd340f3_7da26838 PS9, Line 646: .bash same here -- To view, visit https://review.coreboot.org/c/flashrom/+/68247 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie68bc91c3cea4de2ffdbeffd07e48edd8d5590e1 Gerrit-Change-Number: 68247 Gerrit-PatchSet: 9 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Tue, 29 Nov 2022 17:44:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: libflashrom: Define macro to detect v1.3 header
by Alexander Goncharov (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Felix Singer, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Evan Benn. Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70027 ) Change subject: libflashrom: Define macro to detect v1.3 header ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Heres what SDL does, […] The current macro looks like a stub. As far as I know, nothing prevents us from adding a normal version system, so +1 for Evan's ideas. -- To view, visit https://review.coreboot.org/c/flashrom/+/70027 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iac35ff167272e1bc3d5434f7b47099f53bfceab7 Gerrit-Change-Number: 70027 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Evan Benn <evanbenn(a)google.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Evan Benn <evanbenn(a)google.com> Gerrit-Comment-Date: Tue, 29 Nov 2022 14:50:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Comment-In-Reply-To: Evan Benn <evanbenn(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: ichspi.c: Read chip ID and use it to populate `flash->chip`
by Subrata Banik (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Edward O'Callaghan, Angel Pons, Nikolai Artemiev. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69195 ) Change subject: ichspi.c: Read chip ID and use it to populate `flash->chip` ...................................................................... Patch Set 9: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/69195/comment/c586b5b9_0e0ca9a4 PS2, Line 7: ichspi.c: Read chip ID and use it to identify chip > > Maybe we should just print a warning if >1 chip is detected? > > > > Subrata, do you have any thoughts on this? > > Ideally as per descriptor, there can be 2 SPI flash and we need to drive CS PIN low to initiate the READ JEDEC ID (0x9F) HW seq command for each SPI flash chip to capture the response. looking at the all latest platform, I don't see the usage of dual chips and mostly I could see the descriptor is set to 0 aka 1 chip. -- To view, visit https://review.coreboot.org/c/flashrom/+/69195 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia408e1e45dc6f53c0934afd6558e301abfa48ee6 Gerrit-Change-Number: 69195 Gerrit-PatchSet: 9 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Tue, 29 Nov 2022 07:44:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: ichspi.c: Read chip ID and use it to populate `flash->chip`
by Subrata Banik (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Edward O'Callaghan, Angel Pons, Nikolai Artemiev. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69195 ) Change subject: ichspi.c: Read chip ID and use it to populate `flash->chip` ...................................................................... Patch Set 9: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/69195/comment/11eb0f42_f6d40c02 PS2, Line 7: ichspi.c: Read chip ID and use it to identify chip > Maybe we should just print a warning if >1 chip is detected? > > Subrata, do you have any thoughts on this? Ideally as per descriptor, there can be 2 SPI flash and we need to drive CS PIN low to initiate the READ JEDEC ID (0x9F) HW seq command for each SPI flash chip to capture the response. -- To view, visit https://review.coreboot.org/c/flashrom/+/69195 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia408e1e45dc6f53c0934afd6558e301abfa48ee6 Gerrit-Change-Number: 69195 Gerrit-PatchSet: 9 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Tue, 29 Nov 2022 07:42:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: programmer: Add get_region to spi/opaque masters
by Nikolai Artemiev (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Edward O'Callaghan. Hello build bot (Jenkins), Edward O'Callaghan, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/70126 to look at the new patch set (#2). Change subject: programmer: Add get_region to spi/opaque masters ...................................................................... programmer: Add get_region to spi/opaque masters Add a get_region function to spi and opaque masters so that they can expose access permissions for multiple regions within the flash. A get_region() implementation is added for the ichspi driver in a following patch. Finally, another patch uses get_region() to make read_flash() and write_flash() skip inaccessable regions, making read, write, and erase operations work on Intel platforms with active an CSME coprocessor. This logic will be integrated with layout in the future, but for now this moves ichspi support forward without making refactoring too hard later on. BUG=b:260440773 BRANCH=none TEST=ninja test Change-Id: I8c43f6b705f36ef18842a04ba6241d3a0b36b232 Signed-off-by: Nikolai Artemiev <nartemiev(a)google.com> --- M include/programmer.h 1 file changed, 39 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/26/70126/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/70126 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8c43f6b705f36ef18842a04ba6241d3a0b36b232 Gerrit-Change-Number: 70126 Gerrit-PatchSet: 2 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit