- flashrom-gerrit - mail.coreboot.org

[M] Change in flashrom[master]: writeprotect: Add function to get register values and WP bit masks
by Sergii Dmytruk (Code Review) 16 Feb '23

16 Feb '23

Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev, Anastasia Klimchuk. Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69847 ) Change subject: writeprotect: Add function to get register values and WP bit masks ...................................................................... Patch Set 9: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/69847 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib2a47153b230c9f82bb4eca357c335f2abbacc20 Gerrit-Change-Number: 69847 Gerrit-PatchSet: 9 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 16 Feb 2023 13:05:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: Add support for VIA VL805 USB Controller flashing
by Edward O'Callaghan (Code Review) 16 Feb '23

16 Feb '23

Attention is currently required from: ChrisEric1 CECL, Thomas Heijligen, Nicholas Chin. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72057 ) Change subject: Add support for VIA VL805 USB Controller flashing ...................................................................... Patch Set 18: Code-Review+1 (12 comments) File vl805.c: https://review.coreboot.org/c/flashrom/+/72057/comment/97423f67_9684d6a3 PS18, Line 58: drop \n line 58. https://review.coreboot.org/c/flashrom/+/72057/comment/7a8971b3_6a3883ad PS18, Line 70: unsigned int i, j; just scope iterators to loops. https://review.coreboot.org/c/flashrom/+/72057/comment/bf1c5a6d_45ace785 PS18, Line 71: uint32_t outdata; : uint32_t indata; : unsigned int curwritecnt; : unsigned int curreadcnt; scope to respective loop constructs.. https://review.coreboot.org/c/flashrom/+/72057/comment/1fd2856e_92b7f100 PS18, Line 79: curwritecnt = min(4, writecnt - j); .. i.e., `uint32_t curwritecnt = min(4, writecnt - j);` https://review.coreboot.org/c/flashrom/+/72057/comment/7817b7f8_8c257c24 PS18, Line 107: programmer `_mcu_` ? https://review.coreboot.org/c/flashrom/+/72057/comment/7ab0abb3_2f644793 PS18, Line 117: /* Shutdown stuff. */ remove, adds no value. https://review.coreboot.org/c/flashrom/+/72057/comment/e1fc2ba6_cfe4dfdf PS18, Line 118: dev just pass `vl805_data->dev` it is already well-typed. https://review.coreboot.org/c/flashrom/+/72057/comment/78cf2a71_d10bb8c8 PS18, Line 130: .write_aai = default_spi_write_aai, no need for this default hook, see CB:67479 https://review.coreboot.org/c/flashrom/+/72057/comment/321f6dd2_3d390f74 PS18, Line 141: ditto https://review.coreboot.org/c/flashrom/+/72057/comment/9fdd1cc9_1760a08d PS18, Line 146: nit: drop this \n https://review.coreboot.org/c/flashrom/+/72057/comment/d96f61e8_3b654ddc PS18, Line 158: vl805_programmer_active(dev, 0x1) you seem to toggle on on line 152, read fw rev, toggle off and then immediately back on again? https://review.coreboot.org/c/flashrom/+/72057/comment/9cba9c60_f807f0d9 PS18, Line 171: vl805_programmer_active(dev, 0x0); : : vl805_programmer_active(dev, 0x1); : same here? if this is from a trace it could be from some silly OOP structure that always does a toggle on->do thing->toggle off pattern which leads to a lot of this kind of procedural noise. -- To view, visit https://review.coreboot.org/c/flashrom/+/72057 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I71435afcacdf97e14d627e35bce3d29de9657f38 Gerrit-Change-Number: 72057 Gerrit-PatchSet: 18 Gerrit-Owner: ChrisEric1 CECL <christopherericlentocha(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: ChrisEric1 CECL <christopherericlentocha(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Thu, 16 Feb 2023 10:09:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: asm106x: add programmer for ASM106x SATA controllers
by Alex Badea (Code Review) 15 Feb '23

15 Feb '23

Attention is currently required from: Felix Singer, Edward O'Callaghan. Alex Badea has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73037 ) Change subject: asm106x: add programmer for ASM106x SATA controllers ...................................................................... Patch Set 5: (4 comments) File asm106x.c: https://review.coreboot.org/c/flashrom/+/73037/comment/28979ba0_6e8ab1dc PS5, Line 47: x > Please use `inttype.h` macros here for fixed length integer. […] Done https://review.coreboot.org/c/flashrom/+/73037/comment/e57001dd_67fb5358 PS5, Line 57: msg_pdbg("asm106x timed out, ctrl 0x%02x\n", val); > Same here `... […] Done https://review.coreboot.org/c/flashrom/+/73037/comment/8cb52f6a_f79995ab PS5, Line 81: msg_pdbg2("asm106x write 0x%08x chunk %u\n", val, chunk); > `write %#08"PRIx32" chunk` Done https://review.coreboot.org/c/flashrom/+/73037/comment/3e0189e2_ed0b7364 PS5, Line 99: msg_pdbg2("asm106x read 0x%08x chunk %u\n", val, chunk); > `read %#08"PRIx32" chunk` Done -- To view, visit https://review.coreboot.org/c/flashrom/+/73037 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I591b117be911bdb8249247c20530c1cf70f6e70d Gerrit-Change-Number: 73037 Gerrit-PatchSet: 5 Gerrit-Owner: Alex Badea <vamposdecampos(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Thu, 16 Feb 2023 06:27:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: asm106x: add programmer for ASM106x SATA controllers
by Alex Badea (Code Review) 15 Feb '23

15 Feb '23

Attention is currently required from: Felix Singer, Edward O'Callaghan, Alex Badea. Hello Felix Singer, build bot (Jenkins), Thomas Heijligen, Edward O'Callaghan, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/73037 to look at the new patch set (#6). Change subject: asm106x: add programmer for ASM106x SATA controllers ...................................................................... asm106x: add programmer for ASM106x SATA controllers The ASMedia ASM106x series is a PCIe-SATA controller chip. It supports an attached SPI flash chip that can contain configuration and PCI option ROM. The interface is a simple shifter accessed via PCI config space, up to 4 bytes at a time. Add a programmer driver for it. Tested on a G536PCE1061V11 IO-PCE1061-V1.1 PCIe card, and a MPCE2ST-A01 VER006S mini-PCIe card, both with chips marked ASM1061, both enumerate as: 01:00.0 SATA controller [0106]: ASMedia Technology Inc. ASM1062 Serial ATA Controller [1b21:0612] (rev 02) (prog-if 01 [AHCI 1.0]) Subsystem: ASMedia Technology Inc. ASM1062 Serial ATA Controller [1b21:1060] Change-Id: I591b117be911bdb8249247c20530c1cf70f6e70d Signed-off-by: Alex Badea <vamposdecampos(a)gmail.com> --- M Makefile A asm106x.c M flashrom.8.tmpl M include/programmer.h M meson.build M meson_options.txt M programmer_table.c M test_build.sh 8 files changed, 213 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/37/73037/6 -- To view, visit https://review.coreboot.org/c/flashrom/+/73037 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I591b117be911bdb8249247c20530c1cf70f6e70d Gerrit-Change-Number: 73037 Gerrit-PatchSet: 6 Gerrit-Owner: Alex Badea <vamposdecampos(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Alex Badea <vamposdecampos(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[master]: Revert "flashrom_tester: Add positive check to verify_fail_test"
by Edward O'Callaghan (Code Review) 15 Feb '23

15 Feb '23

Edward O'Callaghan has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/72674 ) Change subject: Revert "flashrom_tester: Add positive check to verify_fail_test" ...................................................................... Abandoned turns out patches downstreaming were just mixed up -- To view, visit https://review.coreboot.org/c/flashrom/+/72674 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib8c99de7aca672f42b3159082e2e63e0fefef08f Gerrit-Change-Number: 72674 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Evan Benn <evanbenn(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[master]: jedec.c: Drop branching non-zero programmer_delay() operands
by Stefan Reinauer (Code Review) 15 Feb '23

15 Feb '23

Attention is currently required from: Edward O'Callaghan. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72692 ) Change subject: jedec.c: Drop branching non-zero programmer_delay() operands ...................................................................... Patch Set 1: (1 comment) File jedec.c: https://review.coreboot.org/c/flashrom/+/72692/comment/649dc0e7_2e2e6a98 PS1, Line 219: programmer_delay(flash, 10); this makes a conditional 10 unit delay into an unconditional one. -- To view, visit https://review.coreboot.org/c/flashrom/+/72692 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic547669bb16e6ace4fe283e07345fc2d7075d63e Gerrit-Change-Number: 72692 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Wed, 15 Feb 2023 18:00:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: jedec.c: Move probe_timings decode into sep func
by Stefan Reinauer (Code Review) 15 Feb '23

15 Feb '23

Attention is currently required from: Edward O'Callaghan. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72609 ) Change subject: jedec.c: Move probe_timings decode into sep func ...................................................................... Patch Set 4: Code-Review+2 (1 comment) Patchset: PS4: it would be good to add a rationale to the commit message -- To view, visit https://review.coreboot.org/c/flashrom/+/72609 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I638518cd537954172eb774f6d15af0db7e06d1ba Gerrit-Change-Number: 72609 Gerrit-PatchSet: 4 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Wed, 15 Feb 2023 17:56:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: jedec.c: Fold up dst into toggle_ready_jedec()
by Stefan Reinauer (Code Review) 15 Feb '23

15 Feb '23

Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72691 ) Change subject: jedec.c: Fold up dst into toggle_ready_jedec() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/72691 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib7a3fdbc6e0a888093dc8da6f5567a7301ec5040 Gerrit-Change-Number: 72691 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Wed, 15 Feb 2023 17:55:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: Add support for VIA VL805 USB Controller flashing
by ChrisEric1 CECL (Code Review) 15 Feb '23

15 Feb '23

Attention is currently required from: ChrisEric1 CECL, Thomas Heijligen, Edward O'Callaghan, Nicholas Chin. Hello build bot (Jenkins), Thomas Heijligen, Edward O'Callaghan, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/72057 to look at the new patch set (#17). Change subject: Add support for VIA VL805 USB Controller flashing ...................................................................... Add support for VIA VL805 USB Controller flashing It works fine for me on my Raspberry Pi 4 Model B. Was able read read, erase, write, verify. Only thing is the WP with the W25X10 gives a untested warning. Change-Id: I71435afcacdf97e14d627e35bce3d29de9657f38 Signed-off-by: Christopher Lentocha <christopherericlentocha(a)gmail.com> --- M Makefile M flashrom.8.tmpl M include/programmer.h M meson.build M meson_options.txt M programmer_table.c A vl805.c 7 files changed, 229 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/57/72057/17 -- To view, visit https://review.coreboot.org/c/flashrom/+/72057 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I71435afcacdf97e14d627e35bce3d29de9657f38 Gerrit-Change-Number: 72057 Gerrit-PatchSet: 17 Gerrit-Owner: ChrisEric1 CECL <christopherericlentocha(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: ChrisEric1 CECL <christopherericlentocha(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: Fix RPi4 VL805 USB controller flashing for W25X10 chips to RDID4
by ChrisEric1 CECL (Code Review) 15 Feb '23

15 Feb '23

ChrisEric1 CECL has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/73059 ) Change subject: Fix RPi4 VL805 USB controller flashing for W25X10 chips to RDID4 ...................................................................... Fix RPi4 VL805 USB controller flashing for W25X10 chips to RDID4 This patch is simple, it helps change id 72057 to work on a Raspberry Pi 4 Model B, by changing the W25X10 flash chip from RDID to RDID4, to flash with the VL805 controller. If this patch is not applied, then this error will come up: "Found Generic flash chip "unknown SPI chip (REMS)" (0 kB, SPI) on vl805." else it detects the 128 kB flash chip just fine. Change-Id: I346a8292eb345fcdbadcf0e09729a55f411c83e3 Signed-off-by: Christopher Lentocha <christopherericlentocha(a)gmail.com> --- M flashchips.c 1 file changed, 18 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/59/73059/1 diff --git a/flashchips.c b/flashchips.c index 625fe62..988f58c 100644 --- a/flashchips.c +++ b/flashchips.c @@ -19123,7 +19123,7 @@ .page_size = 256, .feature_bits = FEATURE_WRSR_WREN, .tested = TEST_OK_PREW, - .probe = PROBE_SPI_RDID, + .probe = PROBE_SPI_RDID4, .probe_timing = TIMING_ZERO, .block_erasers = { -- To view, visit https://review.coreboot.org/c/flashrom/+/73059 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I346a8292eb345fcdbadcf0e09729a55f411c83e3 Gerrit-Change-Number: 73059 Gerrit-PatchSet: 1 Gerrit-Owner: ChrisEric1 CECL <christopherericlentocha(a)gmail.com> Gerrit-MessageType: newchange

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit