Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62869 )
Change subject: ichspi: Factor out common hwseq_xfer logic into helpers
......................................................................
Patch Set 30: Code-Review+1
--
To view, visit https://review.coreboot.org/c/flashrom/+/62869
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ic9fd50841449e02f476a8834f4642d6ecad36dc3
Gerrit-Change-Number: 62869
Gerrit-PatchSet: 30
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Mon, 21 Nov 2022 07:34:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Edward O'Callaghan, Angel Pons, Nikolai Artemiev.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69422 )
Change subject: ichspi: clear byte count in ich_start_hwseq_xfer()
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> Subrata, I believe your patches supersede this one to fix the root cause? Can you coordinate with Ni […]
Yes, I agree that with 69788 and 69789, this regression is expected to get fixed.
--
To view, visit https://review.coreboot.org/c/flashrom/+/69422
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2535bdfb77ff370bddcb507a229bbf4119681cdf
Gerrit-Change-Number: 69422
Gerrit-PatchSet: 2
Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Comment-Date: Mon, 21 Nov 2022 06:16:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Subrata Banik, Angel Pons, Nikolai Artemiev.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69422 )
Change subject: ichspi: clear byte count in ich_start_hwseq_xfer()
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> > Also thank you Angel for pulling on this thread to get a deeper investigation going here so that w […]
Subrata, I believe your patches supersede this one to fix the root cause? Can you coordinate with Nik to abandon/or align the three patches floating about here.
--
To view, visit https://review.coreboot.org/c/flashrom/+/69422
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2535bdfb77ff370bddcb507a229bbf4119681cdf
Gerrit-Change-Number: 69422
Gerrit-PatchSet: 2
Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Comment-Date: Mon, 21 Nov 2022 06:12:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Iman Bingi, Thomas Heijligen.
Hello build bot (Jenkins), Thomas Heijligen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/69714
to look at the new patch set (#10).
Change subject: flashrom/gui: Add GUI to Flashrom
......................................................................
flashrom/gui: Add GUI to Flashrom
Flashrom Graphical User Interface
Depends on:
* gtk+ >=4
* adwaita >=1
Shortcomings:
* Untested
TODO:
* Test on as many hardware/platforms as possible
Change-Id: I130028b07e0465a2c877d5cbbdc2edd9ea5e8266
Signed-off-by: Ben Adu-Boahen <imanbingy(a)gmail.com>
---
A gflashrom/Makefile
A gflashrom/board_info.ui.xml
A gflashrom/chartable.c
A gflashrom/chartable.h
A gflashrom/chipset_info.ui.xml
A gflashrom/common_macros.h
A gflashrom/common_ui.c
A gflashrom/common_ui.h
A gflashrom/config.h
A gflashrom/configuration.c
A gflashrom/configuration.h
A gflashrom/context_menu.ui.xml
A gflashrom/converter.c
A gflashrom/converter.h
A gflashrom/coreboot.Gflashrom.gschema.xml
A gflashrom/data_buffer.c
A gflashrom/data_buffer.h
A gflashrom/device_info.c
A gflashrom/device_info.h
A gflashrom/find_dialog.ui.xml
A gflashrom/find_options.ui.xml
A gflashrom/findreplace.c
A gflashrom/findreplace.h
A gflashrom/flashchip_info.ui.xml
A gflashrom/flashrom.c
A gflashrom/gflashrom.c
A gflashrom/gflashrom.css
A gflashrom/gflashrom.gresource.xml
A gflashrom/gflashrom.h
A gflashrom/gflashrom_app_win.c
A gflashrom/gflashrom_app_win.h
A gflashrom/gflashrom_app_win.ui.xml
A gflashrom/gflashrom_layout_manager.c
A gflashrom/gflashrom_layout_manager.h
A gflashrom/gflashrom_paste_data.c
A gflashrom/gflashrom_paste_data.h
A gflashrom/gflashrom_resources.c
A gflashrom/help_overlay.ui.xml
A gflashrom/hex_dialog.c
A gflashrom/hex_dialog.h
A gflashrom/hex_document.c
A gflashrom/hex_document.h
A gflashrom/hex_statusbar.c
A gflashrom/hex_statusbar.h
A gflashrom/jump_dialog.ui.xml
A gflashrom/main.c
A gflashrom/objects.c
A gflashrom/objects.h
A gflashrom/paste_special.c
A gflashrom/paste_special.h
A gflashrom/paste_special.ui.xml
A gflashrom/preferences.c
A gflashrom/preferences.h
A gflashrom/preferences.ui.xml
A gflashrom/print.c
A gflashrom/print.h
A gflashrom/replace_dialog.ui.xml
57 files changed, 17,913 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/14/69714/10
--
To view, visit https://review.coreboot.org/c/flashrom/+/69714
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I130028b07e0465a2c877d5cbbdc2edd9ea5e8266
Gerrit-Change-Number: 69714
Gerrit-PatchSet: 10
Gerrit-Owner: Iman Bingi <imanbingy(a)gmail.com>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Iman Bingi <imanbingy(a)gmail.com>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-MessageType: newpatchset