April 2024 - flashrom-gerrit - mail.coreboot.org

[XS] Change in flashrom[main]: util/list_yet_unsupported_chips.h: Fix path
by Anastasia Klimchuk (Code Review) 12 Apr '24

12 Apr '24

Attention is currently required from: Maximilian Brune. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81855?usp=email ) Change subject: util/list_yet_unsupported_chips.h: Fix path ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: Ooh this has been broken for a while, include dir was introduced a while ago... thank you for fixing Maximillian! You have probably run the script, does it produce a useful info? Is it detecting the chips that are in .h file but have no definition in .c file? -- To view, visit https://review.coreboot.org/c/flashrom/+/81855?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Iecb6cf3d1f214102a243a3ffa8d0c9301263af0a Gerrit-Change-Number: 81855 Gerrit-PatchSet: 2 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Fri, 12 Apr 2024 05:25:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[main]: flashchips: Add support for MXIC MX25L1633E
by DZ (Code Review) 12 Apr '24

12 Apr '24

DZ has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/81836?usp=email ) Change subject: flashchips: Add support for MXIC MX25L1633E ...................................................................... flashchips: Add support for MXIC MX25L1633E The MX25L1633E has been tested by ch341a programmer : read, write, erase and wp. We have tested --wp-enable, --wp-disable, --wp-list and --wp-range commands for write-protect feature. MX25L1633E datasheet is available at the following URL: https://www.macronix.com/Lists/Datasheet/Attachments/8617/MX25L1633E,%203V,… Change-Id: I63ee0182ad6e62b7408136285aa0e927d53f7bc8 Signed-off-by: DanielZhang <danielzhang(a)mxic.com.cn> --- M flashchips.c 1 file changed, 44 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/36/81836/1 diff --git a/flashchips.c b/flashchips.c index 7a40f07..34a2a51 100644 --- a/flashchips.c +++ b/flashchips.c @@ -9227,7 +9227,7 @@ }, { .eraseblocks = { {2 * 1024 * 1024, 1} }, .block_erase = SPI_BLOCK_ERASE_C7, - }, + OB }, }, .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_BP3_SRWD, /* bit6: Continuously Program (CP) mode, for 73E is quad enable */ .unlock = SPI_DISABLE_BLOCKPROTECT_BP3_SRWD, @@ -9274,6 +9274,49 @@ { .vendor = "Macronix", + .name = "MX25L1633E", + .bustype = BUS_SPI, + .manufacture_id = MACRONIX_ID, + .model_id = MACRONIX_MX25L1635D, + .total_size = 2048, + .page_size = 256, + /* OTP: 64B total; enter 0xB1, exit 0xC1 */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP , + .tested = TEST_OK_PREWB, + .probe = PROBE_SPI_RDID, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 512} }, + .block_erase = SPI_BLOCK_ERASE_20, + }, { + .eraseblocks = { {64 * 1024, 32} }, + .block_erase = SPI_BLOCK_ERASE_D8, + }, { + .eraseblocks = { {2 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_60, + }, { + .eraseblocks = { {2 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_C7, + } + }, + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_BP3_SRWD, /* bit6 is quad enable */ + .unlock = SPI_DISABLE_BLOCKPROTECT_BP3_SRWD, + .write = SPI_CHIP_WRITE256, + .read = SPI_CHIP_READ, /* Fast read (0x0B) and multi I/O supported */ + .voltage = {2700, 3600}, + .reg_bits = + { + .srp = {STATUS1, 7, RW}, + .bp = {{STATUS1, 2, RW}, {STATUS1, 3, RW}, {STATUS1, 4, RW}, {STATUS1, 5, RW}}, + }, + + .decode_range = DECODE_RANGE_SPI25, + }, + + { + .vendor = "Macronix", .name = "MX25L1635E", .bustype = BUS_SPI, .manufacture_id = MACRONIX_ID, -- To view, visit https://review.coreboot.org/c/flashrom/+/81836?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I63ee0182ad6e62b7408136285aa0e927d53f7bc8 Gerrit-Change-Number: 81836 Gerrit-PatchSet: 1 Gerrit-Owner: DZ <danielzhang(a)mxic.com.cn> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[main]: flashchips: Add support for MXIC MX25L1636E
by DZ (Code Review) 12 Apr '24

12 Apr '24

DZ has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/81835?usp=email ) Change subject: flashchips: Add support for MXIC MX25L1636E ...................................................................... flashchips: Add support for MXIC MX25L1636E The MX25L1636E has been tested by ch341a programmer : read, write, erase and wp. We have tested --wp-enable, --wp-disable, --wp-list and --wp-range commands for write-protect feature. MX25L1636E datasheet is available at the following URL: https://www.mxic.com.tw/Lists/Datasheet/Attachments/8596/MX25L1636E,%203V,%… Change-Id: I415e2d6c89d3d59ba44e22753001c6f69421c39d Signed-off-by: DanielZhang <danielzhang(a)mxic.com.cn> --- M flashchips.c 1 file changed, 11 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/35/81835/1 diff --git a/flashchips.c b/flashchips.c index 7a40f07..c60770b 100644 --- a/flashchips.c +++ b/flashchips.c @@ -9274,15 +9274,15 @@ { .vendor = "Macronix", - .name = "MX25L1635E", + .name = "MX25L1635E/MX25L1636E", .bustype = BUS_SPI, .manufacture_id = MACRONIX_ID, .model_id = MACRONIX_MX25L1635E, .total_size = 2048, .page_size = 256, /* OTP: 64B total; enter 0xB1, exit 0xC1 */ - .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP, - .tested = TEST_UNTESTED, + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_CFGR, + .tested = TEST_OK_PREWB, .probe = PROBE_SPI_RDID, .probe_timing = TIMING_ZERO, .block_erasers = @@ -9306,6 +9306,14 @@ .write = SPI_CHIP_WRITE256, .read = SPI_CHIP_READ, /* Fast read (0x0B) and multi I/O supported */ .voltage = {2700, 3600}, + .reg_bits = + { + .srp = {STATUS1, 7, RW}, + .bp = {{STATUS1, 2, RW}, {STATUS1, 3, RW}, {STATUS1, 4, RW}, {STATUS1, 5, RW}}, + .tb = {CONFIG, 3, OTP} + }, + + .decode_range = DECODE_RANGE_SPI25, }, { -- To view, visit https://review.coreboot.org/c/flashrom/+/81835?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I415e2d6c89d3d59ba44e22753001c6f69421c39d Gerrit-Change-Number: 81835 Gerrit-PatchSet: 1 Gerrit-Owner: DZ <danielzhang(a)mxic.com.cn> Gerrit-MessageType: newchange

1 0

[L] Change in flashrom[main]: udelay: only use OS time for delays, except on DOS
by Peter Marheine (Code Review) 12 Apr '24

12 Apr '24

Attention is currently required from: Anastasia Klimchuk, Brian Norris, Thomas Heijligen. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81545?usp=email ) Change subject: udelay: only use OS time for delays, except on DOS ...................................................................... Patch Set 9: (1 comment) File tests/udelay.c: https://review.coreboot.org/c/flashrom/+/81545/comment/0469c528_8164c12f : PS9, Line 41: This test could fail spuriously on a heavily-loaded system > I see you acknowledge this already, but I just want to mention that this is definitely relevant for […] Since this test is mostly meant to exercise the sleep-free case (as I explained in response to Anastasia's comment on the test code), do you think it would be reasonable to maintain this assertion as-is provided we ensure the tested delay is always short enough to avoid sleeping? I'm imagining 100 microseconds as written now, or 1 less than the minimum sleep time if that is not greater than 100 microseconds. Otherwise I wouldn't mind removing the upper bound. I would expect that our time-polling loop would still be responsive enough even on a heavily-loaded CI system, unless we got unlucky and the delay fell right at the end of a quantum (causing the test to be preempted), but perhaps that would still be too common to be acceptable. -- To view, visit https://review.coreboot.org/c/flashrom/+/81545?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I7ac5450d194a475143698d65d64d8bcd2fd25e3f Gerrit-Change-Number: 81545 Gerrit-PatchSet: 9 Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Brian Norris <briannorris(a)chromium.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Fri, 12 Apr 2024 01:22:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Brian Norris <briannorris(a)chromium.org> Gerrit-MessageType: comment

1 0

[L] Change in flashrom[main]: udelay: only use OS time for delays, except on DOS
by Brian Norris (Code Review) 12 Apr '24

12 Apr '24

Attention is currently required from: Anastasia Klimchuk, Peter Marheine, Thomas Heijligen. Brian Norris has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81545?usp=email ) Change subject: udelay: only use OS time for delays, except on DOS ...................................................................... Patch Set 9: Code-Review+1 (3 comments) Patchset: PS9: LGTM % test question File meson.build: https://review.coreboot.org/c/flashrom/+/81545/comment/615b625a_b50dc7b2 : PS4, Line 121: DHAVE_NANOSLEEP=1 > On reflection, this isn't even required. […] 👍 I was kinda wondering if we really cared to support non-POSIX.1-2008 here (outside of Windows and DOS, which build non-nanosleep code already). File tests/udelay.c: https://review.coreboot.org/c/flashrom/+/81545/comment/9e7989ec_59a9e340 : PS9, Line 41: This test could fail spuriously on a heavily-loaded system I see you acknowledge this already, but I just want to mention that this is definitely relevant for ChromeOS. We run tests from quite a few different projects in our CI environment, and sometimes this may yield a lot of system load at the same time. We've seen sleep-related latencies that are 5x their expected. Specifically, we expected 100ms, so we tested for 500ms -- and even then, we saw frequent enough flakes that we expanded the margin to 1000ms. That's to say, I expect this test will become flaky on ChromeOS CI. I don't know how that fits into the flashrom project expectations. Anyway, personally, I'd recommend only testing the lower bound and not the upper bound. --- For the record, public references: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2207141 https://bugs.chromium.org/p/chromium/issues/detail?id=1083515 Non-public reference: b/333412847 -- To view, visit https://review.coreboot.org/c/flashrom/+/81545?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I7ac5450d194a475143698d65d64d8bcd2fd25e3f Gerrit-Change-Number: 81545 Gerrit-PatchSet: 9 Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Fri, 12 Apr 2024 00:31:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Brian Norris <briannorris(a)chromium.org> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org> Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[main]: util/list_yet_unsupported_chips.h: Fix path
by Maximilian Brune (Code Review) 12 Apr '24

12 Apr '24

Maximilian Brune has uploaded a new patch set (#2). ( https://review.coreboot.org/c/flashrom/+/81855?usp=email ) Change subject: util/list_yet_unsupported_chips.h: Fix path ...................................................................... util/list_yet_unsupported_chips.h: Fix path Change-Id: Iecb6cf3d1f214102a243a3ffa8d0c9301263af0a Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> --- M util/list_yet_unsupported_chips.sh 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/55/81855/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/81855?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Iecb6cf3d1f214102a243a3ffa8d0c9301263af0a Gerrit-Change-Number: 81855 Gerrit-PatchSet: 2 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in flashrom[main]: util/list_yet_unsupported_chips.h: Fix path
by Maximilian Brune (Code Review) 12 Apr '24

12 Apr '24

Maximilian Brune has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/81855?usp=email ) Change subject: util/list_yet_unsupported_chips.h: Fix path ...................................................................... util/list_yet_unsupported_chips.h: Fix path Change-Id: Iecb6cf3d1f214102a243a3ffa8d0c9301263af0a Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> --- M util/list_yet_unsupported_chips.sh 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/55/81855/1 diff --git a/util/list_yet_unsupported_chips.sh b/util/list_yet_unsupported_chips.sh index 3a4d1b8..bba5813 100755 --- a/util/list_yet_unsupported_chips.sh +++ b/util/list_yet_unsupported_chips.sh @@ -2,7 +2,7 @@ scriptname=$(readlink -f "$0") 2>/dev/null path=$(dirname "$scriptname")/.. 2>/dev/null -if [ ! -e "$path/flashchips.c" -o ! -e "$path/flashchips.h" ]; then +if [ ! -e "$path/flashchips.c" -o ! -e "$path/include/flashchips.h" ]; then echo "Warning: could not calculate flashchips.[ch]'s directory. Trying current..." path="." if [ ! -e "$path/flashchips.c" -o ! -e "$path/flashchips.h" ]; then @@ -11,11 +11,11 @@ fi fi -chips=$(sed -re '/#define [A-Z]/ !d' -e '/_ID\s/d' -e 's/\s*#define\s+([[:alnum:]_]+)\s+.*/\1/' "$path/flashchips.h") +chips=$(sed -re '/#define [A-Z]/ !d' -e '/_ID\s/d' -e 's/\s*#define\s+([[:alnum:]_]+)\s+.*/\1/' "$path/include/flashchips.h") for c in $chips ; do if ! grep "$c" "$path/flashchips.c" >/dev/null ; then if [ -n "$1" ]; then - grep -o "$c.*" "$path/flashchips.h" + grep -o "$c.*" "$path/include/flashchips.h" else echo "$c" fi -- To view, visit https://review.coreboot.org/c/flashrom/+/81855?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Iecb6cf3d1f214102a243a3ffa8d0c9301263af0a Gerrit-Change-Number: 81855 Gerrit-PatchSet: 1 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[main]: sb600spi.c: Drop "Promontory" support
by Angel Pons (Code Review) 11 Apr '24

11 Apr '24

Angel Pons has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/69170?usp=email ) Change subject: sb600spi.c: Drop "Promontory" support ...................................................................... Abandoned No interest in pursuing this -- To view, visit https://review.coreboot.org/c/flashrom/+/69170?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I1457946dce68321b496d9ffa40a0c5ab46455f72 Gerrit-Change-Number: 69170 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[main]: [WIP] ft2232_spi.c: Reduce scope of programmer param variables
by Angel Pons (Code Review) 11 Apr '24

11 Apr '24

Angel Pons has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/67904?usp=email ) Change subject: [WIP] ft2232_spi.c: Reduce scope of programmer param variables ...................................................................... Abandoned No interest in pursuing this -- To view, visit https://review.coreboot.org/c/flashrom/+/67904?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I2c091d7098ea97141da90b9f8b7b60f94a1a2d3d Gerrit-Change-Number: 67904 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in flashrom[master]: dummyflasher.c: Use programmer logger functions
by Angel Pons (Code Review) 11 Apr '24

11 Apr '24

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/46523 ) Change subject: dummyflasher.c: Use programmer logger functions ...................................................................... dummyflasher.c: Use programmer logger functions All but three log messages use the programmer logger. Change the three outliers that were using the chip logger accordingly. Change-Id: Ia8668e05df2da739e6bb4c7d0fddad86e8d054a3 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M dummyflasher.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/23/46523/1 diff --git a/dummyflasher.c b/dummyflasher.c index 6426ad2..d233db4 100644 --- a/dummyflasher.c +++ b/dummyflasher.c @@ -610,7 +610,7 @@ } for (i = 0; i < data->spi_ignorelist_size; i++) { if (writearr[0] == data->spi_ignorelist[i]) { - msg_cdbg("Ignoring ignorelisted SPI command 0x%02x\n", + msg_pdbg("Ignoring ignorelisted SPI command 0x%02x\n", data->spi_ignorelist[i]); /* Return success because the command does not fail, * it is simply ignored. @@ -1050,7 +1050,7 @@ * Search "total_size * 1024" in code. */ flash->chip->total_size = emu_data->emu_chip_size / 1024; - msg_cdbg("%s: set flash->total_size to %dK bytes.\n", __func__, + msg_pdbg("%s: set flash->total_size to %dK bytes.\n", __func__, flash->chip->total_size); /* Update the first count of each of the block_erasers. */ @@ -1061,7 +1061,7 @@ eraser->eraseblocks[0].count = 1; eraser->eraseblocks[0].size = emu_data->emu_chip_size; - msg_cdbg("%s: eraser.size=%d, .count=%d\n", + msg_pdbg("%s: eraser.size=%d, .count=%d\n", __func__, eraser->eraseblocks[0].size, eraser->eraseblocks[0].count); } -- To view, visit https://review.coreboot.org/c/flashrom/+/46523 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia8668e05df2da739e6bb4c7d0fddad86e8d054a3 Gerrit-Change-Number: 46523 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

3 3

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit April 2024