April 2024 - flashrom-gerrit - mail.coreboot.org

[M] Change in flashrom[main]: ft2232_spi.c: Add struct for programmer params
by Angel Pons (Code Review) 11 Apr '24

11 Apr '24

Angel Pons has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/67906?usp=email ) Change subject: ft2232_spi.c: Add struct for programmer params ...................................................................... Abandoned No interest in pursuing this -- To view, visit https://review.coreboot.org/c/flashrom/+/67906?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I36b9f5f8481907bd605e9310bef08592bb7d9827 Gerrit-Change-Number: 67906 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[main]: flashchips: Add write-protect support for MX25L12833F
by Hsuan-ting Chen (Code Review) 10 Apr '24

10 Apr '24

Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer. Hello Anastasia Klimchuk, Hsuan Ting Chen, Nikolai Artemiev, Stefan Reinauer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/81792?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: flashchips: Add write-protect support for MX25L12833F ...................................................................... flashchips: Add write-protect support for MX25L12833F datasheet: https://www.macronix.com/Lists/Datasheet/Attachments/8934/MX25L12833F,%203V… BUG=b:332486637 TEST=Test flashrom --wp-disable with MX25L12833FZNI-10 on ChromeOS Change-Id: I379c833eea3ed3487504126f45c6df672a772ddc Signed-off-by: Hsuan Ting Chen <roccochen(a)chromium.org> --- M flashchips.c 1 file changed, 9 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/92/81792/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/81792?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I379c833eea3ed3487504126f45c6df672a772ddc Gerrit-Change-Number: 81792 Gerrit-PatchSet: 2 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[main]: Add support for Idaville HCC platform and iRC regions
by Kevin Yu (Code Review) 10 Apr '24

10 Apr '24

Attention is currently required from: Angel Pons, Paul Menzel. Kevin Yu has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81327?usp=email ) Change subject: Add support for Idaville HCC platform and iRC regions ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Hi Paul and Angel Could you help on this? Thanks Kevin Yu -- To view, visit https://review.coreboot.org/c/flashrom/+/81327?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I39e7fa56b1b1de429f413ce32e69c8d8c769b6a9 Gerrit-Change-Number: 81327 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Yu <ykevin(a)celestica.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 10 Apr 2024 08:41:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[main]: flashchips: Add support for MXIC MX25L3273F
by Anastasia Klimchuk (Code Review) 10 Apr '24

10 Apr '24

Attention is currently required from: DZ, Nikolai Artemiev, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81562?usp=email ) Change subject: flashchips: Add support for MXIC MX25L3273F ...................................................................... Patch Set 9: (1 comment) File flashchips.c: https://review.coreboot.org/c/flashrom/+/81562/comment/c683b659_d143aaa5 : PS7, Line 9522: 1024B > Same as other patch: datasheet says 4K-bit secured OTP, so maybe 512B ? Daniel, I noticed that you updated the patch but didn't mark comment as fixed. Is that you forgot to resolve the comment or you are still want to do some more on the patch? -- To view, visit https://review.coreboot.org/c/flashrom/+/81562?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I4adaaa796d1db34702e7b0ed8e6fb167a3a5f6d7 Gerrit-Change-Number: 81562 Gerrit-PatchSet: 9 Gerrit-Owner: DZ <danielzhang(a)mxic.com.cn> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: DZ <danielzhang(a)mxic.com.cn> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Wed, 10 Apr 2024 03:05:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[main]: meson: Update CI script to enforce building man pages and docs
by Anastasia Klimchuk (Code Review) 10 Apr '24

10 Apr '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/81665?usp=email ) Change subject: meson: Update CI script to enforce building man pages and docs ...................................................................... meson: Update CI script to enforce building man pages and docs `test_build.sh` is used by Jenkins, therefore it should build everything. Docker container for Jenkins is expected to have all the dependencies installed, and if some of them are missing, script should fail. Recently we had a situation when docker image was missing sphinx and flashrom Jenkins was silently skipping building man-pages and documentation. This patch prevents this happening again, because building man pages and docs will be enforced. Change-Id: Ib89abddad27d1168cf0a621cf4bdb9f541266165 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/81665 Reviewed-by: Martin L Roth <gaumless(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Anton Samsonov <avscomputing(a)gmail.com> --- M test_build.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Martin L Roth: Looks good to me, approved Anton Samsonov: Looks good to me, but someone else must approve diff --git a/test_build.sh b/test_build.sh index 9b490dc..ee86496 100755 --- a/test_build.sh +++ b/test_build.sh @@ -51,7 +51,7 @@ build_meson () { build_dir=out - meson_opts="-Dtests=enabled" + meson_opts="-Dtests=enabled -Dman-pages=enabled -Ddocumentation=enabled" ninja_opts="-j $(nproc)" rm -rf ${build_dir} -- To view, visit https://review.coreboot.org/c/flashrom/+/81665?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ib89abddad27d1168cf0a621cf4bdb9f541266165 Gerrit-Change-Number: 81665 Gerrit-PatchSet: 4 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anton Samsonov <avscomputing(a)gmail.com> Gerrit-Reviewer: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in flashrom[main]: doc: Make OS specific instructions as headers so they are linkable
by Patrick Georgi (Code Review) 09 Apr '24

09 Apr '24

Attention is currently required from: Anastasia Klimchuk, Thomas Heijligen. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81780?usp=email ) Change subject: doc: Make OS specific instructions as headers so they are linkable ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/81780?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I78645131b1f0acbedcf11964a204a24c45b62cff Gerrit-Change-Number: 81780 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Patrick Georgi Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 09 Apr 2024 09:19:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[main]: doc: Make OS specific instructions as headers so they are linkable
by Patrick Georgi (Code Review) 09 Apr '24

09 Apr '24

Attention is currently required from: Anastasia Klimchuk, Thomas Heijligen. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81780?usp=email ) Change subject: doc: Make OS specific instructions as headers so they are linkable ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File doc/dev_guide/building_from_source.rst: https://review.coreboot.org/c/flashrom/+/81780/comment/46199224_2946cecf : PS1, Line 80: Is this the right level of indentation? -- To view, visit https://review.coreboot.org/c/flashrom/+/81780?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I78645131b1f0acbedcf11964a204a24c45b62cff Gerrit-Change-Number: 81780 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Patrick Georgi Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 09 Apr 2024 06:44:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[main]: meson: Update CI script to enforce building man pages and docs
by Anastasia Klimchuk (Code Review) 08 Apr '24

08 Apr '24

Attention is currently required from: Anton Samsonov, Anton Samsonov, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81665?usp=email ) Change subject: meson: Update CI script to enforce building man pages and docs ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > Although I get all kinds of build and testing errors when running `test_build.sh` […] Yes, the script is designed for Jenkins container, and it expects a specific environment (currently being x86 Linux, all dependencies installed). We have some plans to add FreeBSD environment to run on CI, but this hasn't happened yet. About unit tests: you can run them without running full script test_build.sh. Because they test low level code, it typically needs fixes for each environment. I would really love to have unit tests running on as much environments as possible (out of the ones flashrom supports). Currently they run on Linux (and Jenkins keeps an eye on that), also last year I fixed them to run on top 4 BSDs. I have an idea to try fix them on mac. But the main thing, you need to have that specific environment, to run and re-run tests and fix them. If you would like to join this adventure, you can try fix the unit tests for your environment! The most common causes for segfault in tests are two: 1) missing wrap (example https://review.coreboot.org/c/flashrom/+/73649) 2) syscall which expands into inline code (example https://review.coreboot.org/c/flashrom/+/74157) This is optional, but if you decide to do it, thank you so so much! There is also a doc https://flashrom.org/contrib_howtos/how_to_add_unit_test.html I like flashrom unit tests, I can talk about them forever :) -- To view, visit https://review.coreboot.org/c/flashrom/+/81665?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ib89abddad27d1168cf0a621cf4bdb9f541266165 Gerrit-Change-Number: 81665 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anton Samsonov <avscomputing(a)gmail.com> Gerrit-Reviewer: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anton Samsonov <avscomputing(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Comment-Date: Tue, 09 Apr 2024 02:57:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anton Samsonov <avscomputing(a)gmail.com> Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[main]: Makefile: Fix cleanup for Sphinx versions prior to 4.x
by Anastasia Klimchuk (Code Review) 08 Apr '24

08 Apr '24

Attention is currently required from: Anton Samsonov, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81802?usp=email ) Change subject: Makefile: Fix cleanup for Sphinx versions prior to 4.x ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/81802?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I123aec7cf2f016ba905c220cfc84a217523f9932 Gerrit-Change-Number: 81802 Gerrit-PatchSet: 1 Gerrit-Owner: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Comment-Date: Tue, 09 Apr 2024 02:24:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in flashrom[main]: udelay: only use OS time for delays, except on DOS
by Peter Marheine (Code Review) 08 Apr '24

08 Apr '24

Attention is currently required from: Anastasia Klimchuk, Brian Norris, Thomas Heijligen. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81545?usp=email ) Change subject: udelay: only use OS time for delays, except on DOS ...................................................................... Patch Set 9: (4 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/81545/comment/27cac6b1_03442abc : PS7, Line 10: ) > you can also add the link to archive (keep the title) https://mail.coreboot. […] Done File tests/udelay.c: https://review.coreboot.org/c/flashrom/+/81545/comment/84c49c7f_92768e76 : PS7, Line 47: default_delay(100); > I thought for a moment we can afford a long delay test, for usec = 100001, but I don't know would it […] I think it's most useful to be testing the short delay case, since it's easy to understand the situations in which it should sleep and we depend on the OS for ensuring a sleep is long enough. My goal here was to have some confidence that timer-polling waits won't terminate early, and in that context I don't think it's very useful to exercise a long wait. File udelay.c: https://review.coreboot.org/c/flashrom/+/81545/comment/6ac9c6a0_18bf2605 : PS7, Line 33: #ifdef _POSIX_MONOTONIC_CLOCK : static clockid_t clock_id = CLOCK_MONOTONIC; : #else : static clockid_t clock_id = CLOCK_REALTIME; : #endif > This is only used inside `clock_usec_delay` now, can it be locally defined inside the function? It w […] Done https://review.coreboot.org/c/flashrom/+/81545/comment/66d4ec8e_574ea1f2 : PS7, Line 62: inline > For my education, why the function is inline only for this case and not the above? That's how it was before; no reason as far as I'm concerned. I've removed the inline. -- To view, visit https://review.coreboot.org/c/flashrom/+/81545?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I7ac5450d194a475143698d65d64d8bcd2fd25e3f Gerrit-Change-Number: 81545 Gerrit-PatchSet: 9 Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Brian Norris <briannorris(a)chromium.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 08 Apr 2024 23:23:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit April 2024