April 2024 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: dummyflasher.c: Use programmer logger functions
by Angel Pons (Code Review) 11 Apr '24

11 Apr '24

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/46523 ) Change subject: dummyflasher.c: Use programmer logger functions ...................................................................... dummyflasher.c: Use programmer logger functions All but three log messages use the programmer logger. Change the three outliers that were using the chip logger accordingly. Change-Id: Ia8668e05df2da739e6bb4c7d0fddad86e8d054a3 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M dummyflasher.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/23/46523/1 diff --git a/dummyflasher.c b/dummyflasher.c index 6426ad2..d233db4 100644 --- a/dummyflasher.c +++ b/dummyflasher.c @@ -610,7 +610,7 @@ } for (i = 0; i < data->spi_ignorelist_size; i++) { if (writearr[0] == data->spi_ignorelist[i]) { - msg_cdbg("Ignoring ignorelisted SPI command 0x%02x\n", + msg_pdbg("Ignoring ignorelisted SPI command 0x%02x\n", data->spi_ignorelist[i]); /* Return success because the command does not fail, * it is simply ignored. @@ -1050,7 +1050,7 @@ * Search "total_size * 1024" in code. */ flash->chip->total_size = emu_data->emu_chip_size / 1024; - msg_cdbg("%s: set flash->total_size to %dK bytes.\n", __func__, + msg_pdbg("%s: set flash->total_size to %dK bytes.\n", __func__, flash->chip->total_size); /* Update the first count of each of the block_erasers. */ @@ -1061,7 +1061,7 @@ eraser->eraseblocks[0].count = 1; eraser->eraseblocks[0].size = emu_data->emu_chip_size; - msg_cdbg("%s: eraser.size=%d, .count=%d\n", + msg_pdbg("%s: eraser.size=%d, .count=%d\n", __func__, eraser->eraseblocks[0].size, eraser->eraseblocks[0].count); } -- To view, visit https://review.coreboot.org/c/flashrom/+/46523 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia8668e05df2da739e6bb4c7d0fddad86e8d054a3 Gerrit-Change-Number: 46523 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

3 3

[S] Change in flashrom[main]: treewide: Use calloc() where applicable
by Angel Pons (Code Review) 11 Apr '24

11 Apr '24

Angel Pons has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/55269?usp=email ) Change subject: treewide: Use calloc() where applicable ...................................................................... Abandoned No interest in pursuing this -- To view, visit https://review.coreboot.org/c/flashrom/+/55269?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Id6ef0d6d02c7b63baabc9a0087275cab22a48736 Gerrit-Change-Number: 55269 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[M] Change in flashrom[main]: [UNTESTED] bitbang_spi.c: Support changing clock polarity and phase
by Angel Pons (Code Review) 11 Apr '24

11 Apr '24

Angel Pons has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/49271?usp=email ) Change subject: [UNTESTED] bitbang_spi.c: Support changing clock polarity and phase ...................................................................... Abandoned No interest in pursuing this -- To view, visit https://review.coreboot.org/c/flashrom/+/49271?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I415a528c013f1a523e883d812b6890be39bfcc7b Gerrit-Change-Number: 49271 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Xiang W <wxjstz(a)126.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Shawn C <citypw(a)hardenedlinux.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[XS] Change in flashrom[main]: bitbang_spi.c: Do not set MOSI during initialization
by Angel Pons (Code Review) 11 Apr '24

11 Apr '24

Angel Pons has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/49270?usp=email ) Change subject: bitbang_spi.c: Do not set MOSI during initialization ...................................................................... Abandoned No interest in pursuing this -- To view, visit https://review.coreboot.org/c/flashrom/+/49270?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I925d0ae55ae006dfcc6e7fb90364235526c576ef Gerrit-Change-Number: 49270 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Shawn C <citypw(a)hardenedlinux.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Xiang W <wxjstz(a)126.com> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[main]: bitbang_spi: Refactor `set_sck_set_mosi`
by Angel Pons (Code Review) 11 Apr '24

11 Apr '24

Angel Pons has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/49269?usp=email ) Change subject: bitbang_spi: Refactor `set_sck_set_mosi` ...................................................................... Abandoned No interest in pursuing this -- To view, visit https://review.coreboot.org/c/flashrom/+/49269?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ia84d32965e56ca563062893ebbefbbea5c35814c Gerrit-Change-Number: 49269 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Shawn C <citypw(a)hardenedlinux.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Xiang W <wxjstz(a)126.com> Gerrit-MessageType: abandon

1 0

[M] Change in flashrom[main]: nicintel_spi.c: Cache FLA register value
by Angel Pons (Code Review) 11 Apr '24

11 Apr '24

Angel Pons has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/55720?usp=email ) Change subject: nicintel_spi.c: Cache FLA register value ...................................................................... Abandoned No interest in pursuing this -- To view, visit https://review.coreboot.org/c/flashrom/+/55720?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I4013a71ec498be977f62fe2531ac8770bfffadcd Gerrit-Change-Number: 55720 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Idwer Vollering <vidwer(a)gmail.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[main]: mcp6x_spi.c: Implement `set_sck_set_mosi`
by Angel Pons (Code Review) 11 Apr '24

11 Apr '24

Angel Pons has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/49266?usp=email ) Change subject: mcp6x_spi.c: Implement `set_sck_set_mosi` ...................................................................... Abandoned No interest in pursuing this -- To view, visit https://review.coreboot.org/c/flashrom/+/49266?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ie86cc9d4df6c7f0609c30ff00d6f2d77fbb8b836 Gerrit-Change-Number: 49266 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Shawn C <citypw(a)hardenedlinux.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Xiang W <wxjstz(a)126.com> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[main]: rayer_spi.c: Implement `set_sck_set_mosi`
by Angel Pons (Code Review) 11 Apr '24

11 Apr '24

Angel Pons has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/49265?usp=email ) Change subject: rayer_spi.c: Implement `set_sck_set_mosi` ...................................................................... Abandoned No interest in pursuing this -- To view, visit https://review.coreboot.org/c/flashrom/+/49265?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ieb05a35967685c2444d064cb61cec98e2a00f590 Gerrit-Change-Number: 49265 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Shawn C <citypw(a)hardenedlinux.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Xiang W <wxjstz(a)126.com> Gerrit-MessageType: abandon

1 0

[M] Change in flashrom[main]: bitbang_spi: Drop `set_mosi` and `get_miso` operations
by Angel Pons (Code Review) 11 Apr '24

11 Apr '24

Angel Pons has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/49268?usp=email ) Change subject: bitbang_spi: Drop `set_mosi` and `get_miso` operations ...................................................................... Abandoned No interest in pursuing this -- To view, visit https://review.coreboot.org/c/flashrom/+/49268?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Id6b1edb1e01330feffc5f1ed2ca2c2ebc4fb3b66 Gerrit-Change-Number: 49268 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Shawn C <citypw(a)hardenedlinux.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Xiang W <wxjstz(a)126.com> Gerrit-MessageType: abandon

1 0

[M] Change in flashrom[main]: ft2232_spi.c: Split out most programmer param parsing
by Angel Pons (Code Review) 11 Apr '24

11 Apr '24

Angel Pons has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/67908?usp=email ) Change subject: ft2232_spi.c: Split out most programmer param parsing ...................................................................... Abandoned No interest in pursuing this -- To view, visit https://review.coreboot.org/c/flashrom/+/67908?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I25faac1060fc2bcd6042e34802e5bc493c936377 Gerrit-Change-Number: 67908 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: abandon

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit April 2024