April 2024 - flashrom-gerrit - mail.coreboot.org

[L] Change in flashrom[main]: udelay: only use OS time for delays, except on DOS
by Peter Marheine (Code Review) 09 Apr '24

09 Apr '24

Attention is currently required from: Brian Norris, Peter Marheine, Thomas Heijligen. Hello Anastasia Klimchuk, Brian Norris, Thomas Heijligen, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/81545?usp=email to look at the new patch set (#8). Change subject: udelay: only use OS time for delays, except on DOS ...................................................................... udelay: only use OS time for delays, except on DOS As proposed on the mailing list ("RFC: remove the calibrated delay loop" [1]), this removes the calibrated delay loop and uses OS-based timing functions for all delays because the calibrated delay loop can delay for shorter times than intended. When sleeping this now uses nanosleep() unconditionally, since usleep was only used on DOS (where DJGPP lacks nanosleep). When busy-looping, it uses clock_gettime() with CLOCK_MONOTONIC or CLOCK_REALTIME depending on availability, and gettimeofday() otherwise. The calibrated delay loop is retained for DOS only, because timer resolution on DJGPP is only about 50 milliseconds. Since typical delays in flashrom are around 10 microseconds, using OS timing there would regress performance by around 500x. The old implementation is reused with some branches removed based on the knowledge that timer resolution will not be better than about 50 milliseconds. Tested by reading and writing flash on several Intel and AMD systems: * Lenovo P920 (Intel C620, read/verify only) * "nissa" chromebook (Intel Alder Lake-N) * "zork" chromebook (AMD Zen+) [1]: https://mail.coreboot.org/hyperkitty/list/flashrom@flashrom.org/thread/HFH6… Signed-off-by: Peter Marheine <pmarheine(a)chromium.org> Change-Id: I7ac5450d194a475143698d65d64d8bcd2fd25e3f --- M Makefile M include/programmer.h M libflashrom.c M meson.build M tests/meson.build M tests/tests.c M tests/tests.h A tests/udelay.c M udelay.c A udelay_dos.c 10 files changed, 261 insertions(+), 172 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/45/81545/8 -- To view, visit https://review.coreboot.org/c/flashrom/+/81545?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I7ac5450d194a475143698d65d64d8bcd2fd25e3f Gerrit-Change-Number: 81545 Gerrit-PatchSet: 8 Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Brian Norris <briannorris(a)chromium.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[main]: doc: Make OS specific instructions as headers so they are linkable
by Anastasia Klimchuk (Code Review) 08 Apr '24

08 Apr '24

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/81780?usp=email ) Change subject: doc: Make OS specific instructions as headers so they are linkable ...................................................................... doc: Make OS specific instructions as headers so they are linkable When html page is generated, all headers are generated as links on the page. It is useful to have OS specific instructions as a link to share with people. Change-Id: I78645131b1f0acbedcf11964a204a24c45b62cff Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M doc/dev_guide/building_from_source.rst 1 file changed, 120 insertions(+), 96 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/80/81780/1 diff --git a/doc/dev_guide/building_from_source.rst b/doc/dev_guide/building_from_source.rst index c997832..a6d1dbf 100644 --- a/doc/dev_guide/building_from_source.rst +++ b/doc/dev_guide/building_from_source.rst @@ -47,141 +47,165 @@ * No external dependencies (documentation should be build without fetching all of pypi) * No Javascript? -* Linux - * Debian / Ubuntu - :: +Linux +""""" - apt-get install -y \ - gcc meson ninja-build pkg-config python3-sphinx \ - libcmocka-dev libpci-dev libusb-1.0-0-dev libftdi1-dev libjaylink-dev +* Debian / Ubuntu - * ArchLinux / Manjaro - :: + :: - pacman -S --noconfirm \ - gcc meson ninja pkg-config python-sphinx cmocka \ - pciutils libusb libftdi libjaylink + apt-get install -y \ + gcc meson ninja-build pkg-config python3-sphinx \ + libcmocka-dev libpci-dev libusb-1.0-0-dev libftdi1-dev libjaylink-dev - * openSUSE / SUSE - :: +* ArchLinux / Manjaro - zypper install -y \ - gcc meson ninja pkg-config python3-Sphinx \ - libcmocka-devel pciutils-devel libusb-1_0-devel libftdi1-devel libjaylink-devel + :: - * NixOS / nixpkgs - * There is a ``shell.nix`` under ``scripts/`` + pacman -S --noconfirm \ + gcc meson ninja pkg-config python-sphinx cmocka \ + pciutils libusb libftdi libjaylink - :: +* openSUSE / SUSE - nix-shell -p \ - gcc meson ninja pkg-config sphinx \ - cmocka pciutils libusb1 libftdi1 libjaylink + :: - * Alpine Linux - :: + zypper install -y \ + gcc meson ninja pkg-config python3-Sphinx \ + libcmocka-devel pciutils-devel libusb-1_0-devel libftdi1-devel libjaylink-devel - apk add \ - build-base meson ninja pkgconf py3-sphinx \ - cmocka-dev pciutils-dev libusb-dev libjaylink-dev +* NixOS / nixpkgs -* Windows - * MSYS2 - Install `MSYS2 <https://www.msys2.org/>`_ and ensure it is `fully updated <https://www.msys2.org/docs/updating/>`_. + * There is a ``shell.nix`` under ``scripts/`` - * ``libpci`` is not available through the package manager and pci based programmer are not supported on Windows. - * ``ni845x_spi`` is only available with the proprietary library from National Instruments. Download and install the driver - from `ni.com <https://www.ni.com/en-us/support/downloads/drivers/download.ni-845x-driver-…>`_ and build flashrom - for **32-bit**. Add ``-Dprogrammer=ni845x_spi`` to your meson configuration. + :: - In the MINGW64 shell run:: + nix-shell -p \ + gcc meson ninja pkg-config sphinx \ + cmocka pciutils libusb1 libftdi1 libjaylink - pacman -Sy \ - mingw-w64-x86_64-gcc mingw-w64-x86_64-meson mingw-w64-x86_64-ninja mingw-w64-x86_64-pkg-config mingw-w64-x86_64-python-sphinx \ - mingw-w64-x86_64-cmocka mingw-w64-x86_64-libusb mingw-w64-x86_64-libftdi mingw-w64-x86_64-libjaylink-git +* Alpine Linux - For building flashrom as 32-bit application, use the MSYS2 MINGW32 shell and run:: + :: - pacman -Sy \ - mingw-w64-i686-gcc mingw-w64-i686-meson mingw-w64-i686-ninja mingw-w64-i686-pkg-config mingw-w64-i686-python-sphinx \ - mingw-w64-i686-cmocka mingw-w64-i686-libusb mingw-w64-i686-libftdi mingw-w64-i686-libjaylink-git + apk add \ + build-base meson ninja pkgconf py3-sphinx \ + cmocka-dev pciutils-dev libusb-dev libjaylink-dev -* MacOS - * Homebrew - * ``libpci`` is not available through the package manager - * ``libjaylink`` is not available through the package manager +Windows +""""""" - :: +* MSYS2 - brew install \ - meson ninja pkg-config sphinx-doc \ - libusb libftdi + Install `MSYS2 <https://www.msys2.org/>`_ and ensure it is `fully updated <https://www.msys2.org/docs/updating/>`_. -* BSD - * FreeBSD / DragonFlyBSD - * ``libusb1`` is part of the system - * ``libjaylink`` is not available through the package manager + * ``libpci`` is not available through the package manager and pci based programmer are not supported on Windows. + * ``ni845x_spi`` is only available with the proprietary library from National Instruments. Download and install the driver + from `ni.com <https://www.ni.com/en-us/support/downloads/drivers/download.ni-845x-driver-…>`_ and build flashrom + for **32-bit**. Add ``-Dprogrammer=ni845x_spi`` to your meson configuration. - :: + In the MINGW64 shell run:: - pkg install \ - meson ninja pkgconf py39-sphinx \ - cmocka libpci libftdi1 + pacman -Sy \ + mingw-w64-x86_64-gcc mingw-w64-x86_64-meson mingw-w64-x86_64-ninja mingw-w64-x86_64-pkg-config mingw-w64-x86_64-python-sphinx \ + mingw-w64-x86_64-cmocka mingw-w64-x86_64-libusb mingw-w64-x86_64-libftdi mingw-w64-x86_64-libjaylink-git - * OpenBSD - * ``libjaylink`` is not available through the package manager + For building flashrom as 32-bit application, use the MSYS2 MINGW32 shell and run:: - :: + pacman -Sy \ + mingw-w64-i686-gcc mingw-w64-i686-meson mingw-w64-i686-ninja mingw-w64-i686-pkg-config mingw-w64-i686-python-sphinx \ + mingw-w64-i686-cmocka mingw-w64-i686-libusb mingw-w64-i686-libftdi mingw-w64-i686-libjaylink-git - pkg_add \ - meson ninja pkg-config py39-sphinx\ - cmocka pciutils libusb1 libftdi1 +MacOS +""""" - * NetBSD - * ``libjaylink`` is not available through the package manager - * note: https://www.cambus.net/installing-ca-certificates-on-netbsd/ +* Homebrew - :: + * ``libpci`` is not available through the package manager + * ``libjaylink`` is not available through the package manager - pkgin install \ - meson ninja pkg-config py39-sphinx \ - cmocka pciutils libusb1 libftdi1 + :: -* OpenIndiana (Illumos, Solaris, SunOS) - * ``libpci`` missing, pciutils is build without it - * ``libftdi1`` & ``libjaylink`` are not available through the package manager - * TODO: replace ``build-essential`` with the default compiler + brew install \ + meson ninja pkg-config sphinx-doc \ + libusb libftdi - :: +BSD +""" - pkg install build-essential meson ninja cmocka libusb-1 +* FreeBSD / DragonFlyBSD -* DJGPP-DOS - * Get `DJGPP <https://www.delorie.com/djgpp/>`_ - * A great build script can be found `here <https://github.com/andrewwutw/build-djgpp>`_ - * Download the `pciutils <https://mj.ucw.cz/sw/pciutils/>`_ sources + * ``libusb1`` is part of the system + * ``libjaylink`` is not available through the package manager - | Run the following commands in the the pciutils directory to build libpci for DOS. - | Replace ``<DOS_INSTALL_ROOT>`` with your cross-compile install root. + :: - :: + pkg install \ + meson ninja pkgconf py39-sphinx \ + cmocka libpci libftdi1 - make install-lib \ - ZLIB=no \ - DNS=no \ - HOST=i386-djgpp-djgpp \ - CROSS_COMPILE=i586-pc-msdosdjgpp- \ - STRIP="--strip-program=i586-pc-msdosdjgpp-strip -s" \ - PREFIX=<DOS_INSTALL_ROOT> +* OpenBSD - Point pkg-config to the ``<DOS_INSTALL_ROOT>`` :: + * ``libjaylink`` is not available through the package manager - export PKG_CONFIG_SYSROOT=<DOS_INSTALL_ROOT> + :: - * To compile flashrom use the ``meson_cross/i586_djgpp_dos.txt`` cross-file - * You will need `CWSDPMI.EXE <https://sandmann.dotster.com/cwsdpmi/>`_ to run flashrom + pkg_add \ + meson ninja pkg-config py39-sphinx\ + cmocka pciutils libusb1 libftdi1 -* libpayload +* NetBSD + + * ``libjaylink`` is not available through the package manager + * note: https://www.cambus.net/installing-ca-certificates-on-netbsd/ + + :: + + pkgin install \ + meson ninja pkg-config py39-sphinx \ + cmocka pciutils libusb1 libftdi1 + +OpenIndiana (Illumos, Solaris, SunOS) +""""""""""""""""""""""""""""""""""""" + +* ``libpci`` missing, pciutils is build without it +* ``libftdi1`` & ``libjaylink`` are not available through the package manager +* TODO: replace ``build-essential`` with the default compiler + +:: + + pkg install build-essential meson ninja cmocka libusb-1 + +DJGPP-DOS +""""""""" + +* Get `DJGPP <https://www.delorie.com/djgpp/>`_ +* A great build script can be found `here <https://github.com/andrewwutw/build-djgpp>`_ +* Download the `pciutils <https://mj.ucw.cz/sw/pciutils/>`_ sources + +| Run the following commands in the the pciutils directory to build libpci for DOS. +| Replace ``<DOS_INSTALL_ROOT>`` with your cross-compile install root. + +:: + + make install-lib \ + ZLIB=no \ + DNS=no \ + HOST=i386-djgpp-djgpp \ + CROSS_COMPILE=i586-pc-msdosdjgpp- \ + STRIP="--strip-program=i586-pc-msdosdjgpp-strip -s" \ + PREFIX=<DOS_INSTALL_ROOT> + +Point pkg-config to the ``<DOS_INSTALL_ROOT>`` :: + + export PKG_CONFIG_SYSROOT=<DOS_INSTALL_ROOT> + +* To compile flashrom use the ``meson_cross/i586_djgpp_dos.txt`` cross-file +* You will need `CWSDPMI.EXE <https://sandmann.dotster.com/cwsdpmi/>`_ to run flashrom + +libpayload +"""""""""" + .. todo:: Add building instructions for libpayload -- To view, visit https://review.coreboot.org/c/flashrom/+/81780?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I78645131b1f0acbedcf11964a204a24c45b62cff Gerrit-Change-Number: 81780 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

[XS] Change in flashrom[main]: meson: Update CI script to enforce building man pages and docs
by Anton Samsonov (Code Review) 08 Apr '24

08 Apr '24

Attention is currently required from: Anastasia Klimchuk, Anton Samsonov, Thomas Heijligen. Anton Samsonov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81665?usp=email ) Change subject: meson: Update CI script to enforce building man pages and docs ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Patchset: PS3: Although I get all kinds of build and testing errors when running `test_build.sh` (with both `make` and `meson`, mainly because of running on non-x86 architecture, while the scenario tries to build x86-specific stuff unconditionally, as well as do some unit-testing that mostly segfaults and reports memory corruption — the situation I need much more time to investigate on wider range of systems), this change itself looks fine — the documentation is built successfully. I even found a small bug in my previous commit, thanks to this script! (81802) -- To view, visit https://review.coreboot.org/c/flashrom/+/81665?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ib89abddad27d1168cf0a621cf4bdb9f541266165 Gerrit-Change-Number: 81665 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anton Samsonov <avscomputing(a)gmail.com> Gerrit-Reviewer: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Comment-Date: Mon, 08 Apr 2024 13:40:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[main]: Makefile: Fix cleanup for Sphinx versions prior to 4.x
by Anton Samsonov (Code Review) 08 Apr '24

08 Apr '24

Anton Samsonov has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/81802?usp=email ) Change subject: Makefile: Fix cleanup for Sphinx versions prior to 4.x ...................................................................... Makefile: Fix cleanup for Sphinx versions prior to 4.x Fixup for change I9cd280551a1ba4d17edb2e857d56f80431b61e1b. Change-Id: I123aec7cf2f016ba905c220cfc84a217523f9932 Signed-off-by: Anton Samsonov <devel(a)zxlab.ru> --- M Makefile 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/02/81802/1 diff --git a/Makefile b/Makefile index 9ce5906..1c0904b 100644 --- a/Makefile +++ b/Makefile @@ -1075,7 +1075,7 @@ # We don't use EXEC_SUFFIX here because we want to clean everything. clean: rm -rf $(PROGRAM) $(PROGRAM).exe libflashrom.a $(filter-out Makefile.d, $(wildcard *.d *.o platform/*.d platform/*.o)) \ - man8 .doctrees $(PROGRAM).bash $(BUILD_DETAILS_FILE) + man8 8 .doctrees $(PROGRAM).bash $(BUILD_DETAILS_FILE) @+$(MAKE) -C util/ich_descriptors_tool/ clean install: $(PROGRAM)$(EXEC_SUFFIX) $(call has_dependency, $(HAS_SPHINXBUILD), man8/$(PROGRAM).8) $(PROGRAM).bash -- To view, visit https://review.coreboot.org/c/flashrom/+/81802?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I123aec7cf2f016ba905c220cfc84a217523f9932 Gerrit-Change-Number: 81802 Gerrit-PatchSet: 1 Gerrit-Owner: Anton Samsonov <devel(a)zxlab.ru> Gerrit-MessageType: newchange

1 0

[L] Change in flashrom[main]: udelay: only use OS time for delays, except on DOS
by Anastasia Klimchuk (Code Review) 08 Apr '24

08 Apr '24

Attention is currently required from: Brian Norris, Peter Marheine, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81545?usp=email ) Change subject: udelay: only use OS time for delays, except on DOS ...................................................................... Patch Set 7: (5 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/81545/comment/ccd19393_e76a5d95 : PS7, Line 10: ) you can also add the link to archive (keep the title) https://mail.coreboot.org/hyperkitty/list/flashrom@flashrom.org/thread/HFH6… File include/programmer.h: https://review.coreboot.org/c/flashrom/+/81545/comment/9d01fccc_bfddca33 : PS7, Line 222: void myusec_delay(unsigned int usecs); I am wondering, why `myusec_delay` was here in the first place? It wasn't used anywhere outside udelay.c. File tests/udelay.c: https://review.coreboot.org/c/flashrom/+/81545/comment/ebf04ffe_2553bf5c : PS7, Line 47: default_delay(100); I thought for a moment we can afford a long delay test, for usec = 100001, but I don't know would it be useful test? Maybe it belongs better to a next patch where you can verify nanosleep was called / not called depending on the length of the sleep? File udelay.c: https://review.coreboot.org/c/flashrom/+/81545/comment/77dc43b4_fc7866da : PS7, Line 33: #ifdef _POSIX_MONOTONIC_CLOCK : static clockid_t clock_id = CLOCK_MONOTONIC; : #else : static clockid_t clock_id = CLOCK_REALTIME; : #endif This is only used inside `clock_usec_delay` now, can it be locally defined inside the function? It will be easier to read too. https://review.coreboot.org/c/flashrom/+/81545/comment/6f8bb5ec_181589c6 : PS7, Line 62: inline For my education, why the function is inline only for this case and not the above? -- To view, visit https://review.coreboot.org/c/flashrom/+/81545?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I7ac5450d194a475143698d65d64d8bcd2fd25e3f Gerrit-Change-Number: 81545 Gerrit-PatchSet: 7 Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Brian Norris <briannorris(a)chromium.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Mon, 08 Apr 2024 12:34:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[main]: flashchips: Add write-protect support for MX25L12833F
by Hsuan-ting Chen (Code Review) 08 Apr '24

08 Apr '24

Attention is currently required from: Hsuan Ting Chen. Hello Hsuan Ting Chen, I'd like you to do a code review. Please visit https://review.coreboot.org/c/flashrom/+/81792?usp=email to review the following change. Change subject: flashchips: Add write-protect support for MX25L12833F ...................................................................... flashchips: Add write-protect support for MX25L12833F datasheet: https://www.macronix.com/Lists/Datasheet/Attachments/8934/MX25L12833F,%203V… BUG=b:332486637 TEST=TBU Change-Id: I379c833eea3ed3487504126f45c6df672a772ddc Signed-off-by: Hsuan Ting Chen <roccochen(a)chromium.org> --- M flashchips.c 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/92/81792/1 diff --git a/flashchips.c b/flashchips.c index 7a40f07..c0518cb 100644 --- a/flashchips.c +++ b/flashchips.c @@ -9041,6 +9041,14 @@ .write = SPI_CHIP_WRITE256, .read = SPI_CHIP_READ, /* Fast read (0x0B) supported */ .voltage = {2700, 3600}, + .reg_bits = + { + .srp = {STATUS1, 7, RW}, + .bp = {{STATUS1, 2, RW}, {STATUS1, 3, RW}, {STATUS1, 4, RW}, {STATUS1, 5, RW}}, + .tb = {CONFIG, 3, OTP}, + .wps = {SECURITY, 7, OTP}, /* This bit is set by WPSEL command */ + }, + .decode_range = DECODE_RANGE_SPI25, }, { -- To view, visit https://review.coreboot.org/c/flashrom/+/81792?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I379c833eea3ed3487504126f45c6df672a772ddc Gerrit-Change-Number: 81792 Gerrit-PatchSet: 1 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-MessageType: newchange

1 0

[XS] Change in flashrom[main]: meson: Update CI script to enforce building man pages and docs
by Martin L Roth (Code Review) 06 Apr '24

06 Apr '24

Attention is currently required from: Anastasia Klimchuk, Anton Samsonov, Thomas Heijligen. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81665?usp=email ) Change subject: meson: Update CI script to enforce building man pages and docs ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/81665?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ib89abddad27d1168cf0a621cf4bdb9f541266165 Gerrit-Change-Number: 81665 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Comment-Date: Sat, 06 Apr 2024 14:14:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[main]: meson: Update CI script to enforce building man pages and docs
by Anastasia Klimchuk (Code Review) 06 Apr '24

06 Apr '24

Attention is currently required from: Anton Samsonov, Martin L Roth, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81665?usp=email ) Change subject: meson: Update CI script to enforce building man pages and docs ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > One thing left to test: have a run on clean environment. And I have discovered that my changes to doc/meson.build are not needed because the first line in the file handles it! so now the patch is smaller :) -- To view, visit https://review.coreboot.org/c/flashrom/+/81665?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ib89abddad27d1168cf0a621cf4bdb9f541266165 Gerrit-Change-Number: 81665 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Comment-Date: Sat, 06 Apr 2024 13:36:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[main]: meson: Update CI script to enforce building man pages and docs
by Anastasia Klimchuk (Code Review) 06 Apr '24

06 Apr '24

Attention is currently required from: Anton Samsonov, Martin L Roth, Thomas Heijligen. Hello Anton Samsonov, Martin L Roth, Thomas Heijligen, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/81665?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: meson: Update CI script to enforce building man pages and docs ...................................................................... meson: Update CI script to enforce building man pages and docs `test_build.sh` is used by Jenkins, therefore it should build everything. Docker container for Jenkins is expected to have all the dependencies installed, and if some of them are missing, script should fail. Recently we had a situation when docker image was missing sphinx and flashrom Jenkins was silently skipping building man-pages and documentation. This patch prevents this happening again, because building man pages and docs will be enforced. Change-Id: Ib89abddad27d1168cf0a621cf4bdb9f541266165 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M test_build.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/65/81665/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/81665?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ib89abddad27d1168cf0a621cf4bdb9f541266165 Gerrit-Change-Number: 81665 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anton Samsonov <devel(a)zxlab.ru> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[main]: meson: Update CI script to enforce building man pages and docs
by Anastasia Klimchuk (Code Review) 04 Apr '24

04 Apr '24

Attention is currently required from: Anton Samsonov, Martin L Roth, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81665?usp=email ) Change subject: meson: Update CI script to enforce building man pages and docs ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: One thing left to test: have a run on clean environment. -- To view, visit https://review.coreboot.org/c/flashrom/+/81665?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ib89abddad27d1168cf0a621cf4bdb9f541266165 Gerrit-Change-Number: 81665 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Comment-Date: Thu, 04 Apr 2024 07:44:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit April 2024