April 2024 - flashrom-gerrit - mail.coreboot.org

[L] Change in flashrom[main]: udelay: only use OS time for delays, except on DOS
by Anastasia Klimchuk (Code Review) 16 Apr '24

16 Apr '24

Attention is currently required from: Brian Norris, Peter Marheine, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81545?usp=email ) Change subject: udelay: only use OS time for delays, except on DOS ...................................................................... Patch Set 9: (1 comment) File tests/udelay.c: https://review.coreboot.org/c/flashrom/+/81545/comment/0fb34cc2_07d484b8 : PS9, Line 41: This test could fail spuriously on a heavily-loaded system > > do you think it would be reasonable to maintain this assertion as-is provided we ensure the tested […] Brian, you have good points. Thank you for sharing your valuable experience! I had this thought about guarding against infinite loop (if this is a useful thing?), but for this any large upper bound will do, can be 100x or anything Peter maybe I will leave it to you to decide. I am so happy that you added a test! -- To view, visit https://review.coreboot.org/c/flashrom/+/81545?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I7ac5450d194a475143698d65d64d8bcd2fd25e3f Gerrit-Change-Number: 81545 Gerrit-PatchSet: 9 Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Brian Norris <briannorris(a)chromium.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Tue, 16 Apr 2024 12:15:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Brian Norris <briannorris(a)chromium.org> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[main]: flashchips: Split and add write-protect support for MX25L12833F
by Hsuan-ting Chen (Code Review) 16 Apr '24

16 Apr '24

Attention is currently required from: Anastasia Klimchuk, DZ, Hsuan Ting Chen, Nikolai Artemiev, Stefan Reinauer. Hsuan-ting Chen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81792?usp=email ) Change subject: flashchips: Split and add write-protect support for MX25L12833F ...................................................................... Patch Set 3: (1 comment) File flashchips.c: https://review.coreboot.org/c/flashrom/+/81792/comment/fd137ffc_6bfb3245 : PS2, Line 9008: MX25L12833F/MX25L12835F/MX25L12845E/MX25L12865E/MX25L12873F > This is multi-chip entry, and two of them MX25L12845E and MX25L12865E has no configuration register. […] Split into: * "MX25L12833F/MX25L12835F/MX25L12873F" * "MX25L12845E/MX25L12865E" I've checked all the datasheet, but I don't have other chips to test. I noticed that MX25L12873F doesn't support HPM (hardware protection mode), but IIUC flashrom have nothing to do with it, so I kept it in the same entry. -- To view, visit https://review.coreboot.org/c/flashrom/+/81792?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I379c833eea3ed3487504126f45c6df672a772ddc Gerrit-Change-Number: 81792 Gerrit-PatchSet: 3 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: DZ <danielzhang(a)mxic.com.cn> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: DZ <danielzhang(a)mxic.com.cn> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Tue, 16 Apr 2024 11:40:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[main]: flashchips: Split and add write-protect support for MX25L12833F
by Hsuan-ting Chen (Code Review) 16 Apr '24

16 Apr '24

Attention is currently required from: DZ, Hsuan Ting Chen, Hsuan-ting Chen, Nikolai Artemiev, Stefan Reinauer. Hello Anastasia Klimchuk, DZ, Hsuan Ting Chen, Nikolai Artemiev, Stefan Reinauer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/81792?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: flashchips: Split and add write-protect support for MX25L12833F ...................................................................... flashchips: Split and add write-protect support for MX25L12833F MX25L12833F datasheet: https://www.macronix.com/Lists/Datasheet/Attachments/8934/MX25L12833F,%203V… Status register: page 30 table 7 (BP0~BP3, SRWD) Configuration register: page 31 table 8 (TB) Security register: page 57 table 12 (WPSEL) MX25L12835F datasheet: https://www.macronix.com/Lists/Datasheet/Attachments/8653/MX25L12835F,%203V… Status register: page 31(BP0~BP3, SRWD) Configuration register: page 32 table 7 (TB) Security register: page 61 table 9 (WPSEL) MX25L12845E datasheet: (no CONFIG) https://www.mxic.com.tw/Lists/Datasheet/Attachments/8693/MX25L12845E,%203V,… Status register: page 17 (BP0~BP3, SRWD) Security register: page 29 (WPSEL) MX25L12865E datasheet: (no CONFIG) https://media.digikey.com/pdf/Data%20Sheets/Macronix/MX25L6465E,_MX25L12865… Status register: page 19 (BP0~BP3, SRWD) Security register: page 31 (WPSEL) MX25L12873F datasheet: (no hardware WP) https://www.mxic.com.tw/Lists/Datasheet/Attachments/8652/MX25L12873F,%203V,… Status register: page 31(BP0~BP3, SRWD) Configuration register: page 32 table 7 (TB) Security register: page 60 table 9 (WPSEL) Splits the MX25L12833F/MX25L12835F/MX25L12845E/MX25L12865E/MX25L12873F group into two subgroups: * MX25L12833F/MX25L12835F/MX25L12873F: These chips have the configuration register. * MX25L12845E/MX25L12865E: These chips don't have the configuration register. Tests the write protect functionality on the MX25L12833F chip and mark MX25L12833F/MX25L12835F/MX25L12873F as tested. BUG=b:332486637 TEST=Test flashrom --wp-disable with MX25L12833FZNI-10 on ChromeOS Change-Id: I379c833eea3ed3487504126f45c6df672a772ddc Signed-off-by: Hsuan Ting Chen <roccochen(a)chromium.org> --- M flashchips.c 1 file changed, 57 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/92/81792/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/81792?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I379c833eea3ed3487504126f45c6df672a772ddc Gerrit-Change-Number: 81792 Gerrit-PatchSet: 3 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: DZ <danielzhang(a)mxic.com.cn> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: DZ <danielzhang(a)mxic.com.cn> Gerrit-Attention: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[main]: ich: Add names for region 5, 9, 10, 11, 12, 15
by Hsuan-ting Chen (Code Review) 16 Apr '24

16 Apr '24

Attention is currently required from: Hsuan Ting Chen, Hsuan-ting Chen, Stefan Reinauer. Hello Anastasia Klimchuk, Hsuan Ting Chen, Stefan Reinauer, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/81356?usp=email to look at the new patch set (#6). Change subject: ich: Add names for region 5, 9, 10, 11, 12, 15 ...................................................................... ich: Add names for region 5, 9, 10, 11, 12, 15 Add Region 9 for Intel Meteor Lake; update missing regions. * Include Region 9 as officially required for Intel Meteor Lake platform. * Incorporate missing region names from https://github.com/coreboot/coreboot/blob/main/util/ifdtool/ifdtool.c for completeness. Region 5: Device Expansion (DE or DevExp) Region 9: Device Expansion 2 (DE2 or DevExp2) Region 10: Innovation Engine (IE) Region 11: 10 GbE 0 Region 12: 10 GbE 1 Region 15: PTT BUG=b:319773700 TEST=Run `flashrom -VV` on MTL and see all the regions are printed out Change-Id: I3b164ce4ae84bfd523fcd8be416c5d13183ed632 Signed-off-by: Hsuan Ting Chen <roccochen(a)chromium.org> --- M ich_descriptors.c M ichspi.c M util/ich_descriptors_tool/ich_descriptors_tool.c 3 files changed, 9 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/56/81356/6 -- To view, visit https://review.coreboot.org/c/flashrom/+/81356?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I3b164ce4ae84bfd523fcd8be416c5d13183ed632 Gerrit-Change-Number: 81356 Gerrit-PatchSet: 6 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[XS] Change in flashrom[main]: util/list_yet_unsupported_chips.h: Fix path
by Anastasia Klimchuk (Code Review) 15 Apr '24

15 Apr '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/81855?usp=email ) Change subject: util/list_yet_unsupported_chips.h: Fix path ...................................................................... util/list_yet_unsupported_chips.h: Fix path Change-Id: Iecb6cf3d1f214102a243a3ffa8d0c9301263af0a Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/81855 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M util/list_yet_unsupported_chips.sh 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Anastasia Klimchuk: Looks good to me, approved build bot (Jenkins): Verified diff --git a/util/list_yet_unsupported_chips.sh b/util/list_yet_unsupported_chips.sh index 3a4d1b8..a823261 100755 --- a/util/list_yet_unsupported_chips.sh +++ b/util/list_yet_unsupported_chips.sh @@ -2,20 +2,20 @@ scriptname=$(readlink -f "$0") 2>/dev/null path=$(dirname "$scriptname")/.. 2>/dev/null -if [ ! -e "$path/flashchips.c" -o ! -e "$path/flashchips.h" ]; then +if [ ! -e "$path/flashchips.c" -o ! -e "$path/include/flashchips.h" ]; then echo "Warning: could not calculate flashchips.[ch]'s directory. Trying current..." path="." - if [ ! -e "$path/flashchips.c" -o ! -e "$path/flashchips.h" ]; then + if [ ! -e "$path/flashchips.c" -o ! -e "$path/include/flashchips.h" ]; then echo "Nope, sorry!" exit 1 fi fi -chips=$(sed -re '/#define [A-Z]/ !d' -e '/_ID\s/d' -e 's/\s*#define\s+([[:alnum:]_]+)\s+.*/\1/' "$path/flashchips.h") +chips=$(sed -re '/#define [A-Z]/ !d' -e '/_ID\s/d' -e 's/\s*#define\s+([[:alnum:]_]+)\s+.*/\1/' "$path/include/flashchips.h") for c in $chips ; do if ! grep "$c" "$path/flashchips.c" >/dev/null ; then if [ -n "$1" ]; then - grep -o "$c.*" "$path/flashchips.h" + grep -o "$c.*" "$path/include/flashchips.h" else echo "$c" fi -- To view, visit https://review.coreboot.org/c/flashrom/+/81855?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Iecb6cf3d1f214102a243a3ffa8d0c9301263af0a Gerrit-Change-Number: 81855 Gerrit-PatchSet: 3 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[main]: flashchips: Add support for MXIC MX25L1633E
by Anastasia Klimchuk (Code Review) 13 Apr '24

13 Apr '24

Attention is currently required from: DZ, Nikolai Artemiev, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81836?usp=email ) Change subject: flashchips: Add support for MXIC MX25L1633E ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File flashchips.c: https://review.coreboot.org/c/flashrom/+/81836/comment/be3b8c1b_1f6251fa : PS3, Line 9280: MACRONIX_MX25L1635D Just one thing here: if you can please mention new chip MX25L1633E in a comment to existing macro MACRONIX_MX25L1635D in flashchips.h. Thanks! -- To view, visit https://review.coreboot.org/c/flashrom/+/81836?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I63ee0182ad6e62b7408136285aa0e927d53f7bc8 Gerrit-Change-Number: 81836 Gerrit-PatchSet: 3 Gerrit-Owner: DZ <danielzhang(a)mxic.com.cn> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: DZ <danielzhang(a)mxic.com.cn> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Sat, 13 Apr 2024 08:17:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[main]: flashchips: Add support for MXIC MX25L1636E
by Anastasia Klimchuk (Code Review) 13 Apr '24

13 Apr '24

Attention is currently required from: DZ, Nikolai Artemiev, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81835?usp=email ) Change subject: flashchips: Add support for MXIC MX25L1636E ...................................................................... Patch Set 1: (3 comments) File flashchips.c: https://review.coreboot.org/c/flashrom/+/81835/comment/7d13896d_1ae1a928 : PS1, Line 9283: OTP: 64B total I know it was like this before, but datasheets for both chips say 4k-bit secured OTP, so seems like it was wrong before. It should be 512B https://review.coreboot.org/c/flashrom/+/81835/comment/45bf5729_a1dad53d : PS1, Line 9284: FEATURE_CFGR None of datasheets have configuration register? https://review.coreboot.org/c/flashrom/+/81835/comment/052a50bd_5912daea : PS1, Line 9313: .tb = {CONFIG, 3, OTP} Same as above, none of datasheets have configuration register -- To view, visit https://review.coreboot.org/c/flashrom/+/81835?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I415e2d6c89d3d59ba44e22753001c6f69421c39d Gerrit-Change-Number: 81835 Gerrit-PatchSet: 1 Gerrit-Owner: DZ <danielzhang(a)mxic.com.cn> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: DZ <danielzhang(a)mxic.com.cn> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Sat, 13 Apr 2024 07:55:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in flashrom[main]: udelay: only use OS time for delays, except on DOS
by Brian Norris (Code Review) 12 Apr '24

12 Apr '24

Attention is currently required from: Anastasia Klimchuk, Peter Marheine, Thomas Heijligen. Brian Norris has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81545?usp=email ) Change subject: udelay: only use OS time for delays, except on DOS ...................................................................... Patch Set 9: (1 comment) File tests/udelay.c: https://review.coreboot.org/c/flashrom/+/81545/comment/e25e8253_31a03ad3 : PS9, Line 41: This test could fail spuriously on a heavily-loaded system > do you think it would be reasonable to maintain this assertion as-is provided we ensure the tested delay is always short enough to avoid sleeping? Ah, sorry, thanks for the sleep vs delay callout. The delay loop likely doesn't have the same magnitude of an issue, although it theoretically is still present. I'm fine with "try and see" here. > Jenkins seems to be happy with the test, as we see. Sure, once. But what's to say it doesn't fail 1/100 times? 1/1000? Do we guarantee what system load is run on the same Jenkins instance (I know nothing about Jenkins)? What if we have 10 such 1% flaky tests? Or 100? Eventually, nobody trusts the tests. This is especially close to my heart at the moment, because I've recently been spending more than a week de-flaking another open source project's test suite, which were full of sleep-related magic and race conditions. The lesson that came out of that for me is that just about any race condition can and will be exposed. (And yes, this test has a race condition baked in.) But like I said, I'm not extremely concerned here, unless we see it start flaking in practice. > I like more tests, not less! :) Flaky tests can be worse, at scale. But maybe flashrom is isolated enough (and run in its own tiny test environment) that "scale" doesn't matter much. > ChromeOS fork could perhaps make a small one line diff [...] Yeah, if it does indeed flake much, we'd likely disable or modify the test on the CrOS side. Anyway, I'd consider my original comment resolved, but Anastasia has other comments in here so I'll leave that up to her when to resolve. Thanks! -- To view, visit https://review.coreboot.org/c/flashrom/+/81545?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I7ac5450d194a475143698d65d64d8bcd2fd25e3f Gerrit-Change-Number: 81545 Gerrit-PatchSet: 9 Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Fri, 12 Apr 2024 19:28:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Brian Norris <briannorris(a)chromium.org> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org> Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[main]: util/list_yet_unsupported_chips.h: Fix path
by Maximilian Brune (Code Review) 12 Apr '24

12 Apr '24

Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81855?usp=email ) Change subject: util/list_yet_unsupported_chips.h: Fix path ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Ooh this has been broken for a while, include dir was introduced a while ago... […] It is printing out all the flashes that are not supported (as advertised) as far as I could see. -- To view, visit https://review.coreboot.org/c/flashrom/+/81855?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Iecb6cf3d1f214102a243a3ffa8d0c9301263af0a Gerrit-Change-Number: 81855 Gerrit-PatchSet: 2 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 12 Apr 2024 13:39:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[main]: flashchips: Add write-protect support for MX25L12833F
by Anastasia Klimchuk (Code Review) 12 Apr '24

12 Apr '24

Attention is currently required from: DZ, Hsuan-ting Chen, Nikolai Artemiev, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81792?usp=email ) Change subject: flashchips: Add write-protect support for MX25L12833F ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Daniel, I remember you are currently updating write-protect for MXIC chips, so I thought to add you here in case you have comments. As reviewer, you can add comments to a patch, or if you have no comments you can vote on the patch (there is more info here https://flashrom.org/how_to_support_flashrom.html#code-reviews) -- To view, visit https://review.coreboot.org/c/flashrom/+/81792?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I379c833eea3ed3487504126f45c6df672a772ddc Gerrit-Change-Number: 81792 Gerrit-PatchSet: 2 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: DZ <danielzhang(a)mxic.com.cn> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: DZ <danielzhang(a)mxic.com.cn> Gerrit-Attention: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Fri, 12 Apr 2024 11:52:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit April 2024