December 2024 - flashrom-gerrit

[L] Change in flashrom[main]: doc: Release notes for v1.5.0
by Anastasia Klimchuk (Code Review) 04 Dec '24

04 Dec '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/85156?usp=email ) Change subject: doc: Release notes for v1.5.0 ...................................................................... doc: Release notes for v1.5.0 Change-Id: I0663779020e84cd6d89d33f23a7b5514f8efa2f4 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/85156 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Peter Marheine <pmarheine(a)chromium.org> --- M doc/release_notes/devel.rst M doc/release_notes/index.rst A doc/release_notes/v_1_5.rst 3 files changed, 240 insertions(+), 186 deletions(-) Approvals: build bot (Jenkins): Verified Peter Marheine: Looks good to me, approved diff --git a/doc/release_notes/devel.rst b/doc/release_notes/devel.rst index 7b21a99..bb2b73d 100644 --- a/doc/release_notes/devel.rst +++ b/doc/release_notes/devel.rst @@ -16,189 +16,3 @@ not currently supported. https://ticket.coreboot.org/issues/370 - -Build only supported with Meson -=============================== - -As documented in the :doc:`v1.4 release notes <v_1_4>`, support for building -flashrom with make has been removed; all Makefiles have been deleted. Meson is -now the only supported tool for building flashrom from source. - -New Feature -=========== - -Libpci 3.13.0 and onwards support ECAM to access pci registers. Flashrom will -be moved to ECAM from IO port 0xcf8/0xcfc if the libpci version is >= 3.13.0. -The ECAM has been supported for a very long time, most platforms should support -it. For those platforms don't support ECAM, libpci will terminate the process by -exit. - -Progress display -================ - -Progress display feature is now working for all operations: read, erase, write. - -Command-line option to sacrifice unchanged blocks for speed -=========================================================== - -New command line option ``sacrifice-ratio`` handles the following situation: - -There is a region which is requested to be erased (or written, because -the write operation uses erase too). Some of the areas inside this -region don't need to be erased, because the bytes already have expected -value. Such areas can be skipped. - -The logic selects eraseblocks that can cover the areas which need to be -erased. Suppose there is a region which is partially covered by -eraseblocks of size S (partially because remaining areas don't need to -be erased). Now suppose we can cover the whole region with eraseblock -of larger size, S+1, and erase it all at once. This will run faster: -erase opcode will only be sent once instead of many smaller opcodes. -However, this will run erase over some areas of the chip memory that -didn't need to be erased. Which means the physical chip will wear out -faster. - -This new option sets the maximum % of memory that is allowed for -redundant erase. Default is 0, S+1 size block only selected if all the -area needs to be erased in full. 50 means that if more than a half of -the area needs to be erased, a S+1 size block can be selected to cover -the entire area with one block. - -The tradeoff is the speed of programming operation VS the longevity of -the chip. Default is longevity. - -RPMC support added -================== - -Adding support for RPMC commands as specified by JESD260 to the cli_client. Main -implementation is in rpmc.c. Also adds new parsing capabilities for the sfdp -page carrying the necessary information. All the features are optional and -depend on libcrypto. -It currently uses automatic feature detection through the corresponding -sfdp page. - -Programmer updates -=================== - -* ch347_spi: Add spi clock frequency selection ("spispeed" option) -* dummyflasher: Enable higher frequency emulation, add docs and tests -* ichspi: Change the opcode position for reprogramming on the fly 2->4 -* ichspi: Merge spi_master implementations for Intel ich - -Bugs fixed -========== - -* Modified bytes would sometimes not be verified after writing - - In some situations an off-by-one error would cause the last byte - of memory that was modified by an operation to not be verified. - This could prevent some erase or write errors from being detected, - or in other cases could make verification appear false-negative. - - Fixed by https://review.coreboot.org/c/flashrom/+/84078. - -* Possible crashes while preparing erase operations - - An out-of-bounds memory read was found in the algorithm that selects methods - to erase memory, which could cause flashrom to crash. This issue was first - introduced in release 1.4, and crashes were observed when running on OpenBSD. - - See https://ticket.coreboot.org/issues/555, and fixed by - https://review.coreboot.org/c/flashrom/+/84234. - -* Crash when attempting to erase FEATURE_NO_ERASE chips - - When attempting to erase a chip that doesn't need to be erased before - being written, flashrom could attempt to read through a null pointer - and crash. The only supported chip that is affected is the M95M02 - EEPROM. - - See https://ticket.coreboot.org/issues/553, and fixed by - https://review.coreboot.org/c/flashrom/+/84203. - -* install failures related to libcmocka - - In some configurations, the install target provided by the buildsystem (like - meson install) would fail to execute successfully due to a missing libcmocka - file. This is fixed by not installing libcmocka, because it is a third-party - library used by flashrom only for testing. - - See https://ticket.coreboot.org/issues/561, and fixed by - https://review.coreboot.org/c/flashrom/+/84557. - -* Excess erase of automatically-probed chips on Intel chipsets - - When erasing some chips using the ichspi programmer (for Intel ICH chipsets), - the entire chip would be erased and rewritten even when the hardware supported - erasing smaller blocks, causing operations to take longer to complete and - negatively impacting chip longevity. This issue was first introduced in version - 1.4. - - See https://ticket.coreboot.org/issues/556, and fixed by - https://review.coreboot.org/c/flashrom/+/84253. - -* Unnecessary erases - - When erasing parts of a memory, some blocks could be erased and rewritten - unnecessarily or erased multiple times which could hurt the longevity of - the memory chip. This behavior was introduced in version 1.4. - - Fixed by https://review.coreboot.org/c/flashrom/+/84614 and - https://review.coreboot.org/c/flashrom/+/84686. - -Chipset support -=============== - -Added Raptor Point PCH support. - -Chip model support added -======================== - -* FM25Q04 -* FM25Q64 -* FM25Q128 - -* GD25B128E -* GD25B256E -* GD25B512MF -* GD25F64F -* GD25F256F -* GD25R128E -* GD25R256E -* GD25R512MF -* GD25LB256F -* GD25LB512ME -* GD25LB512MF -* GD25LR256F -* GD25LR512MF -* GD25LF256F -* GD25LF512MF - -* MX25U25645G -* MX77U51250F - -* W25Q32JV_M - -* XM25LU64C -* XM25QH32C -* XM25QH32D -* XM25QH64D -* XM25QH128D -* XM25QH256D -* XM25QH512C -* XM25QH512D -* XM25QU16C -* XM25QU32C -* XM25QU128D -* XM25QU256D -* XM25QU512C -* XM25QU512D - -Misc -========= - -* reduce DELAY_MINIMUM_SLEEP_US to 100 by default -* tests: Add assert for eraseblocks order of invocations for write op -* VERSION: Change name pattern to match tag name from now on -* writeprotect: Fix inaccurate return code -* erasure_layout: Fix unreachable error message diff --git a/doc/release_notes/index.rst b/doc/release_notes/index.rst index fe12d34..ea48b1f 100644 --- a/doc/release_notes/index.rst +++ b/doc/release_notes/index.rst @@ -5,5 +5,6 @@ :maxdepth: 1 devel + v_1_5 v_1_4 v_1_3 diff --git a/doc/release_notes/v_1_5.rst b/doc/release_notes/v_1_5.rst new file mode 100644 index 0000000..6e81353 --- /dev/null +++ b/doc/release_notes/v_1_5.rst @@ -0,0 +1,239 @@ +==================== +v1.5 (Dec 2024) +==================== + +This document describes the major changes in flashrom version v1.5.0, +from more than 80 patches contributed by more than 20 authors (thank you!). + +And we all did it in just ~4 months since previous release. + +Download +======== + +flashrom v1.5.0 can be downloaded in various ways: + +Anonymous checkout from the git repository at https://review.coreboot.org/flashrom.git +(tag v1.5.0) + +A tarball is available for download at <TODO add tarball> +(signature <TODO add signature>) + +fingerprint: <TODO add fingerprint> + +Known issues +============ + +AMD-based PCs with FCH are unable to read flash contents for internal (BIOS +flash) chips larger than 16 MB, and attempting to do so may crash the system. +Systems with AMD "Promontory" IO extenders (mostly "Zen" desktop platforms) are +not currently supported. + +https://ticket.coreboot.org/issues/370 + +Build only supported with Meson +=============================== + +As documented in the :doc:`v1.4 release notes <v_1_4>`, support for building +flashrom with make has been removed; all Makefiles have been deleted. Meson is +now the only supported tool for building flashrom from source. + +New Features +============ + +Support for ECAM +---------------- + +Libpci 3.13.0 and onwards support ECAM to access pci registers. flashrom will +be moved to ECAM from IO port 0xcf8/0xcfc if the libpci version is >= 3.13.0. +The ECAM has been supported for a very long time, most platforms should support +it. For those platforms don't support ECAM, libpci will terminate the process by +exit. + +Progress bar +------------ + +Progress bar feature is now working for all operations: read, erase, write. + +To display progress bar, add ``--progress`` option on the command line. + +Option to choose between speed and longevity of the chip +-------------------------------------------------------- + +New command line option ``--sacrifice-ratio`` handles the following situation: + +There is a region which is requested to be erased (or written, because +the write operation uses erase too). Some of the areas inside this +region don't need to be erased, because the bytes already have expected +value. Such areas can be skipped. + +The logic selects eraseblocks that can cover the areas which need to be +erased. Suppose there is a region which is partially covered by +eraseblocks of size S (partially because remaining areas don't need to +be erased). Now suppose we can cover the whole region with eraseblock +of larger size, S+1, and erase it all at once. This will run faster: +erase opcode will only be sent once instead of many smaller opcodes. +However, this will run erase over some areas of the chip memory that +didn't need to be erased. Which means the physical chip will wear out +faster. + +This new option sets the maximum % of memory that is allowed for +redundant erase. Default is 0, S+1 size block only selected if all the +area needs to be erased in full. 50 means that if more than a half of +the area needs to be erased, a S+1 size block can be selected to cover +the entire area with one block. + +The tradeoff is the speed of programming operation VS the longevity of +the chip. Default is longevity. + +RPMC support added +------------------ + +Adding support for RPMC commands as specified by JESD260 to the cli_client. + +Main implementation is in ``rpmc.c``. Also adds new parsing capabilities for the SFDP +page carrying the necessary information. All the features are optional and +depend on ``libcrypto``. + +It currently uses automatic feature detection through the corresponding +SFDP page. + +Programmer updates +================== + +* ch347_spi: Add spi clock frequency selection (``spispeed`` option) +* dummyflasher: Enable higher frequency emulation, add docs and tests +* ichspi: Change the opcode position for reprogramming on the fly 2->4 +* ichspi: Merge spi_master implementations for Intel ich +* stlinkv3_spi: Mark STLinkV3-Mini not working + +Bugs fixed +========== + +* Modified bytes would sometimes not be verified after writing + + In some situations an off-by-one error would cause the last byte + of memory that was modified by an operation to not be verified. + This could prevent some erase or write errors from being detected, + or in other cases could make verification appear false-negative. + + Fixed by https://review.coreboot.org/c/flashrom/+/84078. + +* Possible crashes while preparing erase operations + + An out-of-bounds memory read was found in the algorithm that selects methods + to erase memory, which could cause flashrom to crash. This issue was first + introduced in release 1.4, and crashes were observed when running on OpenBSD. + + See https://ticket.coreboot.org/issues/555, and fixed by + https://review.coreboot.org/c/flashrom/+/84234. + +* Crash when attempting to erase FEATURE_NO_ERASE chips + + When attempting to erase a chip that doesn't need to be erased before + being written, flashrom could attempt to read through a null pointer + and crash. The only supported chip that is affected is the M95M02 + EEPROM. + + See https://ticket.coreboot.org/issues/553, and fixed by + https://review.coreboot.org/c/flashrom/+/84203. + +* install failures related to libcmocka + + In some configurations, the install target provided by the buildsystem (like + meson install) would fail to execute successfully due to a missing libcmocka + file. This is fixed by not installing libcmocka, because it is a third-party + library used by flashrom only for testing. + + See https://ticket.coreboot.org/issues/561, and fixed by + https://review.coreboot.org/c/flashrom/+/84557. + +* Excess erase of automatically-probed chips on Intel chipsets + + When erasing some chips using the ichspi programmer (for Intel ICH chipsets), + the entire chip would be erased and rewritten even when the hardware supported + erasing smaller blocks, causing operations to take longer to complete and + negatively impacting chip longevity. This issue was first introduced in version + 1.4. + + See https://ticket.coreboot.org/issues/556, and fixed by + https://review.coreboot.org/c/flashrom/+/84253. + +* Unnecessary erases + + When erasing parts of a memory, some blocks could be erased and rewritten + unnecessarily or erased multiple times which could hurt the longevity of + the memory chip. This behavior was introduced in version 1.4. + + Fixed by https://review.coreboot.org/c/flashrom/+/84614 and + https://review.coreboot.org/c/flashrom/+/84686. + +Chipset support +=============== + +Added Raptor Point PCH support. + +Chip model support added +======================== + +* FM25Q04 +* FM25Q64 +* FM25Q128 + +* GD25B128E +* GD25B256E +* GD25B512MF +* GD25F64F +* GD25F128F +* GD25F256F +* GD25R128E +* GD25R256E +* GD25R512MF +* GD25LB256F +* GD25LB512ME +* GD25LB512MF +* GD25LR256F +* GD25LR512MF +* GD25LF256F +* GD25LF512MF + +* MX25U25645G +* MX77U51250F + +* W25Q32JV_M +* W25R512NW +* W74M51NW + +* XM25LU64C +* XM25QH32C +* XM25QH32D +* XM25QH64D +* XM25QH128D +* XM25QH256D +* XM25QH512C +* XM25QH512D +* XM25QU16C +* XM25QU32C +* XM25QU128D +* XM25QU256D +* XM25QU512C +* XM25QU512D + + +* S25FL256L marked as tested + +Misc +========= + +* reduce DELAY_MINIMUM_SLEEP_US to 100 by default +* tests: Add assert for eraseblocks order of invocations for write op +* tests: Add header stdlib.h to allow scan-build to do analysis +* VERSION: Change name pattern to match tag name from now on +* writeprotect: Fix inaccurate return code +* erasure_layout: Fix unreachable error message +* linux_mtd: fix build with clang >= 19 +* Extract usbdev declarations to a separate header +* chipset_enable.c: Add TGL chipset detection based on SPI PCI ID +* flashchips: Skip "WP untested" message for SFDP-capable chip +* sfdp: Update the message shown when SFDP-capable chip is detected +* build script: Add rpmc option to always be enabled on Jenkins +* Rename cli_classic.h to a more adequate cli_getop.h -- To view, visit https://review.coreboot.org/c/flashrom/+/85156?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I0663779020e84cd6d89d33f23a7b5514f8efa2f4 Gerrit-Change-Number: 85156 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[L] Change in flashrom[main]: doc: Release notes for v1.5.0
by Anastasia Klimchuk (Code Review) 04 Dec '24

04 Dec '24

Anastasia Klimchuk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/85156?usp=email ) Change subject: doc: Release notes for v1.5.0 ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > This will be submitted right before changing VERSION to v1.5.0 […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/85156?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I0663779020e84cd6d89d33f23a7b5514f8efa2f4 Gerrit-Change-Number: 85156 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 04 Dec 2024 22:07:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: doc: Reduce size of images in docs
by Anastasia Klimchuk (Code Review) 04 Dec '24

04 Dec '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/85445?usp=email ) Change subject: doc: Reduce size of images in docs ...................................................................... doc: Reduce size of images in docs Since the docs are now in the tree, so are the images in docs. The patch reduces the size of images to be under control: target 1024x768 and within 128Kb whenever possible (which is possible for almost all of them). The patch reduces the size of the tarball from ~10M to ~4.5M Change-Id: I76768d94540f15d929537c73e232b035cf081c7b Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/85445 Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M doc/how_to_add_docs.rst M doc/supported_hw/supported_prog/Buspirate_v3_back.jpg M doc/supported_hw/supported_prog/Buspirate_v3_front.jpg M doc/supported_hw/supported_prog/Dlp_usb1232h_bottom.jpg M doc/supported_hw/supported_prog/Dlp_usb1232h_side.jpg M doc/supported_hw/supported_prog/Dlp_usb1232h_spi_programmer_breadboard_1.jpg M doc/supported_hw/supported_prog/Dlp_usb1232h_spi_programmer_breadboard_2.jpg M doc/supported_hw/supported_prog/Ft2232spi_programer.jpg D doc/supported_hw/supported_prog/Openmoko_0001.jpeg A doc/supported_hw/supported_prog/Openmoko_0001.jpg D doc/supported_hw/supported_prog/Openmoko_0002.jpeg A doc/supported_hw/supported_prog/Openmoko_0002.jpg D doc/supported_hw/supported_prog/Openmoko_0003.jpeg A doc/supported_hw/supported_prog/Openmoko_0003.jpg M doc/supported_hw/supported_prog/Via_epia_m700_bios.jpg M doc/supported_hw/supported_prog/Via_epia_m700_programer.jpg M doc/supported_hw/supported_prog/ft2232_spi.rst M doc/user_docs/1200px-DIP_socket_as_SOIC_clip.jpg M doc/user_docs/Amd_am29f010_tsop32.jpg M doc/user_docs/Dip32_chip_back.jpg M doc/user_docs/Dip32_in_socket.jpg M doc/user_docs/Dip8_chip.jpg M doc/user_docs/Dip_tool.jpg M doc/user_docs/Dual_plcc32_soldered.jpg M doc/user_docs/Empty_dip32_socket.jpg M doc/user_docs/Empty_dip8_socket.jpg M doc/user_docs/Empty_plcc32_socket.jpg M doc/user_docs/Flash-BGA.jpg M doc/user_docs/Plcc32_chip.jpg M doc/user_docs/Plcc32_chip_back.jpg M doc/user_docs/Plcc32_in_socket.jpg M doc/user_docs/Plcc_tool.jpg M doc/user_docs/Soic8_chip.jpg M doc/user_docs/Soic8_socket_back.jpg M doc/user_docs/Soic8_socket_front_closed.jpg M doc/user_docs/Soic8_socket_half_opened.jpg M doc/user_docs/Soic8_socket_open.jpg M doc/user_docs/Soic8_socket_with_chip.jpg M doc/user_docs/Soic8_socket_with_chip_inserted.jpg M doc/user_docs/Soldered_plcc32.jpg M doc/user_docs/Soldered_tsop40.jpg M doc/user_docs/Soldered_tsop48.jpg M doc/user_docs/Spi-socket-dscn2913-1024x768.jpg M doc/user_docs/Sst_39vf040_tsop32.jpg 44 files changed, 6 insertions(+), 6 deletions(-) Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved diff --git a/doc/how_to_add_docs.rst b/doc/how_to_add_docs.rst index ee99ce7..070b0e3 100644 --- a/doc/how_to_add_docs.rst +++ b/doc/how_to_add_docs.rst @@ -33,8 +33,8 @@ * We use CC-BY-4.0 license for documentation. * Writing style can be formal or informal, it's mostly up to you, the - important thing is to make the text clear, readable and unambiguous. You - can insert images if this really helps the readers to understand the - instructions. + important thing is to make the text clear, readable and unambiguous. +* You can insert images if this really helps the readers to understand the + instructions. Please try to target size 1024x768 and within 128Kb whenever possible. * Documentation should be relevant to either flashrom usage or flashrom development diff --git a/doc/supported_hw/supported_prog/Buspirate_v3_back.jpg b/doc/supported_hw/supported_prog/Buspirate_v3_back.jpg index 3afb974..db0be72 100644 --- a/doc/supported_hw/supported_prog/Buspirate_v3_back.jpg +++ b/doc/supported_hw/supported_prog/Buspirate_v3_back.jpg Binary files differ diff --git a/doc/supported_hw/supported_prog/Buspirate_v3_front.jpg b/doc/supported_hw/supported_prog/Buspirate_v3_front.jpg index 3c4fa9c..a179f7c 100644 --- a/doc/supported_hw/supported_prog/Buspirate_v3_front.jpg +++ b/doc/supported_hw/supported_prog/Buspirate_v3_front.jpg Binary files differ diff --git a/doc/supported_hw/supported_prog/Dlp_usb1232h_bottom.jpg b/doc/supported_hw/supported_prog/Dlp_usb1232h_bottom.jpg index 5ebf9b7..643338d 100644 --- a/doc/supported_hw/supported_prog/Dlp_usb1232h_bottom.jpg +++ b/doc/supported_hw/supported_prog/Dlp_usb1232h_bottom.jpg Binary files differ diff --git a/doc/supported_hw/supported_prog/Dlp_usb1232h_side.jpg b/doc/supported_hw/supported_prog/Dlp_usb1232h_side.jpg index 0a17f6e..23d6c31 100644 --- a/doc/supported_hw/supported_prog/Dlp_usb1232h_side.jpg +++ b/doc/supported_hw/supported_prog/Dlp_usb1232h_side.jpg Binary files differ diff --git a/doc/supported_hw/supported_prog/Dlp_usb1232h_spi_programmer_breadboard_1.jpg b/doc/supported_hw/supported_prog/Dlp_usb1232h_spi_programmer_breadboard_1.jpg index 61a7a18..ac6f440 100644 --- a/doc/supported_hw/supported_prog/Dlp_usb1232h_spi_programmer_breadboard_1.jpg +++ b/doc/supported_hw/supported_prog/Dlp_usb1232h_spi_programmer_breadboard_1.jpg Binary files differ diff --git a/doc/supported_hw/supported_prog/Dlp_usb1232h_spi_programmer_breadboard_2.jpg b/doc/supported_hw/supported_prog/Dlp_usb1232h_spi_programmer_breadboard_2.jpg index 92e143a..920bdb6 100644 --- a/doc/supported_hw/supported_prog/Dlp_usb1232h_spi_programmer_breadboard_2.jpg +++ b/doc/supported_hw/supported_prog/Dlp_usb1232h_spi_programmer_breadboard_2.jpg Binary files differ diff --git a/doc/supported_hw/supported_prog/Ft2232spi_programer.jpg b/doc/supported_hw/supported_prog/Ft2232spi_programer.jpg index 84f618c..ff46ad5 100644 --- a/doc/supported_hw/supported_prog/Ft2232spi_programer.jpg +++ b/doc/supported_hw/supported_prog/Ft2232spi_programer.jpg Binary files differ diff --git a/doc/supported_hw/supported_prog/Openmoko_0001.jpeg b/doc/supported_hw/supported_prog/Openmoko_0001.jpeg deleted file mode 100644 index 7ea7968..0000000 --- a/doc/supported_hw/supported_prog/Openmoko_0001.jpeg +++ /dev/null Binary files differ diff --git a/doc/supported_hw/supported_prog/Openmoko_0001.jpg b/doc/supported_hw/supported_prog/Openmoko_0001.jpg new file mode 100644 index 0000000..73551ee --- /dev/null +++ b/doc/supported_hw/supported_prog/Openmoko_0001.jpg Binary files differ diff --git a/doc/supported_hw/supported_prog/Openmoko_0002.jpeg b/doc/supported_hw/supported_prog/Openmoko_0002.jpeg deleted file mode 100644 index be60d56..0000000 --- a/doc/supported_hw/supported_prog/Openmoko_0002.jpeg +++ /dev/null Binary files differ diff --git a/doc/supported_hw/supported_prog/Openmoko_0002.jpg b/doc/supported_hw/supported_prog/Openmoko_0002.jpg new file mode 100644 index 0000000..aad1119 --- /dev/null +++ b/doc/supported_hw/supported_prog/Openmoko_0002.jpg Binary files differ diff --git a/doc/supported_hw/supported_prog/Openmoko_0003.jpeg b/doc/supported_hw/supported_prog/Openmoko_0003.jpeg deleted file mode 100644 index 74109de..0000000 --- a/doc/supported_hw/supported_prog/Openmoko_0003.jpeg +++ /dev/null Binary files differ diff --git a/doc/supported_hw/supported_prog/Openmoko_0003.jpg b/doc/supported_hw/supported_prog/Openmoko_0003.jpg new file mode 100644 index 0000000..36fd12a --- /dev/null +++ b/doc/supported_hw/supported_prog/Openmoko_0003.jpg Binary files differ diff --git a/doc/supported_hw/supported_prog/Via_epia_m700_bios.jpg b/doc/supported_hw/supported_prog/Via_epia_m700_bios.jpg index 6103838..3cc9f49 100644 --- a/doc/supported_hw/supported_prog/Via_epia_m700_bios.jpg +++ b/doc/supported_hw/supported_prog/Via_epia_m700_bios.jpg Binary files differ diff --git a/doc/supported_hw/supported_prog/Via_epia_m700_programer.jpg b/doc/supported_hw/supported_prog/Via_epia_m700_programer.jpg index bc69bcb..02c8f8b 100644 --- a/doc/supported_hw/supported_prog/Via_epia_m700_programer.jpg +++ b/doc/supported_hw/supported_prog/Via_epia_m700_programer.jpg Binary files differ diff --git a/doc/supported_hw/supported_prog/ft2232_spi.rst b/doc/supported_hw/supported_prog/ft2232_spi.rst index 8f87117..2d73fba 100644 --- a/doc/supported_hw/supported_prog/ft2232_spi.rst +++ b/doc/supported_hw/supported_prog/ft2232_spi.rst @@ -241,11 +241,11 @@ Pictures -------- -.. image:: Openmoko_0001.jpeg +.. image:: Openmoko_0001.jpg -.. image:: Openmoko_0002.jpeg +.. image:: Openmoko_0002.jpg -.. image:: Openmoko_0003.jpeg +.. image:: Openmoko_0003.jpg Performances ------------ diff --git a/doc/user_docs/1200px-DIP_socket_as_SOIC_clip.jpg b/doc/user_docs/1200px-DIP_socket_as_SOIC_clip.jpg index c3db692..f8c4f9c 100644 --- a/doc/user_docs/1200px-DIP_socket_as_SOIC_clip.jpg +++ b/doc/user_docs/1200px-DIP_socket_as_SOIC_clip.jpg Binary files differ diff --git a/doc/user_docs/Amd_am29f010_tsop32.jpg b/doc/user_docs/Amd_am29f010_tsop32.jpg index faf0982..ea26d1d 100644 --- a/doc/user_docs/Amd_am29f010_tsop32.jpg +++ b/doc/user_docs/Amd_am29f010_tsop32.jpg Binary files differ diff --git a/doc/user_docs/Dip32_chip_back.jpg b/doc/user_docs/Dip32_chip_back.jpg index f564505..279669d 100644 --- a/doc/user_docs/Dip32_chip_back.jpg +++ b/doc/user_docs/Dip32_chip_back.jpg Binary files differ diff --git a/doc/user_docs/Dip32_in_socket.jpg b/doc/user_docs/Dip32_in_socket.jpg index 38467a3..fdcc89e 100644 --- a/doc/user_docs/Dip32_in_socket.jpg +++ b/doc/user_docs/Dip32_in_socket.jpg Binary files differ diff --git a/doc/user_docs/Dip8_chip.jpg b/doc/user_docs/Dip8_chip.jpg index b1afb41..8a1a8e8 100644 --- a/doc/user_docs/Dip8_chip.jpg +++ b/doc/user_docs/Dip8_chip.jpg Binary files differ diff --git a/doc/user_docs/Dip_tool.jpg b/doc/user_docs/Dip_tool.jpg index 6063333..a223e1f 100644 --- a/doc/user_docs/Dip_tool.jpg +++ b/doc/user_docs/Dip_tool.jpg Binary files differ diff --git a/doc/user_docs/Dual_plcc32_soldered.jpg b/doc/user_docs/Dual_plcc32_soldered.jpg index 7d74251..e2e3153 100644 --- a/doc/user_docs/Dual_plcc32_soldered.jpg +++ b/doc/user_docs/Dual_plcc32_soldered.jpg Binary files differ diff --git a/doc/user_docs/Empty_dip32_socket.jpg b/doc/user_docs/Empty_dip32_socket.jpg index 0c44c3a..cac33c3 100644 --- a/doc/user_docs/Empty_dip32_socket.jpg +++ b/doc/user_docs/Empty_dip32_socket.jpg Binary files differ diff --git a/doc/user_docs/Empty_dip8_socket.jpg b/doc/user_docs/Empty_dip8_socket.jpg index 22e843b..1d76317 100644 --- a/doc/user_docs/Empty_dip8_socket.jpg +++ b/doc/user_docs/Empty_dip8_socket.jpg Binary files differ diff --git a/doc/user_docs/Empty_plcc32_socket.jpg b/doc/user_docs/Empty_plcc32_socket.jpg index acd20b1..5ce2d3e 100644 --- a/doc/user_docs/Empty_plcc32_socket.jpg +++ b/doc/user_docs/Empty_plcc32_socket.jpg Binary files differ diff --git a/doc/user_docs/Flash-BGA.jpg b/doc/user_docs/Flash-BGA.jpg index 2eb059b..cadbe92 100644 --- a/doc/user_docs/Flash-BGA.jpg +++ b/doc/user_docs/Flash-BGA.jpg Binary files differ diff --git a/doc/user_docs/Plcc32_chip.jpg b/doc/user_docs/Plcc32_chip.jpg index 3a0193a..165c4ff 100644 --- a/doc/user_docs/Plcc32_chip.jpg +++ b/doc/user_docs/Plcc32_chip.jpg Binary files differ diff --git a/doc/user_docs/Plcc32_chip_back.jpg b/doc/user_docs/Plcc32_chip_back.jpg index f016900..be2f43f 100644 --- a/doc/user_docs/Plcc32_chip_back.jpg +++ b/doc/user_docs/Plcc32_chip_back.jpg Binary files differ diff --git a/doc/user_docs/Plcc32_in_socket.jpg b/doc/user_docs/Plcc32_in_socket.jpg index 241794c..d65c3a6 100644 --- a/doc/user_docs/Plcc32_in_socket.jpg +++ b/doc/user_docs/Plcc32_in_socket.jpg Binary files differ diff --git a/doc/user_docs/Plcc_tool.jpg b/doc/user_docs/Plcc_tool.jpg index 3d3b801..5e3c458 100644 --- a/doc/user_docs/Plcc_tool.jpg +++ b/doc/user_docs/Plcc_tool.jpg Binary files differ diff --git a/doc/user_docs/Soic8_chip.jpg b/doc/user_docs/Soic8_chip.jpg index d103c7d..0cc766d 100644 --- a/doc/user_docs/Soic8_chip.jpg +++ b/doc/user_docs/Soic8_chip.jpg Binary files differ diff --git a/doc/user_docs/Soic8_socket_back.jpg b/doc/user_docs/Soic8_socket_back.jpg index 49504e2..95b14bf 100644 --- a/doc/user_docs/Soic8_socket_back.jpg +++ b/doc/user_docs/Soic8_socket_back.jpg Binary files differ diff --git a/doc/user_docs/Soic8_socket_front_closed.jpg b/doc/user_docs/Soic8_socket_front_closed.jpg index f6aebd5..5b0fcd2 100644 --- a/doc/user_docs/Soic8_socket_front_closed.jpg +++ b/doc/user_docs/Soic8_socket_front_closed.jpg Binary files differ diff --git a/doc/user_docs/Soic8_socket_half_opened.jpg b/doc/user_docs/Soic8_socket_half_opened.jpg index f4d5730..b1fad9f 100644 --- a/doc/user_docs/Soic8_socket_half_opened.jpg +++ b/doc/user_docs/Soic8_socket_half_opened.jpg Binary files differ diff --git a/doc/user_docs/Soic8_socket_open.jpg b/doc/user_docs/Soic8_socket_open.jpg index 69b4e74..53e585d 100644 --- a/doc/user_docs/Soic8_socket_open.jpg +++ b/doc/user_docs/Soic8_socket_open.jpg Binary files differ diff --git a/doc/user_docs/Soic8_socket_with_chip.jpg b/doc/user_docs/Soic8_socket_with_chip.jpg index 322f638..effdcb1 100644 --- a/doc/user_docs/Soic8_socket_with_chip.jpg +++ b/doc/user_docs/Soic8_socket_with_chip.jpg Binary files differ diff --git a/doc/user_docs/Soic8_socket_with_chip_inserted.jpg b/doc/user_docs/Soic8_socket_with_chip_inserted.jpg index 37af90d..e730635 100644 --- a/doc/user_docs/Soic8_socket_with_chip_inserted.jpg +++ b/doc/user_docs/Soic8_socket_with_chip_inserted.jpg Binary files differ diff --git a/doc/user_docs/Soldered_plcc32.jpg b/doc/user_docs/Soldered_plcc32.jpg index 8a3a6cd..39a3ac1 100644 --- a/doc/user_docs/Soldered_plcc32.jpg +++ b/doc/user_docs/Soldered_plcc32.jpg Binary files differ diff --git a/doc/user_docs/Soldered_tsop40.jpg b/doc/user_docs/Soldered_tsop40.jpg index 1fcf2ef..24e1ec6 100644 --- a/doc/user_docs/Soldered_tsop40.jpg +++ b/doc/user_docs/Soldered_tsop40.jpg Binary files differ diff --git a/doc/user_docs/Soldered_tsop48.jpg b/doc/user_docs/Soldered_tsop48.jpg index 3df63ee..11782c7 100644 --- a/doc/user_docs/Soldered_tsop48.jpg +++ b/doc/user_docs/Soldered_tsop48.jpg Binary files differ diff --git a/doc/user_docs/Spi-socket-dscn2913-1024x768.jpg b/doc/user_docs/Spi-socket-dscn2913-1024x768.jpg index 3b20ae0..9e3392f 100644 --- a/doc/user_docs/Spi-socket-dscn2913-1024x768.jpg +++ b/doc/user_docs/Spi-socket-dscn2913-1024x768.jpg Binary files differ diff --git a/doc/user_docs/Sst_39vf040_tsop32.jpg b/doc/user_docs/Sst_39vf040_tsop32.jpg index beefeba..f3802e0 100644 --- a/doc/user_docs/Sst_39vf040_tsop32.jpg +++ b/doc/user_docs/Sst_39vf040_tsop32.jpg Binary files differ -- To view, visit https://review.coreboot.org/c/flashrom/+/85445?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I76768d94540f15d929537c73e232b035cf081c7b Gerrit-Change-Number: 85445 Gerrit-PatchSet: 4 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in flashrom[main]: doc: Reduce size of images in docs
by Stefan Reinauer (Code Review) 03 Dec '24

03 Dec '24

Attention is currently required from: Anastasia Klimchuk, Peter Marheine. Stefan Reinauer has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/85445?usp=email ) Change subject: doc: Reduce size of images in docs ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/85445?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I76768d94540f15d929537c73e232b035cf081c7b Gerrit-Change-Number: 85445 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Tue, 03 Dec 2024 08:51:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in flashrom[main]: doc: Reduce size of images in docs
by Anastasia Klimchuk (Code Review) 03 Dec '24

03 Dec '24

Attention is currently required from: Peter Marheine. Hello Peter Marheine, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/85445?usp=email to look at the new patch set (#3). Change subject: doc: Reduce size of images in docs ...................................................................... doc: Reduce size of images in docs Since the docs are now in the tree, so are the images in docs. The patch reduces the size of images to be under control: target 1024x768 and within 128Kb whenever possible (which is possible for almost all of them). The patch reduces the size of the tarball from ~10M to ~4.5M Change-Id: I76768d94540f15d929537c73e232b035cf081c7b Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M doc/how_to_add_docs.rst M doc/supported_hw/supported_prog/Buspirate_v3_back.jpg M doc/supported_hw/supported_prog/Buspirate_v3_front.jpg M doc/supported_hw/supported_prog/Dlp_usb1232h_bottom.jpg M doc/supported_hw/supported_prog/Dlp_usb1232h_side.jpg M doc/supported_hw/supported_prog/Dlp_usb1232h_spi_programmer_breadboard_1.jpg M doc/supported_hw/supported_prog/Dlp_usb1232h_spi_programmer_breadboard_2.jpg M doc/supported_hw/supported_prog/Ft2232spi_programer.jpg D doc/supported_hw/supported_prog/Openmoko_0001.jpeg A doc/supported_hw/supported_prog/Openmoko_0001.jpg D doc/supported_hw/supported_prog/Openmoko_0002.jpeg A doc/supported_hw/supported_prog/Openmoko_0002.jpg D doc/supported_hw/supported_prog/Openmoko_0003.jpeg A doc/supported_hw/supported_prog/Openmoko_0003.jpg M doc/supported_hw/supported_prog/Via_epia_m700_bios.jpg M doc/supported_hw/supported_prog/Via_epia_m700_programer.jpg M doc/supported_hw/supported_prog/ft2232_spi.rst M doc/user_docs/1200px-DIP_socket_as_SOIC_clip.jpg M doc/user_docs/Amd_am29f010_tsop32.jpg M doc/user_docs/Dip32_chip_back.jpg M doc/user_docs/Dip32_in_socket.jpg M doc/user_docs/Dip8_chip.jpg M doc/user_docs/Dip_tool.jpg M doc/user_docs/Dual_plcc32_soldered.jpg M doc/user_docs/Empty_dip32_socket.jpg M doc/user_docs/Empty_dip8_socket.jpg M doc/user_docs/Empty_plcc32_socket.jpg M doc/user_docs/Flash-BGA.jpg M doc/user_docs/Plcc32_chip.jpg M doc/user_docs/Plcc32_chip_back.jpg M doc/user_docs/Plcc32_in_socket.jpg M doc/user_docs/Plcc_tool.jpg M doc/user_docs/Soic8_chip.jpg M doc/user_docs/Soic8_socket_back.jpg M doc/user_docs/Soic8_socket_front_closed.jpg M doc/user_docs/Soic8_socket_half_opened.jpg M doc/user_docs/Soic8_socket_open.jpg M doc/user_docs/Soic8_socket_with_chip.jpg M doc/user_docs/Soic8_socket_with_chip_inserted.jpg M doc/user_docs/Soldered_plcc32.jpg M doc/user_docs/Soldered_tsop40.jpg M doc/user_docs/Soldered_tsop48.jpg M doc/user_docs/Spi-socket-dscn2913-1024x768.jpg M doc/user_docs/Sst_39vf040_tsop32.jpg 44 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/45/85445/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/85445?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I76768d94540f15d929537c73e232b035cf081c7b Gerrit-Change-Number: 85445 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org>

1 0

[S] Change in flashrom[main]: doc: Reduce size of images in docs
by Anastasia Klimchuk (Code Review) 03 Dec '24

03 Dec '24

Attention is currently required from: Peter Marheine. Anastasia Klimchuk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/85445?usp=email ) Change subject: doc: Reduce size of images in docs ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/85445/comment/9844b4d4_001584fb?us… : PS1, Line 11: 1024x768 and within 128Kb whenever possible > Would it be useful to include this as a guideline somewhere in developer docs, to suggest to future […] Yes good idea! And we have a doc: `doc/how_to_add_docs.rst` I added a note about size there -- To view, visit https://review.coreboot.org/c/flashrom/+/85445?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I76768d94540f15d929537c73e232b035cf081c7b Gerrit-Change-Number: 85445 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Tue, 03 Dec 2024 04:46:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org>

1 0

[S] Change in flashrom[main]: doc: Reduce size of images in docs
by Anastasia Klimchuk (Code Review) 03 Dec '24

03 Dec '24

Attention is currently required from: Anastasia Klimchuk. Hello Peter Marheine, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/85445?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: doc: Reduce size of images in docs ...................................................................... doc: Reduce size of images in docs Since the docs are now in the tree, so are the images in docs. The patch reduces the size of images to be under control: target 1024x768 and within 128Kb whenever possible (which is possible for almost all of them). The patch reduces the size of the tarball from ~10M to ~4M Change-Id: I76768d94540f15d929537c73e232b035cf081c7b Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M doc/how_to_add_docs.rst M doc/supported_hw/supported_prog/Buspirate_v3_back.jpg M doc/supported_hw/supported_prog/Buspirate_v3_front.jpg M doc/supported_hw/supported_prog/Dlp_usb1232h_bottom.jpg M doc/supported_hw/supported_prog/Dlp_usb1232h_side.jpg M doc/supported_hw/supported_prog/Dlp_usb1232h_spi_programmer_breadboard_1.jpg M doc/supported_hw/supported_prog/Dlp_usb1232h_spi_programmer_breadboard_2.jpg M doc/supported_hw/supported_prog/Ft2232spi_programer.jpg D doc/supported_hw/supported_prog/Openmoko_0001.jpeg A doc/supported_hw/supported_prog/Openmoko_0001.jpg D doc/supported_hw/supported_prog/Openmoko_0002.jpeg A doc/supported_hw/supported_prog/Openmoko_0002.jpg D doc/supported_hw/supported_prog/Openmoko_0003.jpeg A doc/supported_hw/supported_prog/Openmoko_0003.jpg M doc/supported_hw/supported_prog/Via_epia_m700_bios.jpg M doc/supported_hw/supported_prog/Via_epia_m700_programer.jpg M doc/supported_hw/supported_prog/ft2232_spi.rst M doc/user_docs/1200px-DIP_socket_as_SOIC_clip.jpg M doc/user_docs/Amd_am29f010_tsop32.jpg M doc/user_docs/Dip32_chip_back.jpg M doc/user_docs/Dip32_in_socket.jpg M doc/user_docs/Dip8_chip.jpg M doc/user_docs/Dip_tool.jpg M doc/user_docs/Dual_plcc32_soldered.jpg M doc/user_docs/Empty_dip32_socket.jpg M doc/user_docs/Empty_dip8_socket.jpg M doc/user_docs/Empty_plcc32_socket.jpg M doc/user_docs/Flash-BGA.jpg M doc/user_docs/Plcc32_chip.jpg M doc/user_docs/Plcc32_chip_back.jpg M doc/user_docs/Plcc32_in_socket.jpg M doc/user_docs/Plcc_tool.jpg M doc/user_docs/Soic8_chip.jpg M doc/user_docs/Soic8_socket_back.jpg M doc/user_docs/Soic8_socket_front_closed.jpg M doc/user_docs/Soic8_socket_half_opened.jpg M doc/user_docs/Soic8_socket_open.jpg M doc/user_docs/Soic8_socket_with_chip.jpg M doc/user_docs/Soic8_socket_with_chip_inserted.jpg M doc/user_docs/Soldered_plcc32.jpg M doc/user_docs/Soldered_tsop40.jpg M doc/user_docs/Soldered_tsop48.jpg M doc/user_docs/Spi-socket-dscn2913-1024x768.jpg M doc/user_docs/Sst_39vf040_tsop32.jpg 44 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/45/85445/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/85445?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I76768d94540f15d929537c73e232b035cf081c7b Gerrit-Change-Number: 85445 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[XS] Change in flashrom[main]: doc: Reduce size of images in docs
by Peter Marheine (Code Review) 03 Dec '24

03 Dec '24

Attention is currently required from: Anastasia Klimchuk. Peter Marheine has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/85445?usp=email ) Change subject: doc: Reduce size of images in docs ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: I like how Gerrit will show a diff for images, so it's easy to see that making these smaller doesn't compromise legibility. Commit Message: https://review.coreboot.org/c/flashrom/+/85445/comment/86d9a998_f952566d?us… : PS1, Line 11: 1024x768 and within 128Kb whenever possible Would it be useful to include this as a guideline somewhere in developer docs, to suggest to future reviewers that images should be small within reason? -- To view, visit https://review.coreboot.org/c/flashrom/+/85445?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I76768d94540f15d929537c73e232b035cf081c7b Gerrit-Change-Number: 85445 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 03 Dec 2024 04:13:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in flashrom[main]: doc: Reduce size of images in docs
by Anastasia Klimchuk (Code Review) 03 Dec '24

03 Dec '24

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/85445?usp=email ) Change subject: doc: Reduce size of images in docs ...................................................................... doc: Reduce size of images in docs Since the docs are now in the tree, so are the images in docs. The patch reduces the size of images to be under control: target 1024x768 and within 128Kb whenever possible (which is possible for almost all of them). The patch reduces the size of the tarball from ~10M to ~4M Change-Id: I76768d94540f15d929537c73e232b035cf081c7b Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M doc/supported_hw/supported_prog/Buspirate_v3_back.jpg M doc/supported_hw/supported_prog/Buspirate_v3_front.jpg M doc/supported_hw/supported_prog/Dlp_usb1232h_bottom.jpg M doc/supported_hw/supported_prog/Dlp_usb1232h_side.jpg M doc/supported_hw/supported_prog/Dlp_usb1232h_spi_programmer_breadboard_1.jpg M doc/supported_hw/supported_prog/Dlp_usb1232h_spi_programmer_breadboard_2.jpg M doc/supported_hw/supported_prog/Ft2232spi_programer.jpg D doc/supported_hw/supported_prog/Openmoko_0001.jpeg A doc/supported_hw/supported_prog/Openmoko_0001.jpg D doc/supported_hw/supported_prog/Openmoko_0002.jpeg A doc/supported_hw/supported_prog/Openmoko_0002.jpg D doc/supported_hw/supported_prog/Openmoko_0003.jpeg A doc/supported_hw/supported_prog/Openmoko_0003.jpg M doc/supported_hw/supported_prog/Via_epia_m700_bios.jpg M doc/supported_hw/supported_prog/Via_epia_m700_programer.jpg M doc/supported_hw/supported_prog/ft2232_spi.rst M doc/user_docs/1200px-DIP_socket_as_SOIC_clip.jpg M doc/user_docs/Amd_am29f010_tsop32.jpg M doc/user_docs/Dip32_chip_back.jpg M doc/user_docs/Dip32_in_socket.jpg M doc/user_docs/Dip8_chip.jpg M doc/user_docs/Dip_tool.jpg M doc/user_docs/Dual_plcc32_soldered.jpg M doc/user_docs/Empty_dip32_socket.jpg M doc/user_docs/Empty_dip8_socket.jpg M doc/user_docs/Empty_plcc32_socket.jpg M doc/user_docs/Flash-BGA.jpg M doc/user_docs/Plcc32_chip.jpg M doc/user_docs/Plcc32_chip_back.jpg M doc/user_docs/Plcc32_in_socket.jpg M doc/user_docs/Plcc_tool.jpg M doc/user_docs/Soic8_chip.jpg M doc/user_docs/Soic8_socket_back.jpg M doc/user_docs/Soic8_socket_front_closed.jpg M doc/user_docs/Soic8_socket_half_opened.jpg M doc/user_docs/Soic8_socket_open.jpg M doc/user_docs/Soic8_socket_with_chip.jpg M doc/user_docs/Soic8_socket_with_chip_inserted.jpg M doc/user_docs/Soldered_plcc32.jpg M doc/user_docs/Soldered_tsop40.jpg M doc/user_docs/Soldered_tsop48.jpg M doc/user_docs/Spi-socket-dscn2913-1024x768.jpg M doc/user_docs/Sst_39vf040_tsop32.jpg 43 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/45/85445/1 diff --git a/doc/supported_hw/supported_prog/Buspirate_v3_back.jpg b/doc/supported_hw/supported_prog/Buspirate_v3_back.jpg index 3afb974..db0be72 100644 --- a/doc/supported_hw/supported_prog/Buspirate_v3_back.jpg +++ b/doc/supported_hw/supported_prog/Buspirate_v3_back.jpg Binary files differ diff --git a/doc/supported_hw/supported_prog/Buspirate_v3_front.jpg b/doc/supported_hw/supported_prog/Buspirate_v3_front.jpg index 3c4fa9c..a179f7c 100644 --- a/doc/supported_hw/supported_prog/Buspirate_v3_front.jpg +++ b/doc/supported_hw/supported_prog/Buspirate_v3_front.jpg Binary files differ diff --git a/doc/supported_hw/supported_prog/Dlp_usb1232h_bottom.jpg b/doc/supported_hw/supported_prog/Dlp_usb1232h_bottom.jpg index 5ebf9b7..643338d 100644 --- a/doc/supported_hw/supported_prog/Dlp_usb1232h_bottom.jpg +++ b/doc/supported_hw/supported_prog/Dlp_usb1232h_bottom.jpg Binary files differ diff --git a/doc/supported_hw/supported_prog/Dlp_usb1232h_side.jpg b/doc/supported_hw/supported_prog/Dlp_usb1232h_side.jpg index 0a17f6e..23d6c31 100644 --- a/doc/supported_hw/supported_prog/Dlp_usb1232h_side.jpg +++ b/doc/supported_hw/supported_prog/Dlp_usb1232h_side.jpg Binary files differ diff --git a/doc/supported_hw/supported_prog/Dlp_usb1232h_spi_programmer_breadboard_1.jpg b/doc/supported_hw/supported_prog/Dlp_usb1232h_spi_programmer_breadboard_1.jpg index 61a7a18..ac6f440 100644 --- a/doc/supported_hw/supported_prog/Dlp_usb1232h_spi_programmer_breadboard_1.jpg +++ b/doc/supported_hw/supported_prog/Dlp_usb1232h_spi_programmer_breadboard_1.jpg Binary files differ diff --git a/doc/supported_hw/supported_prog/Dlp_usb1232h_spi_programmer_breadboard_2.jpg b/doc/supported_hw/supported_prog/Dlp_usb1232h_spi_programmer_breadboard_2.jpg index 92e143a..920bdb6 100644 --- a/doc/supported_hw/supported_prog/Dlp_usb1232h_spi_programmer_breadboard_2.jpg +++ b/doc/supported_hw/supported_prog/Dlp_usb1232h_spi_programmer_breadboard_2.jpg Binary files differ diff --git a/doc/supported_hw/supported_prog/Ft2232spi_programer.jpg b/doc/supported_hw/supported_prog/Ft2232spi_programer.jpg index 84f618c..ff46ad5 100644 --- a/doc/supported_hw/supported_prog/Ft2232spi_programer.jpg +++ b/doc/supported_hw/supported_prog/Ft2232spi_programer.jpg Binary files differ diff --git a/doc/supported_hw/supported_prog/Openmoko_0001.jpeg b/doc/supported_hw/supported_prog/Openmoko_0001.jpeg deleted file mode 100644 index 7ea7968..0000000 --- a/doc/supported_hw/supported_prog/Openmoko_0001.jpeg +++ /dev/null Binary files differ diff --git a/doc/supported_hw/supported_prog/Openmoko_0001.jpg b/doc/supported_hw/supported_prog/Openmoko_0001.jpg new file mode 100644 index 0000000..73551ee --- /dev/null +++ b/doc/supported_hw/supported_prog/Openmoko_0001.jpg Binary files differ diff --git a/doc/supported_hw/supported_prog/Openmoko_0002.jpeg b/doc/supported_hw/supported_prog/Openmoko_0002.jpeg deleted file mode 100644 index be60d56..0000000 --- a/doc/supported_hw/supported_prog/Openmoko_0002.jpeg +++ /dev/null Binary files differ diff --git a/doc/supported_hw/supported_prog/Openmoko_0002.jpg b/doc/supported_hw/supported_prog/Openmoko_0002.jpg new file mode 100644 index 0000000..aad1119 --- /dev/null +++ b/doc/supported_hw/supported_prog/Openmoko_0002.jpg Binary files differ diff --git a/doc/supported_hw/supported_prog/Openmoko_0003.jpeg b/doc/supported_hw/supported_prog/Openmoko_0003.jpeg deleted file mode 100644 index 74109de..0000000 --- a/doc/supported_hw/supported_prog/Openmoko_0003.jpeg +++ /dev/null Binary files differ diff --git a/doc/supported_hw/supported_prog/Openmoko_0003.jpg b/doc/supported_hw/supported_prog/Openmoko_0003.jpg new file mode 100644 index 0000000..36fd12a --- /dev/null +++ b/doc/supported_hw/supported_prog/Openmoko_0003.jpg Binary files differ diff --git a/doc/supported_hw/supported_prog/Via_epia_m700_bios.jpg b/doc/supported_hw/supported_prog/Via_epia_m700_bios.jpg index 6103838..3cc9f49 100644 --- a/doc/supported_hw/supported_prog/Via_epia_m700_bios.jpg +++ b/doc/supported_hw/supported_prog/Via_epia_m700_bios.jpg Binary files differ diff --git a/doc/supported_hw/supported_prog/Via_epia_m700_programer.jpg b/doc/supported_hw/supported_prog/Via_epia_m700_programer.jpg index bc69bcb..02c8f8b 100644 --- a/doc/supported_hw/supported_prog/Via_epia_m700_programer.jpg +++ b/doc/supported_hw/supported_prog/Via_epia_m700_programer.jpg Binary files differ diff --git a/doc/supported_hw/supported_prog/ft2232_spi.rst b/doc/supported_hw/supported_prog/ft2232_spi.rst index 8f87117..2d73fba 100644 --- a/doc/supported_hw/supported_prog/ft2232_spi.rst +++ b/doc/supported_hw/supported_prog/ft2232_spi.rst @@ -241,11 +241,11 @@ Pictures -------- -.. image:: Openmoko_0001.jpeg +.. image:: Openmoko_0001.jpg -.. image:: Openmoko_0002.jpeg +.. image:: Openmoko_0002.jpg -.. image:: Openmoko_0003.jpeg +.. image:: Openmoko_0003.jpg Performances ------------ diff --git a/doc/user_docs/1200px-DIP_socket_as_SOIC_clip.jpg b/doc/user_docs/1200px-DIP_socket_as_SOIC_clip.jpg index c3db692..f8c4f9c 100644 --- a/doc/user_docs/1200px-DIP_socket_as_SOIC_clip.jpg +++ b/doc/user_docs/1200px-DIP_socket_as_SOIC_clip.jpg Binary files differ diff --git a/doc/user_docs/Amd_am29f010_tsop32.jpg b/doc/user_docs/Amd_am29f010_tsop32.jpg index faf0982..ea26d1d 100644 --- a/doc/user_docs/Amd_am29f010_tsop32.jpg +++ b/doc/user_docs/Amd_am29f010_tsop32.jpg Binary files differ diff --git a/doc/user_docs/Dip32_chip_back.jpg b/doc/user_docs/Dip32_chip_back.jpg index f564505..279669d 100644 --- a/doc/user_docs/Dip32_chip_back.jpg +++ b/doc/user_docs/Dip32_chip_back.jpg Binary files differ diff --git a/doc/user_docs/Dip32_in_socket.jpg b/doc/user_docs/Dip32_in_socket.jpg index 38467a3..fdcc89e 100644 --- a/doc/user_docs/Dip32_in_socket.jpg +++ b/doc/user_docs/Dip32_in_socket.jpg Binary files differ diff --git a/doc/user_docs/Dip8_chip.jpg b/doc/user_docs/Dip8_chip.jpg index b1afb41..8a1a8e8 100644 --- a/doc/user_docs/Dip8_chip.jpg +++ b/doc/user_docs/Dip8_chip.jpg Binary files differ diff --git a/doc/user_docs/Dip_tool.jpg b/doc/user_docs/Dip_tool.jpg index 6063333..a223e1f 100644 --- a/doc/user_docs/Dip_tool.jpg +++ b/doc/user_docs/Dip_tool.jpg Binary files differ diff --git a/doc/user_docs/Dual_plcc32_soldered.jpg b/doc/user_docs/Dual_plcc32_soldered.jpg index 7d74251..e2e3153 100644 --- a/doc/user_docs/Dual_plcc32_soldered.jpg +++ b/doc/user_docs/Dual_plcc32_soldered.jpg Binary files differ diff --git a/doc/user_docs/Empty_dip32_socket.jpg b/doc/user_docs/Empty_dip32_socket.jpg index 0c44c3a..cac33c3 100644 --- a/doc/user_docs/Empty_dip32_socket.jpg +++ b/doc/user_docs/Empty_dip32_socket.jpg Binary files differ diff --git a/doc/user_docs/Empty_dip8_socket.jpg b/doc/user_docs/Empty_dip8_socket.jpg index 22e843b..1d76317 100644 --- a/doc/user_docs/Empty_dip8_socket.jpg +++ b/doc/user_docs/Empty_dip8_socket.jpg Binary files differ diff --git a/doc/user_docs/Empty_plcc32_socket.jpg b/doc/user_docs/Empty_plcc32_socket.jpg index acd20b1..5ce2d3e 100644 --- a/doc/user_docs/Empty_plcc32_socket.jpg +++ b/doc/user_docs/Empty_plcc32_socket.jpg Binary files differ diff --git a/doc/user_docs/Flash-BGA.jpg b/doc/user_docs/Flash-BGA.jpg index 2eb059b..cadbe92 100644 --- a/doc/user_docs/Flash-BGA.jpg +++ b/doc/user_docs/Flash-BGA.jpg Binary files differ diff --git a/doc/user_docs/Plcc32_chip.jpg b/doc/user_docs/Plcc32_chip.jpg index 3a0193a..165c4ff 100644 --- a/doc/user_docs/Plcc32_chip.jpg +++ b/doc/user_docs/Plcc32_chip.jpg Binary files differ diff --git a/doc/user_docs/Plcc32_chip_back.jpg b/doc/user_docs/Plcc32_chip_back.jpg index f016900..be2f43f 100644 --- a/doc/user_docs/Plcc32_chip_back.jpg +++ b/doc/user_docs/Plcc32_chip_back.jpg Binary files differ diff --git a/doc/user_docs/Plcc32_in_socket.jpg b/doc/user_docs/Plcc32_in_socket.jpg index 241794c..d65c3a6 100644 --- a/doc/user_docs/Plcc32_in_socket.jpg +++ b/doc/user_docs/Plcc32_in_socket.jpg Binary files differ diff --git a/doc/user_docs/Plcc_tool.jpg b/doc/user_docs/Plcc_tool.jpg index 3d3b801..5e3c458 100644 --- a/doc/user_docs/Plcc_tool.jpg +++ b/doc/user_docs/Plcc_tool.jpg Binary files differ diff --git a/doc/user_docs/Soic8_chip.jpg b/doc/user_docs/Soic8_chip.jpg index d103c7d..0cc766d 100644 --- a/doc/user_docs/Soic8_chip.jpg +++ b/doc/user_docs/Soic8_chip.jpg Binary files differ diff --git a/doc/user_docs/Soic8_socket_back.jpg b/doc/user_docs/Soic8_socket_back.jpg index 49504e2..95b14bf 100644 --- a/doc/user_docs/Soic8_socket_back.jpg +++ b/doc/user_docs/Soic8_socket_back.jpg Binary files differ diff --git a/doc/user_docs/Soic8_socket_front_closed.jpg b/doc/user_docs/Soic8_socket_front_closed.jpg index f6aebd5..5b0fcd2 100644 --- a/doc/user_docs/Soic8_socket_front_closed.jpg +++ b/doc/user_docs/Soic8_socket_front_closed.jpg Binary files differ diff --git a/doc/user_docs/Soic8_socket_half_opened.jpg b/doc/user_docs/Soic8_socket_half_opened.jpg index f4d5730..b1fad9f 100644 --- a/doc/user_docs/Soic8_socket_half_opened.jpg +++ b/doc/user_docs/Soic8_socket_half_opened.jpg Binary files differ diff --git a/doc/user_docs/Soic8_socket_open.jpg b/doc/user_docs/Soic8_socket_open.jpg index 69b4e74..53e585d 100644 --- a/doc/user_docs/Soic8_socket_open.jpg +++ b/doc/user_docs/Soic8_socket_open.jpg Binary files differ diff --git a/doc/user_docs/Soic8_socket_with_chip.jpg b/doc/user_docs/Soic8_socket_with_chip.jpg index 322f638..effdcb1 100644 --- a/doc/user_docs/Soic8_socket_with_chip.jpg +++ b/doc/user_docs/Soic8_socket_with_chip.jpg Binary files differ diff --git a/doc/user_docs/Soic8_socket_with_chip_inserted.jpg b/doc/user_docs/Soic8_socket_with_chip_inserted.jpg index 37af90d..e730635 100644 --- a/doc/user_docs/Soic8_socket_with_chip_inserted.jpg +++ b/doc/user_docs/Soic8_socket_with_chip_inserted.jpg Binary files differ diff --git a/doc/user_docs/Soldered_plcc32.jpg b/doc/user_docs/Soldered_plcc32.jpg index 8a3a6cd..39a3ac1 100644 --- a/doc/user_docs/Soldered_plcc32.jpg +++ b/doc/user_docs/Soldered_plcc32.jpg Binary files differ diff --git a/doc/user_docs/Soldered_tsop40.jpg b/doc/user_docs/Soldered_tsop40.jpg index 1fcf2ef..24e1ec6 100644 --- a/doc/user_docs/Soldered_tsop40.jpg +++ b/doc/user_docs/Soldered_tsop40.jpg Binary files differ diff --git a/doc/user_docs/Soldered_tsop48.jpg b/doc/user_docs/Soldered_tsop48.jpg index 3df63ee..11782c7 100644 --- a/doc/user_docs/Soldered_tsop48.jpg +++ b/doc/user_docs/Soldered_tsop48.jpg Binary files differ diff --git a/doc/user_docs/Spi-socket-dscn2913-1024x768.jpg b/doc/user_docs/Spi-socket-dscn2913-1024x768.jpg index 3b20ae0..9e3392f 100644 --- a/doc/user_docs/Spi-socket-dscn2913-1024x768.jpg +++ b/doc/user_docs/Spi-socket-dscn2913-1024x768.jpg Binary files differ diff --git a/doc/user_docs/Sst_39vf040_tsop32.jpg b/doc/user_docs/Sst_39vf040_tsop32.jpg index beefeba..f3802e0 100644 --- a/doc/user_docs/Sst_39vf040_tsop32.jpg +++ b/doc/user_docs/Sst_39vf040_tsop32.jpg Binary files differ -- To view, visit https://review.coreboot.org/c/flashrom/+/85445?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I76768d94540f15d929537c73e232b035cf081c7b Gerrit-Change-Number: 85445 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit December 2024