Attention is currently required from: Anastasia Klimchuk, Peter Marheine.
Stefan Reinauer has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/85445?usp=email )
Change subject: doc: Reduce size of images in docs
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/flashrom/+/85445?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I76768d94540f15d929537c73e232b035cf081c7b
Gerrit-Change-Number: 85445
Gerrit-PatchSet: 3
Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Comment-Date: Tue, 03 Dec 2024 08:51:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Peter Marheine.
Hello Peter Marheine, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/85445?usp=email
to look at the new patch set (#3).
Change subject: doc: Reduce size of images in docs
......................................................................
doc: Reduce size of images in docs
Since the docs are now in the tree, so are the images in docs.
The patch reduces the size of images to be under control: target
1024x768 and within 128Kb whenever possible (which is possible for
almost all of them).
The patch reduces the size of the tarball from ~10M to ~4.5M
Change-Id: I76768d94540f15d929537c73e232b035cf081c7b
Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org>
---
M doc/how_to_add_docs.rst
M doc/supported_hw/supported_prog/Buspirate_v3_back.jpg
M doc/supported_hw/supported_prog/Buspirate_v3_front.jpg
M doc/supported_hw/supported_prog/Dlp_usb1232h_bottom.jpg
M doc/supported_hw/supported_prog/Dlp_usb1232h_side.jpg
M doc/supported_hw/supported_prog/Dlp_usb1232h_spi_programmer_breadboard_1.jpg
M doc/supported_hw/supported_prog/Dlp_usb1232h_spi_programmer_breadboard_2.jpg
M doc/supported_hw/supported_prog/Ft2232spi_programer.jpg
D doc/supported_hw/supported_prog/Openmoko_0001.jpeg
A doc/supported_hw/supported_prog/Openmoko_0001.jpg
D doc/supported_hw/supported_prog/Openmoko_0002.jpeg
A doc/supported_hw/supported_prog/Openmoko_0002.jpg
D doc/supported_hw/supported_prog/Openmoko_0003.jpeg
A doc/supported_hw/supported_prog/Openmoko_0003.jpg
M doc/supported_hw/supported_prog/Via_epia_m700_bios.jpg
M doc/supported_hw/supported_prog/Via_epia_m700_programer.jpg
M doc/supported_hw/supported_prog/ft2232_spi.rst
M doc/user_docs/1200px-DIP_socket_as_SOIC_clip.jpg
M doc/user_docs/Amd_am29f010_tsop32.jpg
M doc/user_docs/Dip32_chip_back.jpg
M doc/user_docs/Dip32_in_socket.jpg
M doc/user_docs/Dip8_chip.jpg
M doc/user_docs/Dip_tool.jpg
M doc/user_docs/Dual_plcc32_soldered.jpg
M doc/user_docs/Empty_dip32_socket.jpg
M doc/user_docs/Empty_dip8_socket.jpg
M doc/user_docs/Empty_plcc32_socket.jpg
M doc/user_docs/Flash-BGA.jpg
M doc/user_docs/Plcc32_chip.jpg
M doc/user_docs/Plcc32_chip_back.jpg
M doc/user_docs/Plcc32_in_socket.jpg
M doc/user_docs/Plcc_tool.jpg
M doc/user_docs/Soic8_chip.jpg
M doc/user_docs/Soic8_socket_back.jpg
M doc/user_docs/Soic8_socket_front_closed.jpg
M doc/user_docs/Soic8_socket_half_opened.jpg
M doc/user_docs/Soic8_socket_open.jpg
M doc/user_docs/Soic8_socket_with_chip.jpg
M doc/user_docs/Soic8_socket_with_chip_inserted.jpg
M doc/user_docs/Soldered_plcc32.jpg
M doc/user_docs/Soldered_tsop40.jpg
M doc/user_docs/Soldered_tsop48.jpg
M doc/user_docs/Spi-socket-dscn2913-1024x768.jpg
M doc/user_docs/Sst_39vf040_tsop32.jpg
44 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/45/85445/3
--
To view, visit https://review.coreboot.org/c/flashrom/+/85445?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I76768d94540f15d929537c73e232b035cf081c7b
Gerrit-Change-Number: 85445
Gerrit-PatchSet: 3
Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org>
Attention is currently required from: Peter Marheine.
Anastasia Klimchuk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/85445?usp=email )
Change subject: doc: Reduce size of images in docs
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/85445/comment/9844b4d4_001584fb?us… :
PS1, Line 11: 1024x768 and within 128Kb whenever possible
> Would it be useful to include this as a guideline somewhere in developer docs, to suggest to future […]
Yes good idea! And we have a doc: `doc/how_to_add_docs.rst` I added a note about size there
--
To view, visit https://review.coreboot.org/c/flashrom/+/85445?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I76768d94540f15d929537c73e232b035cf081c7b
Gerrit-Change-Number: 85445
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Comment-Date: Tue, 03 Dec 2024 04:46:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org>
Attention is currently required from: Anastasia Klimchuk.
Hello Peter Marheine, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/85445?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: doc: Reduce size of images in docs
......................................................................
doc: Reduce size of images in docs
Since the docs are now in the tree, so are the images in docs.
The patch reduces the size of images to be under control: target
1024x768 and within 128Kb whenever possible (which is possible for
almost all of them).
The patch reduces the size of the tarball from ~10M to ~4M
Change-Id: I76768d94540f15d929537c73e232b035cf081c7b
Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org>
---
M doc/how_to_add_docs.rst
M doc/supported_hw/supported_prog/Buspirate_v3_back.jpg
M doc/supported_hw/supported_prog/Buspirate_v3_front.jpg
M doc/supported_hw/supported_prog/Dlp_usb1232h_bottom.jpg
M doc/supported_hw/supported_prog/Dlp_usb1232h_side.jpg
M doc/supported_hw/supported_prog/Dlp_usb1232h_spi_programmer_breadboard_1.jpg
M doc/supported_hw/supported_prog/Dlp_usb1232h_spi_programmer_breadboard_2.jpg
M doc/supported_hw/supported_prog/Ft2232spi_programer.jpg
D doc/supported_hw/supported_prog/Openmoko_0001.jpeg
A doc/supported_hw/supported_prog/Openmoko_0001.jpg
D doc/supported_hw/supported_prog/Openmoko_0002.jpeg
A doc/supported_hw/supported_prog/Openmoko_0002.jpg
D doc/supported_hw/supported_prog/Openmoko_0003.jpeg
A doc/supported_hw/supported_prog/Openmoko_0003.jpg
M doc/supported_hw/supported_prog/Via_epia_m700_bios.jpg
M doc/supported_hw/supported_prog/Via_epia_m700_programer.jpg
M doc/supported_hw/supported_prog/ft2232_spi.rst
M doc/user_docs/1200px-DIP_socket_as_SOIC_clip.jpg
M doc/user_docs/Amd_am29f010_tsop32.jpg
M doc/user_docs/Dip32_chip_back.jpg
M doc/user_docs/Dip32_in_socket.jpg
M doc/user_docs/Dip8_chip.jpg
M doc/user_docs/Dip_tool.jpg
M doc/user_docs/Dual_plcc32_soldered.jpg
M doc/user_docs/Empty_dip32_socket.jpg
M doc/user_docs/Empty_dip8_socket.jpg
M doc/user_docs/Empty_plcc32_socket.jpg
M doc/user_docs/Flash-BGA.jpg
M doc/user_docs/Plcc32_chip.jpg
M doc/user_docs/Plcc32_chip_back.jpg
M doc/user_docs/Plcc32_in_socket.jpg
M doc/user_docs/Plcc_tool.jpg
M doc/user_docs/Soic8_chip.jpg
M doc/user_docs/Soic8_socket_back.jpg
M doc/user_docs/Soic8_socket_front_closed.jpg
M doc/user_docs/Soic8_socket_half_opened.jpg
M doc/user_docs/Soic8_socket_open.jpg
M doc/user_docs/Soic8_socket_with_chip.jpg
M doc/user_docs/Soic8_socket_with_chip_inserted.jpg
M doc/user_docs/Soldered_plcc32.jpg
M doc/user_docs/Soldered_tsop40.jpg
M doc/user_docs/Soldered_tsop48.jpg
M doc/user_docs/Spi-socket-dscn2913-1024x768.jpg
M doc/user_docs/Sst_39vf040_tsop32.jpg
44 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/45/85445/2
--
To view, visit https://review.coreboot.org/c/flashrom/+/85445?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I76768d94540f15d929537c73e232b035cf081c7b
Gerrit-Change-Number: 85445
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Attention is currently required from: Anastasia Klimchuk.
Peter Marheine has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/85445?usp=email )
Change subject: doc: Reduce size of images in docs
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
I like how Gerrit will show a diff for images, so it's easy to see that making these smaller doesn't compromise legibility.
Commit Message:
https://review.coreboot.org/c/flashrom/+/85445/comment/86d9a998_f952566d?us… :
PS1, Line 11: 1024x768 and within 128Kb whenever possible
Would it be useful to include this as a guideline somewhere in developer docs, to suggest to future reviewers that images should be small within reason?
--
To view, visit https://review.coreboot.org/c/flashrom/+/85445?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I76768d94540f15d929537c73e232b035cf081c7b
Gerrit-Change-Number: 85445
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Comment-Date: Tue, 03 Dec 2024 04:13:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No