December 2024 - flashrom-gerrit

[S] Change in flashrom[1.5.x]: doc: Add section about v1.5.1 into release notes
by Anastasia Klimchuk (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Matt DeVillier, Peter Marheine. Hello Matt DeVillier, Peter Marheine, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/85655?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: doc: Add section about v1.5.1 into release notes ...................................................................... doc: Add section about v1.5.1 into release notes Change-Id: I80f8423133bf779093d57ea6928f09d9d377d20e Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M doc/release_notes/v_1_5.rst 1 file changed, 33 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/55/85655/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/85655?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: 1.5.x Gerrit-Change-Id: I80f8423133bf779093d57ea6928f09d9d377d20e Gerrit-Change-Number: 85655 Gerrit-PatchSet: 4 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org>

1 0

[S] Change in flashrom[1.5.x]: doc: Add section about v1.5.1 into release notes
by Anastasia Klimchuk (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Matt DeVillier, Peter Marheine. Anastasia Klimchuk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/85655?usp=email ) Change subject: doc: Add section about v1.5.1 into release notes ...................................................................... Patch Set 3: (3 comments) Patchset: PS2: > > The wording I tried to make such that I don't need to return back and change after putting a tag ( […] Yes, that was what I was worried about: the tarball will be a bit later. But if you are saying it's fine, all good then! Patchset: PS3: I made another patch on the top of this, which changes the VERSION , since there is nothing more left to do File doc/release_notes/v_1_5.rst: https://review.coreboot.org/c/flashrom/+/85655/comment/cc598115_7c6039dc?us… : PS2, Line 38: v1.5.1 can be downloaded in the same location, same fingerprint. Tarball name will be ``flashrom-v1.5.1.tar.xz``. > Forgot to include the git tag names, but I think those should also be included near the tarball link […] Yes this looks much better, thank you so much for help! I did as you suggested, only one thing on the top: I added a paragraph about users who are affected (the paragraph was in patchset2) -- To view, visit https://review.coreboot.org/c/flashrom/+/85655?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: 1.5.x Gerrit-Change-Id: I80f8423133bf779093d57ea6928f09d9d377d20e Gerrit-Change-Number: 85655 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Fri, 20 Dec 2024 05:01:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org>

1 0

[XS] Change in flashrom[1.5.x]: VERSION: Update version to v1.5.1
by Anastasia Klimchuk (Code Review) 20 Dec '24

20 Dec '24

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/85688?usp=email ) Change subject: VERSION: Update version to v1.5.1 ...................................................................... VERSION: Update version to v1.5.1 Change-Id: I6cfc5ff2fa3c168f0fce04e1abbd7e834c853c5f Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M VERSION 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/88/85688/1 diff --git a/VERSION b/VERSION index 2e7bd91..53b5bbb 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -v1.5.0 +v1.5.1 -- To view, visit https://review.coreboot.org/c/flashrom/+/85688?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: flashrom Gerrit-Branch: 1.5.x Gerrit-Change-Id: I6cfc5ff2fa3c168f0fce04e1abbd7e834c853c5f Gerrit-Change-Number: 85688 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[1.5.x]: doc: Add section about v1.5.1 into release notes
by Anastasia Klimchuk (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Anastasia Klimchuk, Matt DeVillier. Hello Matt DeVillier, Peter Marheine, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/85655?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: doc: Add section about v1.5.1 into release notes ...................................................................... doc: Add section about v1.5.1 into release notes Change-Id: I80f8423133bf779093d57ea6928f09d9d377d20e Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M doc/release_notes/v_1_5.rst 1 file changed, 32 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/55/85655/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/85655?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: 1.5.x Gerrit-Change-Id: I80f8423133bf779093d57ea6928f09d9d377d20e Gerrit-Change-Number: 85655 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[1.5.x]: doc: Add section about v1.5.1 into release notes
by Peter Marheine (Code Review) 19 Dec '24

19 Dec '24

Attention is currently required from: Anastasia Klimchuk, Matt DeVillier. Peter Marheine has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/85655?usp=email ) Change subject: doc: Add section about v1.5.1 into release notes ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > The wording I tried to make such that I don't need to return back and change after putting a tag (which we usually do with main releases). That's reasonable, but as long as we know what we want the URL to be I think it's fine to have a short window where there's a link that doesn't work. Better to make everything explicit, I think. -- To view, visit https://review.coreboot.org/c/flashrom/+/85655?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: 1.5.x Gerrit-Change-Id: I80f8423133bf779093d57ea6928f09d9d377d20e Gerrit-Change-Number: 85655 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 19 Dec 2024 23:38:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[1.5.x]: doc: Add section about v1.5.1 into release notes
by Peter Marheine (Code Review) 19 Dec '24

19 Dec '24

Attention is currently required from: Anastasia Klimchuk, Matt DeVillier. Peter Marheine has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/85655?usp=email ) Change subject: doc: Add section about v1.5.1 into release notes ...................................................................... Patch Set 2: (1 comment) File doc/release_notes/v_1_5.rst: https://review.coreboot.org/c/flashrom/+/85655/comment/e801b007_69542160?us… : PS2, Line 38: v1.5.1 can be downloaded in the same location, same fingerprint. Tarball name will be ``flashrom-v1.5.1.tar.xz``. > I'd prefer to include the links so readers don't need to manually munge the URL, and put them up in […] Forgot to include the git tag names, but I think those should also be included near the tarball links. So something like ``` Git tag: v1.5.1 Tarball: ... ... Git tag: v1.5.0 Tarball: ... ``` -- To view, visit https://review.coreboot.org/c/flashrom/+/85655?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: 1.5.x Gerrit-Change-Id: I80f8423133bf779093d57ea6928f09d9d377d20e Gerrit-Change-Number: 85655 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 19 Dec 2024 23:33:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org>

1 0

[S] Change in flashrom[1.5.x]: doc: Add section about v1.5.1 into release notes
by Peter Marheine (Code Review) 19 Dec '24

19 Dec '24

Attention is currently required from: Anastasia Klimchuk, Matt DeVillier. Peter Marheine has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/85655?usp=email ) Change subject: doc: Add section about v1.5.1 into release notes ...................................................................... Patch Set 2: (1 comment) File doc/release_notes/v_1_5.rst: https://review.coreboot.org/c/flashrom/+/85655/comment/373ebe44_13fe376c?us… : PS2, Line 38: v1.5.1 can be downloaded in the same location, same fingerprint. Tarball name will be ``flashrom-v1.5.1.tar.xz``. I'd prefer to include the links so readers don't need to manually munge the URL, and put them up in the Download section above so it's very obvious that 1.5.1 is the newest. Something like: ``` Download ======== flashrom v1.5 can be downloaded either via anonymous git at https://review.coreboot.org/flashrom.git, or as signed source tarballs. The key fingerprint for source tarballs is 6E6E F9A0 BA47 8006 E277 6E4C C037 BB41 3134 D111. Version 1.5.1 ------------- Version 1.5.1 fixed an issue flashing some Intel-based platforms with the internal programmer that was introduced in 1.5.0. All users are encouraged to update. Tarball: https://download.flashrom.org/releases/flashrom-v1.5.1.tar.xz Signature: https://download.flashrom.org/releases/flashrom-v1.5.1.tar.xz.asc Version 1.5.0 ------------- Tarball: https://download.flashrom.org/releases/flashrom-v1.5.0.tar.xz Signature: https://download.flashrom.org/releases/flashrom-v1.5.0.tar.xz.asc ``` -- To view, visit https://review.coreboot.org/c/flashrom/+/85655?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: 1.5.x Gerrit-Change-Id: I80f8423133bf779093d57ea6928f09d9d377d20e Gerrit-Change-Number: 85655 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 19 Dec 2024 23:30:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in flashrom[1.5.x]: doc: Add section about v1.5.1 into release notes
by Anastasia Klimchuk (Code Review) 19 Dec '24

19 Dec '24

Attention is currently required from: Matt DeVillier, Peter Marheine. Anastasia Klimchuk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/85655?usp=email ) Change subject: doc: Add section about v1.5.1 into release notes ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Peter, thank you so much for review! The wording I tried to make such that I don't need to return back and change after putting a tag (which we usually do with main releases). I will later cherry-pick to main, so that it can be published on the website. But that will be after the tag. -- To view, visit https://review.coreboot.org/c/flashrom/+/85655?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: 1.5.x Gerrit-Change-Id: I80f8423133bf779093d57ea6928f09d9d377d20e Gerrit-Change-Number: 85655 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Thu, 19 Dec 2024 20:16:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in flashrom[1.5.x]: doc: Add section about v1.5.1 into release notes
by Matt DeVillier (Code Review) 19 Dec '24

19 Dec '24

Attention is currently required from: Anastasia Klimchuk. Matt DeVillier has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/85655?usp=email ) Change subject: doc: Add section about v1.5.1 into release notes ...................................................................... Patch Set 2: (1 comment) File doc/release_notes/v_1_5.rst: https://review.coreboot.org/c/flashrom/+/85655/comment/0245a752_607087a8?us… : PS1, Line 34: <TODO ADD WHO IS AFFECTED> > Matt, do you remember we discussed that you can help with writing this piece? :) I appreciate your h […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/85655?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: 1.5.x Gerrit-Change-Id: I80f8423133bf779093d57ea6928f09d9d377d20e Gerrit-Change-Number: 85655 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 19 Dec 2024 18:10:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: doc: Add section about v1.5.1 into release notes
by Matt DeVillier (Code Review) 19 Dec '24

19 Dec '24

Matt DeVillier has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/85679?usp=email ) Change subject: doc: Add section about v1.5.1 into release notes ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/85679?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I80f8423133bf779093d57ea6928f09d9d377d20e Gerrit-Change-Number: 85679 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit December 2024