December 2024 - flashrom-gerrit

[M] Change in flashrom[main]: Extract SPI declarations to the correct header
by Anastasia Klimchuk (Code Review) 12 Dec '24

12 Dec '24

Attention is currently required from: Antonio Vázquez Blanco, David Reguera Garcia (Dreg), Matti Finder, Miklós Márton, Nikolai Artemiev, Sergii Dmytruk. Anastasia Klimchuk has posted comments on this change by Antonio Vázquez Blanco. ( https://review.coreboot.org/c/flashrom/+/85539?usp=email ) Change subject: Extract SPI declarations to the correct header ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: This is a nice clean up across the tree, thank you everyone! Commit Message: https://review.coreboot.org/c/flashrom/+/85539/comment/659c3b9d_3bd65290?us… : PS2, Line 8: My only comment here is that now that the patch goes across the whole tree, maybe you can add to a commit description, to mention that after moving spi declarations some of the file don't need to include flash.h because spi.h is sufficient, and so includes of flash.h are removed where they are unnecessary. -- To view, visit https://review.coreboot.org/c/flashrom/+/85539?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I794a71536a3b85fde39f83c802fa0f5dd8d428e0 Gerrit-Change-Number: 85539 Gerrit-PatchSet: 2 Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: David Reguera Garcia (Dreg) <regueragarciadavid(a)gmail.com> Gerrit-Reviewer: Matti Finder <matti.finder(a)gmail.com> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: David Reguera Garcia (Dreg) <regueragarciadavid(a)gmail.com> Gerrit-Attention: Matti Finder <matti.finder(a)gmail.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Thu, 12 Dec 2024 12:00:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in flashrom[main]: Add Glasgow to supported serprog programmers documentation
by Anastasia Klimchuk (Code Review) 12 Dec '24

12 Dec '24

Attention is currently required from: cattusqq(a)gmail.com. Anastasia Klimchuk has posted comments on this change by cattusqq(a)gmail.com. ( https://review.coreboot.org/c/flashrom/+/85527?usp=email ) Change subject: Add Glasgow to supported serprog programmers documentation ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: One more thing I forgot: in the email from Gerrit your name is "Name of user not set". I think you need to do p.6 from here https://flashrom.org/dev_guide/development_guide.html#creating-an-account -- To view, visit https://review.coreboot.org/c/flashrom/+/85527?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Iabcec27dd675485c69875178858c604ce5c3da29 Gerrit-Change-Number: 85527 Gerrit-PatchSet: 1 Gerrit-Owner: cattusqq(a)gmail.com Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: cattusqq(a)gmail.com Gerrit-Comment-Date: Thu, 12 Dec 2024 08:57:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in flashrom[main]: Add Glasgow to supported serprog programmers documentation
by Anastasia Klimchuk (Code Review) 12 Dec '24

12 Dec '24

Attention is currently required from: cattusqq(a)gmail.com. Anastasia Klimchuk has posted comments on this change by cattusqq(a)gmail.com. ( https://review.coreboot.org/c/flashrom/+/85527?usp=email ) Change subject: Add Glasgow to supported serprog programmers documentation ...................................................................... Patch Set 1: (5 comments) Patchset: PS1: Cattus, thank you for the contribution, and nice to meet you. I read your post, I like it so much, very detailed information, it's just great! - I held my breath when I read that the chip was not recognised... But then I kept reading and there was a happy ending at the end :) - Somewhere in the middle there was a link on how to "write a mapping for flashrom", just wanted to say we also have a doc on this https://flashrom.org/contrib_howtos/how_to_add_new_chip.html. We did split a giant flashchips.c into a per-vendor file recently. - If you want you can try to enable write-protection capability for the chip: because you have the datasheet and the actual chip. There is a section about it in the doc: https://flashrom.org/contrib_howtos/how_to_add_new_chip.html#write-protecti…. For the examples, look for the chip definitions that have test status TEST_OK_PREWB Commit Message: https://review.coreboot.org/c/flashrom/+/85527/comment/1e9bc633_fd397b83?us… : PS1, Line 10: the project wouldnt compile with meson for me (MacOS 15.1) I first thought that flashrom does not compile, but then I read your blog post and now I think maybe that's the documentation did not compile? I downloaded your patch and built with documentation, and so I added two comments (as you see below). https://review.coreboot.org/c/flashrom/+/85527/comment/18e71279_d6bdcb84?us… : PS1, Line 9: Updated the serprog overview page with info about the Glasgow Interface Explorer as a valid programmer. : Wasnt able to test as the project wouldnt compile with meson for me (MacOS 15.1) : but tried to make it as similar as possible to what was already there. We wrap commit message by 72 chars, and I think the first line is longer (maybe the second one too) https://flashrom.org/dev_guide/development_guide.html#commit-message-1 File doc/supported_hw/supported_prog/serprog/overview.rst: https://review.coreboot.org/c/flashrom/+/85527/comment/80bf589f_616b08ef?us… : PS1, Line 105: Source for the Glasgow Project can be found `here <https://github.com/GlasgowEmbedded/glasgow>`_ This gives a warning `WARNING: Duplicate explicit target name: "here".` So maybe you can change slightly, for example Here is the <source for the Glasgow Project> (in <> brackets would be the link text) https://review.coreboot.org/c/flashrom/+/85527/comment/edef2f8e_6a300892?us… : PS1, Line 108: 76hPuPkpDOTAxj7TegVqV8UkmKEjZ8TvLLBoDoVPpw What is this hash? :) I assume that's by mistake? -- To view, visit https://review.coreboot.org/c/flashrom/+/85527?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Iabcec27dd675485c69875178858c604ce5c3da29 Gerrit-Change-Number: 85527 Gerrit-PatchSet: 1 Gerrit-Owner: cattusqq(a)gmail.com Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: cattusqq(a)gmail.com Gerrit-Comment-Date: Thu, 12 Dec 2024 08:56:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in flashrom[main]: Extract SPI declarations to the correct header
by Peter Marheine (Code Review) 09 Dec '24

09 Dec '24

Attention is currently required from: Anastasia Klimchuk, Antonio Vázquez Blanco, David Reguera Garcia (Dreg), Matti Finder, Miklós Márton, Nikolai Artemiev, Sergii Dmytruk. Peter Marheine has posted comments on this change by Antonio Vázquez Blanco. ( https://review.coreboot.org/c/flashrom/+/85539?usp=email ) Change subject: Extract SPI declarations to the correct header ...................................................................... Patch Set 2: (2 comments) File edi.c: https://review.coreboot.org/c/flashrom/+/85539/comment/107cd861_f79f24d4?us… : PS2, Line 18: #include <spi.h> These are not system includes, so the newly-added lines should still be quoted (`"spi.h"`). That goes for all of these `<spi.h>` occurrences. File include/spi.h: https://review.coreboot.org/c/flashrom/+/85539/comment/8e57b371_0609e974?us… : PS2, Line 19: #include <flash.h> Same as for `spi.h`, quote this instead of using angle brackets. -- To view, visit https://review.coreboot.org/c/flashrom/+/85539?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I794a71536a3b85fde39f83c802fa0f5dd8d428e0 Gerrit-Change-Number: 85539 Gerrit-PatchSet: 2 Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: David Reguera Garcia (Dreg) <regueragarciadavid(a)gmail.com> Gerrit-Reviewer: Matti Finder <matti.finder(a)gmail.com> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: David Reguera Garcia (Dreg) <regueragarciadavid(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Matti Finder <matti.finder(a)gmail.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Mon, 09 Dec 2024 22:23:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in flashrom[main]: Extract SPI declarations to the correct header
by Antonio Vázquez Blanco (Code Review) 09 Dec '24

09 Dec '24

Attention is currently required from: Anastasia Klimchuk, David Reguera Garcia (Dreg), Matti Finder, Miklós Márton, Nikolai Artemiev, Peter Marheine, Sergii Dmytruk. Antonio Vázquez Blanco has posted comments on this change by Antonio Vázquez Blanco. ( https://review.coreboot.org/c/flashrom/+/85539?usp=email ) Change subject: Extract SPI declarations to the correct header ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > Since you moved spi_send_command to spi.h the `#include "flash.h"` from rpmc.c can be removed. […] I hope I did not miss any... Thanks! -- To view, visit https://review.coreboot.org/c/flashrom/+/85539?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I794a71536a3b85fde39f83c802fa0f5dd8d428e0 Gerrit-Change-Number: 85539 Gerrit-PatchSet: 2 Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: David Reguera Garcia (Dreg) <regueragarciadavid(a)gmail.com> Gerrit-Reviewer: Matti Finder <matti.finder(a)gmail.com> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: David Reguera Garcia (Dreg) <regueragarciadavid(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Matti Finder <matti.finder(a)gmail.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Mon, 09 Dec 2024 20:41:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matti Finder <matti.finder(a)gmail.com>

1 0

[M] Change in flashrom[main]: Extract SPI declarations to the correct header
by Antonio Vázquez Blanco (Code Review) 09 Dec '24

09 Dec '24

Attention is currently required from: Anastasia Klimchuk, Antonio Vázquez Blanco. Hello Anastasia Klimchuk, Matti Finder, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/85539?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: Extract SPI declarations to the correct header ...................................................................... Extract SPI declarations to the correct header Change-Id: I794a71536a3b85fde39f83c802fa0f5dd8d428e0 Signed-off-by: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> --- M amd_imc.c M at45db.c M bitbang_spi.c M buspirate_spi.c M dediprog.c M dummyflasher.c M edi.c M ft2232_spi.c M ichspi.c M include/flash.h M include/programmer.h M include/spi.h M it87spi.c M jlink_spi.c M linux_spi.c M mediatek_i2c_spi.c M mstarddc_spi.c M ni845x_spi.c M nicintel_eeprom.c M pickit2_spi.c M rpmc.c M sb600spi.c M sfdp.c M spi.c M spi25.c M spi25_statusreg.c M stlinkv3_spi.c M usbblaster_spi.c M wbsio_spi.c M writeprotect.c 30 files changed, 17 insertions(+), 41 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/39/85539/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/85539?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I794a71536a3b85fde39f83c802fa0f5dd8d428e0 Gerrit-Change-Number: 85539 Gerrit-PatchSet: 2 Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Matti Finder <matti.finder(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: Extract SPI declarations to the correct header
by Matti Finder (Code Review) 09 Dec '24

09 Dec '24

Attention is currently required from: Anastasia Klimchuk, Antonio Vázquez Blanco. Matti Finder has posted comments on this change by Antonio Vázquez Blanco. ( https://review.coreboot.org/c/flashrom/+/85539?usp=email ) Change subject: Extract SPI declarations to the correct header ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Since you moved spi_send_command to spi.h the `#include "flash.h"` from rpmc.c can be removed. This is probably also the case in edi.c and also a lot of other files within flashrom. I think changing them within this commit would make sense, so that this doesn't get missed later. -- To view, visit https://review.coreboot.org/c/flashrom/+/85539?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I794a71536a3b85fde39f83c802fa0f5dd8d428e0 Gerrit-Change-Number: 85539 Gerrit-PatchSet: 1 Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Matti Finder <matti.finder(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 09 Dec 2024 13:03:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in flashrom[main]: Extract SPI declarations to the correct header
by Antonio Vázquez Blanco (Code Review) 09 Dec '24

09 Dec '24

Antonio Vázquez Blanco has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/85539?usp=email ) Change subject: Extract SPI declarations to the correct header ...................................................................... Extract SPI declarations to the correct header Change-Id: I794a71536a3b85fde39f83c802fa0f5dd8d428e0 Signed-off-by: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> --- M edi.c M include/flash.h M include/programmer.h M include/spi.h M rpmc.c M spi.c 6 files changed, 17 insertions(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/39/85539/1 diff --git a/edi.c b/edi.c index 56ed62c..0d504e7 100644 --- a/edi.c +++ b/edi.c @@ -15,6 +15,7 @@ */ #include <string.h> +#include <spi.h> #include "flash.h" #include "chipdrivers.h" #include "ene.h" diff --git a/include/flash.h b/include/flash.h index 629ef3a..f5ec4da 100644 --- a/include/flash.h +++ b/include/flash.h @@ -758,17 +758,6 @@ void init_progress(struct flashctx *flash, enum flashrom_progress_stage stage, size_t total); void update_progress(struct flashctx *flash, enum flashrom_progress_stage stage, size_t increment); -/* spi.c */ -struct spi_command { - unsigned int writecnt; - unsigned int readcnt; - const unsigned char *writearr; - unsigned char *readarr; -}; -#define NULL_SPI_CMD { 0, 0, NULL, NULL, } -int spi_send_command(const struct flashctx *flash, unsigned int writecnt, unsigned int readcnt, const unsigned char *writearr, unsigned char *readarr); -int spi_send_multicommand(const struct flashctx *flash, struct spi_command *cmds); - enum chipbustype get_buses_supported(void); #endif /* !__FLASH_H__ */ diff --git a/include/programmer.h b/include/programmer.h index babb0bc..4784be1 100644 --- a/include/programmer.h +++ b/include/programmer.h @@ -23,6 +23,7 @@ #include <stdbool.h> #include <stdint.h> +#include <spi.h> #include "flash.h" /* for chipaddr and flashctx */ enum programmer_type { diff --git a/include/spi.h b/include/spi.h index 505aecd..f5519d3 100644 --- a/include/spi.h +++ b/include/spi.h @@ -16,6 +16,8 @@ #ifndef __SPI_H__ #define __SPI_H__ 1 +#include <flash.h> + /* * Contains the generic SPI headers */ @@ -235,6 +237,16 @@ #define SPI_FLASHROM_BUG -5 #define SPI_PROGRAMMER_ERROR -6 +struct spi_command { + unsigned int writecnt; + unsigned int readcnt; + const unsigned char *writearr; + unsigned char *readarr; +}; +#define NULL_SPI_CMD { 0, 0, NULL, NULL, } +int spi_send_command(const struct flashctx *flash, unsigned int writecnt, unsigned int readcnt, const unsigned char *writearr, unsigned char *readarr); +int spi_send_multicommand(const struct flashctx *flash, struct spi_command *cmds); + void clear_spi_id_cache(void); #endif /* !__SPI_H__ */ diff --git a/rpmc.c b/rpmc.c index 72b0f2f..27e9332 100644 --- a/rpmc.c +++ b/rpmc.c @@ -23,6 +23,7 @@ #include <openssl/evp.h> #include <openssl/rand.h> #include <string.h> +#include <spi.h> // OP1 commands #define RPMC_WRITE_ROOT_KEY_MSG_LENGTH (RPMC_OP1_MSG_HEADER_LENGTH + RPMC_HMAC_KEY_LENGTH + RPMC_TRUNCATED_SIG_LENGTH) diff --git a/spi.c b/spi.c index b2ffc33..99f60fa 100644 --- a/spi.c +++ b/spi.c @@ -18,13 +18,13 @@ * Contains the generic SPI framework */ +#include <spi.h> + #include <strings.h> #include <string.h> -#include "flash.h" #include "flashchips.h" #include "chipdrivers.h" #include "programmer.h" -#include "spi.h" static int default_spi_send_command(const struct flashctx *flash, unsigned int writecnt, unsigned int readcnt, -- To view, visit https://review.coreboot.org/c/flashrom/+/85539?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I794a71536a3b85fde39f83c802fa0f5dd8d428e0 Gerrit-Change-Number: 85539 Gerrit-PatchSet: 1 Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com>

1 0

[XS] Change in flashrom[main]: Extract programmer declarations to the correct header
by Antonio Vázquez Blanco (Code Review) 09 Dec '24

09 Dec '24

Antonio Vázquez Blanco has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/85538?usp=email ) Change subject: Extract programmer declarations to the correct header ...................................................................... Extract programmer declarations to the correct header Change-Id: Ib37b33417154f666d7f72a904381cdf32f6ecc77 Signed-off-by: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> --- M include/flash.h M include/programmer.h 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/38/85538/1 diff --git a/include/flash.h b/include/flash.h index 629ef3a..a845186 100644 --- a/include/flash.h +++ b/include/flash.h @@ -769,6 +769,4 @@ int spi_send_command(const struct flashctx *flash, unsigned int writecnt, unsigned int readcnt, const unsigned char *writearr, unsigned char *readarr); int spi_send_multicommand(const struct flashctx *flash, struct spi_command *cmds); -enum chipbustype get_buses_supported(void); - #endif /* !__FLASH_H__ */ diff --git a/include/programmer.h b/include/programmer.h index babb0bc..e0630b8 100644 --- a/include/programmer.h +++ b/include/programmer.h @@ -526,4 +526,6 @@ (flash->chip->feature_bits & (FEATURE_4BA_ENTER | FEATURE_4BA_ENTER_WREN | FEATURE_4BA_ENTER_EAR7)); } +enum chipbustype get_buses_supported(void); + #endif /* !__PROGRAMMER_H__ */ -- To view, visit https://review.coreboot.org/c/flashrom/+/85538?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ib37b33417154f666d7f72a904381cdf32f6ecc77 Gerrit-Change-Number: 85538 Gerrit-PatchSet: 1 Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com>

1 0

[S] Change in flashrom[main]: Add Glasgow to supported serprog programmers documentation
by Name of user not set (Code Review) 07 Dec '24

07 Dec '24

cattusqq(a)gmail.com has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/85527?usp=email ) Change subject: Add Glasgow to supported serprog programmers documentation ...................................................................... Add Glasgow to supported serprog programmers documentation Updated the serprog overview page with info about the Glasgow Interface Explorer as a valid programmer. Wasnt able to test as the project wouldnt compile with meson for me (MacOS 15.1) but tried to make it as similar as possible to what was already there. Change-Id: Iabcec27dd675485c69875178858c604ce5c3da29 Signed-off-by: Cattus QQ <cattusqq(a)gmail.com> --- A doc/supported_hw/supported_prog/serprog/300px-glasgow-in-case.png A doc/supported_hw/supported_prog/serprog/300px-glasgow-pcba.png M doc/supported_hw/supported_prog/serprog/overview.rst 3 files changed, 13 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/27/85527/1 diff --git a/doc/supported_hw/supported_prog/serprog/300px-glasgow-in-case.png b/doc/supported_hw/supported_prog/serprog/300px-glasgow-in-case.png new file mode 100644 index 0000000..8630424 --- /dev/null +++ b/doc/supported_hw/supported_prog/serprog/300px-glasgow-in-case.png Binary files differ diff --git a/doc/supported_hw/supported_prog/serprog/300px-glasgow-pcba.png b/doc/supported_hw/supported_prog/serprog/300px-glasgow-pcba.png new file mode 100644 index 0000000..b06bb9f --- /dev/null +++ b/doc/supported_hw/supported_prog/serprog/300px-glasgow-pcba.png Binary files differ diff --git a/doc/supported_hw/supported_prog/serprog/overview.rst b/doc/supported_hw/supported_prog/serprog/overview.rst index ba01b02..6088414 100644 --- a/doc/supported_hw/supported_prog/serprog/overview.rst +++ b/doc/supported_hw/supported_prog/serprog/overview.rst @@ -93,3 +93,16 @@ `Riku_V's fork <https://codeberg.org/Riku_V/pico-serprog>`_ which uses the hardware SPI implementation instead of SPI over PIO (programmable IO) which sacrifices arbitrary pinouts. The fork also implements custom USB descriptors which allow for custom udev-rules. + +Glasgow Interface Explorer by Whitequark +======================================== + +.. image:: 300px-glasgow-in-case.png +.. image:: 300px-glasgow-pcba.png + +The Glasgow Interface Explorer is a tool for programming, debugging, and analysing digital electronics. +It is based on an FPGA and a microcontroller, and can be used as a serprog programmer. +Source for the Glasgow Project can be found `here <https://github.com/GlasgowEmbedded/glasgow>`_. +For example use with Flashrom and serprog, see `this blog post <https://cattusqq.github.io/posts/Firmware_Dumping_with_SPI/>`_. + +76hPuPkpDOTAxj7TegVqV8UkmKEjZ8TvLLBoDoVPpw \ No newline at end of file -- To view, visit https://review.coreboot.org/c/flashrom/+/85527?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Iabcec27dd675485c69875178858c604ce5c3da29 Gerrit-Change-Number: 85527 Gerrit-PatchSet: 1 Gerrit-Owner: cattusqq(a)gmail.com

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit December 2024