December 2024 - flashrom-gerrit

[XS] Change in flashrom[main]: ichspi: Check whether chipset is locked when probing opcode
by Nikolai Artemiev (Code Review) 16 Dec '24

16 Dec '24

Attention is currently required from: Anastasia Klimchuk, Bill XIE. Nikolai Artemiev has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/85592?usp=email ) Change subject: ichspi: Check whether chipset is locked when probing opcode ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/85592?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I701a86f030cfef43a1158bf075287ade569254e6 Gerrit-Change-Number: 85592 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 16 Dec 2024 03:49:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in flashrom[main]: ichspi: Check whether chipset is locked when probing opcode
by Stefan Reinauer (Code Review) 16 Dec '24

16 Dec '24

Attention is currently required from: Anastasia Klimchuk, Bill XIE, Nikolai Artemiev. Stefan Reinauer has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/85592?usp=email ) Change subject: ichspi: Check whether chipset is locked when probing opcode ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/85592?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I701a86f030cfef43a1158bf075287ade569254e6 Gerrit-Change-Number: 85592 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Mon, 16 Dec 2024 00:02:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in flashrom[main]: Extract programmer declarations to the correct header
by Anastasia Klimchuk (Code Review) 15 Dec '24

15 Dec '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/85538?usp=email ) Change subject: Extract programmer declarations to the correct header ...................................................................... Extract programmer declarations to the correct header Change-Id: Ib37b33417154f666d7f72a904381cdf32f6ecc77 Signed-off-by: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/85538 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M include/flash.h M include/programmer.h 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Anastasia Klimchuk: Looks good to me, approved build bot (Jenkins): Verified diff --git a/include/flash.h b/include/flash.h index 629ef3a..a845186 100644 --- a/include/flash.h +++ b/include/flash.h @@ -769,6 +769,4 @@ int spi_send_command(const struct flashctx *flash, unsigned int writecnt, unsigned int readcnt, const unsigned char *writearr, unsigned char *readarr); int spi_send_multicommand(const struct flashctx *flash, struct spi_command *cmds); -enum chipbustype get_buses_supported(void); - #endif /* !__FLASH_H__ */ diff --git a/include/programmer.h b/include/programmer.h index babb0bc..e0630b8 100644 --- a/include/programmer.h +++ b/include/programmer.h @@ -526,4 +526,6 @@ (flash->chip->feature_bits & (FEATURE_4BA_ENTER | FEATURE_4BA_ENTER_WREN | FEATURE_4BA_ENTER_EAR7)); } +enum chipbustype get_buses_supported(void); + #endif /* !__PROGRAMMER_H__ */ -- To view, visit https://review.coreboot.org/c/flashrom/+/85538?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ib37b33417154f666d7f72a904381cdf32f6ecc77 Gerrit-Change-Number: 85538 Gerrit-PatchSet: 2 Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in flashrom[main]: ichspi: Check whether chipset is locked when probing opcode
by Matt DeVillier (Code Review) 15 Dec '24

15 Dec '24

Attention is currently required from: Anastasia Klimchuk, Bill XIE. Matt DeVillier has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/85592?usp=email ) Change subject: ichspi: Check whether chipset is locked when probing opcode ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > That's good news thank you! Did it make any difference for #573 (the issue you found)? sorry not sure why I wrote #556, I meant it resolves #573 😊 -- To view, visit https://review.coreboot.org/c/flashrom/+/85592?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I701a86f030cfef43a1158bf075287ade569254e6 Gerrit-Change-Number: 85592 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sun, 15 Dec 2024 00:09:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[XS] Change in flashrom[main]: ichspi: Check whether chipset is locked when probing opcode
by Anastasia Klimchuk (Code Review) 14 Dec '24

14 Dec '24

Attention is currently required from: Bill XIE, Matt DeVillier. Anastasia Klimchuk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/85592?usp=email ) Change subject: ichspi: Check whether chipset is locked when probing opcode ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > this resolves issue #556 for me That's good news thank you! Did it make any difference for #573 (the issue you found)? -- To view, visit https://review.coreboot.org/c/flashrom/+/85592?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I701a86f030cfef43a1158bf075287ade569254e6 Gerrit-Change-Number: 85592 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Sat, 14 Dec 2024 23:42:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>

1 0

[XS] Change in flashrom[main]: ichspi: Check whether chipset is locked when probing opcode
by Matt DeVillier (Code Review) 14 Dec '24

14 Dec '24

Attention is currently required from: Anastasia Klimchuk, Bill XIE. Matt DeVillier has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/85592?usp=email ) Change subject: ichspi: Check whether chipset is locked when probing opcode ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Patchset: PS3: this resolves issue #556 for me -- To view, visit https://review.coreboot.org/c/flashrom/+/85592?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I701a86f030cfef43a1158bf075287ade569254e6 Gerrit-Change-Number: 85592 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sat, 14 Dec 2024 15:54:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in flashrom[main]: ichspi: Check whether chipset is locked when probing opcode
by Anastasia Klimchuk (Code Review) 14 Dec '24

14 Dec '24

Attention is currently required from: Bill XIE, Matt DeVillier. Anastasia Klimchuk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/85592?usp=email ) Change subject: ichspi: Check whether chipset is locked when probing opcode ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: Hello Bill! Maybe you can have a look? There is a discussion in the ticket (with logs and everything), it would be so helpful if you could join. Thank you! -- To view, visit https://review.coreboot.org/c/flashrom/+/85592?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I701a86f030cfef43a1158bf075287ade569254e6 Gerrit-Change-Number: 85592 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Sat, 14 Dec 2024 10:05:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in flashrom[main]: ichspi: Check whether chipset is locked when probing opcode
by Anastasia Klimchuk (Code Review) 14 Dec '24

14 Dec '24

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/85592?usp=email to look at the new patch set (#3). Change subject: ichspi: Check whether chipset is locked when probing opcode ...................................................................... ichspi: Check whether chipset is locked when probing opcode This is follow up (or fix) for commit 26a1eb514ccefc61b110068cf0eea73c397ba045 When probing opcode, all opcodes in POSSIBLE_OPCODES are reported as supported, even if the opcode is not in curopcodes. This is relying on reprogramming on-the-fly to handle the gap between POSSIBLE_OPCODES and curopcodes. However, for locked chipsets on-the-fly is not happening (is not possible, since list of opcodes is locked), so we can't rely on it. So, we need to check whether chipset is locked. Ticket: https://ticket.coreboot.org/issues/573 Change-Id: I701a86f030cfef43a1158bf075287ade569254e6 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M ichspi.c 1 file changed, 6 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/92/85592/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/85592?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I701a86f030cfef43a1158bf075287ade569254e6 Gerrit-Change-Number: 85592 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in flashrom[main]: ichspi: Check whether chipset is locked when probing opcode
by Anastasia Klimchuk (Code Review) 14 Dec '24

14 Dec '24

Anastasia Klimchuk has uploaded a new patch set (#2). ( https://review.coreboot.org/c/flashrom/+/85592?usp=email ) Change subject: ichspi: Check whether chipset is locked when probing opcode ...................................................................... ichspi: Check whether chipset is locked when probing opcode This is follow up (or fix) for commit 26a1eb514ccefc61b110068cf0eea73c397ba045 When probing opcode, all opcodes in POSSIBLE_OPCODES are reported as supported, even if the opcode is not in curopcodes. This is relying on reprogramming on-the-fly to handle the gap between POSSIBLE_OPCODES and curopcodes. However, for locked chipsets on-the-fly is not happening (is not possible, since list of opcodes is locked), so we can't rely on it. So, we need to check whether chipset is locked. Change-Id: I701a86f030cfef43a1158bf075287ade569254e6 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M ichspi.c 1 file changed, 6 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/92/85592/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/85592?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I701a86f030cfef43a1158bf075287ade569254e6 Gerrit-Change-Number: 85592 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[XS] Change in flashrom[main]: ichspi: Check whether chipset is locked when probing opcode
by Anastasia Klimchuk (Code Review) 14 Dec '24

14 Dec '24

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/85592?usp=email ) Change subject: ichspi: Check whether chipset is locked when probing opcode ...................................................................... ichspi: Check whether chipset is locked when probing opcode This is follow up (or fix) for commit 26a1eb514ccefc61b110068cf0eea73c397ba045 When probing opcode, all opcodes in POSSIBLE_OPCODES are reported as supported, even if the opcode is not in curopcodes. This is relying on reprogramming on-the-fly to handle the gap between POSSIBLE_OPCODES and curopcodes. However, for locked chipsets on-the-fly is not happening (is not possible, since list of opcodes is locked), so we can't rely on it. So, we need to check whether chipset is locked. Change-Id: I701a86f030cfef43a1158bf075287ade569254e6 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M ichspi.c 1 file changed, 6 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/92/85592/1 diff --git a/ichspi.c b/ichspi.c index fc994db..94227de 100644 --- a/ichspi.c +++ b/ichspi.c @@ -1823,8 +1823,12 @@ static bool ich_spi_probe_opcode(const struct flashctx *flash, uint8_t opcode) { int ret = find_opcode(curopcodes, opcode); - if ((ret == -1) && (lookup_spi_type(opcode) <= 3)) - /* opcode is in POSSIBLE_OPCODES, report supported. */ + if ((ret == -1) && (lookup_spi_type(opcode) <= 3) && (!ichspi_lock)) + /* opcode is in POSSIBLE_OPCODES, report supported. + * Relying on reprogramming on-the-fly + * when opcode is not in curopcodes, but is in POSSIBLE_OPCODES. + * + * on-the-fly does not work for locked chipsets, therefore checking ichspi_lock. */ return true; return ret >= 0; } -- To view, visit https://review.coreboot.org/c/flashrom/+/85592?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I701a86f030cfef43a1158bf075287ade569254e6 Gerrit-Change-Number: 85592 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit December 2024