June 2023 - flashrom-gerrit - mail.coreboot.org

[S] Change in flashrom[master]: doc: Add build instructions for NI-845x on Windows
by Miklós Márton (Code Review) 05 Jun '23

05 Jun '23

Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Peter Marheine, Thomas Heijligen. Miklós Márton has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75270?usp=email ) Change subject: doc: Add build instructions for NI-845x on Windows ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/75270?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I97ad08632f35aa241b3d19d9ce7711146e3f1f4a Gerrit-Change-Number: 75270 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Mon, 05 Jun 2023 07:24:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips: Add support for Boya BY25D80A
by Peter Marheine (Code Review) 04 Jun '23

04 Jun '23

Attention is currently required from: Anastasia Klimchuk, Edward O'Callaghan, Piotr Halama, Thomas Heijligen. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73513?usp=email ) Change subject: flashchips: Add support for Boya BY25D80A ...................................................................... Patch Set 7: Code-Review+2 (1 comment) Patchset: PS7: > Peter, you have approved (3 months ago, but still :D ) , I just rebased the patch. […] Diff is unchanged, so no problem here. -- To view, visit https://review.coreboot.org/c/flashrom/+/73513?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I586f3455d925132bbda3fccdad00f0b1e22c2ea7 Gerrit-Change-Number: 73513 Gerrit-PatchSet: 7 Gerrit-Owner: Piotr Halama <skrzynka(a)halamix2.pl> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Piotr Halama <skrzynka(a)halamix2.pl> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sun, 04 Jun 2023 23:55:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: dirtyjtag: Add DirtyJTAG programmer
by David Williams (Code Review) 04 Jun '23

04 Jun '23

David Williams has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67878?usp=email ) Change subject: dirtyjtag: Add DirtyJTAG programmer ...................................................................... Patch Set 17: (1 comment) Patchset: PS17: There's a typo in the Makefile. We should be adding to FEATURE_FLAGS not FEATURE_CFLAGS. Without this, the interface *is never (has never?) been loaded* I wrote this up as an issue in github. https://github.com/flashrom/flashrom/issues/296 Now, when this bug is fixed, the interface doesn't seem to work. I'm reluctant to debug if this has never been run or tested by people more knowledgeable and skilled than me! -- To view, visit https://review.coreboot.org/c/flashrom/+/67878?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic43e9a014ed7d04e429e73b30c9dcfdde1a78913 Gerrit-Change-Number: 67878 Gerrit-PatchSet: 17 Gerrit-Owner: Jean THOMAS <virgule(a)jeanthomas.me> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: David Williams Gerrit-Comment-Date: Sun, 04 Jun 2023 23:17:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: doc: Add build instructions for NI-845x on Windows
by Peter Marheine (Code Review) 04 Jun '23

04 Jun '23

Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Miklós Márton, Thomas Heijligen. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75270?usp=email ) Change subject: doc: Add build instructions for NI-845x on Windows ...................................................................... Patch Set 5: (1 comment) File doc/dev_guide/building_from_source.rst: https://review.coreboot.org/c/flashrom/+/75270/comment/6c4d629f_c7ac684b : PS5, Line 17: * linux-headers† : * libpci† : * libusb1† : * libftdi1† : * libjaylink† : * NI-845x driver & library package‡ : : | \* optional, for building unit testing : | † optional, depending on the selected programmer : | ‡ optional, proprietary and Windows only. (See Windows build instructions) > How about using [Footnotes](https://www.sphinx-doc.org/en/master/usage/restructuredtext/basi…. […] I thought it made more sense to keep these near the list, since it seems unnecessarily difficult to scroll to the bottom of the page for these notes that don't really stand alone. It would be a different story if there were a footnote-but-place-it-after-this-paragraph construct, but there doesn't seem to be any such thing. The paragraph above does the same thing, so if we wanted to debate such a change it seems like something to do in another commit (and change both of them). -- To view, visit https://review.coreboot.org/c/flashrom/+/75270?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I97ad08632f35aa241b3d19d9ce7711146e3f1f4a Gerrit-Change-Number: 75270 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Sun, 04 Jun 2023 23:16:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips: add support for MX25V16066/KH25V16066
by Joseph Goh (Code Review) 04 Jun '23

04 Jun '23

Joseph Goh has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68278?usp=email ) Change subject: flashchips: add support for MX25V16066/KH25V16066 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Hello, no worries. Here is the datasheet I used: https://www.mxic.com.tw/Lists/Datasheet/Attachments/8879/MX25V16066,%202.5V… There is also an older version of datasheet: https://www.macronix.com.hk/Lists/Datasheet/Attachments/277/KH25V16066ver13… -- To view, visit https://review.coreboot.org/c/flashrom/+/68278?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic5f0548f023fcd09a970148586497e00414ad1ae Gerrit-Change-Number: 68278 Gerrit-PatchSet: 1 Gerrit-Owner: Joseph Goh <josephgoh7(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sun, 04 Jun 2023 06:27:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: doc: Add build instructions for NI-845x on Windows
by Alexander Goncharov (Code Review) 03 Jun '23

03 Jun '23

Attention is currently required from: Anastasia Klimchuk, Miklós Márton, Peter Marheine, Thomas Heijligen. Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75270?usp=email ) Change subject: doc: Add build instructions for NI-845x on Windows ...................................................................... Patch Set 5: (1 comment) File doc/dev_guide/building_from_source.rst: https://review.coreboot.org/c/flashrom/+/75270/comment/f300a9de_2dc23d3e : PS5, Line 17: * linux-headers† : * libpci† : * libusb1† : * libftdi1† : * libjaylink† : * NI-845x driver & library package‡ : : | \* optional, for building unit testing : | † optional, depending on the selected programmer : | ‡ optional, proprietary and Windows only. (See Windows build instructions) How about using [Footnotes](https://www.sphinx-doc.org/en/master/usage/restructuredtext/basi… over asterisks / unicode characters? -- To view, visit https://review.coreboot.org/c/flashrom/+/75270?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I97ad08632f35aa241b3d19d9ce7711146e3f1f4a Gerrit-Change-Number: 75270 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Sat, 03 Jun 2023 11:55:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips: reset a M25P10-A before a probe
by Anastasia Klimchuk (Code Review) 03 Jun '23

03 Jun '23

Attention is currently required from: Lubomir Rintel. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/23337?usp=email ) Change subject: flashchips: reset a M25P10-A before a probe ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Hello people on this patch, I have a question. Is anyone here interested to continue this work? Thanks! -- To view, visit https://review.coreboot.org/c/flashrom/+/23337?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I19a5332756d15b3cb74609c44a8d3fed2f4a2d68 Gerrit-Change-Number: 23337 Gerrit-PatchSet: 2 Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: Carl-Daniel Hailfinger <hailfinger(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Stefan T <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Comment-Date: Sat, 03 Jun 2023 11:06:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips: add support for ISSI IS25LP016
by Anastasia Klimchuk (Code Review) 03 Jun '23

03 Jun '23

Attention is currently required from: Angel Pons, Mario Kicherer, Nico Huber, Nikolai Artemiev. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68295?usp=email ) Change subject: flashchips: add support for ISSI IS25LP016 ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/68295?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iffd7c4284d4d96b30a94f5dee882b5403fdfc183 Gerrit-Change-Number: 68295 Gerrit-PatchSet: 4 Gerrit-Owner: Mario Kicherer Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Mario Kicherer Gerrit-Comment-Date: Sat, 03 Jun 2023 10:10:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips: add support for ISSI IS25LP016
by Anastasia Klimchuk (Code Review) 03 Jun '23

03 Jun '23

Attention is currently required from: Angel Pons, Edward O'Callaghan, Mario Kicherer, Nico Huber. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68295?usp=email ) Change subject: flashchips: add support for ISSI IS25LP016 ...................................................................... Patch Set 4: (9 comments) File flashchips.c: https://review.coreboot.org/c/flashrom/+/68295/comment/9ddad419_5319444d : PS3, Line 7487: probe_spi_rdid > PROBE_SPI_RDID Done https://review.coreboot.org/c/flashrom/+/68295/comment/fc467d5f_139bab11 : PS3, Line 7493: spi_block_erase_20 > SPI_BLOCK_ERASE_20 Done https://review.coreboot.org/c/flashrom/+/68295/comment/f3347f16_d3f653f1 : PS3, Line 7496: spi_block_erase_d7 > SPI_BLOCK_ERASE_D7 Done https://review.coreboot.org/c/flashrom/+/68295/comment/6ca8854a_ba4d1c2c : PS3, Line 7499: spi_block_erase_52 > SPI_BLOCK_ERASE_52 Done https://review.coreboot.org/c/flashrom/+/68295/comment/d186c531_ee62c9e2 : PS3, Line 7502: spi_block_erase_d8 > SPI_BLOCK_ERASE_D8 Done https://review.coreboot.org/c/flashrom/+/68295/comment/a8c7e29a_1b33fb12 : PS3, Line 7505: spi_block_erase_60 > SPI_BLOCK_ERASE_60 Done https://review.coreboot.org/c/flashrom/+/68295/comment/154ab8aa_fd2e5703 : PS3, Line 7508: spi_block_erase_c7 > SPI_BLOCK_ERASE_C7 Done https://review.coreboot.org/c/flashrom/+/68295/comment/ff103966_aeb9d308 : PS3, Line 7512: spi_chip_write_256 > SPI_CHIP_WRITE256 Done https://review.coreboot.org/c/flashrom/+/68295/comment/674d730d_b6630e02 : PS3, Line 7513: spi_chip_read > SPI_CHIP_READ Done -- To view, visit https://review.coreboot.org/c/flashrom/+/68295?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iffd7c4284d4d96b30a94f5dee882b5403fdfc183 Gerrit-Change-Number: 68295 Gerrit-PatchSet: 4 Gerrit-Owner: Mario Kicherer Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Mario Kicherer Gerrit-Comment-Date: Sat, 03 Jun 2023 10:00:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips: add support for ISSI IS25LP016
by Anastasia Klimchuk (Code Review) 03 Jun '23

03 Jun '23

Attention is currently required from: Anastasia Klimchuk, Angel Pons, Edward O'Callaghan, Mario Kicherer, Nico Huber. Anastasia Klimchuk has uploaded a new patch set (#4) to the change originally created by Mario Kicherer. ( https://review.coreboot.org/c/flashrom/+/68295?usp=email ) The following approvals got outdated and were removed: Code-Review+1 by Anastasia Klimchuk, Verified-1 by build bot (Jenkins) Change subject: flashchips: add support for ISSI IS25LP016 ...................................................................... flashchips: add support for ISSI IS25LP016 I took the original patch from Ondrej Hennel [1] and applied the requested changes. Reading, erasing and writing works. [1] https://patchwork.ozlabs.org/project/flashrom/list/?series=261647 Change-Id: Iffd7c4284d4d96b30a94f5dee882b5403fdfc183 Signed-off-by: Mario Kicherer <dev(a)kicherer.org> Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M flashchips.c M include/flashchips.h 2 files changed, 42 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/95/68295/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/68295?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iffd7c4284d4d96b30a94f5dee882b5403fdfc183 Gerrit-Change-Number: 68295 Gerrit-PatchSet: 4 Gerrit-Owner: Mario Kicherer Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Mario Kicherer Gerrit-MessageType: newpatchset

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit June 2023