June 2023 - flashrom-gerrit - mail.coreboot.org

[S] Change in flashrom[master]: flashchips.c: Add write protect support for W25Q16.V
by Anastasia Klimchuk (Code Review) June 2, 2023

June 2, 2023

Attention is currently required from: Angel Pons, Khoa Hoang, Nikolai Artemiev, Sergii Dmytruk. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67713?usp=email ) Change subject: flashchips.c: Add write protect support for W25Q16.V ...................................................................... Patch Set 8: (1 comment) Patchset: PS8: Nikolai, Sergii, can you have a look at this patch again? I see you approved, but it was a while ago, and sadly the patch was left. I rebased it, if you can have a look that would be great. And now you also can approve :) -- To view, visit https://review.coreboot.org/c/flashrom/+/67713?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6c0b35f82b47a1169bccfd08222e9e3b3be30d75 Gerrit-Change-Number: 67713 Gerrit-PatchSet: 8 Gerrit-Owner: Khoa Hoang <admin(a)khoahoang.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)chromium.org> Gerrit-Attention: Khoa Hoang <admin(a)khoahoang.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Fri, 02 Jun 2023 10:02:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips.c: Add write protect support for W25Q16.V
by Anastasia Klimchuk (Code Review) June 2, 2023

June 2, 2023

Attention is currently required from: Anastasia Klimchuk, Angel Pons, Khoa Hoang, Nikolai Artemiev, Sergii Dmytruk. Anastasia Klimchuk has uploaded a new patch set (#8) to the change originally created by Khoa Hoang. ( https://review.coreboot.org/c/flashrom/+/67713?usp=email ) The following approvals got outdated and were removed: Code-Review+1 by Angel Pons, Code-Review+1 by Sergii Dmytruk, Verified+1 by build bot (Jenkins) Change subject: flashchips.c: Add write protect support for W25Q16.V ...................................................................... flashchips.c: Add write protect support for W25Q16.V Enable WRSR2 feature flag and define reg_bits and decode_range for W25Q16.V to enable write protect support. Based on W25Q16DV, Revision: 1, Release: Nov 18 2014 datasheet TEST=flashrom --wp-{enable,disable,range,list,status} Change-Id: I6c0b35f82b47a1169bccfd08222e9e3b3be30d75 Signed-off-by: Khoa Hoang <admin(a)khoahoang.com> Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M flashchips.c 1 file changed, 12 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/13/67713/8 -- To view, visit https://review.coreboot.org/c/flashrom/+/67713?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6c0b35f82b47a1169bccfd08222e9e3b3be30d75 Gerrit-Change-Number: 67713 Gerrit-PatchSet: 8 Gerrit-Owner: Khoa Hoang <admin(a)khoahoang.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)chromium.org> Gerrit-Attention: Khoa Hoang <admin(a)khoahoang.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: flashchips: add support for MX25V16066/KH25V16066
by Anastasia Klimchuk (Code Review) June 2, 2023

June 2, 2023

Attention is currently required from: Joseph Goh. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68278?usp=email ) Change subject: flashchips: add support for MX25V16066/KH25V16066 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Joseph, thank you for the patch! sorry it has been missed :\ Are you still here? Do you have datasheets for the chip? -- To view, visit https://review.coreboot.org/c/flashrom/+/68278?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic5f0548f023fcd09a970148586497e00414ad1ae Gerrit-Change-Number: 68278 Gerrit-PatchSet: 1 Gerrit-Owner: Joseph Goh <josephgoh7(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Joseph Goh <josephgoh7(a)gmail.com> Gerrit-Comment-Date: Fri, 02 Jun 2023 09:47:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips: Add AT45DB641E
by Anastasia Klimchuk (Code Review) June 2, 2023

June 2, 2023

Attention is currently required from: Nico Huber, Savva. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63345?usp=email ) Change subject: flashchips: Add AT45DB641E ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Savva, are you still interested in this patch? There is one comment to it. -- To view, visit https://review.coreboot.org/c/flashrom/+/63345?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I56843b02bee74918a5131326627941ea82003f1f Gerrit-Change-Number: 63345 Gerrit-PatchSet: 1 Gerrit-Owner: Savva <savvamtr(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Savva <savvamtr(a)gmail.com> Gerrit-Comment-Date: Fri, 02 Jun 2023 09:43:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: flashchips.c: Add 4BA block erasers to W25Q256.W
by Anastasia Klimchuk (Code Review) June 2, 2023

June 2, 2023

Attention is currently required from: Simon Buhrow. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62711?usp=email ) Change subject: flashchips.c: Add 4BA block erasers to W25Q256.W ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Simon, just checking, are you still interested in this patch? You haven't added any reviewers, did you plan to send it for review? -- To view, visit https://review.coreboot.org/c/flashrom/+/62711?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1085c76574dbc76e278644ee05a6eca009798aa6 Gerrit-Change-Number: 62711 Gerrit-PatchSet: 1 Gerrit-Owner: Simon Buhrow Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Simon Buhrow Gerrit-Comment-Date: Fri, 02 Jun 2023 09:39:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips: Added missing voltages
by Name of user not set (Code Review) June 2, 2023

June 2, 2023

roman.stingler(a)gmail.com has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/40432 ) Change subject: flashchips: Added missing voltages ...................................................................... flashchips: Added missing voltages Signed-off-by: Roman Stingler <roman.stingler(a)gmail.com> Change-Id: I0825ab11e53c0b018b49173907e2b274a4cf1fab --- M flashchips.c 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/32/40432/1 diff --git a/flashchips.c b/flashchips.c index b4006df..f2d9fc1 100644 --- a/flashchips.c +++ b/flashchips.c @@ -7650,6 +7650,7 @@ }, .write = write_82802ab, .read = read_memmapped, + .voltage = {4500, 5500}, }, { @@ -7677,6 +7678,7 @@ }, .write = write_82802ab, .read = read_memmapped, + .voltage = {4500, 5500}, }, { @@ -7704,6 +7706,7 @@ }, .write = write_82802ab, .read = read_memmapped, + .voltage = {4500, 5500}, }, { @@ -7727,6 +7730,7 @@ .unlock = unlock_28f004s5, .write = write_82802ab, .read = read_memmapped, + .voltage = {2700, 3600}, }, { @@ -7755,6 +7759,7 @@ }, .write = write_82802ab, .read = read_memmapped, + .voltage = {4500, 5500}, }, { @@ -7783,6 +7788,7 @@ }, .write = write_82802ab, .read = read_memmapped, + .voltage = {4500, 5500}, }, { @@ -9972,6 +9978,7 @@ .unlock = spi_disable_blockprotect_bp3_srwd, .write = spi_chip_write_256, .read = spi_chip_read, + .voltage = {2700, 3600}, }, { @@ -17550,6 +17557,7 @@ }, .write = write_jedec, .read = read_memmapped, + .voltage = {4500, 5500}, }, { @@ -17573,6 +17581,7 @@ }, .write = write_jedec, .read = read_memmapped, + .voltage = {4500, 5500}, }, { -- To view, visit https://review.coreboot.org/c/flashrom/+/40432 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0825ab11e53c0b018b49173907e2b274a4cf1fab Gerrit-Change-Number: 40432 Gerrit-PatchSet: 1 Gerrit-Owner: roman.stingler(a)gmail.com Gerrit-MessageType: newchange

4 6

[M] Change in flashrom[master]: flashchips.c: big erase blocksize first
by Anastasia Klimchuk (Code Review) June 2, 2023

June 2, 2023

Anastasia Klimchuk has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/58467?usp=email ) Change subject: flashchips.c: big erase blocksize first ...................................................................... Abandoned CB:74872 enables optimisation in the tree -- To view, visit https://review.coreboot.org/c/flashrom/+/58467?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I862ce0b5f8912565e43c340578d8126aa2e6aa3b Gerrit-Change-Number: 58467 Gerrit-PatchSet: 5 Gerrit-Owner: Simon Buhrow Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: abandon

1 0

[M] Change in flashrom[master]: flashchips.c: big erase blocksize first
by Anastasia Klimchuk (Code Review) June 2, 2023

June 2, 2023

Attention is currently required from: Angel Pons, Simon Buhrow. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58467?usp=email ) Change subject: flashchips.c: big erase blocksize first ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: Good news: erase blocks optimisation is enabled in the tree as of CB:74872 ! I will mark this patch as abandoned. Hope Simon you don't mind! -- To view, visit https://review.coreboot.org/c/flashrom/+/58467?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I862ce0b5f8912565e43c340578d8126aa2e6aa3b Gerrit-Change-Number: 58467 Gerrit-PatchSet: 5 Gerrit-Owner: Simon Buhrow Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Simon Buhrow Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 02 Jun 2023 09:10:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: flashchips: Mark S25FL128L as tested for probe, read, write, erase
by Anastasia Klimchuk (Code Review) June 2, 2023

June 2, 2023

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/75604?usp=email ) Change subject: flashchips: Mark S25FL128L as tested for probe, read, write, erase ...................................................................... flashchips: Mark S25FL128L as tested for probe, read, write, erase As reported on the mailing list: https://mail.coreboot.org/hyperkitty/list/flashrom@flashrom.org/thread/3CC5… Change-Id: I0700d3e4f684db096fea63eb9bc5add44e246758 Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/04/75604/1 diff --git a/flashchips.c b/flashchips.c index 6a5cf49..62afd9d 100644 --- a/flashchips.c +++ b/flashchips.c @@ -16574,7 +16574,7 @@ .page_size = 256, /* 4 x 256B Security Region (OTP) */ .feature_bits = FEATURE_WRSR_WREN | FEATURE_WRSR_EXT3 | FEATURE_OTP, - .tested = TEST_UNTESTED, + .tested = TEST_OK_PREW, .probe = PROBE_SPI_RDID, .probe_timing = TIMING_ZERO, .block_erasers = -- To view, visit https://review.coreboot.org/c/flashrom/+/75604?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0700d3e4f684db096fea63eb9bc5add44e246758 Gerrit-Change-Number: 75604 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[master]: doc: Add build instructions for NI-845x on Windows
by Peter Marheine (Code Review) June 2, 2023

June 2, 2023

Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Miklós Márton, Peter Marheine, Thomas Heijligen. Peter Marheine has uploaded a new patch set (#5) to the change originally created by Thomas Heijligen. ( https://review.coreboot.org/c/flashrom/+/75270?usp=email ) Change subject: doc: Add build instructions for NI-845x on Windows ...................................................................... doc: Add build instructions for NI-845x on Windows Change-Id: I97ad08632f35aa241b3d19d9ce7711146e3f1f4a Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> Signed-off-by: Peter Marheine <pmarheine(a)chromium.org> --- M doc/dev_guide/building_from_source.rst M doc/dev_guide/building_with_make.rst 2 files changed, 24 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/70/75270/5 -- To view, visit https://review.coreboot.org/c/flashrom/+/75270?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I97ad08632f35aa241b3d19d9ce7711146e3f1f4a Gerrit-Change-Number: 75270 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: newpatchset

1 0