roman.stingler@gmail.com has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/40432 )
Change subject: flashchips: Added missing voltages ......................................................................
flashchips: Added missing voltages
Signed-off-by: Roman Stingler roman.stingler@gmail.com Change-Id: I0825ab11e53c0b018b49173907e2b274a4cf1fab --- M flashchips.c 1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/32/40432/1
diff --git a/flashchips.c b/flashchips.c index b4006df..f2d9fc1 100644 --- a/flashchips.c +++ b/flashchips.c @@ -7650,6 +7650,7 @@ }, .write = write_82802ab, .read = read_memmapped, + .voltage = {4500, 5500}, },
{ @@ -7677,6 +7678,7 @@ }, .write = write_82802ab, .read = read_memmapped, + .voltage = {4500, 5500}, },
{ @@ -7704,6 +7706,7 @@ }, .write = write_82802ab, .read = read_memmapped, + .voltage = {4500, 5500}, },
{ @@ -7727,6 +7730,7 @@ .unlock = unlock_28f004s5, .write = write_82802ab, .read = read_memmapped, + .voltage = {2700, 3600}, },
{ @@ -7755,6 +7759,7 @@ }, .write = write_82802ab, .read = read_memmapped, + .voltage = {4500, 5500}, },
{ @@ -7783,6 +7788,7 @@ }, .write = write_82802ab, .read = read_memmapped, + .voltage = {4500, 5500}, },
{ @@ -9972,6 +9978,7 @@ .unlock = spi_disable_blockprotect_bp3_srwd, .write = spi_chip_write_256, .read = spi_chip_read, + .voltage = {2700, 3600}, },
{ @@ -17550,6 +17557,7 @@ }, .write = write_jedec, .read = read_memmapped, + .voltage = {4500, 5500}, },
{ @@ -17573,6 +17581,7 @@ }, .write = write_jedec, .read = read_memmapped, + .voltage = {4500, 5500}, },
{
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40432 )
Change subject: flashchips: Added missing voltages ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/flashrom/+/40432/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/40432/1//COMMIT_MSG@7 PS1, Line 7: Added Add
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40432 )
Change subject: flashchips: Added missing voltages ......................................................................
Patch Set 1: Code-Review+2
Stefan Reinauer has uploaded a new patch set (#2) to the change originally created by roman.stingler@gmail.com. ( https://review.coreboot.org/c/flashrom/+/40432 )
Change subject: flashchips: Add missing voltages ......................................................................
flashchips: Add missing voltages
Signed-off-by: Roman Stingler roman.stingler@gmail.com Change-Id: I0825ab11e53c0b018b49173907e2b274a4cf1fab --- M flashchips.c 1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/32/40432/2
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40432 )
Change subject: flashchips: Add missing voltages ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/flashrom/+/40432/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/40432/1//COMMIT_MSG@7 PS1, Line 7: Added
Add
Done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40432 )
Change subject: flashchips: Add missing voltages ......................................................................
Patch Set 2: Code-Review+2
Attention is currently required from: Stefan Reinauer, roman.stingler@gmail.com.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40432?usp=email )
Change subject: flashchips: Add missing voltages ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2: I have just came along this patch. I have no idea why it hasn't been merged, but I think it should be. It is doing useful stuff! I tried auto-rebase but it didn't work. Non-surprisingly, the patch is almost 3 years old :\ Is anyone still here interested to manual rebase? If no one, I will try myself later...
Roman, sorry for that! It's not great that a patch is waiting for 3 years :(
-
Anastasia Klimchuk (Code Review) -
Angel Pons (Code Review)
-
Name of user not set (Code Review)
-
Stefan Reinauer (Code Review)