June 2023 - flashrom-gerrit - mail.coreboot.org

[S] Change in flashrom[master]: flashchips: Add AT25DF011
by Anastasia Klimchuk (Code Review) 02 Jun '23

02 Jun '23

Attention is currently required from: Anastasia Klimchuk, Angel Pons, Hanno Heinrichs, Nikolai Artemiev. Anastasia Klimchuk has uploaded a new patch set (#6) to the change originally created by Hanno Heinrichs. ( https://review.coreboot.org/c/flashrom/+/51048?usp=email ) The following approvals got outdated and were removed: Code-Review+1 by Nikolai Artemiev, Verified+1 by build bot (Jenkins) Change subject: flashchips: Add AT25DF011 ...................................................................... flashchips: Add AT25DF011 Tested read/write/erase/probe operations with a ch341a_spi programmer. Datasheet is available at https://www.mouser.de/datasheet/2/590/DS-AT25DF011_032-1098683.pdf Signed-off-by: Hanno Heinrichs <hanno.heinrichs(a)rwth-aachen.de> Change-Id: I5a2141f1380e864c843d6a3008fdb02dc1b75131 Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M flashchips.c M include/flashchips.h 2 files changed, 40 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/48/51048/6 -- To view, visit https://review.coreboot.org/c/flashrom/+/51048?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5a2141f1380e864c843d6a3008fdb02dc1b75131 Gerrit-Change-Number: 51048 Gerrit-PatchSet: 6 Gerrit-Owner: Hanno Heinrichs <hanno.heinrichs(a)rwth-aachen.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Hanno Heinrichs <hanno.heinrichs(a)rwth-aachen.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: flashchips: add definition of the XT25F02E SPI NOR flash
by Anastasia Klimchuk (Code Review) 02 Jun '23

02 Jun '23

Attention is currently required from: Neil Armstrong, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/50263?usp=email ) Change subject: flashchips: add definition of the XT25F02E SPI NOR flash ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: Hello Neil, sorry there was a really long delay for this patch :( Are you still interested? There are two comments, for commit message. Also I see you need to rebase the patch (I think that would need to be a manual rebase). Also about testing, were you testing with CB:50264 ? Thank you! -- To view, visit https://review.coreboot.org/c/flashrom/+/50263?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I295633c448c05520e4a6aa09c08bd7c9f2346d54 Gerrit-Change-Number: 50263 Gerrit-PatchSet: 4 Gerrit-Owner: Neil Armstrong <narmstrong(a)baylibre.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Neil Armstrong <narmstrong(a)baylibre.com> Gerrit-Comment-Date: Fri, 02 Jun 2023 12:57:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips.c: Add write protect support for W25Q16.V
by Sergii Dmytruk (Code Review) 02 Jun '23

02 Jun '23

Attention is currently required from: Anastasia Klimchuk, Angel Pons, Khoa Hoang, Nikolai Artemiev. Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67713?usp=email ) Change subject: flashchips.c: Add write protect support for W25Q16.V ...................................................................... Patch Set 10: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/67713?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6c0b35f82b47a1169bccfd08222e9e3b3be30d75 Gerrit-Change-Number: 67713 Gerrit-PatchSet: 10 Gerrit-Owner: Khoa Hoang <admin(a)khoahoang.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)chromium.org> Gerrit-Attention: Khoa Hoang <admin(a)khoahoang.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Fri, 02 Jun 2023 12:38:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: VIA VL805 SPI Flash Bus support
by Anastasia Klimchuk (Code Review) 02 Jun '23

02 Jun '23

Attention is currently required from: Carl-Daniel Hailfinger, Neil Armstrong, jmorrison(a)bogomips.com. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/50264?usp=email ) Change subject: VIA VL805 SPI Flash Bus support ...................................................................... Patch Set 6: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/50264/comment/9e685c08_08f9c024 : PS6, Line 22: [narmstrong: Tested, fixed validated on an Amlogic ARM64 based board with the VL806 variant] You can express this as `Tested-by: ` tag , and details in commit message. Patchset: PS6: Hello Neil, John Paul, Carl-Daniel, are you interested in this patch? Would you like to get it completed and merged? Thank you for your contribution! -- To view, visit https://review.coreboot.org/c/flashrom/+/50264?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7439d31cdf5a2174dd27b9dbe5de24ad64963334 Gerrit-Change-Number: 50264 Gerrit-PatchSet: 6 Gerrit-Owner: Neil Armstrong <narmstrong(a)baylibre.com> Gerrit-Reviewer: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: jmorrison(a)bogomips.com Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Neil Armstrong <narmstrong(a)baylibre.com> Gerrit-Attention: jmorrison(a)bogomips.com Gerrit-Attention: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Gerrit-Comment-Date: Fri, 02 Jun 2023 12:00:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips: Add support for Boya BY25D80A
by Anastasia Klimchuk (Code Review) 02 Jun '23

02 Jun '23

Attention is currently required from: Edward O'Callaghan, Piotr Halama, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73513?usp=email ) Change subject: flashchips: Add support for Boya BY25D80A ...................................................................... Patch Set 7: (1 comment) Patchset: PS7: Peter, you have approved (3 months ago, but still :D ) , I just rebased the patch. Could you please have another look? thank you so much! -- To view, visit https://review.coreboot.org/c/flashrom/+/73513?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I586f3455d925132bbda3fccdad00f0b1e22c2ea7 Gerrit-Change-Number: 73513 Gerrit-PatchSet: 7 Gerrit-Owner: Piotr Halama <skrzynka(a)halamix2.pl> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Piotr Halama <skrzynka(a)halamix2.pl> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Fri, 02 Jun 2023 11:53:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips: Add support for Boya BY25D80A
by Anastasia Klimchuk (Code Review) 02 Jun '23

02 Jun '23

Attention is currently required from: Edward O'Callaghan, Piotr Halama, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73513?usp=email ) Change subject: flashchips: Add support for Boya BY25D80A ...................................................................... Patch Set 6: (1 comment) File flashchips.c: https://review.coreboot.org/c/flashrom/+/73513/comment/088a8265_40905ec7 : PS2, Line 3552: {32 * 1024, 32} > Ah, sorry, `{64 * 1024, 16}` does make more sense, updated Done -- To view, visit https://review.coreboot.org/c/flashrom/+/73513?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I586f3455d925132bbda3fccdad00f0b1e22c2ea7 Gerrit-Change-Number: 73513 Gerrit-PatchSet: 6 Gerrit-Owner: Piotr Halama <skrzynka(a)halamix2.pl> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Piotr Halama <skrzynka(a)halamix2.pl> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Fri, 02 Jun 2023 11:46:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Piotr Halama <skrzynka(a)halamix2.pl> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips: add support for MX77L25650F chip
by Anastasia Klimchuk (Code Review) 02 Jun '23

02 Jun '23

Attention is currently required from: Angel Pons, Artur Kowalski. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68557?usp=email ) Change subject: flashchips: add support for MX77L25650F chip ...................................................................... Patch Set 4: (6 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/68557/comment/c7672f59_a6e1c65f : PS1, Line 7: flashrom > fixed Done https://review.coreboot.org/c/flashrom/+/68557/comment/7bf88b33_d2bfaa1c : PS1, Line 9: read and write > Erasing was done before writing and it worked properly, updated commit message accordingly Done Commit Message: https://review.coreboot.org/c/flashrom/+/68557/comment/60b27d08_6dbdeddf : PS4, Line 11: can't disable it can't enable it (that's what seems to be the case from commit message?) Patchset: PS4: Artur sorry this patch got delayed! I hope you are still here and have some time to finish remaining comments? I marked as resolved the comments which are seem to be resolved. Thank you! File flashchips.c: https://review.coreboot.org/c/flashrom/+/68557/comment/6ea6ae72_c0a64cbf : PS1, Line 10215: // TODO: add 64K block erase > Added 64K block erase Done File flashchips.c: https://review.coreboot.org/c/flashrom/+/68557/comment/207b30fc_eb74b78c : PS4, Line 10449: // TODO: add support for flash protection I don't think we need this TODO is the code. If you don't plan to add support for write protect, better to remove the TODO. But I understand the patch is sitting for a while, maybe the situation has changed and you can add wp support now? Either way, you don't need a TODO. -- To view, visit https://review.coreboot.org/c/flashrom/+/68557?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iaea5485f8b59b8538dc47beada2c308376ea027c Gerrit-Change-Number: 68557 Gerrit-PatchSet: 4 Gerrit-Owner: Artur Kowalski <artur.kowalski(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Artur Kowalski <arturkow2000(a)gmail.com> Gerrit-Attention: Artur Kowalski <artur.kowalski(a)3mdeb.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 02 Jun 2023 10:48:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Comment-In-Reply-To: Artur Kowalski <artur.kowalski(a)3mdeb.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips.c: Add write protect support for W25Q16.V
by Anastasia Klimchuk (Code Review) 02 Jun '23

02 Jun '23

Attention is currently required from: Angel Pons, Khoa Hoang, Nikolai Artemiev, Sergii Dmytruk. Anastasia Klimchuk has uploaded a new patch set (#10) to the change originally created by Khoa Hoang. ( https://review.coreboot.org/c/flashrom/+/67713?usp=email ) Change subject: flashchips.c: Add write protect support for W25Q16.V ...................................................................... flashchips.c: Add write protect support for W25Q16.V Enable WRSR2 feature flag and define reg_bits and decode_range for W25Q16.V to enable write protect support. Based on W25Q16DV, Revision: 1, Release: Nov 18 2014 datasheet TEST=flashrom --wp-{enable,disable,range,list,status} Change-Id: I6c0b35f82b47a1169bccfd08222e9e3b3be30d75 Signed-off-by: Khoa Hoang <admin(a)khoahoang.com> Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M flashchips.c 1 file changed, 12 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/13/67713/10 -- To view, visit https://review.coreboot.org/c/flashrom/+/67713?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6c0b35f82b47a1169bccfd08222e9e3b3be30d75 Gerrit-Change-Number: 67713 Gerrit-PatchSet: 10 Gerrit-Owner: Khoa Hoang <admin(a)khoahoang.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)chromium.org> Gerrit-Attention: Khoa Hoang <admin(a)khoahoang.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: lashchips.c: Add write protect support for W25Q16.V
by Anastasia Klimchuk (Code Review) 02 Jun '23

02 Jun '23

Attention is currently required from: Angel Pons, Khoa Hoang, Nikolai Artemiev, Sergii Dmytruk. Anastasia Klimchuk has uploaded a new patch set (#9) to the change originally created by Khoa Hoang. ( https://review.coreboot.org/c/flashrom/+/67713?usp=email ) The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: lashchips.c: Add write protect support for W25Q16.V ...................................................................... lashchips.c: Add write protect support for W25Q16.V Enable WRSR2 feature flag and define reg_bits and decode_range for W25Q16.V to enable write protect support. Based on W25Q16DV, Revision: 1, Release: Nov 18 2014 datasheet TEST=flashrom --wp-{enable,disable,range,list,status} Change-Id: I6c0b35f82b47a1169bccfd08222e9e3b3be30d75 Signed-off-by: Khoa Hoang <admin(a)khoahoang.com> Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M flashchips.c 1 file changed, 12 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/13/67713/9 -- To view, visit https://review.coreboot.org/c/flashrom/+/67713?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6c0b35f82b47a1169bccfd08222e9e3b3be30d75 Gerrit-Change-Number: 67713 Gerrit-PatchSet: 9 Gerrit-Owner: Khoa Hoang <admin(a)khoahoang.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)chromium.org> Gerrit-Attention: Khoa Hoang <admin(a)khoahoang.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: flashchips.c: Add write protect support for W25Q16.V
by Anastasia Klimchuk (Code Review) 02 Jun '23

02 Jun '23

Attention is currently required from: Angel Pons, Khoa Hoang, Nikolai Artemiev, Sergii Dmytruk. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67713?usp=email ) Change subject: flashchips.c: Add write protect support for W25Q16.V ...................................................................... Patch Set 8: (1 comment) Patchset: PS8: Nikolai, Sergii, can you have a look at this patch again? I see you approved, but it was a while ago, and sadly the patch was left. I rebased it, if you can have a look that would be great. And now you also can approve :) -- To view, visit https://review.coreboot.org/c/flashrom/+/67713?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6c0b35f82b47a1169bccfd08222e9e3b3be30d75 Gerrit-Change-Number: 67713 Gerrit-PatchSet: 8 Gerrit-Owner: Khoa Hoang <admin(a)khoahoang.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)chromium.org> Gerrit-Attention: Khoa Hoang <admin(a)khoahoang.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Fri, 02 Jun 2023 10:02:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit June 2023