June 2023 - flashrom-gerrit - mail.coreboot.org

[S] Change in flashrom[master]: flashchips: add support for ISSI IS25LP016
by Anastasia Klimchuk (Code Review) 03 Jun '23

03 Jun '23

Attention is currently required from: Angel Pons, Mario Kicherer, Nico Huber, Nikolai Artemiev. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68295?usp=email ) Change subject: flashchips: add support for ISSI IS25LP016 ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/68295?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iffd7c4284d4d96b30a94f5dee882b5403fdfc183 Gerrit-Change-Number: 68295 Gerrit-PatchSet: 4 Gerrit-Owner: Mario Kicherer Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Mario Kicherer Gerrit-Comment-Date: Sat, 03 Jun 2023 10:10:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips: add support for ISSI IS25LP016
by Anastasia Klimchuk (Code Review) 03 Jun '23

03 Jun '23

Attention is currently required from: Angel Pons, Edward O'Callaghan, Mario Kicherer, Nico Huber. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68295?usp=email ) Change subject: flashchips: add support for ISSI IS25LP016 ...................................................................... Patch Set 4: (9 comments) File flashchips.c: https://review.coreboot.org/c/flashrom/+/68295/comment/9ddad419_5319444d : PS3, Line 7487: probe_spi_rdid > PROBE_SPI_RDID Done https://review.coreboot.org/c/flashrom/+/68295/comment/fc467d5f_139bab11 : PS3, Line 7493: spi_block_erase_20 > SPI_BLOCK_ERASE_20 Done https://review.coreboot.org/c/flashrom/+/68295/comment/f3347f16_d3f653f1 : PS3, Line 7496: spi_block_erase_d7 > SPI_BLOCK_ERASE_D7 Done https://review.coreboot.org/c/flashrom/+/68295/comment/6ca8854a_ba4d1c2c : PS3, Line 7499: spi_block_erase_52 > SPI_BLOCK_ERASE_52 Done https://review.coreboot.org/c/flashrom/+/68295/comment/d186c531_ee62c9e2 : PS3, Line 7502: spi_block_erase_d8 > SPI_BLOCK_ERASE_D8 Done https://review.coreboot.org/c/flashrom/+/68295/comment/a8c7e29a_1b33fb12 : PS3, Line 7505: spi_block_erase_60 > SPI_BLOCK_ERASE_60 Done https://review.coreboot.org/c/flashrom/+/68295/comment/154ab8aa_fd2e5703 : PS3, Line 7508: spi_block_erase_c7 > SPI_BLOCK_ERASE_C7 Done https://review.coreboot.org/c/flashrom/+/68295/comment/ff103966_aeb9d308 : PS3, Line 7512: spi_chip_write_256 > SPI_CHIP_WRITE256 Done https://review.coreboot.org/c/flashrom/+/68295/comment/674d730d_b6630e02 : PS3, Line 7513: spi_chip_read > SPI_CHIP_READ Done -- To view, visit https://review.coreboot.org/c/flashrom/+/68295?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iffd7c4284d4d96b30a94f5dee882b5403fdfc183 Gerrit-Change-Number: 68295 Gerrit-PatchSet: 4 Gerrit-Owner: Mario Kicherer Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Mario Kicherer Gerrit-Comment-Date: Sat, 03 Jun 2023 10:00:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips: add support for ISSI IS25LP016
by Anastasia Klimchuk (Code Review) 03 Jun '23

03 Jun '23

Attention is currently required from: Anastasia Klimchuk, Angel Pons, Edward O'Callaghan, Mario Kicherer, Nico Huber. Anastasia Klimchuk has uploaded a new patch set (#4) to the change originally created by Mario Kicherer. ( https://review.coreboot.org/c/flashrom/+/68295?usp=email ) The following approvals got outdated and were removed: Code-Review+1 by Anastasia Klimchuk, Verified-1 by build bot (Jenkins) Change subject: flashchips: add support for ISSI IS25LP016 ...................................................................... flashchips: add support for ISSI IS25LP016 I took the original patch from Ondrej Hennel [1] and applied the requested changes. Reading, erasing and writing works. [1] https://patchwork.ozlabs.org/project/flashrom/list/?series=261647 Change-Id: Iffd7c4284d4d96b30a94f5dee882b5403fdfc183 Signed-off-by: Mario Kicherer <dev(a)kicherer.org> Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M flashchips.c M include/flashchips.h 2 files changed, 42 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/95/68295/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/68295?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iffd7c4284d4d96b30a94f5dee882b5403fdfc183 Gerrit-Change-Number: 68295 Gerrit-PatchSet: 4 Gerrit-Owner: Mario Kicherer Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Mario Kicherer Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[master]: flashchips: Add EON EN25T80 and EN25T80
by Anastasia Klimchuk (Code Review) 03 Jun '23

03 Jun '23

Attention is currently required from: Shreeyash . Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66438?usp=email ) Change subject: flashchips: Add EON EN25T80 and EN25T80 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Shreeyash, hello! I wanted to check, are you still interested to finish this patch? -- To view, visit https://review.coreboot.org/c/flashrom/+/66438?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie62a08bed242b5b006e4bb2f86eb70c871bd5ed9 Gerrit-Change-Number: 66438 Gerrit-PatchSet: 1 Gerrit-Owner: Shreeyash <shreeyash335(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Shreeyash <shreeyash335(a)gmail.com> Gerrit-Comment-Date: Sat, 03 Jun 2023 09:12:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: flashchips: Add support for GigaDevice GD25LR256E, GD251R512ME
by Anastasia Klimchuk (Code Review) 03 Jun '23

03 Jun '23

Attention is currently required from: Angel Pons, Raj Astekar, Ravishankar Sarawadi, Wonkyu Kim. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58025?usp=email ) Change subject: flashchips: Add support for GigaDevice GD25LR256E, GD251R512ME ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: Ravishankar, thank you for the patch, I am sorry it got lost. It needs a manual rebase, would you be able to do it? I see you also have CB:69928 in the same state. If you could rebase them both on the latest head (maybe put one on the top of another) and then we can get the patches through. -- To view, visit https://review.coreboot.org/c/flashrom/+/58025?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2fe6bc1219cd1ee19b93caabab69de938cfc44b0 Gerrit-Change-Number: 58025 Gerrit-PatchSet: 4 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Comment-Date: Sat, 03 Jun 2023 09:01:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: flashchips: Add support for GigaDevice GD25LR256E, GD251R512ME
by Anastasia Klimchuk (Code Review) 03 Jun '23

03 Jun '23

Attention is currently required from: Angel Pons, Raj Astekar, Ravishankar Sarawadi, Wonkyu Kim. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58025?usp=email ) Change subject: flashchips: Add support for GigaDevice GD25LR256E, GD251R512ME ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/58025/comment/018c597e_6af2cfe6 : PS2, Line 10: > Please use two spaces instead of tabs. Also below. Done -- To view, visit https://review.coreboot.org/c/flashrom/+/58025?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2fe6bc1219cd1ee19b93caabab69de938cfc44b0 Gerrit-Change-Number: 58025 Gerrit-PatchSet: 4 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Comment-Date: Sat, 03 Jun 2023 08:50:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips: Add support for IS25WP016
by Anastasia Klimchuk (Code Review) 03 Jun '23

03 Jun '23

Attention is currently required from: Alex Mikhalev, Angel Pons, Nikolai Artemiev. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70140?usp=email ) Change subject: flashchips: Add support for IS25WP016 ...................................................................... Patch Set 5: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/70140/comment/af4c6105_c8030fbd : PS4, Line 9: Tested reading, writing and erasing using `linux_spi` programmer on Raspberry : Pi CM4. > There is an unnecessary new line after Raspberry, it seems? […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/70140?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2b8caea229ffda72f1b04183c31715faccb64ad5 Gerrit-Change-Number: 70140 Gerrit-PatchSet: 5 Gerrit-Owner: Alex Mikhalev <alex(a)corvus-robotics.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Alex Mikhalev <alex(a)corvus-robotics.com> Gerrit-Comment-Date: Sat, 03 Jun 2023 08:48:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips: Add support for IS25WP016
by Anastasia Klimchuk (Code Review) 03 Jun '23

03 Jun '23

Attention is currently required from: Alex Mikhalev, Angel Pons. Anastasia Klimchuk has uploaded a new patch set (#5) to the change originally created by Alex Mikhalev. ( https://review.coreboot.org/c/flashrom/+/70140?usp=email ) Change subject: flashchips: Add support for IS25WP016 ...................................................................... flashchips: Add support for IS25WP016 Tested reading, writing and erasing using `linux_spi` programmer on Raspberry Pi CM4. Datasheet: https://web.archive.org/web/20221129211027/https://www.issi.com/WW/pdf/25LP… Change-Id: I2b8caea229ffda72f1b04183c31715faccb64ad5 Signed-off-by: Alex Mikhalev <alex(a)corvus-robotics.com> --- M flashchips.c M include/flashchips.h 2 files changed, 43 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/40/70140/5 -- To view, visit https://review.coreboot.org/c/flashrom/+/70140?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2b8caea229ffda72f1b04183c31715faccb64ad5 Gerrit-Change-Number: 70140 Gerrit-PatchSet: 5 Gerrit-Owner: Alex Mikhalev <alex(a)corvus-robotics.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Alex Mikhalev <alex(a)corvus-robotics.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: flashchips: Add support for GigaDevice GD251R512ME
by Anastasia Klimchuk (Code Review) 03 Jun '23

03 Jun '23

Attention is currently required from: Harsha B R, Ravishankar Sarawadi. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69928?usp=email ) Change subject: flashchips: Add support for GigaDevice GD251R512ME ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Ravishankar, thank you for the patch. I just noticed it, I see there are unresolved comments. Would you be able to resolve them? Thank you! -- To view, visit https://review.coreboot.org/c/flashrom/+/69928?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I15f76ce089cb2a2baf8bf8525510a7a7fe44b352 Gerrit-Change-Number: 69928 Gerrit-PatchSet: 1 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Harsha B R <harsha.b.r(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Harsha B R <harsha.b.r(a)intel.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Comment-Date: Sat, 03 Jun 2023 08:37:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips: Add AT25DF011
by Anastasia Klimchuk (Code Review) 02 Jun '23

02 Jun '23

Attention is currently required from: Angel Pons, Hanno Heinrichs, Nikolai Artemiev. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51048?usp=email ) Change subject: flashchips: Add AT25DF011 ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: Nikolai, Angel, could you please have a look once again? I know you reviewed but that was long time ago, and sadly the patch was left. Thank you! -- To view, visit https://review.coreboot.org/c/flashrom/+/51048?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5a2141f1380e864c843d6a3008fdb02dc1b75131 Gerrit-Change-Number: 51048 Gerrit-PatchSet: 6 Gerrit-Owner: Hanno Heinrichs <hanno.heinrichs(a)rwth-aachen.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Hanno Heinrichs <hanno.heinrichs(a)rwth-aachen.de> Gerrit-Comment-Date: Fri, 02 Jun 2023 13:20:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit June 2023