June 2023 - flashrom-gerrit - mail.coreboot.org

[XL] Change in flashrom[master]: Plain mjson 1.6
by Edward O'Callaghan (Code Review) 08 Jun '23

08 Jun '23

Attention is currently required from: Stefan Reinauer. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75647?usp=email ) Change subject: Plain mjson 1.6 ...................................................................... Patch Set 5: Code-Review+2 (1 comment) Patchset: PS5: can we plop this into a directory called 'import/' or something with its own little meson file and it can just be linked to should it be enabled as a feature. -- To view, visit https://review.coreboot.org/c/flashrom/+/75647?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9f770baec883f35507bf3b7b60ef2d581db27002 Gerrit-Change-Number: 75647 Gerrit-PatchSet: 5 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Thu, 08 Jun 2023 03:35:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: Replace all flashchips accesses with get functions
by Edward O'Callaghan (Code Review) 08 Jun '23

08 Jun '23

Attention is currently required from: Anastasia Klimchuk, Stefan Reinauer. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75646?usp=email ) Change subject: Replace all flashchips accesses with get functions ...................................................................... Patch Set 5: (11 comments) Patchset: PS5: I realise this patch was a intermediate step so the comments are just how it should probably look for when the desire to merge comes about. File flashchips.c: https://review.coreboot.org/c/flashrom/+/75646/comment/1a29ee84_6580ba0a : PS5, Line 34: internal_ no need to rename if it becomes static, also "internal" is a overloaded term with the internal programmer. https://review.coreboot.org/c/flashrom/+/75646/comment/efe728fb_a207593b : PS5, Line 20844: get_flashchips(void) you *could* have a signature of: `void get_flashchip_db(struct flashchip **db, size_t *len)` ? https://review.coreboot.org/c/flashrom/+/75646/comment/37be779e_1568c5f4 : PS5, Line 20849: unsigned int should be `size_t` for the size of an array. File ichspi.c: https://review.coreboot.org/c/flashrom/+/75646/comment/94da9d4a_c9a16f09 : PS5, Line 1469: const struct flashchip *chip; : : struct flashchip *flashchips=get_flashchips(); : : if (!flashchips) : return NULL; ``` const struct flashchip *chip = get_flashchips()[0]; for (; chip->vendor; chip++) { ``` File libflashrom.c: https://review.coreboot.org/c/flashrom/+/75646/comment/e7497a3f_73f35ef3 : PS5, Line 95: unsigned int size_t File print.c: https://review.coreboot.org/c/flashrom/+/75646/comment/be9da440_ff4b7a31 : PS5, Line 56: const struct flashchip *chip; delete https://review.coreboot.org/c/flashrom/+/75646/comment/0bc5f4e4_9914ab1d : PS5, Line 62: flashchips chip https://review.coreboot.org/c/flashrom/+/75646/comment/d6c77b67_ecd3cf69 : PS5, Line 65: chip = flashchips delete File print_wiki.c: https://review.coreboot.org/c/flashrom/+/75646/comment/86a26de7_0c05b97b : PS5, Line 294: flashchips get_flashchips() https://review.coreboot.org/c/flashrom/+/75646/comment/a7599e14_85aaabe1 : PS5, Line 310: flashchips get_flashchips() -- To view, visit https://review.coreboot.org/c/flashrom/+/75646?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ibc89e32c83975e01c958b8cf0d11dad73c461a53 Gerrit-Change-Number: 75646 Gerrit-PatchSet: 5 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 08 Jun 2023 03:34:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: serprog.c: Replace custom mapper with max_rom_decode
by Jonathon Hall (Code Review) 07 Jun '23

07 Jun '23

Jonathon Hall has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/68093?usp=email ) Change subject: serprog.c: Replace custom mapper with max_rom_decode ...................................................................... Abandoned Couldn't find anyone with serprog hardware to test. -- To view, visit https://review.coreboot.org/c/flashrom/+/68093?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If8b313708a52813b9354cbf45cb91cdd1fe36b13 Gerrit-Change-Number: 68093 Gerrit-PatchSet: 3 Gerrit-Owner: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[master]: serprog.c: Replace custom mapper with max_rom_decode
by Jonathon Hall (Code Review) 07 Jun '23

07 Jun '23

Attention is currently required from: Thomas Heijligen. Jonathon Hall has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68093?usp=email ) Change subject: serprog.c: Replace custom mapper with max_rom_decode ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: Abandoning this since I could not find someone with the appropriate hardware to test. -- To view, visit https://review.coreboot.org/c/flashrom/+/68093?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If8b313708a52813b9354cbf45cb91cdd1fe36b13 Gerrit-Change-Number: 68093 Gerrit-PatchSet: 3 Gerrit-Owner: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Wed, 07 Jun 2023 20:17:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: Replace all flashchips accesses with get functions
by Stefan Reinauer (Code Review) 07 Jun '23

07 Jun '23

Attention is currently required from: Anastasia Klimchuk, Stefan Reinauer. Hello Anastasia Klimchuk, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/75646?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: Replace all flashchips accesses with get functions ...................................................................... Replace all flashchips accesses with get functions Abstract access to struct flashchip flashchips[]. Change-Id: Ibc89e32c83975e01c958b8cf0d11dad73c461a53 Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> --- M cli_classic.c M flashchips.c M flashrom.c M ichspi.c M include/flash.h M libflashrom.c M print.c M print_wiki.c M tests/selfcheck.c 9 files changed, 52 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/46/75646/5 -- To view, visit https://review.coreboot.org/c/flashrom/+/75646?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ibc89e32c83975e01c958b8cf0d11dad73c461a53 Gerrit-Change-Number: 75646 Gerrit-PatchSet: 5 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[master]: Replace all flashchips accesses with get functions
by Stefan Reinauer (Code Review) 07 Jun '23

07 Jun '23

Attention is currently required from: Anastasia Klimchuk, Stefan Reinauer. Hello Anastasia Klimchuk, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/75646?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: Replace all flashchips accesses with get functions ...................................................................... Replace all flashchips accesses with get functions Abstract access to struct flashchip flashchips[]. Change-Id: Ibc89e32c83975e01c958b8cf0d11dad73c461a53 Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> --- M cli_classic.c M flashchips.c M flashrom.c M ichspi.c M include/flash.h M libflashrom.c M print.c M print_wiki.c M tests/selfcheck.c 9 files changed, 52 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/46/75646/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/75646?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ibc89e32c83975e01c958b8cf0d11dad73c461a53 Gerrit-Change-Number: 75646 Gerrit-PatchSet: 4 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: flashchips: Add support for IS25WP016
by Stefan Reinauer (Code Review) 07 Jun '23

07 Jun '23

Attention is currently required from: Alex Mikhalev, Anastasia Klimchuk, Angel Pons, Nikolai Artemiev. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70140?usp=email ) Change subject: flashchips: Add support for IS25WP016 ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/70140?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2b8caea229ffda72f1b04183c31715faccb64ad5 Gerrit-Change-Number: 70140 Gerrit-PatchSet: 6 Gerrit-Owner: Alex Mikhalev <alex(a)corvus-robotics.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Alex Mikhalev <alex(a)corvus-robotics.com> Gerrit-Comment-Date: Wed, 07 Jun 2023 05:26:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: Replace all flashchips accesses with get functions
by Stefan Reinauer (Code Review) 07 Jun '23

07 Jun '23

Attention is currently required from: Stefan Reinauer. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/75646?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: Replace all flashchips accesses with get functions ...................................................................... Replace all flashchips accesses with get functions Abstract access to struct flashchip flashchips[]. Change-Id: Ibc89e32c83975e01c958b8cf0d11dad73c461a53 Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> --- M cli_classic.c M flashchips.c M flashrom.c M ichspi.c M include/flash.h M libflashrom.c M print.c M print_wiki.c M tests/selfcheck.c 9 files changed, 47 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/46/75646/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/75646?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ibc89e32c83975e01c958b8cf0d11dad73c461a53 Gerrit-Change-Number: 75646 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[XL] Change in flashrom[master]: Plain mjson 1.6
by Stefan Reinauer (Code Review) 07 Jun '23

07 Jun '23

Attention is currently required from: Stefan Reinauer. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/75647?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: Plain mjson 1.6 ...................................................................... Plain mjson 1.6 With whitespace fixes. Because flashrom doesn't like vanilla. Change-Id: I9f770baec883f35507bf3b7b60ef2d581db27002 Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> --- A mjson.c A mjson.h 2 files changed, 1,016 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/47/75647/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/75647?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9f770baec883f35507bf3b7b60ef2d581db27002 Gerrit-Change-Number: 75647 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: Replace all flashchips accesses with get functions
by Stefan Reinauer (Code Review) 07 Jun '23

07 Jun '23

Attention is currently required from: Stefan Reinauer. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/75646?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: Replace all flashchips accesses with get functions ...................................................................... Replace all flashchips accesses with get functions Abstract access to struct flashchip flashchips[]. Change-Id: Ibc89e32c83975e01c958b8cf0d11dad73c461a53 Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> --- M cli_classic.c M flashchips.c M flashrom.c M ichspi.c M include/flash.h M libflashrom.c M print.c M print_wiki.c 8 files changed, 41 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/46/75646/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/75646?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ibc89e32c83975e01c958b8cf0d11dad73c461a53 Gerrit-Change-Number: 75646 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit June 2023