June 2023 - flashrom-gerrit - mail.coreboot.org

[M] Change in flashrom[master]: Replace all flashchips accesses with get functions
by Anastasia Klimchuk (Code Review) 08 Jun '23

08 Jun '23

Attention is currently required from: Edward O'Callaghan, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75646?usp=email ) Change subject: Replace all flashchips accesses with get functions ...................................................................... Patch Set 5: (7 comments) Patchset: PS5: This is awesome! Thank you so much for the patch! File flashchips.c: https://review.coreboot.org/c/flashrom/+/75646/comment/33f9b98c_b5f85d79 : PS5, Line 28: * Temporarily, this file is sorted alphabetically by vendor and name to : * assist with merging the Chromium fork of flashrom. Can we remove this comment by now? (maybe in a separate patch). the most confusing part is "temporarily". https://review.coreboot.org/c/flashrom/+/75646/comment/91d643ef_a179c1d5 : PS5, Line 34: internal_ > i understand there is no technical need, but i did it to make it more obvious that it is not coming […] I agree that "internal" almost always means internal programmer. It is flashromspeak :) It is certainly not coming from the outside because it is static. I am not sure a prefix needed, if you think it is really needed then maybe "supported_flashchips", but this doesn't add much readability. Maybe let's try without prefix? https://review.coreboot.org/c/flashrom/+/75646/comment/c86ac272_1775a663 : PS5, Line 20844: get_flashchips(void) > sure, but that would be more complex. Where would the caller get the pointer to flashchip db? and why the caller needs to have the pointer? I want to understand the idea. File flashrom.c: https://review.coreboot.org/c/flashrom/+/75646/comment/c2c93978_dd607a9f : PS5, Line 1099: return -1; Maybe you can add `msg_gerr` before returning. It seems like a big issue if the entire database of chips is absent. File tests/selfcheck.c: https://review.coreboot.org/c/flashrom/+/75646/comment/bf8cd711_d836c264 : PS5, Line 80: /* unused */ But it is used two lines below? https://review.coreboot.org/c/flashrom/+/75646/comment/ae27dd19_c5f3a407 : PS5, Line 83: flashchips = get_flashchips(); : flashchips_size = get_flashchips_size(); Can this be immediately initialised? (and the same above). This is what non-test code is doing. -- To view, visit https://review.coreboot.org/c/flashrom/+/75646?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ibc89e32c83975e01c958b8cf0d11dad73c461a53 Gerrit-Change-Number: 75646 Gerrit-PatchSet: 5 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Thu, 08 Jun 2023 13:03:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: doc: Add documentation license
by Anastasia Klimchuk (Code Review) 08 Jun '23

08 Jun '23

Attention is currently required from: Alexander Goncharov, Patrick Georgi, Stefan Reinauer, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75727?usp=email ) Change subject: doc: Add documentation license ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I have some issues with nested that which do not behave :\ but meanwhile I am looking into nested lists, I wanted to ask. I appreciate an advice, because I am not fully familiar with licensing matters... Am I correct to create a page with license text? (I copied text from coreboot page). Is there anything else needed for the docs? For example on coreboot website there is in the footer of every page: © Copyright CC-by 4.0 the coreboot project do we need the same? Thank you so much for help! -- To view, visit https://review.coreboot.org/c/flashrom/+/75727?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ied858b5f1e9c4a83a6eb21dcefb288c4474b08c0 Gerrit-Change-Number: 75727 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Thu, 08 Jun 2023 11:08:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: doc: Add documentation license
by Anastasia Klimchuk (Code Review) 08 Jun '23

08 Jun '23

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/75727?usp=email ) Change subject: doc: Add documentation license ...................................................................... doc: Add documentation license Change-Id: Ied858b5f1e9c4a83a6eb21dcefb288c4474b08c0 Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- A doc/documentation_license.rst M doc/index.rst 2 files changed, 296 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/27/75727/1 diff --git a/doc/documentation_license.rst b/doc/documentation_license.rst new file mode 100644 index 0000000..00f55c4 --- /dev/null +++ b/doc/documentation_license.rst @@ -0,0 +1,295 @@ +flashrom documentation license +============================== + +Files under doc/ are licensed under CC-BY 4.0 terms, printed below. + +Attribution 4.0 International +----------------------------- + +Creative Commons Corporation ("Creative Commons") is not a law firm and does not provide +legal services or legal advice. Distribution of Creative Commons public licenses does +not create a lawyer-client or other relationship. Creative Commons makes its licenses +and related information available on an "as-is" basis. Creative Commons gives no warranties +regarding its licenses, any material licensed under their terms and conditions, or any +related information. Creative Commons disclaims all liability for damages resulting from +their use to the fullest extent possible. + +Using Creative Commons Public Licenses +"""""""""""""""""""""""""""""""""""""" + +Creative Commons public licenses provide a standard set of terms and conditions that +creators and other rights holders may use to share original works of authorship and other +material subject to copyright and certain other rights specified in the public license below. +The following considerations are for informational purposes only, are not exhaustive, and do +not form part of our licenses. + +* **Considerations for licensors:** Our public licenses are intended for use by those + authorized to give the public permission to use material in ways otherwise restricted + by copyright and certain other rights. Our licenses are irrevocable. Licensors should + read and understand the terms and conditions of the license they choose before applying it. + Licensors should also secure all rights necessary before applying our licenses so that the + public can reuse the material as expected. Licensors should clearly mark any material not + subject to the license. This includes other CC-licensed material, or material used under an + exception or limitation to copyright. `More considerations for licensors <http://wiki.creativecommons.org/Considerations_for_licensors_and_licensees#…>`_ + +* **Considerations for the public:** By using one of our public licenses, a licensor grants + the public permission to use the licensed material under specified terms and conditions. If + the licensor's permission is not necessary for any reason - for example, because of any + applicable exception or limitation to copyright - then that use is not regulated by the + license. Our licenses grant only permissions under copyright and certain other rights that a + licensor has authority to grant. Use of the licensed material may still be restricted for + other reasons, including because others have copyright or other rights in the material. + A licensor may make special requests, such as asking that all changes be marked or described. + Although not required by our licenses, you are encouraged to respect those requests where + reasonable. `More considerations for the public <http://wiki.creativecommons.org/Considerations_for_licensors_and_licensees#…>`_ + +Creative Commons Attribution 4.0 International Public License +------------------------------------------------------------- + +By exercising the Licensed Rights (defined below), You accept and agree to be bound by the +terms and conditions of this Creative Commons Attribution 4.0 International Public License +("Public License"). To the extent this Public License may be interpreted as a contract, You +are granted the Licensed Rights in consideration of Your acceptance of these terms and +conditions, and the Licensor grants You such rights in consideration of benefits the Licensor +receives from making the Licensed Material available under these terms and conditions. + +Section 1 - Definitions. +"""""""""""""""""""""""" + +a. **Adapted Material** means material subject to Copyright and Similar Rights that is +derived from or based upon the Licensed Material and in which the Licensed Material is +translated, altered, arranged, transformed, or otherwise modified in a manner requiring +permission under the Copyright and Similar Rights held by the Licensor. For purposes of +this Public License, where the Licensed Material is a musical work, performance, or sound +recording, Adapted Material is always produced where the Licensed Material is synched in +timed relation with a moving image. + +b. **Adapter's License** means the license You apply to Your Copyright and Similar Rights +in Your contributions to Adapted Material in accordance with the terms and conditions of +this Public License. + +c. **Copyright and Similar Rights** means copyright and/or similar rights closely related +to copyright including, without limitation, performance, broadcast, sound recording, and +Sui Generis Database Rights, without regard to how the rights are labeled or categorized. +For purposes of this Public License, the rights specified in Section 2(b)(1)-(2) are not +Copyright and Similar Rights. + +d. **Effective Technological Measures** means those measures that, in the absence of proper +authority, may not be circumvented under laws fulfilling obligations under Article 11 of +the WIPO Copyright Treaty adopted on December 20, 1996, and/or similar international agreements. + +e. **Exceptions and Limitations** means fair use, fair dealing, and/or any other exception or +limitation to Copyright and Similar Rights that applies to Your use of the Licensed Material. + +f. **Licensed Material** means the artistic or literary work, database, or other material to +which the Licensor applied this Public License. + +g. **Licensed Rights** means the rights granted to You subject to the terms and conditions of +this Public License, which are limited to all Copyright and Similar Rights that apply to Your +use of the Licensed Material and that the Licensor has authority to license. + +h\. **Licensor** means the individual(s) or entity(ies) granting rights under this Public License. + +i. **Share** means to provide material to the public by any means or process that requires +permission under the Licensed Rights, such as reproduction, public display, public performance, +distribution, dissemination, communication, or importation, and to make material available to +the public including in ways that members of the public may access the material from a place +and at a time individually chosen by them. + +j. **Sui Generis Database Rights** means rights other than copyright resulting from Directive 96/9/EC +of the European Parliament and of the Council of 11 March 1996 on the legal protection of databases, +as amended and/or succeeded, as well as other essentially equivalent rights anywhere in the world. + +k. **You** means the individual or entity exercising the Licensed Rights under this Public License. +Your has a corresponding meaning. + +Section 2 - Scope. +"""""""""""""""""" + +a\. **License grant.** + + 1\. Subject to the terms and conditions of this Public License, the Licensor hereby grants You a worldwide, + royalty-free, non-sublicensable, non-exclusive, irrevocable license to exercise the Licensed Rights in + the Licensed Material to: + + A\. reproduce and Share the Licensed Material, in whole or in part; and + + B\. produce, reproduce, and Share Adapted Material. + + 2\. **Exceptions and Limitations.** For the avoidance of doubt, where Exceptions and Limitations apply + to Your use, this Public License does not apply, and You do not need to comply with its terms and conditions. + + 3\. **Term.** The term of this Public License is specified in Section 6(a). + + 4\. **Media and formats; technical modifications allowed.** The Licensor authorizes You to exercise + the Licensed Rights in all media and formats whether now known or hereafter created, and to make + technical modifications necessary to do so. The Licensor waives and/or agrees not to assert any right + or authority to forbid You from making technical modifications necessary to exercise the Licensed Rights, + including technical modifications necessary to circumvent Effective Technological Measures. For purposes + of this Public License, simply making modifications authorized by this Section 2(a)(4) never produces Adapted Material. + + 5\. **Downstream recipients.** + + A\. **Offer from the Licensor - Licensed Material.** Every recipient of the Licensed Material + automatically receives an offer from the Licensor to exercise the Licensed Rights under the + terms and conditions of this Public License. + + B\. **No downstream restrictions.** You may not offer or impose any additional or different terms + or conditions on, or apply any Effective Technological Measures to, the Licensed Material if + doing so restricts exercise of the Licensed Rights by any recipient of the Licensed Material. + + 6\. **No endorsement.** Nothing in this Public License constitutes or may be construed as permission + to assert or imply that You are, or that Your use of the Licensed Material is, connected with, or + sponsored, endorsed, or granted official status by, the Licensor or others designated to receive + attribution as provided in Section 3(a)(1)(A)(i). + +b\. **Other rights.** + + 1\. Moral rights, such as the right of integrity, are not licensed under this Public License, nor are + publicity, privacy, and/or other similar personality rights; however, to the extent possible, the + Licensor waives and/or agrees not to assert any such rights held by the Licensor to the limited extent + necessary to allow You to exercise the Licensed Rights, but not otherwise. + + 2\. Patent and trademark rights are not licensed under this Public License. + + 3\. To the extent possible, the Licensor waives any right to collect royalties from You for the exercise + of the Licensed Rights, whether directly or through a collecting society under any voluntary or waivable + statutory or compulsory licensing scheme. In all other cases the Licensor expressly reserves any right + to collect such royalties. + +Section 3 - License Conditions. +""""""""""""""""""""""""""""""""" + +Your exercise of the Licensed Rights is expressly made subject to the following conditions. + +a\. **Attribution.** + + 1\. If You Share the Licensed Material (including in modified form), You must: + + A\. retain the following if it is supplied by the Licensor with the Licensed Material: + + i\. identification of the creator(s) of the Licensed Material and any others designated to receive + attribution, in any reasonable manner requested by the Licensor (including by pseudonym if designated); + + ii\. a copyright notice; + + iii\. a notice that refers to this Public License; + + iv\. a notice that refers to the disclaimer of warranties; + + v\. a URI or hyperlink to the Licensed Material to the extent reasonably practicable; + + B\. indicate if You modified the Licensed Material and retain an indication of any previous modifications; and + + C\. indicate the Licensed Material is licensed under this Public License, and include the text of, + or the URI or hyperlink to, this Public License. + + 2\. You may satisfy the conditions in Section 3(a)(1) in any reasonable manner based on the medium, means, + and context in which You Share the Licensed Material. For example, it may be reasonable to satisfy the + conditions by providing a URI or hyperlink to a resource that includes the required information. + + 3\. If requested by the Licensor, You must remove any of the information required by Section 3(a)(1)(A) to + the extent reasonably practicable. + + 4\. If You Share Adapted Material You produce, the Adapter's License You apply must not prevent recipients + of the Adapted Material from complying with this Public License. + +Section 4 - Sui Generis Database Rights. +"""""""""""""""""""""""""""""""""""""""" + +Where the Licensed Rights include Sui Generis Database Rights that apply to Your use of the Licensed Material: + +a. for the avoidance of doubt, Section 2(a)(1) grants You the right to extract, reuse, reproduce, and Share +all or a substantial portion of the contents of the database; + +b. if You include all or a substantial portion of the database contents in a database in which You have +Sui Generis Database Rights, then the database in which You have Sui Generis Database Rights (but not its +individual contents) is Adapted Material; and + +c. You must comply with the conditions in Section 3(a) if You Share all or a substantial portion of the +contents of the database. + +For the avoidance of doubt, this Section 4 supplements and does not replace Your obligations under this +Public License where the Licensed Rights include other Copyright and Similar Rights. + +Section 5 - Disclaimer of Warranties and Limitation of Liability. +""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""" + +a. **Unless otherwise separately undertaken by the Licensor, to the extent possible, the Licensor offers +the Licensed Material as-is and as-available, and makes no representations or warranties of any kind +oncerning the Licensed Material, whether express, implied, statutory, or other. This includes, without +limitation, warranties of title, merchantability, fitness for a particular purpose, non-infringement, +absence of latent or other defects, accuracy, or the presence or absence of errors, whether or not known +or discoverable. Where disclaimers of warranties are not allowed in full or in part, this disclaimer may +not apply to You.** + +b. **To the extent possible, in no event will the Licensor be liable to You on any legal theory (including, +without limitation, negligence) or otherwise for any direct, special, indirect, incidental, consequential, +punitive, exemplary, or other losses, costs, expenses, or damages arising out of this Public License or use +of the Licensed Material, even if the Licensor has been advised of the possibility of such losses, costs, +expenses, or damages. Where a limitation of liability is not allowed in full or in part, this limitation +may not apply to You.** + +c. The disclaimer of warranties and limitation of liability provided above shall be interpreted in a manner that, +to the extent possible, most closely approximates an absolute disclaimer and waiver of all liability. + +Section 6 - Term and Termination. +""""""""""""""""""""""""""""""""" + +a. This Public License applies for the term of the Copyright and Similar Rights licensed here. However, if You +fail to comply with this Public License, then Your rights under this Public License terminate automatically. + +b. Where Your right to use the Licensed Material has terminated under Section 6(a), it reinstates: + + 1. automatically as of the date the violation is cured, provided it is cured within 30 days of Your + discovery of the violation; or + + 2. upon express reinstatement by the Licensor. + + For the avoidance of doubt, this Section 6(b) does not affect any right the Licensor may have to seek + remedies for Your violations of this Public License. + +c. For the avoidance of doubt, the Licensor may also offer the Licensed Material under separate terms or +conditions or stop distributing the Licensed Material at any time; however, doing so will not terminate this Public License. + +d. Sections 1, 5, 6, 7, and 8 survive termination of this Public License. + +Section 7 - Other Terms and Conditions. +""""""""""""""""""""""""""""""""""""""" + +a. The Licensor shall not be bound by any additional or different terms or conditions communicated by You +unless expressly agreed. + +b. Any arrangements, understandings, or agreements regarding the Licensed Material not stated herein are +separate from and independent of the terms and conditions of this Public License. + +Section 8 - Interpretation. +""""""""""""""""""""""""""" + +a. For the avoidance of doubt, this Public License does not, and shall not be interpreted to, reduce, limit, +restrict, or impose conditions on any use of the Licensed Material that could lawfully be made without +permission under this Public License. + +b. To the extent possible, if any provision of this Public License is deemed unenforceable, it shall be +automatically reformed to the minimum extent necessary to make it enforceable. If the provision cannot +be reformed, it shall be severed from this Public License without affecting the enforceability of the +remaining terms and conditions. + +c. No term or condition of this Public License will be waived and no failure to comply consented to unless +expressly agreed to by the Licensor. + +d. Nothing in this Public License constitutes or may be interpreted as a limitation upon, or waiver of, any +privileges and immunities that apply to the Licensor or You, including from the legal processes of any +jurisdiction or authority. + + Creative Commons is not a party to its public licenses. Notwithstanding, Creative Commons may elect + to apply one of its public licenses to material it publishes and in those instances will be considered + the "Licensor". Except for the limited purpose of indicating that material is shared under a + Creative Commons public license or as otherwise permitted by the Creative Commons policies published at + `creativecommons.org/policies <http://creativecommons.org/policies>`_, Creative Commons does not authorize + the use of the trademark "Creative Commons" or any other trademark or logo of Creative Commons without + its prior written consent including, without limitation, in connection with any unauthorized modifications + to any of its public licenses or any other arrangements, understandings, or agreements concerning use of + licensed material. For the avoidance of doubt, this paragraph does not form part of the public licenses. + + Creative Commons may be contacted at creativecommons.org diff --git a/doc/index.rst b/doc/index.rst index f48a214..6a0f815 100644 --- a/doc/index.rst +++ b/doc/index.rst @@ -10,6 +10,7 @@ classic_cli_manpage contact how_to_add_docs + documentation_license .. include:: intro.rst -- To view, visit https://review.coreboot.org/c/flashrom/+/75727?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ied858b5f1e9c4a83a6eb21dcefb288c4474b08c0 Gerrit-Change-Number: 75727 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[master]: doc: Add intro to the home page
by Anastasia Klimchuk (Code Review) 08 Jun '23

08 Jun '23

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/75723?usp=email ) Change subject: doc: Add intro to the home page ...................................................................... doc: Add intro to the home page The intro text is converted from wiki home page. Change-Id: I2bf0d8a3b2e16c9bb7e6fbde5931ff816aede14a Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M doc/index.rst A doc/intro.rst 2 files changed, 26 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/23/75723/1 diff --git a/doc/index.rst b/doc/index.rst index e6dcc4d..f48a214 100644 --- a/doc/index.rst +++ b/doc/index.rst @@ -11,4 +11,6 @@ contact how_to_add_docs +.. include:: intro.rst + .. include:: ../README.rst diff --git a/doc/intro.rst b/doc/intro.rst new file mode 100644 index 0000000..254555a --- /dev/null +++ b/doc/intro.rst @@ -0,0 +1,24 @@ +**flashrom** is a utility for identifying, reading, writing, verifying and erasing flash +chips. It is designed to flash BIOS/EFI/coreboot/firmware/optionROM images on mainboards, +network/graphics/storage controller cards, and various other programmer devices. + +* Supports more than 476 flash chips, 291 chipsets, 500 mainboards, 79 PCI devices, + 17 USB devices and various parallel/serial port-based programmers. +* Supports parallel, LPC, FWH and SPI flash interfaces and various chip packages (DIP32, + PLCC32, DIP8, SO8/SOIC8, TSOP32, TSOP40, TSOP48, BGA and more). +* No physical access needed, root access is sufficient (not needed for some programmers). +* No bootable floppy disk, bootable CD-ROM or other media needed. +* No keyboard or monitor needed. Simply reflash remotely via SSH. +* No instant reboot needed. Reflash your chip in a running system, verify it, be happy. + The new firmware will be present next time you boot. +* Crossflashing and hotflashing is possible as long as the flash chips are electrically + and logically compatible (same protocol). Great for recovery. +* Scriptability. Reflash a whole pool of identical machines at the same time from the + command line. It is recommended to check flashrom output and error codes. +* Speed. flashrom is often much faster than most vendor flash tools. +* Portability. Supports DOS, Linux, FreeBSD (including Debian/kFreeBSD), NetBSD, OpenBSD, + DragonFlyBSD, anything Solaris-like, Mac OS X, and other Unix-like OSes as well as GNU Hurd. + Partial Windows support is available (no internal programmer support at the moment, hence + no "BIOS flashing"). + +.. todo:: Convert Technology page and add links here -- To view, visit https://review.coreboot.org/c/flashrom/+/75723?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2bf0d8a3b2e16c9bb7e6fbde5931ff816aede14a Gerrit-Change-Number: 75723 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[master]: doc: Add build instructions for NI-845x on Windows
by Anastasia Klimchuk (Code Review) 08 Jun '23

08 Jun '23

Attention is currently required from: Alexander Goncharov, Miklós Márton, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75270?usp=email ) Change subject: doc: Add build instructions for NI-845x on Windows ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/75270?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I97ad08632f35aa241b3d19d9ce7711146e3f1f4a Gerrit-Change-Number: 75270 Gerrit-PatchSet: 7 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Thu, 08 Jun 2023 08:12:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: meson: Add support for ni845x_spi on Windows
by Anastasia Klimchuk (Code Review) 08 Jun '23

08 Jun '23

Attention is currently required from: Miklós Márton, Peter Marheine, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75236?usp=email ) Change subject: meson: Add support for ni845x_spi on Windows ...................................................................... Patch Set 6: Code-Review+1 (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/75236/comment/661b91c8_865c4261 : PS6, Line 12: choise Oh I found typo: choise -> choice Patchset: PS4: > I rebased this branch on top of master (currently b09aad573) and it built successfully for me. […] Miklos, does this work for you? I see you approved documentation patch (next one in the chain), does it mean it builds for you successfully? PS4: > Need testing: what if the include path is not available under windows? will it just ignore the non e […] Thomas, do you plan any more testing? Which include path do you mean, is that the one hardcoded in meson options, `C:\Program Files (x86)\National Instruments\Ni-845x\MS Visual C` ? -- To view, visit https://review.coreboot.org/c/flashrom/+/75236?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2d32f11852ac1a5184af8e8683ca1914a6e72973 Gerrit-Change-Number: 75236 Gerrit-PatchSet: 6 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Thu, 08 Jun 2023 08:11:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Miklós Márton <martonmiklosqdev(a)gmail.com> Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips: Add support for IS25WP016
by Anastasia Klimchuk (Code Review) 08 Jun '23

08 Jun '23

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/70140?usp=email ) ( 6 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: flashchips: Add support for IS25WP016 ...................................................................... flashchips: Add support for IS25WP016 Tested reading, writing and erasing using `linux_spi` programmer on Raspberry Pi CM4. Datasheet: https://web.archive.org/web/20221129211027/https://www.issi.com/WW/pdf/25LP… Change-Id: I2b8caea229ffda72f1b04183c31715faccb64ad5 Signed-off-by: Alex Mikhalev <alex(a)corvus-robotics.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/70140 Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M flashchips.c M include/flashchips.h 2 files changed, 43 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved Anastasia Klimchuk: Looks good to me, approved diff --git a/flashchips.c b/flashchips.c index 287e2f5..3e19659 100644 --- a/flashchips.c +++ b/flashchips.c @@ -7645,6 +7645,48 @@ { .vendor = "ISSI", + .name = "IS25WP016", + .bustype = BUS_SPI, + .manufacture_id = ISSI_ID_SPI, + .model_id = ISSI_IS25WP016, + .total_size = 2048, + .page_size = 256, + /* OTP: 1024B total; read 0x48; write 0x42 */ + /* QPI enable 0x35, disable 0xF5 */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI, + .tested = TEST_OK_PREW, + .probe = PROBE_SPI_RDID, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 512} }, + .block_erase = SPI_BLOCK_ERASE_20, + }, { + .eraseblocks = { {4 * 1024, 512} }, + .block_erase = SPI_BLOCK_ERASE_D7, + }, { + .eraseblocks = { {32 * 1024, 64} }, + .block_erase = SPI_BLOCK_ERASE_52, + }, { + .eraseblocks = { {64 * 1024, 32} }, + .block_erase = SPI_BLOCK_ERASE_D8, + }, { + .eraseblocks = { {2 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_60, + }, { + .eraseblocks = { {2 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_C7, + } + }, + .unlock = SPI_DISABLE_BLOCKPROTECT, + .write = SPI_CHIP_WRITE256, + .read = SPI_CHIP_READ, + .voltage = {1650, 1950}, + }, + + { + .vendor = "ISSI", .name = "IS25WP032", .bustype = BUS_SPI, .manufacture_id = ISSI_ID_SPI, diff --git a/include/flashchips.h b/include/flashchips.h index a0fbf55..dc4a059 100644 --- a/include/flashchips.h +++ b/include/flashchips.h @@ -476,6 +476,7 @@ #define ISSI_IS25LP064 0x6017 #define ISSI_IS25LP128 0x6018 #define ISSI_IS25LP256 0x6019 +#define ISSI_IS25WP016 0x7015 #define ISSI_IS25WP032 0x7016 #define ISSI_IS25WP064 0x7017 #define ISSI_IS25WP128 0x7018 -- To view, visit https://review.coreboot.org/c/flashrom/+/70140?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2b8caea229ffda72f1b04183c31715faccb64ad5 Gerrit-Change-Number: 70140 Gerrit-PatchSet: 9 Gerrit-Owner: Alex Mikhalev <alex(a)corvus-robotics.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[master]: flashchips: Add support for Boya BY25D80A
by Anastasia Klimchuk (Code Review) 08 Jun '23

08 Jun '23

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/73513?usp=email ) ( 7 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: flashchips: Add support for Boya BY25D80A ...................................................................... flashchips: Add support for Boya BY25D80A Read tested on Raspberry Pico with pico-serprog Change-Id: I586f3455d925132bbda3fccdad00f0b1e22c2ea7 Signed-off-by: Piotr Halama <skrzynka(a)halamix2.pl> Reviewed-on: https://review.coreboot.org/c/flashrom/+/73513 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Peter Marheine <pmarheine(a)chromium.org> --- M flashchips.c M include/flashchips.h 2 files changed, 39 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Peter Marheine: Looks good to me, approved diff --git a/flashchips.c b/flashchips.c index ccc1e8c..287e2f5 100644 --- a/flashchips.c +++ b/flashchips.c @@ -3530,6 +3530,44 @@ { .vendor = "Boya/BoHong Microelectronics", + .name = "B.25D80A", + .bustype = BUS_SPI, + .manufacture_id = BOYA_BOHONG_ID, + .model_id = BOYA_BOHONG_B__25D80A, + .total_size = 1024, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN, + .tested = TEST_OK_PR, + .probe = PROBE_SPI_RDID, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 256} }, + .block_erase = SPI_BLOCK_ERASE_20, + }, { + .eraseblocks = { {32 * 1024, 32} }, + .block_erase = SPI_BLOCK_ERASE_52, + }, { + .eraseblocks = { {64 * 1024, 16} }, + .block_erase = SPI_BLOCK_ERASE_D8, + }, { + .eraseblocks = { {1 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_60, + }, { + .eraseblocks = { {1 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_C7, + } + }, + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_BP2_SRWD, + .unlock = SPI_DISABLE_BLOCKPROTECT_BP2_SRWD, + .write = SPI_CHIP_WRITE256, + .read = SPI_CHIP_READ, + .voltage = {2700, 3600}, + }, + + { + .vendor = "Boya/BoHong Microelectronics", .name = "B.25Q128AS", .bustype = BUS_SPI, .manufacture_id = BOYA_BOHONG_ID, diff --git a/include/flashchips.h b/include/flashchips.h index aa59a6d..a0fbf55 100644 --- a/include/flashchips.h +++ b/include/flashchips.h @@ -210,6 +210,7 @@ /* Boya/BoHong Microelectronics Inc. */ #define BOYA_BOHONG_ID 0x68 +#define BOYA_BOHONG_B__25D80A 0x4014 #define BOYA_BOHONG_B_25D16A 0x4015 #define BOYA_BOHONG_B_25Q128AS 0x4018 -- To view, visit https://review.coreboot.org/c/flashrom/+/73513?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I586f3455d925132bbda3fccdad00f0b1e22c2ea7 Gerrit-Change-Number: 73513 Gerrit-PatchSet: 9 Gerrit-Owner: Piotr Halama <skrzynka(a)halamix2.pl> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in flashrom[master]: Replace all flashchips accesses with get functions
by Stefan Reinauer (Code Review) 08 Jun '23

08 Jun '23

Attention is currently required from: Anastasia Klimchuk, Edward O'Callaghan. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75646?usp=email ) Change subject: Replace all flashchips accesses with get functions ...................................................................... Patch Set 5: (6 comments) Patchset: PS5: good thoughts on the simplification.. maybe generally the API should already have an init function at this point that handles a possible failure case (flashchips = NULL) and bails out so we don't have to test for null/0 at various places in the code over and again. File flashchips.c: https://review.coreboot.org/c/flashrom/+/75646/comment/ab2028b4_0acf0ddf : PS5, Line 34: internal_ > no need to rename if it becomes static, also "internal" is a overloaded term with the internal progr […] i understand there is no technical need, but i did it to make it more obvious that it is not coming from the outside. it keeps the code easier to understand https://review.coreboot.org/c/flashrom/+/75646/comment/571ad0b5_ced6bafb : PS5, Line 20844: get_flashchips(void) > you *could* have a signature of: […] sure, but that would be more complex. https://review.coreboot.org/c/flashrom/+/75646/comment/e0d7eb5f_cdff91bf : PS5, Line 20849: unsigned int > should be `size_t` for the size of an array. maybe so. it was unsigned int before, so i didn't change it. if we want to fix that, we could do that in a separate patch that focused on that. trying to keep it to one logical change per patch File ichspi.c: https://review.coreboot.org/c/flashrom/+/75646/comment/3f7ed0e0_aa93c407 : PS5, Line 1469: const struct flashchip *chip; : : struct flashchip *flashchips=get_flashchips(); : : if (!flashchips) : return NULL; > ``` […] very clever. and doesn't check the return value. i suppose we could bail out earlier if we don't have a good database in memory File libflashrom.c: https://review.coreboot.org/c/flashrom/+/75646/comment/39849728_2d12ddb0 : PS5, Line 95: unsigned int > size_t shouldn't then i downstairs also be size_t? not against this, but it seems that is a larger consistency cleanup that needs to happen across the tree separately if this is a notion that is agreed upon. -- To view, visit https://review.coreboot.org/c/flashrom/+/75646?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ibc89e32c83975e01c958b8cf0d11dad73c461a53 Gerrit-Change-Number: 75646 Gerrit-PatchSet: 5 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 08 Jun 2023 05:08:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: Hook up mjson into build system
by Edward O'Callaghan (Code Review) 08 Jun '23

08 Jun '23

Attention is currently required from: Stefan Reinauer, Thomas Heijligen. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75648?usp=email ) Change subject: Hook up mjson into build system ...................................................................... Patch Set 5: Code-Review+1 (1 comment) File meson.build: https://review.coreboot.org/c/flashrom/+/75648/comment/595dadf1_8898f228 : PS5, Line 76: 'mjson.c', : 'flashchips.c', probably the structure should be: ``` imports/mjson/{mjson.c, meson.build} => gen 'mjson.a'. ``` && ``` flashchipdb/{flashchips.c, flashchips.h, meson.build} => gen flashchips.a ``` this affords us the path to having a feature flag for link-time decision to which db to use - builtin or parsed external. WDYT? -- To view, visit https://review.coreboot.org/c/flashrom/+/75648?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I714b35f7c869932924ff50c505ad39cf88cf3950 Gerrit-Change-Number: 75648 Gerrit-PatchSet: 5 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Thu, 08 Jun 2023 03:38:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit June 2023