Attention is currently required from: Anastasia Klimchuk, Miklós Márton, Thomas Heijligen.
Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75236?usp=email )
Change subject: meson: Add support for ni845x_spi on Windows
......................................................................
Patch Set 7: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/75236/comment/c3cd1caf_8d878293 :
PS6, Line 12: choise
> Oh I found typo: choise -> choice
Done
--
To view, visit https://review.coreboot.org/c/flashrom/+/75236?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2d32f11852ac1a5184af8e8683ca1914a6e72973
Gerrit-Change-Number: 75236
Gerrit-PatchSet: 7
Gerrit-Owner: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Comment-Date: Tue, 13 Jun 2023 02:29:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Miklós Márton, Peter Marheine, Thomas Heijligen.
Peter Marheine has uploaded a new patch set (#7) to the change originally created by Thomas Heijligen. ( https://review.coreboot.org/c/flashrom/+/75236?usp=email )
Change subject: meson: Add support for ni845x_spi on Windows
......................................................................
meson: Add support for ni845x_spi on Windows
TEST=On MSYS32 MINGW32 with ni845x library installed:
meson setup -Dprogrammer=ni845x_spi build
meson compile -C build
./build/flashrom.exe lists the ni845x_spi as choice.
Change-Id: I2d32f11852ac1a5184af8e8683ca1914a6e72973
Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com>
---
M meson.build
M meson_options.txt
M ni845x_spi.c
3 files changed, 33 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/36/75236/7
--
To view, visit https://review.coreboot.org/c/flashrom/+/75236?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2d32f11852ac1a5184af8e8683ca1914a6e72973
Gerrit-Change-Number: 75236
Gerrit-PatchSet: 7
Gerrit-Owner: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Stefan Reinauer.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75706?usp=email )
Change subject: Switch over master branch to main
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Good idea, and I think we need a plan! […]
More details about Dev guidelines: plain conversion to rst is already done in CB:74923 but what I need to do is to re-write the guidelines according to what we decided on the brainstorming session in the end of April.
Either way, should not block renaming branches.
--
To view, visit https://review.coreboot.org/c/flashrom/+/75706?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8f4a377735f3f6ab4a22006949ff294a218bdf22
Gerrit-Change-Number: 75706
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Comment-Date: Sun, 11 Jun 2023 12:13:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: comment
Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/75723?usp=email )
Change subject: doc: Add intro to the home page
......................................................................
doc: Add intro to the home page
The intro text is converted from wiki home page.
Change-Id: I2bf0d8a3b2e16c9bb7e6fbde5931ff816aede14a
Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/75723
Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
---
M doc/index.rst
A doc/intro.rst
2 files changed, 26 insertions(+), 0 deletions(-)
Approvals:
build bot (Jenkins): Verified
Stefan Reinauer: Looks good to me, approved
diff --git a/doc/index.rst b/doc/index.rst
index e6dcc4d..f48a214 100644
--- a/doc/index.rst
+++ b/doc/index.rst
@@ -11,4 +11,6 @@
contact
how_to_add_docs
+.. include:: intro.rst
+
.. include:: ../README.rst
diff --git a/doc/intro.rst b/doc/intro.rst
new file mode 100644
index 0000000..254555a
--- /dev/null
+++ b/doc/intro.rst
@@ -0,0 +1,24 @@
+**flashrom** is a utility for identifying, reading, writing, verifying and erasing flash
+chips. It is designed to flash BIOS/EFI/coreboot/firmware/optionROM images on mainboards,
+network/graphics/storage controller cards, and various other programmer devices.
+
+* Supports more than 476 flash chips, 291 chipsets, 500 mainboards, 79 PCI devices,
+ 17 USB devices and various parallel/serial port-based programmers.
+* Supports parallel, LPC, FWH and SPI flash interfaces and various chip packages (DIP32,
+ PLCC32, DIP8, SO8/SOIC8, TSOP32, TSOP40, TSOP48, BGA and more).
+* No physical access needed, root access is sufficient (not needed for some programmers).
+* No bootable floppy disk, bootable CD-ROM or other media needed.
+* No keyboard or monitor needed. Simply reflash remotely via SSH.
+* No instant reboot needed. Reflash your chip in a running system, verify it, be happy.
+ The new firmware will be present next time you boot.
+* Crossflashing and hotflashing is possible as long as the flash chips are electrically
+ and logically compatible (same protocol). Great for recovery.
+* Scriptability. Reflash a whole pool of identical machines at the same time from the
+ command line. It is recommended to check flashrom output and error codes.
+* Speed. flashrom is often much faster than most vendor flash tools.
+* Portability. Supports DOS, Linux, FreeBSD (including Debian/kFreeBSD), NetBSD, OpenBSD,
+ DragonFlyBSD, anything Solaris-like, Mac OS X, and other Unix-like OSes as well as GNU Hurd.
+ Partial Windows support is available (no internal programmer support at the moment, hence
+ no "BIOS flashing").
+
+.. todo:: Convert Technology page and add links here
--
To view, visit https://review.coreboot.org/c/flashrom/+/75723?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2bf0d8a3b2e16c9bb7e6fbde5931ff816aede14a
Gerrit-Change-Number: 75723
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Attention is currently required from: Stefan Reinauer.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75706?usp=email )
Change subject: Switch over master branch to main
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/75706/comment/46963b70_7cab36ae :
PS1, Line 7: Switch over master branch to main
Rename master branch to main
(if my understanding is correct, this is what is happening?)
Patchset:
PS1:
Good idea, and I think we need a plan!
1) It would be great to have an announcement on the mailing list, and say "ABC is going to happen next week, on Xth of June. This is the instruction how do you prepare for it:"
a) instructions what to do with local repo
b) instructions for maintainers of downstream forks
2) Update Development guidelines.
In the ideal universe, I will produce a patch very soon to convert Dev guidelines to rst, for the new website. But I don't want to block this patch if I won't have time. In this case Dev guidelines on wiki need to be updated (I can do that, we just need to coordinate).
--
To view, visit https://review.coreboot.org/c/flashrom/+/75706?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8f4a377735f3f6ab4a22006949ff294a218bdf22
Gerrit-Change-Number: 75706
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Comment-Date: Sun, 11 Jun 2023 09:31:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Stefan Reinauer has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/75706?usp=email )
Change subject: Switch over master branch to main
......................................................................
Switch over master branch to main
Change-Id: I8f4a377735f3f6ab4a22006949ff294a218bdf22
Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
---
M util/manibuilder/Makefile
M util/manibuilder/README.md
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/06/75706/1
diff --git a/util/manibuilder/Makefile b/util/manibuilder/Makefile
index 98ed30c..b1b982c 100644
--- a/util/manibuilder/Makefile
+++ b/util/manibuilder/Makefile
@@ -56,7 +56,7 @@
--env IDENT=$(call ident,$*) \
--volume manicache:/home/mani/.ccache \
--name mani_$(call ident,$*) mani/$* \
- "git fetch origin $${TEST_REVISION:-master} && \
+ "git fetch origin $${TEST_REVISION:-main} && \
git checkout FETCH_HEAD && \
$(MAKECMD) clean && $(MAKECMD) -j$${CPUS:-1} CC='$(CC)' \
$(if $(STRIP),STRIP='$(STRIP)') \
diff --git a/util/manibuilder/README.md b/util/manibuilder/README.md
index b00d618..e2ccd81 100644
--- a/util/manibuilder/README.md
+++ b/util/manibuilder/README.md
@@ -38,7 +38,7 @@
-------------
The most common use case may be testing the current upstream
-*master* branch which is the default for `$(TEST_REVISION)`.
+*main* branch which is the default for `$(TEST_REVISION)`.
You'll need roughly 20GiB for the *Docker* images. Might look
like this:
--
To view, visit https://review.coreboot.org/c/flashrom/+/75706?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8f4a377735f3f6ab4a22006949ff294a218bdf22
Gerrit-Change-Number: 75706
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-MessageType: newchange
Attention is currently required from: Aarya, Simon Buhrow, Thomas Heijligen.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67535?usp=email )
Change subject: tests: Unit tests for erase function selection algo
......................................................................
Patch Set 9:
(1 comment)
Patchset:
PS8:
> I made it work! […]
I started implementing assertions for expected order of erase blocks invocations, and discovered that each erase block is called twice.
I don't know yet whether it's something in the test, or in the code.
It was not the case in October, but since then both test and code has changed.
I uploaded the latest test that I have, if anyone is interested to have a look!
I don't see anything obvious in the test which would make invoke each eraser twice. Will try to debug later: if there is an issue in the code, it needs to be fixed.
--
To view, visit https://review.coreboot.org/c/flashrom/+/67535?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8f3fdefb76e71f6f8dc295d9dead5f38642aace7
Gerrit-Change-Number: 67535
Gerrit-PatchSet: 9
Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Aarya <aarya.chaumal(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Simon Buhrow
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-CC: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Attention: Simon Buhrow
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com>
Gerrit-Comment-Date: Sat, 10 Jun 2023 12:11:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Aarya, Simon Buhrow, Thomas Heijligen.
Hello Aarya, Edward O'Callaghan, Simon Buhrow, Thomas Heijligen, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/67535?usp=email
to look at the new patch set (#9).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: tests: Unit tests for erase function selection algo
......................................................................
tests: Unit tests for erase function selection algo
The test checks that algorithm for erase functions selection
works and there are no regressions.
Specifically, test contains a number of test cases (14 at the
time of writing, but more can be added). Each case initialises a
given initial state of the memory for the mock chip, and layout
regions on the chip, and then performs erase and write operations.
At the end of operation, test asserts the state of mock chip memory
is as expected, i.e. properly erased and written.
Also test asserts operation returned 0.
TODO to be added soon: assert that erase blocks are invoked in
expected order. This part tests there are no regressions to the
algorithm.
Change-Id: I8f3fdefb76e71f6f8dc295d9dead5f38642aace7
Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org>
---
A tests/erase_func_algo.c
M tests/meson.build
M tests/tests.c
M tests/tests.h
4 files changed, 564 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/35/67535/9
--
To view, visit https://review.coreboot.org/c/flashrom/+/67535?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8f3fdefb76e71f6f8dc295d9dead5f38642aace7
Gerrit-Change-Number: 67535
Gerrit-PatchSet: 9
Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Aarya <aarya.chaumal(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Simon Buhrow
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-CC: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Attention: Simon Buhrow
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com>
Gerrit-MessageType: newpatchset