Jean THOMAS has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67878?usp=email )
Change subject: dirtyjtag: Add DirtyJTAG programmer
......................................................................
Patch Set 17:
(1 comment)
Patchset:
PS17:
> There's a typo in the Makefile. We should be adding to FEATURE_FLAGS not FEATURE_CFLAGS. […]
Taken care of in https://review.coreboot.org/c/flashrom/+/75891
--
To view, visit https://review.coreboot.org/c/flashrom/+/67878?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ic43e9a014ed7d04e429e73b30c9dcfdde1a78913
Gerrit-Change-Number: 67878
Gerrit-PatchSet: 17
Gerrit-Owner: Jean THOMAS <virgule(a)jeanthomas.me>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-CC: David Williams
Gerrit-Comment-Date: Thu, 15 Jun 2023 21:10:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: David Williams
Gerrit-MessageType: comment
Attention is currently required from: David Williams, Thomas Heijligen.
Jean THOMAS has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75891?usp=email )
Change subject: Makefile: Fix DirtyJTAG build
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Hi everyone,
Earlier this month David reported an issue with the Makefile which prevented DirtyJTAG from being used with flashrom when built using the Makefile. I think I missed this issue when I added support for DirtyJTAG as I was only testing builds with meson.
This patch fixes the typo and finally brings DirtyJTAG for Make enthusiasts.
Jean.
--
To view, visit https://review.coreboot.org/c/flashrom/+/75891?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4b6bce24f34848d11731f4bc118a3052fb24e639
Gerrit-Change-Number: 75891
Gerrit-PatchSet: 2
Gerrit-Owner: Jean THOMAS <virgule(a)jeanthomas.me>
Gerrit-Reviewer: David Williams
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: David Williams
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Comment-Date: Thu, 15 Jun 2023 21:04:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Jean THOMAS, Thomas Heijligen.
Hello Thomas Heijligen, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/75891?usp=email
to look at the new patch set (#2).
Change subject: Makefile: Fix DirtyJTAG build
......................................................................
Makefile: Fix DirtyJTAG build
Fix typo where "FEATURE_FLAGS" is spelled "FEATURE_CFLAGS", preventing
the DirtyJTAG driver from being used.
Signed-off-by: Jean THOMAS <virgule(a)jeanthomas.me>
Change-Id: I4b6bce24f34848d11731f4bc118a3052fb24e639
---
M Makefile
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/91/75891/2
--
To view, visit https://review.coreboot.org/c/flashrom/+/75891?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4b6bce24f34848d11731f4bc118a3052fb24e639
Gerrit-Change-Number: 75891
Gerrit-PatchSet: 2
Gerrit-Owner: Jean THOMAS <virgule(a)jeanthomas.me>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Jean THOMAS <virgule(a)jeanthomas.me>
Gerrit-MessageType: newpatchset
Attention is currently required from: Edward O'Callaghan, eshankelkar(a)galorithm.com.
Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/71872?usp=email )
Change subject: ichspi.c: Bug fix for ich_hwseq_get_flash_id
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/flashrom/+/71872?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I35c112cd032e3b94e30c347766764392d5bbfe3d
Gerrit-Change-Number: 71872
Gerrit-PatchSet: 1
Gerrit-Owner: eshankelkar(a)galorithm.com
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Attention: eshankelkar(a)galorithm.com
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Comment-Date: Thu, 15 Jun 2023 03:54:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment