June 2023 - flashrom-gerrit - mail.coreboot.org

[XS] Change in flashrom[master]: flashrom MAINTAINERS: Add Martin Roth as reviewer for AMD SPI
by Anastasia Klimchuk (Code Review) 16 Jun '23

16 Jun '23

Attention is currently required from: Martin L Roth, Martin Roth. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74954?usp=email ) Change subject: flashrom MAINTAINERS: Add Martin Roth as reviewer for AMD SPI ...................................................................... Patch Set 1: (1 comment) File MAINTAINERS: https://review.coreboot.org/c/flashrom/+/74954/comment/480bc9dc_94779102 : PS1, Line 133: R: Martin maybe you would agree to be `M:` ? There can be multiple people on the same item. -- To view, visit https://review.coreboot.org/c/flashrom/+/74954?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I27a07be1549ef070ad72b8e657d72170c7e85620 Gerrit-Change-Number: 74954 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Fri, 16 Jun 2023 13:24:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: MAINTAINERS: Add Anastasia Klimchuk for flashchips
by Anastasia Klimchuk (Code Review) 16 Jun '23

16 Jun '23

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/75895?usp=email ) Change subject: MAINTAINERS: Add Anastasia Klimchuk for flashchips ...................................................................... MAINTAINERS: Add Anastasia Klimchuk for flashchips Change-Id: I82049c6686b7199dec55082ab9cbe71bfa89d2d7 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M MAINTAINERS 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/95/75895/1 diff --git a/MAINTAINERS b/MAINTAINERS index c8e4453..98165dd 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -97,6 +97,12 @@ F: erasure_layout* F: include/erasure_layout* +FLASHCHIPS +M: Anastasia Klimchuk <aklm(a)chromium.org> +S: Maintained +F: flashchips* +F: include/flashchips* + I2C HELPERS M: Peter Marheine <pmarheine(a)chromium.org> S: Supported -- To view, visit https://review.coreboot.org/c/flashrom/+/75895?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I82049c6686b7199dec55082ab9cbe71bfa89d2d7 Gerrit-Change-Number: 75895 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

[M] Change in flashrom[master]: flashchips.c: Adding support for ISSI IS25WP020/40/80
by Anastasia Klimchuk (Code Review) 16 Jun '23

16 Jun '23

Attention is currently required from: Ao Zhong. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75830?usp=email ) Change subject: flashchips.c: Adding support for ISSI IS25WP020/40/80 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Hello Ao, thank you for the patch! It is great that you added the logs, but the logs a too long for commit message. Could you please use the paste service https://paste.flashrom.org/ to save the logs, and then add a link to your paste in commit message? -- To view, visit https://review.coreboot.org/c/flashrom/+/75830?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8a786de5cf9ffefb2d57f89bbab71e289b5c2b28 Gerrit-Change-Number: 75830 Gerrit-PatchSet: 1 Gerrit-Owner: Ao Zhong <hacc1225(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Ao Zhong <hacc1225(a)gmail.com> Gerrit-Comment-Date: Fri, 16 Jun 2023 13:01:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips: add support for MX77L25650F chip
by Anastasia Klimchuk (Code Review) 16 Jun '23

16 Jun '23

Attention is currently required from: Angel Pons, Artur Kowalski. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68557?usp=email ) Change subject: flashchips: add support for MX77L25650F chip ...................................................................... Patch Set 4: (3 comments) Patchset: PS4: A thread on the mailing list adding the same chip: https://mail.coreboot.org/hyperkitty/list/flashrom@flashrom.org/thread/ZVRE… There are more erasers on the ml, what's in the datasheet? File flashchips.c: https://review.coreboot.org/c/flashrom/+/68557/comment/dd2548c0_390bc809 : PS4, Line 10428: .vendor = "Macronix", The values need to be tab-aligned, see the other entries. https://review.coreboot.org/c/flashrom/+/68557/comment/646d2836_055d979b : PS4, Line 10452: }, The voltage is missing? -- To view, visit https://review.coreboot.org/c/flashrom/+/68557?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iaea5485f8b59b8538dc47beada2c308376ea027c Gerrit-Change-Number: 68557 Gerrit-PatchSet: 4 Gerrit-Owner: Artur Kowalski <artur.kowalski(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Artur Kowalski <arturkow2000(a)gmail.com> Gerrit-Attention: Artur Kowalski <artur.kowalski(a)3mdeb.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 16 Jun 2023 11:17:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips: add support for MX25V16066/KH25V16066
by Anastasia Klimchuk (Code Review) 16 Jun '23

16 Jun '23

Attention is currently required from: Joseph Goh. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68278?usp=email ) Change subject: flashchips: add support for MX25V16066/KH25V16066 ...................................................................... Patch Set 2: (3 comments) Patchset: PS1: > Hello, no worries. Here is the datasheet I used: https://www.mxic.com. […] Thanks for datasheets! I uploaded new patchset, because since the time you pushed the initial version of the patch we made changes to flashchips db and replaced function pointers with enums. I thought it's a bit unfair to dump this migration on you. However, I have few comments about the numbers, have a look at my other comments. Also, would it be possible for you to test the chip again, on the latest version of code? Thank you! File flashchips.c: https://review.coreboot.org/c/flashrom/+/68278/comment/630915d1_6118d959 : PS2, Line 8772: MACRONIX_MX25L1605 This is 0x2015 but looking at the datasheet this chip may be 0x2014 ? https://review.coreboot.org/c/flashrom/+/68278/comment/3af72d49_dd18cda9 : PS2, Line 8802: 2700 datasheet says 2.3V ? -- To view, visit https://review.coreboot.org/c/flashrom/+/68278?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic5f0548f023fcd09a970148586497e00414ad1ae Gerrit-Change-Number: 68278 Gerrit-PatchSet: 2 Gerrit-Owner: Joseph Goh <josephgoh7(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Joseph Goh <josephgoh7(a)gmail.com> Gerrit-Comment-Date: Fri, 16 Jun 2023 10:04:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Joseph Goh <josephgoh7(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips: add support for MX25V16066/KH25V16066
by Anastasia Klimchuk (Code Review) 16 Jun '23

16 Jun '23

Attention is currently required from: Anastasia Klimchuk. Anastasia Klimchuk has uploaded a new patch set (#2) to the change originally created by Joseph Goh. ( https://review.coreboot.org/c/flashrom/+/68278?usp=email ) The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: flashchips: add support for MX25V16066/KH25V16066 ...................................................................... flashchips: add support for MX25V16066/KH25V16066 Change-Id: Ic5f0548f023fcd09a970148586497e00414ad1ae Signed-off-by: Joseph Goh <josephgoh7(a)gmail.com> Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M flashchips.c 1 file changed, 38 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/78/68278/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/68278?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic5f0548f023fcd09a970148586497e00414ad1ae Gerrit-Change-Number: 68278 Gerrit-PatchSet: 2 Gerrit-Owner: Joseph Goh <josephgoh7(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: flashchips: Add support for XMC XM25QH128A
by Anastasia Klimchuk (Code Review) 16 Jun '23

16 Jun '23

Attention is currently required from: Angel Pons, Nikolai Artemiev, foss(a)volatilesystems.org. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69309?usp=email ) Change subject: flashchips: Add support for XMC XM25QH128A ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Patchset: PS3: Nikolai, may I ask you to check reg_bits in this chip definition? I checked the rest and replaced remaining fn pointers with enums. Thank you! -- To view, visit https://review.coreboot.org/c/flashrom/+/69309?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iced40403c6694a55fd648ea2785cdcba21712234 Gerrit-Change-Number: 69309 Gerrit-PatchSet: 3 Gerrit-Owner: foss(a)volatilesystems.org Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: foss(a)volatilesystems.org Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Fri, 16 Jun 2023 09:18:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips: Add support for XMC XM25QH128A
by Anastasia Klimchuk (Code Review) 16 Jun '23

16 Jun '23

Attention is currently required from: Angel Pons, foss(a)volatilesystems.org. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69309?usp=email ) Change subject: flashchips: Add support for XMC XM25QH128A ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/69309/comment/64e83d68_e2e3cd86 : PS1, Line 8: > > Has been read/write/erase tested. Is that sufficient and if not what other info should I provide? […] Done Commit Message: https://review.coreboot.org/c/flashrom/+/69309/comment/824ddc79_c6e757cc : PS2, Line 7: . > Remove the dot. […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/69309?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iced40403c6694a55fd648ea2785cdcba21712234 Gerrit-Change-Number: 69309 Gerrit-PatchSet: 3 Gerrit-Owner: foss(a)volatilesystems.org Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: foss(a)volatilesystems.org Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 16 Jun 2023 09:13:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Comment-In-Reply-To: foss(a)volatilesystems.org Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips: Add support for XMC XM25QH128A
by Anastasia Klimchuk (Code Review) 16 Jun '23

16 Jun '23

Attention is currently required from: Angel Pons, foss(a)volatilesystems.org. Anastasia Klimchuk has uploaded a new patch set (#3) to the change originally created by foss(a)volatilesystems.org. ( https://review.coreboot.org/c/flashrom/+/69309?usp=email ) The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: flashchips: Add support for XMC XM25QH128A ...................................................................... flashchips: Add support for XMC XM25QH128A Tested: read, write and erase. Chip (and datasheet) have recenty been removed from XMC's website but can still be retrieved through web archive: https://web.archive.org/web/20221122191724/https://www.semiee.com/file/XMC/… Signed-off-by: Stijn Segers <foss(a)volatilesystems.org> Change-Id: Iced40403c6694a55fd648ea2785cdcba21712234 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M flashchips.c M include/flashchips.h 2 files changed, 49 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/09/69309/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/69309?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iced40403c6694a55fd648ea2785cdcba21712234 Gerrit-Change-Number: 69309 Gerrit-PatchSet: 3 Gerrit-Owner: foss(a)volatilesystems.org Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: foss(a)volatilesystems.org Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in flashrom[master]: Makefile: Fix DirtyJTAG build
by Anastasia Klimchuk (Code Review) 16 Jun '23

16 Jun '23

Attention is currently required from: David Williams, Jean THOMAS, Peter Marheine, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75891?usp=email ) Change subject: Makefile: Fix DirtyJTAG build ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Patchset: PS3: Jean, thank you so much for your patch! I rebase it so that Jenkins re-runs and verifies the patch. When only commit message is changed, Jenkins does not re-run (even though it failed because of commit message! :)). -- To view, visit https://review.coreboot.org/c/flashrom/+/75891?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I4b6bce24f34848d11731f4bc118a3052fb24e639 Gerrit-Change-Number: 75891 Gerrit-PatchSet: 3 Gerrit-Owner: Jean THOMAS <virgule(a)jeanthomas.me> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: David Williams Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: David Williams Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Jean THOMAS <virgule(a)jeanthomas.me> Gerrit-Comment-Date: Fri, 16 Jun 2023 01:19:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit June 2023