June 2023 - flashrom-gerrit - mail.coreboot.org

[S] Change in flashrom[master]: flashrom: only unlock for write/erase operations
by Nikolai Artemiev (Code Review) 21 Jun '23

21 Jun '23

Nikolai Artemiev has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/75991?usp=email ) Change subject: flashrom: only unlock for write/erase operations ...................................................................... flashrom: only unlock for write/erase operations Don't unlock for read/verify operations because most chips don't have read locks, and the ones that do aren't supported by flashrom's unlock functions anyway. Unconditionally unlocking slows down flashrom significantly with some programmers, particularly linux_mtd due to inefficiency in the current kernel MTD interface. BUG=b:283779258 BRANCH=none TEST=`ninja test` TEST=`flashrom -{r,w,E,v}` on strongbad TEST=`flashrom --wp-enable; flashrom -{w,E}` on strongbad Change-Id: I5dc66474a0b7969b51b86ac9f5daa2c95ae968f1 Signed-off-by: Nikolai Artemiev <nartemiev(a)google.com> --- M flashrom.c 1 file changed, 15 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/91/75991/1 diff --git a/flashrom.c b/flashrom.c index b6e5cf8..918bcea 100644 --- a/flashrom.c +++ b/flashrom.c @@ -2092,17 +2092,23 @@ /* Initialize chip_restore_fn_count before chip unlock calls. */ flash->chip_restore_fn_count = 0; - /* Given the existence of read locks, we want to unlock for read, erase and write. */ + /* + * Only unlock for erase and write. Read and verify generally do not + * require unlocking. Some chips have read locks, but flashrom's chip + * drivers don't support disabling them anyway. + */ int ret = 1; - if (flash->chip->decode_range != NO_DECODE_RANGE_FUNC || - (flash->mst->buses_supported & BUS_PROG && flash->mst->opaque.wp_write_cfg)) { - ret = unlock_flash_wp(flash); - if (ret) - msg_cerr("Failed to unlock flash status reg with wp support.\n"); + if (write_it || erase_it) { + if (flash->chip->decode_range != NO_DECODE_RANGE_FUNC || + (flash->mst->buses_supported & BUS_PROG && flash->mst->opaque.wp_write_cfg)) { + ret = unlock_flash_wp(flash); + if (ret) + msg_cerr("Failed to unlock flash status reg with wp support.\n"); + } + blockprotect_func_t *bp_func = lookup_blockprotect_func_ptr(flash->chip); + if (ret && bp_func) + bp_func(flash); } - blockprotect_func_t *bp_func = lookup_blockprotect_func_ptr(flash->chip); - if (ret && bp_func) - bp_func(flash); flash->address_high_byte = -1; flash->in_4ba_mode = false; -- To view, visit https://review.coreboot.org/c/flashrom/+/75991?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5dc66474a0b7969b51b86ac9f5daa2c95ae968f1 Gerrit-Change-Number: 75991 Gerrit-PatchSet: 1 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: newchange

1 0

[XS] Change in flashrom[master]: ichspi.c: Bug fix for ich_hwseq_get_flash_id
by Anastasia Klimchuk (Code Review) 20 Jun '23

20 Jun '23

Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev, eshankelkar(a)galorithm.com. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/71872?usp=email ) Change subject: ichspi.c: Bug fix for ich_hwseq_get_flash_id ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Okay I rebased since there was a merge conflict that needed to be resolved manually. Nikolai could you please approve again? Thank you! -- To view, visit https://review.coreboot.org/c/flashrom/+/71872?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I35c112cd032e3b94e30c347766764392d5bbfe3d Gerrit-Change-Number: 71872 Gerrit-PatchSet: 2 Gerrit-Owner: eshankelkar(a)galorithm.com Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: eshankelkar(a)galorithm.com Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Tue, 20 Jun 2023 09:14:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: ichspi.c: Bug fix for ich_hwseq_get_flash_id
by Anastasia Klimchuk (Code Review) 20 Jun '23

20 Jun '23

Attention is currently required from: Anastasia Klimchuk, Edward O'Callaghan, Nikolai Artemiev, eshankelkar(a)galorithm.com. Anastasia Klimchuk has uploaded a new patch set (#2) to the change originally created by eshankelkar(a)galorithm.com. ( https://review.coreboot.org/c/flashrom/+/71872?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by Nikolai Artemiev, Verified+1 by build bot (Jenkins) The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: ichspi.c: Bug fix for ich_hwseq_get_flash_id ...................................................................... ichspi.c: Bug fix for ich_hwseq_get_flash_id In ich_hwseq_get_flash_id, flash_id_to_entry would return address of a structure present in flashchips array corresponding to provided manufacture_id and model_id. If this function returns NULL and if we don't return after printing the warning using msg_pwarn, we'll be dereferencing a NULL pointer, hence the return in that if is provided. Change-Id: I35c112cd032e3b94e30c347766764392d5bbfe3d Signed-off-by: Eshan Kelkar <eshangalorithm(a)gmail.com> Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M ichspi.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/72/71872/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/71872?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I35c112cd032e3b94e30c347766764392d5bbfe3d Gerrit-Change-Number: 71872 Gerrit-PatchSet: 2 Gerrit-Owner: eshankelkar(a)galorithm.com Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: eshankelkar(a)galorithm.com Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[XS] Change in flashrom[master]: ichspi.c: Bug fix for ich_hwseq_get_flash_id
by Nikolai Artemiev (Code Review) 20 Jun '23

20 Jun '23

Attention is currently required from: Anastasia Klimchuk, Edward O'Callaghan, eshankelkar(a)galorithm.com. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/71872?usp=email ) Change subject: ichspi.c: Bug fix for ich_hwseq_get_flash_id ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Nikolai, just to check, so is this normal if `ich_hwseq_get_flash_id` doesn't write anything into `f […] That's right, it is ok for this function to return without copying anything, -- To view, visit https://review.coreboot.org/c/flashrom/+/71872?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I35c112cd032e3b94e30c347766764392d5bbfe3d Gerrit-Change-Number: 71872 Gerrit-PatchSet: 1 Gerrit-Owner: eshankelkar(a)galorithm.com Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: eshankelkar(a)galorithm.com Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 20 Jun 2023 00:19:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: ichspi.c: Bug fix for ich_hwseq_get_flash_id
by Anastasia Klimchuk (Code Review) 19 Jun '23

19 Jun '23

Attention is currently required from: Edward O'Callaghan, eshankelkar(a)galorithm.com. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/71872?usp=email ) Change subject: ichspi.c: Bug fix for ich_hwseq_get_flash_id ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Nikolai, just to check, so is this normal if `ich_hwseq_get_flash_id` doesn't write anything into `flash->chip` and just returns, this is not an error? -- To view, visit https://review.coreboot.org/c/flashrom/+/71872?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I35c112cd032e3b94e30c347766764392d5bbfe3d Gerrit-Change-Number: 71872 Gerrit-PatchSet: 1 Gerrit-Owner: eshankelkar(a)galorithm.com Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: eshankelkar(a)galorithm.com Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Mon, 19 Jun 2023 11:35:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: dirtyjtag: Add DirtyJTAG programmer
by Anastasia Klimchuk (Code Review) 19 Jun '23

19 Jun '23

Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67878?usp=email ) Change subject: dirtyjtag: Add DirtyJTAG programmer ...................................................................... Patch Set 17: (1 comment) Patchset: PS17: > Taken care of in https://review.coreboot. […] David, do you have more details, maybe logs or error messages that you can give? It's hard to understand the issue otherwise. The programmer has been tested, but it usually details that matter. If you could give details, maybe you can post on the mailing list? Or if you have account, maybe you can create issue on https://ticket.coreboot.org/projects/flashrom ? Whatever you prefer. thank you! -- To view, visit https://review.coreboot.org/c/flashrom/+/67878?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic43e9a014ed7d04e429e73b30c9dcfdde1a78913 Gerrit-Change-Number: 67878 Gerrit-PatchSet: 17 Gerrit-Owner: Jean THOMAS <virgule(a)jeanthomas.me> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: David Williams Gerrit-Comment-Date: Mon, 19 Jun 2023 11:29:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: David Williams Comment-In-Reply-To: Jean THOMAS <virgule(a)jeanthomas.me> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips: change chip lock status funcs for Winbond chips
by Alexander Goncharov (Code Review) 19 Jun '23

19 Jun '23

Alexander Goncharov has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/75877?usp=email ) Change subject: flashchips: change chip lock status funcs for Winbond chips ...................................................................... flashchips: change chip lock status funcs for Winbond chips Decode status register bits for user friendly output. Signed-off-by: Alexander Goncharov <chat(a)joursoir.net> Change-Id: I5066863b514825aee0dffe496492514ac99b6e49 --- M flashchips.c 1 file changed, 21 insertions(+), 21 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/77/75877/1 diff --git a/flashchips.c b/flashchips.c index 3f09687..8a99309 100644 --- a/flashchips.c +++ b/flashchips.c @@ -17874,7 +17874,7 @@ .block_erase = SPI_BLOCK_ERASE_C7, } }, - .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_PLAIN, /* TODO: improve */ + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_AMIC_A25L032, .unlock = SPI_DISABLE_BLOCKPROTECT, .write = SPI_CHIP_WRITE256, .read = SPI_CHIP_READ, @@ -17923,7 +17923,7 @@ .block_erase = SPI_BLOCK_ERASE_C7, } }, - .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_PLAIN, + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_AMIC_A25L032, .unlock = SPI_DISABLE_BLOCKPROTECT, .write = SPI_CHIP_WRITE256, .read = SPI_CHIP_READ, @@ -17973,7 +17973,7 @@ .block_erase = SPI_BLOCK_ERASE_C7, } }, - .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_PLAIN, /* TODO: improve */ + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_AMIC_A25L032, .unlock = SPI_DISABLE_BLOCKPROTECT, .write = SPI_CHIP_WRITE256, .read = SPI_CHIP_READ, @@ -18021,7 +18021,7 @@ .block_erase = SPI_BLOCK_ERASE_C7, } }, - .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_PLAIN, /* TODO: improve */ + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_AMIC_A25L032, .unlock = SPI_DISABLE_BLOCKPROTECT, .write = SPI_CHIP_WRITE256, .read = SPI_CHIP_READ, @@ -18071,7 +18071,7 @@ .block_erase = SPI_BLOCK_ERASE_C7, } }, - .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_PLAIN, /* TODO: improve */ + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_AMIC_A25L032, .unlock = SPI_DISABLE_BLOCKPROTECT, .write = SPI_CHIP_WRITE256, .read = SPI_CHIP_READ, @@ -18202,7 +18202,7 @@ .block_erase = SPI_BLOCK_ERASE_C7, } }, - .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_PLAIN, /* TODO: improve */ + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_BP3_SRWD, .unlock = SPI_DISABLE_BLOCKPROTECT, .write = SPI_CHIP_WRITE256, .read = SPI_CHIP_READ, @@ -18257,7 +18257,7 @@ .block_erase = SPI_BLOCK_ERASE_C7, } }, - .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_PLAIN, /* TODO: improve */ + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_BP3_SRWD, .unlock = SPI_DISABLE_BLOCKPROTECT, .write = SPI_CHIP_WRITE256, .read = SPI_CHIP_READ, @@ -18312,7 +18312,7 @@ .block_erase = SPI_BLOCK_ERASE_C7, } }, - .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_PLAIN, /* TODO: improve */ + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_BP3_SRWD, .unlock = SPI_DISABLE_BLOCKPROTECT, .write = SPI_CHIP_WRITE256, .read = SPI_CHIP_READ, @@ -18367,7 +18367,7 @@ .block_erase = SPI_BLOCK_ERASE_C7, } }, - .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_PLAIN, /* TODO: improve */ + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_BP3_SRWD, .unlock = SPI_DISABLE_BLOCKPROTECT, .write = SPI_CHIP_WRITE256, .read = SPI_CHIP_READ, @@ -18414,7 +18414,7 @@ .block_erase = SPI_BLOCK_ERASE_C7, } }, - .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_PLAIN, /* TODO: improve */ + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_BP3_SRWD, .unlock = SPI_DISABLE_BLOCKPROTECT, .write = SPI_CHIP_WRITE256, .read = SPI_CHIP_READ, @@ -18464,7 +18464,7 @@ .block_erase = SPI_BLOCK_ERASE_C7, } }, - .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_PLAIN, /* TODO: improve */ + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_AMIC_A25L032, .unlock = SPI_DISABLE_BLOCKPROTECT, .write = SPI_CHIP_WRITE256, .read = SPI_CHIP_READ, @@ -18515,7 +18515,7 @@ .block_erase = SPI_BLOCK_ERASE_C7, } }, - .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_PLAIN, /* TODO: improve */ + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_AMIC_A25L032, .unlock = SPI_DISABLE_BLOCKPROTECT, .write = SPI_CHIP_WRITE256, .read = SPI_CHIP_READ, @@ -18567,7 +18567,7 @@ .block_erase = SPI_BLOCK_ERASE_C7, } }, - .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_PLAIN, /* TODO: improve */ + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_AMIC_A25L032, .unlock = SPI_DISABLE_BLOCKPROTECT, .write = SPI_CHIP_WRITE256, .read = SPI_CHIP_READ, @@ -18618,7 +18618,7 @@ .block_erase = SPI_BLOCK_ERASE_C7, } }, - .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_PLAIN, /* TODO: improve */ + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_AMIC_A25L032, .unlock = SPI_DISABLE_BLOCKPROTECT, .write = SPI_CHIP_WRITE256, .read = SPI_CHIP_READ, @@ -18669,7 +18669,7 @@ .block_erase = SPI_BLOCK_ERASE_C7, } }, - .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_PLAIN, /* TODO: improve */ + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_AMIC_A25L032, .unlock = SPI_DISABLE_BLOCKPROTECT, .write = SPI_CHIP_WRITE256, .read = SPI_CHIP_READ, @@ -18721,7 +18721,7 @@ .block_erase = SPI_BLOCK_ERASE_C7, } }, - .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_PLAIN, /* TODO: improve */ + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_AMIC_A25L032, .unlock = SPI_DISABLE_BLOCKPROTECT, .write = SPI_CHIP_WRITE256, .read = SPI_CHIP_READ, @@ -18773,7 +18773,7 @@ .block_erase = SPI_BLOCK_ERASE_C7, } }, - .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_BP2_TB_BPL, + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_AMIC_A25L032, .unlock = SPI_DISABLE_BLOCKPROTECT_BP2_SRWD, .write = SPI_CHIP_WRITE256, .read = SPI_CHIP_READ, @@ -19040,7 +19040,7 @@ .block_erase = SPI_BLOCK_ERASE_C7, } }, - .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_PLAIN, /* TODO: improve */ + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_AMIC_A25L032, .unlock = SPI_DISABLE_BLOCKPROTECT, .write = SPI_CHIP_WRITE256, .read = SPI_CHIP_READ, @@ -19182,7 +19182,7 @@ .block_erase = SPI_BLOCK_ERASE_C7, } }, - .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_PLAIN, /* TODO: improve */ + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_AMIC_A25L032, .unlock = SPI_DISABLE_BLOCKPROTECT, .write = SPI_CHIP_WRITE256, .read = SPI_CHIP_READ, @@ -19232,7 +19232,7 @@ .block_erase = SPI_BLOCK_ERASE_C7, } }, - .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_PLAIN, /* TODO: improve */ + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_AMIC_A25L032, .unlock = SPI_DISABLE_BLOCKPROTECT, .write = SPI_CHIP_WRITE256, .read = SPI_CHIP_READ, @@ -20565,7 +20565,7 @@ .block_erase = SPI_BLOCK_ERASE_C7, } }, - .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_PLAIN, + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_AMIC_A25L032, .unlock = SPI_DISABLE_BLOCKPROTECT, .write = SPI_CHIP_WRITE256, .read = SPI_CHIP_READ, -- To view, visit https://review.coreboot.org/c/flashrom/+/75877?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5066863b514825aee0dffe496492514ac99b6e49 Gerrit-Change-Number: 75877 Gerrit-PatchSet: 1 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: newchange

1 0

[XS] Change in flashrom[master]: Makefile: Fix DirtyJTAG build
by Anastasia Klimchuk (Code Review) 19 Jun '23

19 Jun '23

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/75891?usp=email ) Change subject: Makefile: Fix DirtyJTAG build ...................................................................... Makefile: Fix DirtyJTAG build Fix typo where "FEATURE_FLAGS" is spelled "FEATURE_CFLAGS", preventing the DirtyJTAG driver from being used. Signed-off-by: Jean THOMAS <virgule(a)jeanthomas.me> Change-Id: I4b6bce24f34848d11731f4bc118a3052fb24e639 Reviewed-on: https://review.coreboot.org/c/flashrom/+/75891 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Peter Marheine <pmarheine(a)chromium.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Anastasia Klimchuk: Looks good to me, approved build bot (Jenkins): Verified Peter Marheine: Looks good to me, approved diff --git a/Makefile b/Makefile index da5203e..5827cab 100644 --- a/Makefile +++ b/Makefile @@ -828,7 +828,7 @@ endif ifeq ($(CONFIG_DIRTYJTAG_SPI), yes) -FEATURE_CFLAGS += -D'CONFIG_DIRTYJTAG_SPI=1' +FEATURE_FLAGS += -D'CONFIG_DIRTYJTAG_SPI=1' PROGRAMMER_OBJS += dirtyjtag_spi.o ACTIVE_PROGRAMMERS += dirtyjtag_spi endif -- To view, visit https://review.coreboot.org/c/flashrom/+/75891?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I4b6bce24f34848d11731f4bc118a3052fb24e639 Gerrit-Change-Number: 75891 Gerrit-PatchSet: 4 Gerrit-Owner: Jean THOMAS <virgule(a)jeanthomas.me> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: David Williams Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in flashrom[master]: Revert "MAINTAINERS: Add Arthur Heymans for sb600spi"
by Anastasia Klimchuk (Code Review) 19 Jun '23

19 Jun '23

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/75901?usp=email ) Change subject: Revert "MAINTAINERS: Add Arthur Heymans for sb600spi" ...................................................................... Revert "MAINTAINERS: Add Arthur Heymans for sb600spi" This reverts commit 0bc84bfe4a2b9bb8cbfa719f6221eef2d8f866ca. Change-Id: Ie538337a409f606b717d7104fad346b708f9e2f8 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-on: https://review.coreboot.org/c/flashrom/+/75901 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M MAINTAINERS 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: build bot (Jenkins): Verified Anastasia Klimchuk: Looks good to me, approved diff --git a/MAINTAINERS b/MAINTAINERS index c8e4453..7699eca 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -129,11 +129,6 @@ # PROGRAMMERS ################################################################################ -AMD SB600SPI -M: Arthur Heymans <arthur(a)aheymans.xyz> -S: Maintained -F: sb600spi.c - CH347 M: Nicholas Chin <nic.c3.14(a)gmail.com> S: Maintained -- To view, visit https://review.coreboot.org/c/flashrom/+/75901?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie538337a409f606b717d7104fad346b708f9e2f8 Gerrit-Change-Number: 75901 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in flashrom[master]: flashchips.c: Adding support for ISSI IS25WP020/40/80
by Ao Zhong (Code Review) 19 Jun '23

19 Jun '23

Attention is currently required from: Ao Zhong. Hello Anastasia Klimchuk, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/75830?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: flashchips.c: Adding support for ISSI IS25WP020/40/80 ...................................................................... flashchips.c: Adding support for ISSI IS25WP020/40/80 Hello, I added support for IS25WP020, IS25WP040, and IS25WP080 SPI flash chips. The datasheet for these chips can be found at: https://www.issi.com/WW/pdf/25WP016_080_040_020.pdf Tested read, write, and erase functions on IS25WP080. Here are test logs Write: https://paste.flashrom.org/view.php?id=3698 Write test 2: https://paste.flashrom.org/view.php?id=3699 Erase: https://paste.flashrom.org/view.php?id=3700 Change-Id: I8a786de5cf9ffefb2d57f89bbab71e289b5c2b28 Signed-off-by: Ao Zhong <hacc1225(a)gmail.com> --- M flashchips.c M include/flashchips.h 2 files changed, 129 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/30/75830/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/75830?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8a786de5cf9ffefb2d57f89bbab71e289b5c2b28 Gerrit-Change-Number: 75830 Gerrit-PatchSet: 2 Gerrit-Owner: Ao Zhong <hacc1225(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Ao Zhong <hacc1225(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit June 2023