June 2023 - flashrom-gerrit - mail.coreboot.org

[S] Change in flashrom[master]: flashchips: change chip lock status funcs for Winbond chips
by Anastasia Klimchuk (Code Review) 30 Jun '23

30 Jun '23

Attention is currently required from: Alexander Goncharov, Edward O'Callaghan, Nikolai Artemiev. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75877?usp=email ) Change subject: flashchips: change chip lock status funcs for Winbond chips ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: Nikolai, I think we need your code review over here. Thank you so much! File flashchips.c: https://review.coreboot.org/c/flashrom/+/75877/comment/28709d25_3fae3cc6 : PS2, Line 17877: SPI_PRETTYPRINT_STATUS_REGISTER_AMIC_A25L032 I wanted to ask, how did you pick the printlock func? (I want to understand for myself). Also I am wondering, what happens if, just theoretically, a wrong func is chosen? Will print wrong values or breaks (like segfault or something)? -- To view, visit https://review.coreboot.org/c/flashrom/+/75877?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5066863b514825aee0dffe496492514ac99b6e49 Gerrit-Change-Number: 75877 Gerrit-PatchSet: 2 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Fri, 30 Jun 2023 09:26:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips: add support for MX25V16066/KH25V16066
by Anastasia Klimchuk (Code Review) 30 Jun '23

30 Jun '23

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/68278?usp=email ) Change subject: flashchips: add support for MX25V16066/KH25V16066 ...................................................................... flashchips: add support for MX25V16066/KH25V16066 Change-Id: Ic5f0548f023fcd09a970148586497e00414ad1ae Signed-off-by: Joseph Goh <josephgoh7(a)gmail.com> Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/68278 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M flashchips.c M include/flashchips.h 2 files changed, 39 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Anastasia Klimchuk: Looks good to me, approved diff --git a/flashchips.c b/flashchips.c index 4508fc6..9b2a187 100644 --- a/flashchips.c +++ b/flashchips.c @@ -8766,6 +8766,44 @@ { .vendor = "Macronix", + .name = "MX25V16066", /* was called KH25V16066 in rev v1.3 */ + .bustype = BUS_SPI, + .manufacture_id = MACRONIX_ID, + .model_id = MACRONIX_MX25L1605, + .total_size = 2048, /* 16M-bits */ + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN, + .tested = TEST_OK_PR, + .probe = PROBE_SPI_RDID, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 512} }, + .block_erase = SPI_BLOCK_ERASE_20, + }, { + .eraseblocks = { {32 * 1024, 64} }, + .block_erase = SPI_BLOCK_ERASE_52, + }, { + .eraseblocks = { {64 * 1024, 32} }, + .block_erase = SPI_BLOCK_ERASE_D8, + }, { + .eraseblocks = { {2 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_60, + }, { + .eraseblocks = { {2 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_C7, + }, + }, + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_BP3_SRWD, + .unlock = SPI_DISABLE_BLOCKPROTECT_BP3_SRWD, + .write = SPI_CHIP_WRITE256, + .read = SPI_CHIP_READ, /* Fast read (0x0B) supported */ + .voltage = {2700, 3600}, + }, + + { + .vendor = "Macronix", .name = "MX25L1605A/MX25L1606E/MX25L1608E", .bustype = BUS_SPI, .manufacture_id = MACRONIX_ID, diff --git a/include/flashchips.h b/include/flashchips.h index 4140203..49e54fa 100644 --- a/include/flashchips.h +++ b/include/flashchips.h @@ -507,7 +507,7 @@ #define MACRONIX_MX25L2005 0x2012 /* Same as MX25L2005C, MX25L2006E */ #define MACRONIX_MX25L4005 0x2013 /* Same as MX25L4005A, MX25L4005C, MX25L4006E */ #define MACRONIX_MX25L8005 0x2014 /* Same as MX25V8005, MX25L8006E, MX25L8008E, FIXME: MX25L8073E (4k 0x20) */ -#define MACRONIX_MX25L1605 0x2015 /* MX25L1605 (64k 0x20); MX25L1605A/MX25L1606E/MX25L1608E (4k 0x20, 64k 0x52); MX25L1605D/MX25L1608D/MX25L1673E (4k 0x20) */ +#define MACRONIX_MX25L1605 0x2015 /* MX25L1605 (64k 0x20); MX25V16066 (4k 0x20, 32k 0x52, 64k 0xD8); MX25L1605A/MX25L1606E/MX25L1608E (4k 0x20, 64k 0x52); MX25L1605D/MX25L1608D/MX25L1673E (4k 0x20) */ #define MACRONIX_MX25L3205 0x2016 /* MX25L3205, MX25L3205A (64k 0x20); MX25L3205D/MX25L3208D (4k 0x20); MX25L3206E/MX25L3208E (4k 0x20, 64k 0x52); MX25L3233F/MX25L3273E (4k 0x20, 32k 0x52) */ #define MACRONIX_MX25L6405 0x2017 /* MX25L6405, MX25L6405D (64k 0x20); MX25L6406E/MX25L6408E (4k 0x20); MX25L6436E/MX25L6445E/MX25L6465E/MX25L6473E (4k 0x20, 32k 0x52) */ #define MACRONIX_MX25L12805D 0x2018 /* MX25L12805D (no 32k); MX25L12865E, MX25L12835F, MX25L12845E, MX25L12873F, MX25L12833F (32k 0x52) */ -- To view, visit https://review.coreboot.org/c/flashrom/+/68278?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic5f0548f023fcd09a970148586497e00414ad1ae Gerrit-Change-Number: 68278 Gerrit-PatchSet: 5 Gerrit-Owner: Joseph Goh <josephgoh7(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[master]: flashchips: add support for MX25V16066/KH25V16066
by Anastasia Klimchuk (Code Review) 30 Jun '23

30 Jun '23

Attention is currently required from: Joseph Goh. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68278?usp=email ) Change subject: flashchips: add support for MX25V16066/KH25V16066 ...................................................................... Patch Set 4: Code-Review+2 (1 comment) Patchset: PS3: > Ah, I see. […] You are welcome! Also you are welcome to send more patches in future. First time is the hardest, second time gets easier, and so on :) -- To view, visit https://review.coreboot.org/c/flashrom/+/68278?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic5f0548f023fcd09a970148586497e00414ad1ae Gerrit-Change-Number: 68278 Gerrit-PatchSet: 4 Gerrit-Owner: Joseph Goh <josephgoh7(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Joseph Goh <josephgoh7(a)gmail.com> Gerrit-Comment-Date: Fri, 30 Jun 2023 07:59:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Joseph Goh <josephgoh7(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: MAINTAINERS: Add Anastasia Klimchuk for flashchips
by Nikolai Artemiev (Code Review) 30 Jun '23

30 Jun '23

Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Angel Pons, Sergii Dmytruk, Stefan Reinauer, Thomas Heijligen. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75895?usp=email ) Change subject: MAINTAINERS: Add Anastasia Klimchuk for flashchips ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/75895?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I82049c6686b7199dec55082ab9cbe71bfa89d2d7 Gerrit-Change-Number: 75895 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Fri, 30 Jun 2023 05:58:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: doc: Add Team page which describes Gerrit groups
by Nikolai Artemiev (Code Review) 30 Jun '23

30 Jun '23

Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Angel Pons, Edward O'Callaghan, Peter Marheine, Stefan Reinauer, Thomas Heijligen. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/76075?usp=email ) Change subject: doc: Add Team page which describes Gerrit groups ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/76075?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3118b2b036eab93e901814447543b02c760c6a80 Gerrit-Change-Number: 76075 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Fri, 30 Jun 2023 05:54:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips: add support for MX25V16066/KH25V16066
by Joseph Goh (Code Review) 27 Jun '23

27 Jun '23

Joseph Goh has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68278?usp=email ) Change subject: flashchips: add support for MX25V16066/KH25V16066 ...................................................................... Patch Set 4: (1 comment) Patchset: PS3: > Joseph, last thing to do for you is to click Rebase (or rebase locally on the top and push). […] Ah, I see. Thanks for guiding me through this patch! I'm quite new to gerrit, so this was really cool and interesting learning experience for me. -- To view, visit https://review.coreboot.org/c/flashrom/+/68278?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic5f0548f023fcd09a970148586497e00414ad1ae Gerrit-Change-Number: 68278 Gerrit-PatchSet: 4 Gerrit-Owner: Joseph Goh <josephgoh7(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 27 Jun 2023 11:05:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips: add support for MX25V16066/KH25V16066
by Anastasia Klimchuk (Code Review) 27 Jun '23

27 Jun '23

Attention is currently required from: Joseph Goh. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68278?usp=email ) Change subject: flashchips: add support for MX25V16066/KH25V16066 ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Patchset: PS3: Joseph, last thing to do for you is to click Rebase (or rebase locally on the top and push). If I rebase myself I become an uploader, my approval might not count. -- To view, visit https://review.coreboot.org/c/flashrom/+/68278?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic5f0548f023fcd09a970148586497e00414ad1ae Gerrit-Change-Number: 68278 Gerrit-PatchSet: 3 Gerrit-Owner: Joseph Goh <josephgoh7(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Joseph Goh <josephgoh7(a)gmail.com> Gerrit-Comment-Date: Tue, 27 Jun 2023 10:56:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashrom: only unlock for write/erase operations
by Edward O'Callaghan (Code Review) 27 Jun '23

27 Jun '23

Attention is currently required from: Brian Norris, Nikolai Artemiev. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75991?usp=email ) Change subject: flashrom: only unlock for write/erase operations ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I checked the unlock functions, it turns out one of them actually does unlock for reads (last bullet […] Tricky, what about doing the `R|W` specialisation within the `unlock_flash_wp()` preamble? If the chip has `SPI_DISABLE_BLOCKPROTECT_SST26_GLOBAL_UNPROTECT` set `return 1` to let the fallback to the old `bp_func` mechanism for these special chips? -- To view, visit https://review.coreboot.org/c/flashrom/+/75991?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5dc66474a0b7969b51b86ac9f5daa2c95ae968f1 Gerrit-Change-Number: 75991 Gerrit-PatchSet: 1 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Brian Norris <briannorris(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Tue, 27 Jun 2023 00:02:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Brian Norris <briannorris(a)chromium.org> Comment-In-Reply-To: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips: add support for MX25V16066/KH25V16066
by Joseph Goh (Code Review) 26 Jun '23

26 Jun '23

Attention is currently required from: Anastasia Klimchuk. Joseph Goh has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68278?usp=email ) Change subject: flashchips: add support for MX25V16066/KH25V16066 ...................................................................... Patch Set 3: (1 comment) File flashchips.c: https://review.coreboot.org/c/flashrom/+/68278/comment/db0dd93c_82d2faf8 : PS2, Line 8772: MACRONIX_MX25L1605 > Thanks for explaining! I agree. […] Done! I've also added the erase commands in brackets although I'm not completely sure why the erase commands were included in brackets specifically for these chips. -- To view, visit https://review.coreboot.org/c/flashrom/+/68278?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic5f0548f023fcd09a970148586497e00414ad1ae Gerrit-Change-Number: 68278 Gerrit-PatchSet: 3 Gerrit-Owner: Joseph Goh <josephgoh7(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 26 Jun 2023 13:42:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Joseph Goh <josephgoh7(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips: add support for MX25V16066/KH25V16066
by Joseph Goh (Code Review) 26 Jun '23

26 Jun '23

Attention is currently required from: Anastasia Klimchuk, Joseph Goh. Hello Anastasia Klimchuk, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/68278?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by Anastasia Klimchuk, Verified+1 by build bot (Jenkins) Change subject: flashchips: add support for MX25V16066/KH25V16066 ...................................................................... flashchips: add support for MX25V16066/KH25V16066 Change-Id: Ic5f0548f023fcd09a970148586497e00414ad1ae Signed-off-by: Joseph Goh <josephgoh7(a)gmail.com> Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M flashchips.c M include/flashchips.h 2 files changed, 39 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/78/68278/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/68278?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic5f0548f023fcd09a970148586497e00414ad1ae Gerrit-Change-Number: 68278 Gerrit-PatchSet: 3 Gerrit-Owner: Joseph Goh <josephgoh7(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Joseph Goh <josephgoh7(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit June 2023