May 2023 - flashrom-gerrit - mail.coreboot.org

[S] Change in flashrom[master]: doc: Add doc how to add docs
by Angel Pons (Code Review) 12 May '23

12 May '23

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk, Alexander Goncharov. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74225 ) Change subject: doc: Add doc how to add docs ...................................................................... Patch Set 6: Code-Review+2 (1 comment) Patchset: PS6: > Is anyone interested to approve? :) or tell me what do you think One vague idea: interaction with manpage. We could tell people to consider whether information belongs in the manpage or the docs, or possibly have the manpage auto-added to the docs to avoid redundancy. -- To view, visit https://review.coreboot.org/c/flashrom/+/74225 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I356a286ad2f3334392efadda366b0ca0f8042752 Gerrit-Change-Number: 74225 Gerrit-PatchSet: 6 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Fri, 12 May 2023 08:41:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: jlink_spi: add cs=tms option to jlink_spi programmer
by Chen (Code Review) 12 May '23

12 May '23

Attention is currently required from: Thomas Heijligen, Alexander Goncharov. Chen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75011 ) Change subject: jlink_spi: add cs=tms option to jlink_spi programmer ...................................................................... Patch Set 5: (1 comment) File jlink_spi.c: https://review.coreboot.org/c/flashrom/+/75011/comment/1e2ead2d_ba45b174 PS3, Line 160: tms_buffer > Chen, thanks for adding comment to the code, that's useful. […] I have tested both cases by changing the wiring of Dupont lines. -- To view, visit https://review.coreboot.org/c/flashrom/+/75011 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0cb467fcc2c403a25f260462de0cd020e7022bb1 Gerrit-Change-Number: 75011 Gerrit-PatchSet: 5 Gerrit-Owner: Chen <c(a)jia.je> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Fri, 12 May 2023 06:23:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Chen <c(a)jia.je> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: ni845x_spi: support building with Meson
by Peter Marheine (Code Review) 12 May '23

12 May '23

Attention is currently required from: Miklós Márton, Thomas Heijligen, Anastasia Klimchuk. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74963 ) Change subject: ni845x_spi: support building with Meson ...................................................................... Patch Set 3: (1 comment) File meson.build: https://review.coreboot.org/c/flashrom/+/74963/comment/c772c9b2_0bdee4b8 PS3, Line 162: dependencies : cc.find_library( > Isn't the cc. […] No, because specifying `header_include_directories` doesn't cause the returned dep to add those directories to the include search path. I tried `libni845x = cc.find_library(...)` and the build failed with an inability to find `ni845x.h`. -- To view, visit https://review.coreboot.org/c/flashrom/+/74963 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I90e85c424f97898b47bf0a3d78672d6c25af12b0 Gerrit-Change-Number: 74963 Gerrit-PatchSet: 3 Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Fri, 12 May 2023 00:47:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: README: Add installing and packaging instructions for meson
by Peter Marheine (Code Review) 12 May '23

12 May '23

Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75125 ) Change subject: README: Add installing and packaging instructions for meson ...................................................................... Patch Set 1: (1 comment) File README.rst: https://review.coreboot.org/c/flashrom/+/75125/comment/be6f83de_113ccdf1 PS1, Line 171: meson install -C <your_build_dir> There's already a copy of this in building_from_source.rst: which one should we keep? I'm inclined to put all of the meson documentation in the other file, and eventually the makefile docs will be deleted from here so all the build/install/package docs would then live outside the root-level README. A very short "quickstart" sort of thing of commands that can be copied/pasted without any thought might be reasonable here, though; essentially copy the TL;DR section from the other doc. ``` To build and install flashrom using meson: meson setup builddir meson compile -C builddir meson install -C builddir For more details, refer to :doc:`dev_guide/building_from_source`. ``` -- To view, visit https://review.coreboot.org/c/flashrom/+/75125 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2d5900538d54c43efcc8c5b7010df5d867f3b190 Gerrit-Change-Number: 75125 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Fri, 12 May 2023 00:26:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: doc: Add doc how to add docs
by Anastasia Klimchuk (Code Review) 11 May '23

11 May '23

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Alexander Goncharov. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74225 ) Change subject: doc: Add doc how to add docs ...................................................................... Patch Set 6: (2 comments) Patchset: PS3: > I really want to keep "how to add docs" in the root menu, to make it as visible as possible and less […] I was going to start setting up new website soon (because readme is merged). But I really want the "doc how to add docs" to be there from the very beginning, and in the root, so that everyone who wants to help upgrade documentation and new website would be able to help. I definitely agree to also have it also in HowTo section. Hope it's fine I resolve this comment :) Patchset: PS6: Is anyone interested to approve? :) or tell me what do you think -- To view, visit https://review.coreboot.org/c/flashrom/+/74225 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I356a286ad2f3334392efadda366b0ca0f8042752 Gerrit-Change-Number: 74225 Gerrit-PatchSet: 6 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Thu, 11 May 2023 23:43:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: jlink_spi: add cs=tms option to jlink_spi programmer
by Anastasia Klimchuk (Code Review) 11 May '23

11 May '23

Attention is currently required from: Chen, Thomas Heijligen, Alexander Goncharov. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75011 ) Change subject: jlink_spi: add cs=tms option to jlink_spi programmer ...................................................................... Patch Set 5: Code-Review+2 (1 comment) File jlink_spi.c: https://review.coreboot.org/c/flashrom/+/75011/comment/ad3ce4c3_f0ef3036 PS3, Line 160: tms_buffer > When CS is connected to TMS, TMS should remain low(nCS=0, CS=1) upon transmission. Chen, thanks for adding comment to the code, that's useful. Does this answer your question Joursoir? don't want to resolve without checking with you. From me a question: I understand you tested with `cs=TMS` right? Would it be possible for you to test a default case too? Thanks! -- To view, visit https://review.coreboot.org/c/flashrom/+/75011 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0cb467fcc2c403a25f260462de0cd020e7022bb1 Gerrit-Change-Number: 75011 Gerrit-PatchSet: 5 Gerrit-Owner: Chen <c(a)jia.je> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Chen <c(a)jia.je> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Thu, 11 May 2023 23:31:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Chen <c(a)jia.je> Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: jlink_spi: add cs=tms option to jlink_spi programmer
by Chen (Code Review) 11 May '23

11 May '23

Attention is currently required from: Chen, Thomas Heijligen, Alexander Goncharov. Hello build bot (Jenkins), Thomas Heijligen, Anastasia Klimchuk, Alexander Goncharov, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/75011 to look at the new patch set (#5). Change subject: jlink_spi: add cs=tms option to jlink_spi programmer ...................................................................... jlink_spi: add cs=tms option to jlink_spi programmer Currently, the code assumes the nCS pin of spi nor flash is connected to either nRESET(pin 15) or nTRST(pin 3). But it is incompatible with the pinout from official JFlash SPI, whereas the nCS pin is wired to TMS(pin 7). This commit adds cs=tms option to share the same pinout as JFlash SPI. It works by toggling TMS in assert_cs and deassert_cs, and sets TMS to zero in jlink_spi_send_command. The default option is set to cs=reset for backward compatibility. Tested on macOS 13.3.1 with JLink and Winbond W25Q128 Change-Id: I0cb467fcc2c403a25f260462de0cd020e7022bb1 Signed-off-by: Jiajie Chen <c(a)jia.je> --- M doc/classic_cli_manpage.rst M jlink_spi.c 2 files changed, 65 insertions(+), 15 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/11/75011/5 -- To view, visit https://review.coreboot.org/c/flashrom/+/75011 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0cb467fcc2c403a25f260462de0cd020e7022bb1 Gerrit-Change-Number: 75011 Gerrit-PatchSet: 5 Gerrit-Owner: Chen <c(a)jia.je> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Chen <c(a)jia.je> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[master]: jlink_spi: add cs=tms option to jlink_spi programmer
by Chen (Code Review) 11 May '23

11 May '23

Attention is currently required from: Thomas Heijligen, Alexander Goncharov. Hello build bot (Jenkins), Thomas Heijligen, Anastasia Klimchuk, Alexander Goncharov, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/75011 to look at the new patch set (#4). Change subject: jlink_spi: add cs=tms option to jlink_spi programmer ...................................................................... jlink_spi: add cs=tms option to jlink_spi programmer Currently, the code assumes the nCS pin of spi nor flash is connected to either nRESET(pin 15) or nTRST(pin 3). But it is incompatible with the pinout from official JFlash SPI, whereas the nCS pin is wired to TMS(pin 7). This commit adds cs=tms option to share the same pinout as JFlash SPI. It works by toggling TMS in assert_cs and deassert_cs, and sets TMS to zero in jlink_spi_send_command. The default option is set to cs=reset for backward compatibility. Tested on macOS 13.3.1 with JLink and Winbond W25Q128 Change-Id: I0cb467fcc2c403a25f260462de0cd020e7022bb1 Signed-off-by: Jiajie Chen <c(a)jia.je> --- M doc/classic_cli_manpage.rst M jlink_spi.c 2 files changed, 65 insertions(+), 15 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/11/75011/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/75011 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0cb467fcc2c403a25f260462de0cd020e7022bb1 Gerrit-Change-Number: 75011 Gerrit-PatchSet: 4 Gerrit-Owner: Chen <c(a)jia.je> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[master]: sb600spi.c: Combine CHIPSET_YANGTZE and CHIPSET_PROMONTORY
by Anastasia Klimchuk (Code Review) 10 May '23

10 May '23

Attention is currently required from: Edward O'Callaghan, Arthur Heymans, Felix Held. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/65238 ) Change subject: sb600spi.c: Combine CHIPSET_YANGTZE and CHIPSET_PROMONTORY ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: Is it possible to test this? Would be really great. Thank you! -- To view, visit https://review.coreboot.org/c/flashrom/+/65238 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6a3fcc23c1e5fbe5d9e365e2e5f864655aee873f Gerrit-Change-Number: 65238 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 10 May 2023 12:35:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: sb600spi.c: Everything after rev 0x4a is a SPI100 ctrl
by Anastasia Klimchuk (Code Review) 10 May '23

10 May '23

Attention is currently required from: Jason Glenesk, Martin Roth, Marshall Dawson, Paul Menzel, Edward O'Callaghan, Arthur Heymans, Felix Held. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/65237 ) Change subject: sb600spi.c: Everything after rev 0x4a is a SPI100 ctrl ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > That sounds good. […] Sorry for confusion... I was going to ask you to do this, sorry if my message was confusing. Thank you so much!! I appreciate a lot! -- To view, visit https://review.coreboot.org/c/flashrom/+/65237 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id1c526e04ef4cf1f9a036328cbfb0d14ec310116 Gerrit-Change-Number: 65237 Gerrit-PatchSet: 3 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 10 May 2023 12:33:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit May 2023