May 2023 - flashrom-gerrit - mail.coreboot.org

[S] Change in flashrom[master]: sb600spi.c: Everything after rev 0x4a is a SPI100 ctrl
by Edward O'Callaghan (Code Review) 10 May '23

10 May '23

Attention is currently required from: Jason Glenesk, Martin Roth, Marshall Dawson, Paul Menzel, Anastasia Klimchuk, Felix Held. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/65237 ) Change subject: sb600spi.c: Everything after rev 0x4a is a SPI100 ctrl ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Edward, thank you so much for working on this ! Can we revive this patch series and complete your wo […] That sounds good. You can split everything post CHIPSET_PROMONTORY in this driver into the amd_spi100.c too so you end up with that and sb600spi.c -- To view, visit https://review.coreboot.org/c/flashrom/+/65237 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id1c526e04ef4cf1f9a036328cbfb0d14ec310116 Gerrit-Change-Number: 65237 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 10 May 2023 04:19:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: doc: Convert README to sphinx
by Anastasia Klimchuk (Code Review) 10 May '23

10 May '23

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/74216 ) Change subject: doc: Convert README to sphinx ...................................................................... doc: Convert README to sphinx This patch also includes small changes to README file that were agreed earlier: changing all links to https re-ordering of sections as Build instructions, Installations, Packaging, Contact Change-Id: I6e0debc0e15a9c4866f6d16fb010cd3f13171ff3 Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/74216 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Thomas Heijligen <src(a)posteo.de> --- D README A README.rst M doc/index.rst 3 files changed, 241 insertions(+), 211 deletions(-) Approvals: build bot (Jenkins): Verified Thomas Heijligen: Looks good to me, approved diff --git a/README b/README deleted file mode 100644 index d00524e..0000000 --- a/README +++ /dev/null @@ -1,210 +0,0 @@ -------------------------------------------------------------------------------- -flashrom README -------------------------------------------------------------------------------- - -flashrom is a utility for detecting, reading, writing, verifying and erasing -flash chips. It is often used to flash BIOS/EFI/coreboot/firmware images -in-system using a supported mainboard, but it also supports flashing of network -cards (NICs), SATA controller cards, and other external devices which can -program flash chips. - -It supports a wide range of flash chips (most commonly found in SOIC8, DIP8, -SOIC16, WSON8, PLCC32, DIP32, TSOP32, and TSOP40 packages), which use various -protocols such as LPC, FWH, parallel flash, or SPI. - -Do not use flashrom on laptops (yet)! The embedded controller (EC) present in -many laptops might interact badly with any attempts to communicate with the -flash chip and may brick your laptop. - -Please make a backup of your flash chip before writing to it. - -Please see the flashrom(8) manpage. - - -Packaging ---------- - -To package flashrom and remove dependencies on Git, either use -make export -or -make tarball - -'make export' will export all flashrom files from the Git repository at -revision HEAD into a directory named "$EXPORTDIR/flashrom-$RELEASENAME" -and will additionally add a "versioninfo.inc" file in that directory to -contain the Git revision of the exported tree and a date for the manual -page. - -'make tarball' will simply tar up the result of make export and compress -it with bzip2. - -The snapshot tarballs are the result of 'make tarball' and require no -further processing. Some git files (for example the rust bindings) are omitted -from the tarball, as controlled by the .gitattributes files. - - -Build Instructions ------------------- - -flashrom supports building with make and meson. - -Meson build system supports almost all the environments, although not exactly -all of them. Full meson support is on the roadmap in the nearest future. -To build flashrom with meson, follow the instruction and information in -/Documentation/building.md - -If you are unsure which build system to use, and/or don't know what's the -difference, use make for now. - -The rest of Build Instructions below refers to building flashrom with make. - -To build flashrom you need to install the following software: - - * C compiler (GCC / clang) - * pkg-config - - * pciutils+libpci (if you want support for mainboard or PCI device flashing) - * libusb (if you want FT2232, Dediprog or USB-Blaster support) - * libftdi (if you want FT2232 or USB-Blaster support) - * libjaylink (if you want support for SEGGER J-Link and compatible devices) - -Linux et al: - - * pciutils / libpci - * pciutils-devel / pciutils-dev / libpci-dev - * zlib-devel / zlib1g-dev (needed if libpci was compiled with libz support) - -On FreeBSD, you need the following ports: - - * devel/gmake - * devel/libpci - -On OpenBSD, you need the following ports: - - * devel/gmake - * sysutils/pciutils - -To compile on Linux, use: - - make - -To compile on FreeBSD, OpenBSD or DragonFly BSD, use: - - gmake - -To compile on Nexenta, use: - - make - -To compile on Solaris, use: - - gmake LDFLAGS="-L$pathtolibpci" CC="gcc -I$pathtopciheaders" CFLAGS=-O2 - -To compile on NetBSD (with pciutils, libftdi, libusb installed in /usr/pkg/), use: - - gmake - -To compile and run on Darwin/Mac OS X: - - Install DirectHW from coresystems GmbH. - DirectHW is available at http://www.coreboot.org/DirectHW . - -To cross-compile on Linux for DOS: - - Get packages of the DJGPP cross compiler and install them: - djgpp-filesystem djgpp-gcc djgpp-cpp djgpp-runtime djgpp-binutils - As an alternative, the DJGPP web site offers packages for download as well: - djcross-binutils-2.29.1-1ap.x86_64.rpm - djcross-gcc-7.2.0-1ap.x86_64.rpm - djcrx-2.05-5.x86_64.rpm - The cross toolchain packages for your distribution may have slightly different - names (look for packages named *djgpp*). - - Alternatively, you could use a script to build it from scratch: - https://github.com/andrewwutw/build-djgpp - - You will need the libpci and libgetopt library source trees and - their compiled static libraries and header files installed in some - directory say libpci-libgetopt/, which will be later specified with - LIBS_BASE parameter during flashrom compilation. Easiest way to - handle it is to put pciutils, libgetopt and flashrom directories - in one subdirectory. There will be an extra subdirectory libpci-libgetopt - created, which will contain compiled libpci and libgetopt. - - Download pciutils 3.5.6 and apply http://flashrom.org/File:Pciutils-3.5.6.patch.gz - Compile pciutils, using following command line: - - make ZLIB=no DNS=no HOST=i386-djgpp-djgpp CROSS_COMPILE=i586-pc-msdosdjgpp- \ - PREFIX=/ DESTDIR=$PWD/../libpci-libgetopt \ - STRIP="--strip-program=i586-pc-msdosdjgpp-strip -s" install install-lib - - Download and compile with 'make' http://flashrom.org/File:Libgetopt.tar.gz - - Copy the libgetopt.a to ../libpci-libgetopt/lib and - getopt.h to ../libpci-libgetopt/include - - Enter the flashrom directory. - - make CC=i586-pc-msdosdjgpp-gcc STRIP=i586-pc-msdosdjgpp-strip LIBS_BASE=../libpci-libgetopt/ strip - - If you like, you can compress the resulting executable with UPX: - - upx -9 flashrom.exe - - To run flashrom.exe, download http://flashrom.org/File:Csdpmi7b.zip and - unpack CWSDPMI.EXE into the current directory or one in PATH. - -To cross-compile on Linux for Windows: - - Get packages of the MinGW cross compiler and install them: - mingw32-filesystem mingw32-cross-cpp mingw32-cross-binutils mingw32-cross-gcc - mingw32-runtime mingw32-headers - The cross toolchain packages for your distribution may have slightly different - names (look for packages named *mingw*). - PCI-based programmers (internal etc.) are not supported on Windows. - Run (change CC= and STRIP= settings where appropriate) - make CC=i686-w64-mingw32-gcc STRIP=i686-w64-mingw32-strip - -Processor architecture dependent features: - - On non-x86 architectures a few programmers don't work (yet) because they - use port-based I/O which is not directly available on non-x86. Those - programmers will be disabled automatically if you run "make". - -Compiler quirks: - -If you are using clang and if you want to enable only one driver, you may hit an -overzealous compiler warning from clang. Compile with "make WARNERROR=no" to -force it to continue and enjoy. - -Bindings: - - Foreign function interface bindings for the rust language are included in the - bindings folder. These are not compiled as part of the normal build process. - See the readme under bindings/rust for more information. - -Installation ------------- - -In order to install flashrom and the manpage into /usr/local, type: - - make install - -For installation in a different directory use DESTDIR, e.g. like this: - - make DESTDIR=/usr install - -If you have insufficient permissions for the destination directory, use sudo -by adding sudo in front of the commands above. - - -Contact -------- - -The official flashrom website is: - - http://www.flashrom.org/ - -Available contact methods are - - https://www.flashrom.org/Contact diff --git a/README.rst b/README.rst new file mode 100644 index 0000000..ff73341 --- /dev/null +++ b/README.rst @@ -0,0 +1,220 @@ +flashrom README +=============== + +flashrom is a utility for detecting, reading, writing, verifying and erasing +flash chips. It is often used to flash BIOS/EFI/coreboot/firmware images +in-system using a supported mainboard, but it also supports flashing of network +cards (NICs), SATA controller cards, and other external devices which can +program flash chips. + +It supports a wide range of flash chips (most commonly found in SOIC8, DIP8, +SOIC16, WSON8, PLCC32, DIP32, TSOP32, and TSOP40 packages), which use various +protocols such as LPC, FWH, parallel flash, or SPI. + +Do not use flashrom on laptops (yet)! The embedded controller (EC) present in +many laptops might interact badly with any attempts to communicate with the +flash chip and may brick your laptop. + +Please make a backup of your flash chip before writing to it. + +Please see the flashrom(8) manpage :doc:`classic_cli_manpage`. + + +Build Instructions +------------------ + +flashrom supports building with **make** and **meson**. + +Meson build system supports almost all the environments, although not exactly +all of them. Full meson support is on the roadmap in the nearest future. +To build flashrom with meson, follow the instruction and information in +:doc:`dev_guide/building_from_source` + +If you are unsure which build system to use, and/or don't know what's the +difference, use make for now. + +The rest of Build Instructions below refers to building flashrom with make. + +**To build flashrom you need to install the following software:** + + * C compiler (GCC / clang) + * pkg-config + + * pciutils+libpci (if you want support for mainboard or PCI device flashing) + * libusb (if you want FT2232, Dediprog or USB-Blaster support) + * libftdi (if you want FT2232 or USB-Blaster support) + * libjaylink (if you want support for SEGGER J-Link and compatible devices) + +**Linux et al:** + + * pciutils / libpci + * pciutils-devel / pciutils-dev / libpci-dev + * zlib-devel / zlib1g-dev (needed if libpci was compiled with libz support) + +**On FreeBSD, you need the following ports:** + + * devel/gmake + * devel/libpci + +**On OpenBSD, you need the following ports:** + + * devel/gmake + * sysutils/pciutils + +**To compile on Linux, use**:: + + make + +**To compile on FreeBSD, OpenBSD or DragonFly BSD, use**:: + + gmake + +**To compile on Nexenta, use**:: + + make + +**To compile on Solaris, use**:: + + gmake LDFLAGS="-L$pathtolibpci" CC="gcc -I$pathtopciheaders" CFLAGS=-O2 + +**To compile on NetBSD (with pciutils, libftdi, libusb installed in /usr/pkg/), use**:: + + gmake + +**To compile and run on Darwin/Mac OS X:** + +Install DirectHW from coresystems GmbH. +DirectHW is available at https://www.coreboot.org/DirectHW . + +**To cross-compile on Linux for DOS:** + +Get packages of the DJGPP cross compiler and install them: + + * djgpp-filesystem djgpp-gcc djgpp-cpp djgpp-runtime djgpp-binutils + +As an alternative, the DJGPP web site offers packages for download as well: + + * djcross-binutils-2.29.1-1ap.x86_64.rpm + * djcross-gcc-7.2.0-1ap.x86_64.rpm + * djcrx-2.05-5.x86_64.rpm + +The cross toolchain packages for your distribution may have slightly different +names (look for packages named *djgpp*). + +Alternatively, you could use a script to build it from scratch: +https://github.com/andrewwutw/build-djgpp + +You will need the libpci and libgetopt library source trees and +their compiled static libraries and header files installed in some +directory say libpci-libgetopt/, which will be later specified with +LIBS_BASE parameter during flashrom compilation. Easiest way to +handle it is to put pciutils, libgetopt and flashrom directories +in one subdirectory. There will be an extra subdirectory libpci-libgetopt +created, which will contain compiled libpci and libgetopt. + +Download pciutils 3.5.6 and apply https://flashrom.org/File:Pciutils-3.5.6.patch.gz +Compile pciutils, using following command line:: + + make ZLIB=no DNS=no HOST=i386-djgpp-djgpp CROSS_COMPILE=i586-pc-msdosdjgpp- \ + PREFIX=/ DESTDIR=$PWD/../libpci-libgetopt \ + STRIP="--strip-program=i586-pc-msdosdjgpp-strip -s" install install-lib + +Download and compile with 'make' https://flashrom.org/File:Libgetopt.tar.gz + +Copy the libgetopt.a to ../libpci-libgetopt/lib and +getopt.h to ../libpci-libgetopt/include + +Enter the flashrom directory:: + + make CC=i586-pc-msdosdjgpp-gcc STRIP=i586-pc-msdosdjgpp-strip LIBS_BASE=../libpci-libgetopt/ strip + +If you like, you can compress the resulting executable with UPX:: + + upx -9 flashrom.exe + +To run flashrom.exe, download https://flashrom.org/File:Csdpmi7b.zip and +unpack CWSDPMI.EXE into the current directory or one in PATH. + +**To cross-compile on Linux for Windows:** + +Get packages of the MinGW cross compiler and install them:: + + mingw32-filesystem mingw32-cross-cpp mingw32-cross-binutils mingw32-cross-gcc + mingw32-runtime mingw32-headers + +The cross toolchain packages for your distribution may have slightly different +names (look for packages named *mingw*). +PCI-based programmers (internal etc.) are not supported on Windows. +Run (change CC= and STRIP= settings where appropriate):: + + make CC=i686-w64-mingw32-gcc STRIP=i686-w64-mingw32-strip + +**Processor architecture dependent features:** + +On non-x86 architectures a few programmers don't work (yet) because they +use port-based I/O which is not directly available on non-x86. Those +programmers will be disabled automatically if you run "make". + +**Compiler quirks:** + +If you are using clang and if you want to enable only one driver, you may hit an +overzealous compiler warning from clang. Compile with "make WARNERROR=no" to +force it to continue and enjoy. + +**Bindings:** + +Foreign function interface bindings for the rust language are included in the +bindings folder. These are not compiled as part of the normal build process. +See the readme under bindings/rust for more information. + + +Installation +------------ + +In order to install flashrom and the manpage into /usr/local, type:: + + make install + +For installation in a different directory use DESTDIR, e.g. like this:: + + make DESTDIR=/usr install + +If you have insufficient permissions for the destination directory, use sudo +by adding sudo in front of the commands above. + + +Packaging +--------- + +To package flashrom and remove dependencies on Git, either use:: + + make export + +or:: + + make tarball + +``make export`` will export all flashrom files from the Git repository at +revision HEAD into a directory named ``$EXPORTDIR/flashrom-$RELEASENAME`` +and will additionally add a ``versioninfo.inc`` file in that directory to +contain the Git revision of the exported tree and a date for the manual +page. + +``make tarball`` will simply tar up the result of make export and compress +it with bzip2. + +The snapshot tarballs are the result of ``make tarball`` and require no +further processing. Some git files (for example the rust bindings) are omitted +from the tarball, as controlled by the .gitattributes files. + + +Contact +------- + +The official flashrom website is: + + https://www.flashrom.org/ + +Available contact methods are + + https://www.flashrom.org/Contact diff --git a/doc/index.rst b/doc/index.rst index ea1027e..326f684 100644 --- a/doc/index.rst +++ b/doc/index.rst @@ -10,4 +10,4 @@ classic_cli_manpage contact -.. include:: ../README +.. include:: ../README.rst -- To view, visit https://review.coreboot.org/c/flashrom/+/74216 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6e0debc0e15a9c4866f6d16fb010cd3f13171ff3 Gerrit-Change-Number: 74216 Gerrit-PatchSet: 7 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[master]: Makefile: Build man-page only when sphinx is available
by Anastasia Klimchuk (Code Review) 10 May '23

10 May '23

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/74519 ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: Makefile: Build man-page only when sphinx is available ...................................................................... Makefile: Build man-page only when sphinx is available Currently, it's not possible to compile the upstream branch using the `make' command without sphinx beeing installed. Check if sphinx-build is installed and only then build or install the man-page. The problem was noticed from commit f4f2f3dd19784efa26fd5619b7a44b4cdf14b04c move manpage to sphinx. Change-Id: If1b81d9bc25ecac19d493b44b00a7c42d0643fe6 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/74519 Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M Makefile M Makefile.include 2 files changed, 42 insertions(+), 7 deletions(-) Approvals: build bot (Jenkins): Verified Anastasia Klimchuk: Looks good to me, approved diff --git a/Makefile b/Makefile index e6d4554..da5203e 100644 --- a/Makefile +++ b/Makefile @@ -36,6 +36,7 @@ RANLIB ?= ranlib PKG_CONFIG ?= pkg-config BUILD_DETAILS_FILE ?= build_details.txt +SPHINXBUILD ?= sphinx-build # The following parameter changes the default programmer that will be used if there is no -p/--programmer # argument given when running flashrom. The predefined setting does not enable any default so that every @@ -259,6 +260,7 @@ HAS_LINUX_SPI := $(call c_compile_test, Makefile.d/linux_spi_test.c) HAS_LINUX_I2C := $(call c_compile_test, Makefile.d/linux_i2c_test.c) HAS_SERIAL := $(strip $(if $(filter $(TARGET_OS), DOS libpayload), no, yes)) +HAS_SPHINXBUILD := $(shell command -v $(SPHINXBUILD) &>/dev/null && echo yes || echo no) EXEC_SUFFIX := $(strip $(if $(filter $(TARGET_OS), DOS MinGW), .exe)) override CFLAGS += -Iinclude @@ -956,7 +958,7 @@ OBJS = $(CHIP_OBJS) $(PROGRAMMER_OBJS) $(LIB_OBJS) -all: $(PROGRAM)$(EXEC_SUFFIX) man8/$(PROGRAM).8 +all: $(PROGRAM)$(EXEC_SUFFIX) $(call has_dependency, $(HAS_SPHINXBUILD), man8/$(PROGRAM).8) ifeq ($(ARCH), x86) @+$(MAKE) -C util/ich_descriptors_tool/ HOST_OS=$(HOST_OS) TARGET_OS=$(TARGET_OS) endif @@ -1017,6 +1019,7 @@ echo "The following features are unavailable on your machine: $(UNSUPPORTED_FEATURES)" \ exit 1; \ fi + @echo "Checking for program \"sphinx-build\": $(HAS_SPHINXBUILD)" %.o: %.c | config $(CC) -MMD $(CFLAGS) $(CPPFLAGS) $(FLASHROM_CFLAGS) $(FEATURE_FLAGS) -D'FLASHROM_VERSION=$(VERSION)' -o $@ -c $< @@ -1028,9 +1031,13 @@ $(AR) rcs $@ $^ $(RANLIB) $@ -SPHINXBUILD ?= sphinx-build man8/$(PROGRAM).8: doc/* - @FLASHROM_VERSION=$(VERSION) $(SPHINXBUILD) -b man doc . + @if [ "$(HAS_SPHINXBUILD)" = "yes" ]; then \ + $(SPHINXBUILD) -Drelease=$(VERSION) -b man doc .; \ + else \ + echo "$(SPHINXBUILD) not found. Can't build man-page"; \ + exit 1; \ + fi $(PROGRAM).bash: util/$(PROGRAM).bash-completion.tmpl @# Add to the bash completion file a list of enabled programmers. @@ -1047,13 +1054,15 @@ man8 .doctrees $(PROGRAM).bash $(BUILD_DETAILS_FILE) @+$(MAKE) -C util/ich_descriptors_tool/ clean -install: $(PROGRAM)$(EXEC_SUFFIX) man8/$(PROGRAM).8 $(PROGRAM).bash +install: $(PROGRAM)$(EXEC_SUFFIX) $(call has_dependency, $(HAS_SPHINXBUILD), man8/$(PROGRAM).8) $(PROGRAM).bash mkdir -p $(DESTDIR)$(PREFIX)/sbin - mkdir -p $(DESTDIR)$(MANDIR)/man8 - mkdir -p $(DESTDIR)$(BASHCOMPDIR) $(INSTALL) -m 0755 $(PROGRAM)$(EXEC_SUFFIX) $(DESTDIR)$(PREFIX)/sbin - $(INSTALL) -m 0644 man8/$(PROGRAM).8 $(DESTDIR)$(MANDIR)/man8 + mkdir -p $(DESTDIR)$(BASHCOMPDIR) $(INSTALL) -m 0644 $(PROGRAM).bash $(DESTDIR)$(BASHCOMPDIR) +ifeq ($(HAS_SPHINXBUILD), yes) + mkdir -p $(DESTDIR)$(MANDIR)/man8 + $(INSTALL) -m 0644 man8/$(PROGRAM).8 $(DESTDIR)$(MANDIR)/man8 +endif libinstall: libflashrom.a include/libflashrom.h mkdir -p $(DESTDIR)$(PREFIX)/lib diff --git a/Makefile.include b/Makefile.include index a55f6f5..5f81ccc 100644 --- a/Makefile.include +++ b/Makefile.include @@ -52,6 +52,10 @@ $(call debug_shell, $(if $(PKG_CONFIG_LIBDIR),PKG_CONFIG_LIBDIR=$(PKG_CONFIG_LIBDIR),) $(PKG_CONFIG) --modversion $1 2>/dev/null) endef +define has_dependency # $1: dependency, $2: action/target +$(if $(findstring $(strip $1),yes), $(strip $2)) +endef + define dependency_cflags $(call debug_shell, $(if $(PKG_CONFIG_LIBDIR),PKG_CONFIG_LIBDIR=$(PKG_CONFIG_LIBDIR),) $(PKG_CONFIG) --cflags $1 2>/dev/null) endef -- To view, visit https://review.coreboot.org/c/flashrom/+/74519 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If1b81d9bc25ecac19d493b44b00a7c42d0643fe6 Gerrit-Change-Number: 74519 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: merged

1 0

[M] Change in flashrom[master]: jlink_spi: add cs=tms option to jlink_spi programmer
by Anastasia Klimchuk (Code Review) 10 May '23

10 May '23

Attention is currently required from: Chen, Thomas Heijligen, Alexander Goncharov. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75011 ) Change subject: jlink_spi: add cs=tms option to jlink_spi programmer ...................................................................... Patch Set 3: Code-Review+2 (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/75011/comment/98efc72d_027a7943 PS2, Line 7: spi > Sorry I didn't notice in the first pass: this should be `jlink_spi` , so that it describes more spec […] Done Patchset: PS2: > One more thing I forgot on the first pass: could you please update the manpage, it is here: […] Done Patchset: PS3: Looks good, Thomas, Joursoir are you fine with the patch? -- To view, visit https://review.coreboot.org/c/flashrom/+/75011 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0cb467fcc2c403a25f260462de0cd020e7022bb1 Gerrit-Change-Number: 75011 Gerrit-PatchSet: 3 Gerrit-Owner: Chen <c(a)jia.je> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Chen <c(a)jia.je> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Wed, 10 May 2023 02:54:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: sb600spi.c: Everything after rev 0x4a is a SPI100 ctrl
by Anastasia Klimchuk (Code Review) 10 May '23

10 May '23

Attention is currently required from: Jason Glenesk, Martin Roth, Marshall Dawson, Paul Menzel, Edward O'Callaghan, Felix Held. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/65237 ) Change subject: sb600spi.c: Everything after rev 0x4a is a SPI100 ctrl ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Edward, thank you so much for working on this ! Can we revive this patch series and complete your work on sb600spi? I will take care this work moves forward and not stuck, but I think first thing to do is: the chain needs to be rebased with the latest state of the tree. -- To view, visit https://review.coreboot.org/c/flashrom/+/65237 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id1c526e04ef4cf1f9a036328cbfb0d14ec310116 Gerrit-Change-Number: 65237 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 10 May 2023 02:28:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: jlink_spi: add cs=tms option to jlink_spi programmer
by Chen (Code Review) 10 May '23

10 May '23

Attention is currently required from: Chen, Alexander Goncharov. Hello build bot (Jenkins), Anastasia Klimchuk, Alexander Goncharov, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/75011 to look at the new patch set (#3). Change subject: jlink_spi: add cs=tms option to jlink_spi programmer ...................................................................... jlink_spi: add cs=tms option to jlink_spi programmer Currently, the code assumes the nCS pin of spi nor flash is connected to either nRESET(pin 15) or nTRST(pin 3). But it is incompatible with the pinout from official JFlash SPI, whereas the nCS pin is wired to TMS(pin 7). This commit adds cs=tms option to share the same pinout as JFlash SPI. It works by toggling TMS in assert_cs and deassert_cs, and sets TMS to zero in jlink_spi_send_command. The default option is set to cs=reset for backward compatibility. Tested on macOS 13.3.1 with JLink and Winbond W25Q128 Change-Id: I0cb467fcc2c403a25f260462de0cd020e7022bb1 Signed-off-by: Jiajie Chen <c(a)jia.je> --- M doc/classic_cli_manpage.rst M jlink_spi.c 2 files changed, 62 insertions(+), 15 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/11/75011/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/75011 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0cb467fcc2c403a25f260462de0cd020e7022bb1 Gerrit-Change-Number: 75011 Gerrit-PatchSet: 3 Gerrit-Owner: Chen <c(a)jia.je> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Chen <c(a)jia.je> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[master]: spi: add cs=tms option to jlink_spi programmer
by Anastasia Klimchuk (Code Review) 10 May '23

10 May '23

Attention is currently required from: Chen, Alexander Goncharov. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75011 ) Change subject: spi: add cs=tms option to jlink_spi programmer ...................................................................... Patch Set 2: Code-Review+1 (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/75011/comment/52f2139a_a6397dee PS2, Line 7: spi Sorry I didn't notice in the first pass: this should be `jlink_spi` , so that it describes more specifically where the change is. Just change `spi` -> `jlink_spi` Patchset: PS2: One more thing I forgot on the first pass: could you please update the manpage, it is here: doc/classic_cli_manpage.rst It currently still mentions two possible values for `cs` option. Thank you! -- To view, visit https://review.coreboot.org/c/flashrom/+/75011 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0cb467fcc2c403a25f260462de0cd020e7022bb1 Gerrit-Change-Number: 75011 Gerrit-PatchSet: 2 Gerrit-Owner: Chen <c(a)jia.je> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Chen <c(a)jia.je> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Wed, 10 May 2023 02:15:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: spi: add cs=tms option to jlink_spi programmer
by Chen (Code Review) 09 May '23

09 May '23

Attention is currently required from: Anastasia Klimchuk, Alexander Goncharov. Chen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75011 ) Change subject: spi: add cs=tms option to jlink_spi programmer ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > Yes, I have tested it on macOS 13.3.1 with JLink and Winbond W25Q128. […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/75011 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0cb467fcc2c403a25f260462de0cd020e7022bb1 Gerrit-Change-Number: 75011 Gerrit-PatchSet: 2 Gerrit-Owner: Chen <c(a)jia.je> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Tue, 09 May 2023 12:17:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Chen <c(a)jia.je> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: spi: add cs=tms option to jlink_spi programmer
by Chen (Code Review) 09 May '23

09 May '23

Attention is currently required from: Anastasia Klimchuk, Alexander Goncharov. Chen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75011 ) Change subject: spi: add cs=tms option to jlink_spi programmer ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > Chen, thank you for the patch! It's a nice and clean change, looks good! […] Yes, I have tested it on macOS 13.3.1 with JLink and Winbond W25Q128. The testing info is added to commmit message. -- To view, visit https://review.coreboot.org/c/flashrom/+/75011 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0cb467fcc2c403a25f260462de0cd020e7022bb1 Gerrit-Change-Number: 75011 Gerrit-PatchSet: 2 Gerrit-Owner: Chen <c(a)jia.je> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Tue, 09 May 2023 12:17:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: spi: add cs=tms option to jlink_spi programmer
by Chen (Code Review) 09 May '23

09 May '23

Attention is currently required from: Chen, Alexander Goncharov. Hello build bot (Jenkins), Anastasia Klimchuk, Alexander Goncharov, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/75011 to look at the new patch set (#2). Change subject: spi: add cs=tms option to jlink_spi programmer ...................................................................... spi: add cs=tms option to jlink_spi programmer Currently, the code assumes the nCS pin of spi nor flash is connected to either nRESET(pin 15) or nTRST(pin 3). But it is incompatible with the pinout from official JFlash SPI, whereas the nCS pin is wired to TMS(pin 7). This commit adds cs=tms option to share the same pinout as JFlash SPI. It works by toggling TMS in assert_cs and deassert_cs, and sets TMS to zero in jlink_spi_send_command. The default option is set to cs=reset for backward compatibility. Tested on macOS 13.3.1 with JLink and Winbond W25Q128 Change-Id: I0cb467fcc2c403a25f260462de0cd020e7022bb1 Signed-off-by: Jiajie Chen <c(a)jia.je> --- M jlink_spi.c 1 file changed, 60 insertions(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/11/75011/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/75011 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0cb467fcc2c403a25f260462de0cd020e7022bb1 Gerrit-Change-Number: 75011 Gerrit-PatchSet: 2 Gerrit-Owner: Chen <c(a)jia.je> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Chen <c(a)jia.je> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: newpatchset

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit May 2023