May 2023 - flashrom-gerrit - mail.coreboot.org

[M] Change in flashrom[master]: cli_classic: wrap options validation in function
by Alexander Goncharov (Code Review) 13 May '23

13 May '23

Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk. Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66531 ) Change subject: cli_classic: wrap options validation in function ...................................................................... Patch Set 6: (1 comment) Patchset: PS5: > If you could rebase and test with dummy, that would be great, thanks! I've provided a list of commands that I used to test this patch. Does it look good? -- To view, visit https://review.coreboot.org/c/flashrom/+/66531 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib5685eb5ee3810ef2efd40a3901340e2ceb229ff Gerrit-Change-Number: 66531 Gerrit-PatchSet: 6 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sat, 13 May 2023 10:59:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: cli_classic: wrap options validation in function
by Alexander Goncharov (Code Review) 13 May '23

13 May '23

Attention is currently required from: Edward O'Callaghan, Alexander Goncharov. Hello build bot (Jenkins), Edward O'Callaghan, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/66531 to look at the new patch set (#6). Change subject: cli_classic: wrap options validation in function ...................................................................... cli_classic: wrap options validation in function Introduce a function that will be responsible for checking the parameters. This is one of the steps on the way to simplify the main function by using helper functions with descriptive names. TOPIC=split_main_func TEST=the following scenarios failed as expected ./flashrom -p dummy:emulate=W25Q128FV -r "" ./flashrom -p dummy:emulate=W25Q128FV -l "" ./flashrom -p dummy:emulate=W25Q128FV --fmap-file "" ./flashrom -p dummy:emulate=W25Q128FV --flash-contents "" ./flashrom -p dummy:emulate=W25Q128FV --o "" Change-Id: Ib5685eb5ee3810ef2efd40a3901340e2ceb229ff Signed-off-by: Alexander Goncharov <chat(a)joursoir.net> --- M cli_classic.c 1 file changed, 41 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/31/66531/6 -- To view, visit https://review.coreboot.org/c/flashrom/+/66531 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib5685eb5ee3810ef2efd40a3901340e2ceb229ff Gerrit-Change-Number: 66531 Gerrit-PatchSet: 6 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[master]: jlink_spi: add cs=tms option to jlink_spi programmer
by Alexander Goncharov (Code Review) 13 May '23

13 May '23

Attention is currently required from: Chen, Thomas Heijligen. Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75011 ) Change subject: jlink_spi: add cs=tms option to jlink_spi programmer ...................................................................... Patch Set 5: Code-Review+2 (1 comment) File jlink_spi.c: https://review.coreboot.org/c/flashrom/+/75011/comment/bf2ec21a_c7c2dff9 PS3, Line 160: tms_buffer > I have tested both cases by changing the wiring of Dupont lines. Now it's clear to me, thank you. I was worried about the situation when CS is not wired to TMS, but I see that you've fixed that. -- To view, visit https://review.coreboot.org/c/flashrom/+/75011 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0cb467fcc2c403a25f260462de0cd020e7022bb1 Gerrit-Change-Number: 75011 Gerrit-PatchSet: 5 Gerrit-Owner: Chen <c(a)jia.je> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Chen <c(a)jia.je> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Sat, 13 May 2023 10:11:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Chen <c(a)jia.je> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: meson.build: enable jlink_spi by default
by Angel Pons (Code Review) 12 May '23

12 May '23

Attention is currently required from: Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75171 ) Change subject: meson.build: enable jlink_spi by default ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/75171 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I80f204de1bb26f459a38177f54a167db72003dbd Gerrit-Change-Number: 75171 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Fri, 12 May 2023 14:54:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: meson.build: enable serial programmer on Winwows.
by Angel Pons (Code Review) 12 May '23

12 May '23

Attention is currently required from: Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75170 ) Change subject: meson.build: enable serial programmer on Winwows. ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/75170/comment/07395846_de98afd0 PS1, Line 7: w typo: d -- To view, visit https://review.coreboot.org/c/flashrom/+/75170 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie60a25a9305374f9ed84a38f2650d517ec094387 Gerrit-Change-Number: 75170 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Fri, 12 May 2023 14:53:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: meson.build: enable jlink_spi by default
by Thomas Heijligen (Code Review) 12 May '23

12 May '23

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/75171 ) Change subject: meson.build: enable jlink_spi by default ...................................................................... meson.build: enable jlink_spi by default Most systems are shipping libjaylink, so try to build the programmer by default. Change-Id: I80f204de1bb26f459a38177f54a167db72003dbd Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M meson.build 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/71/75171/1 diff --git a/meson.build b/meson.build index 40f448f..b04f7e5 100644 --- a/meson.build +++ b/meson.build @@ -326,7 +326,6 @@ 'groups' : [ group_jlink, group_external ], 'srcs' : files('jlink_spi.c'), 'flags' : [ '-DCONFIG_JLINK_SPI=1' ], - 'default' : false, }, 'linux_mtd' : { 'systems' : [ 'linux' ], -- To view, visit https://review.coreboot.org/c/flashrom/+/75171 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I80f204de1bb26f459a38177f54a167db72003dbd Gerrit-Change-Number: 75171 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[master]: meson.build: enable serial programmer on Winwows.
by Thomas Heijligen (Code Review) 12 May '23

12 May '23

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/75170 ) Change subject: meson.build: enable serial programmer on Winwows. ...................................................................... meson.build: enable serial programmer on Winwows. Change-Id: Ie60a25a9305374f9ed84a38f2650d517ec094387 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M meson.build 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/70/75170/1 diff --git a/meson.build b/meson.build index 87f7809..40f448f 100644 --- a/meson.build +++ b/meson.build @@ -130,7 +130,7 @@ endif systems_hwaccess = [ 'linux', 'openbsd', 'freebsd', 'dragonfly', 'netbsd', 'dos' ] -systems_serial = [ 'linux', 'openbsd', 'freebsd', 'dragonfly', 'netbsd', 'darwin' ] +systems_serial = [ 'linux', 'openbsd', 'freebsd', 'dragonfly', 'netbsd', 'darwin', 'windows' ] cpus_port_io = [ 'x86', 'x86_64' ] -- To view, visit https://review.coreboot.org/c/flashrom/+/75170 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie60a25a9305374f9ed84a38f2650d517ec094387 Gerrit-Change-Number: 75170 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[master]: meson_options.txt: Unquote false
by Angel Pons (Code Review) 12 May '23

12 May '23

Attention is currently required from: Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75149 ) Change subject: meson_options.txt: Unquote false ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/75149/comment/e34a332c_a6037e73 PS1, Line 7: meson_options.txt: Unquote false You're unquoting a `true` -- To view, visit https://review.coreboot.org/c/flashrom/+/75149 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib3a46112678098ff3b2e92c44cf4539089216106 Gerrit-Change-Number: 75149 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Fri, 12 May 2023 14:40:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: meson_options.txt: Unquote false
by Thomas Heijligen (Code Review) 12 May '23

12 May '23

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/75149 ) Change subject: meson_options.txt: Unquote false ...................................................................... meson_options.txt: Unquote false Meson 1.1.0 deprecates the translation from 'false' to false in the boolean typed option. Remove the quotes to keep compatible with newer meson versions. https://mesonbuild.com/Release-notes-for-1-1-0.html#coercing-values-in-the-… Change-Id: Ib3a46112678098ff3b2e92c44cf4539089216106 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M meson_options.txt 1 file changed, 17 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/49/75149/1 diff --git a/meson_options.txt b/meson_options.txt index 91d3045..732d8d52 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -5,7 +5,7 @@ option('ich_descriptors_tool', type : 'feature', value : 'auto', description : 'Build ich_descriptors_tool') option('bash_completion', type : 'feature', value : 'auto', description : 'Install bash completion') option('tests', type : 'feature', value : 'auto', description : 'Build unit tests') -option('use_internal_dmi', type : 'boolean', value : 'true') +option('use_internal_dmi', type : 'boolean', value : true) option('programmer', type : 'array', value : ['auto'], choices : [ 'auto', 'all', 'group_internal', 'group_external', -- To view, visit https://review.coreboot.org/c/flashrom/+/75149 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib3a46112678098ff3b2e92c44cf4539089216106 Gerrit-Change-Number: 75149 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[master]: doc: Add doc how to add docs
by Anastasia Klimchuk (Code Review) 12 May '23

12 May '23

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Alexander Goncharov. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74225 ) Change subject: doc: Add doc how to add docs ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: > One vague idea: interaction with manpage. […] The first part is a good idea `We could tell people to consider whether information belongs in the manpage or the docs` I will think about it, yes I might try add a sentence or two about it (I need to think a bit). The second part: good news! :) manpage is already converted to docs! it lives here: doc/classic_cli_manpage.rst manpage is generated when docs option is enabled with meson (and it is auto-enabled when sphinx dep is found) -- To view, visit https://review.coreboot.org/c/flashrom/+/74225 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I356a286ad2f3334392efadda366b0ca0f8042752 Gerrit-Change-Number: 74225 Gerrit-PatchSet: 6 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Fri, 12 May 2023 09:33:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit May 2023