May 2023 - flashrom-gerrit - mail.coreboot.org

[S] Change in flashrom[master]: meson_options.txt: Unquote true
by Thomas Heijligen (Code Review) 13 May '23

13 May '23

Attention is currently required from: Angel Pons. Hello build bot (Jenkins), Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/75149 to look at the new patch set (#3). Change subject: meson_options.txt: Unquote true ...................................................................... meson_options.txt: Unquote true Meson 1.1.0 deprecates the translation from 'true' to true and 'false' to false in the boolean typed option. Remove the quotes to keep compatible with newer meson versions. https://mesonbuild.com/Release-notes-for-1-1-0.html#coercing-values-in-the-… Change-Id: Ib3a46112678098ff3b2e92c44cf4539089216106 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M meson_options.txt 1 file changed, 17 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/49/75149/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/75149 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib3a46112678098ff3b2e92c44cf4539089216106 Gerrit-Change-Number: 75149 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: meson.build: enable jlink_spi by default
by Thomas Heijligen (Code Review) 13 May '23

13 May '23

Attention is currently required from: Thomas Heijligen. Hello build bot (Jenkins), Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/75171 to look at the new patch set (#3). Change subject: meson.build: enable jlink_spi by default ...................................................................... meson.build: enable jlink_spi by default Most systems are shipping libjaylink, so try to build the programmer by default. Change-Id: I80f204de1bb26f459a38177f54a167db72003dbd Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M meson.build 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/71/75171/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/75171 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I80f204de1bb26f459a38177f54a167db72003dbd Gerrit-Change-Number: 75171 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: meson_options.txt: Unquote true
by Thomas Heijligen (Code Review) 13 May '23

13 May '23

Attention is currently required from: Angel Pons. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75149 ) Change subject: meson_options.txt: Unquote true ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/75149/comment/4cab29a7_a315c404 PS1, Line 7: meson_options.txt: Unquote false > You're unquoting a `true` Done -- To view, visit https://review.coreboot.org/c/flashrom/+/75149 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib3a46112678098ff3b2e92c44cf4539089216106 Gerrit-Change-Number: 75149 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sat, 13 May 2023 16:37:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: doc: Add Windows MSYS2 build instructions
by Thomas Heijligen (Code Review) 13 May '23

13 May '23

Attention is currently required from: Anastasia Klimchuk. Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/75189 ) Change subject: doc: Add Windows MSYS2 build instructions ...................................................................... doc: Add Windows MSYS2 build instructions Change-Id: I847428535547242ff32af92c4fe8477241826814 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M doc/dev_guide/building_from_source.rst 1 file changed, 21 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/89/75189/1 diff --git a/doc/dev_guide/building_from_source.rst b/doc/dev_guide/building_from_source.rst index 42a16f0..78ef1d9 100644 --- a/doc/dev_guide/building_from_source.rst +++ b/doc/dev_guide/building_from_source.rst @@ -81,7 +81,17 @@ cmocka-dev pciutils-dev libusb-dev libjaylink-dev * Windows - .. todo:: Add build instructions to build under MSYS2, CYGWIN or cross compiling from Linux + * MSYS2 + Install `MSYS2 <https://www.msys2.org/>`_ as recommended. + Then update the MSYS2 installation by running ``pacman -Syu`` multiple times. + + * ``libpci`` is not available through the package manager and pci based programmer are not supported on Windows. + + In the MINGW64 shell run:: + + pacman -Sy \ + mingw-w64-x86_64-gcc mingw-w64-x86_64-meson mingw-w64-x86_64-ninja mingw-w64-x86_64-pkg-config mingw-w64-python-sphinx \ + mingw-w64-x86_64-cmocka mingw-w64-x86_64-libusb mingw-w64-x86_64-libftdi mingw-w64-x86_64-libjaylink-git * MacOS * Homebrew -- To view, visit https://review.coreboot.org/c/flashrom/+/75189 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I847428535547242ff32af92c4fe8477241826814 Gerrit-Change-Number: 75189 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[master]: meson.build: enable jlink_spi by default
by Thomas Heijligen (Code Review) 13 May '23

13 May '23

Attention is currently required from: Thomas Heijligen. Hello build bot (Jenkins), Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/75171 to look at the new patch set (#2). Change subject: meson.build: enable jlink_spi by default ...................................................................... meson.build: enable jlink_spi by default Most systems are shipping libjaylink, so try to build the programmer by default. Change-Id: I80f204de1bb26f459a38177f54a167db72003dbd Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M meson.build 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/71/75171/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/75171 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I80f204de1bb26f459a38177f54a167db72003dbd Gerrit-Change-Number: 75171 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: meson.build: enable serial programmer on Windows.
by Thomas Heijligen (Code Review) 13 May '23

13 May '23

Attention is currently required from: Thomas Heijligen. Hello build bot (Jenkins), Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/75170 to look at the new patch set (#2). Change subject: meson.build: enable serial programmer on Windows. ...................................................................... meson.build: enable serial programmer on Windows. Change-Id: Ie60a25a9305374f9ed84a38f2650d517ec094387 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M meson.build 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/70/75170/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/75170 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie60a25a9305374f9ed84a38f2650d517ec094387 Gerrit-Change-Number: 75170 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: meson_options.txt: Unquote true
by Thomas Heijligen (Code Review) 13 May '23

13 May '23

Attention is currently required from: Thomas Heijligen. Hello build bot (Jenkins), Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/75149 to look at the new patch set (#2). Change subject: meson_options.txt: Unquote true ...................................................................... meson_options.txt: Unquote true Meson 1.1.0 deprecates the translation from 'false' to false in the boolean typed option. Remove the quotes to keep compatible with newer meson versions. https://mesonbuild.com/Release-notes-for-1-1-0.html#coercing-values-in-the-… Change-Id: Ib3a46112678098ff3b2e92c44cf4539089216106 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M meson_options.txt 1 file changed, 17 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/49/75149/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/75149 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib3a46112678098ff3b2e92c44cf4539089216106 Gerrit-Change-Number: 75149 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[master]: cli_classic: move validation of incompatible options to one place
by Alexander Goncharov (Code Review) 13 May '23

13 May '23

Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk. Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66532 ) Change subject: cli_classic: move validation of incompatible options to one place ...................................................................... Patch Set 7: (1 comment) Patchset: PS6: > Another note on testing: all the invalid combinations can be tested with dummy. […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/66532 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If6d7579847cc8ae13b54ef7bd50072a9402f835f Gerrit-Change-Number: 66532 Gerrit-PatchSet: 7 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sat, 13 May 2023 11:28:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: cli_classic: move validation of incompatible options to one place
by Alexander Goncharov (Code Review) 13 May '23

13 May '23

Attention is currently required from: Edward O'Callaghan, Alexander Goncharov. Hello build bot (Jenkins), Edward O'Callaghan, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/66532 to look at the new patch set (#7). Change subject: cli_classic: move validation of incompatible options to one place ...................................................................... cli_classic: move validation of incompatible options to one place Avoid repeating the same messages. TOPIC=split_main_func TEST=the following scenarios failed as expected ./flashrom -p dummy:emulate=W25Q128FV -v "ff.bin" -n ./flashrom -p dummy:emulate=W25Q128FV -l "tmp.layout" --ifd ./flashrom -p dummy:emulate=W25Q128FV -l "tmp.layout" --fmap ./flashrom -p dummy:emulate=W25Q128FV -l "tmp.layout" --fmap-file "fmap.bin" ./flashrom -p dummy:emulate=W25Q128FV --wp-enable --wp-disable ./flashrom -p dummy:emulate=W25Q128FV \ -l "tmp.layout" \ --wp-enable \ --wp-range=0x00000000,0x01000000 \ --wp-region "boot" Change-Id: If6d7579847cc8ae13b54ef7bd50072a9402f835f Signed-off-by: Alexander Goncharov <chat(a)joursoir.net> --- M cli_classic.c 1 file changed, 38 insertions(+), 33 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/32/66532/7 -- To view, visit https://review.coreboot.org/c/flashrom/+/66532 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If6d7579847cc8ae13b54ef7bd50072a9402f835f Gerrit-Change-Number: 66532 Gerrit-PatchSet: 7 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[master]: cli_classic: wrap options validation in function
by Alexander Goncharov (Code Review) 13 May '23

13 May '23

Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk. Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66531 ) Change subject: cli_classic: wrap options validation in function ...................................................................... Patch Set 6: (1 comment) Patchset: PS5: > If you could rebase and test with dummy, that would be great, thanks! I've provided a list of commands that I used to test this patch. Does it look good? -- To view, visit https://review.coreboot.org/c/flashrom/+/66531 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib5685eb5ee3810ef2efd40a3901340e2ceb229ff Gerrit-Change-Number: 66531 Gerrit-PatchSet: 6 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sat, 13 May 2023 10:59:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit May 2023