Attention is currently required from: Anastasia Klimchuk.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75125 )
Change subject: README: Add installing and packaging instructions for meson
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I would rather remove the build and packaging instructions from the readme, link only to the documentation and not add also the meson ones. E.g. Add a building_with_make.rst page.
--
To view, visit https://review.coreboot.org/c/flashrom/+/75125
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2d5900538d54c43efcc8c5b7010df5d867f3b190
Gerrit-Change-Number: 75125
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Comment-Date: Sun, 14 May 2023 15:12:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, Anastasia Klimchuk, Nicholas Chin.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75192 )
Change subject: doc: Add info about Discord channel
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
I would prefer to switch the order of Discord and IRC, since Discord is the new one and IRC was there for ever.
--
To view, visit https://review.coreboot.org/c/flashrom/+/75192
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ide57b8d04bd805cf42e402a79653e0b051a477da
Gerrit-Change-Number: 75192
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Sun, 14 May 2023 14:51:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Chen, Anastasia Klimchuk, Alexander Goncharov.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75193 )
Change subject: meson: Set minimum required version for libjaylink
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/75193/comment/38cba289_2b6fe083
PS2, Line 9: This is needed after
Commit <> requires `jaylink_jtag_set_tms()`. This function is introduces at libjaylink version 0.3.0. Check the version before compiling.
File meson.build:
https://review.coreboot.org/c/flashrom/+/75193/comment/35396871_a328d517
PS2, Line 150: >=0.3
>=0.3.0
--
To view, visit https://review.coreboot.org/c/flashrom/+/75193
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I31b37256fc2c3c12b43eeda60e6cb2718f1fef02
Gerrit-Change-Number: 75193
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Reviewer: Chen <c(a)jia.je>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Chen <c(a)jia.je>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Comment-Date: Sun, 14 May 2023 14:45:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Chen, Thomas Heijligen, Alexander Goncharov.
Hello Chen, Thomas Heijligen, Alexander Goncharov,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/75193
to look at the new patch set (#2).
Change subject: meson: Set minimum required version for libjaylink
......................................................................
meson: Set minimum required version for libjaylink
This is needed after
commit 592c1c3e5fd9ae42a261966c82ddd83f777ce2b6
Change-Id: I31b37256fc2c3c12b43eeda60e6cb2718f1fef02
Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org>
---
M meson.build
1 file changed, 14 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/93/75193/2
--
To view, visit https://review.coreboot.org/c/flashrom/+/75193
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I31b37256fc2c3c12b43eeda60e6cb2718f1fef02
Gerrit-Change-Number: 75193
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Reviewer: Chen <c(a)jia.je>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Chen <c(a)jia.je>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-MessageType: newpatchset
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75011 )
Change subject: jlink_spi: add cs=tms option to jlink_spi programmer
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
Update: we now need CB:75193 so we can go to that other patch and talk about it , thanks!
--
To view, visit https://review.coreboot.org/c/flashrom/+/75011
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I0cb467fcc2c403a25f260462de0cd020e7022bb1
Gerrit-Change-Number: 75011
Gerrit-PatchSet: 6
Gerrit-Owner: Chen <c(a)jia.je>
Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Sun, 14 May 2023 13:36:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Chen, Thomas Heijligen, Alexander Goncharov.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75193 )
Change subject: meson: Set minimum required version for libjaylink
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I made a patch to make things build, but tell me if there is more correct solution!
--
To view, visit https://review.coreboot.org/c/flashrom/+/75193
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I31b37256fc2c3c12b43eeda60e6cb2718f1fef02
Gerrit-Change-Number: 75193
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Reviewer: Chen <c(a)jia.je>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Chen <c(a)jia.je>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Comment-Date: Sun, 14 May 2023 13:34:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Thomas Heijligen.
Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/75192 )
Change subject: doc: Add info about Discord channel
......................................................................
doc: Add info about Discord channel
The patch adds information about Discord #flashrom channel.
Because there are now two different real-time channels, the
page is re-structured to have "Real time chats" section and
information about Discord and IRC inside "Real time chats".
Change-Id: Ide57b8d04bd805cf42e402a79653e0b051a477da
Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org>
---
M doc/contact.rst
1 file changed, 43 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/92/75192/1
diff --git a/doc/contact.rst b/doc/contact.rst
index 3a29c24..ea39cc0 100644
--- a/doc/contact.rst
+++ b/doc/contact.rst
@@ -31,26 +31,45 @@
If your mail contains any BIOS images or F segment dumps (instead of links which are fine), the mail will be rejected for legal reasons
(we do not have the right to distribute BIOS images).
+Real time chats
+---------------
+
+Flashrom has real time channels where you have the chance to talk to people being involved or interested in the project.
+Most of the discussion is about flashrom development, contributions, tech talk and user help.
+
+You are welcome to join and discuss current and future flashrom development, ideas and contributions.
+
+If you have a problem and would like to get help, don't ask for help. Instead, just **explain** your problem right away,
+and make sure to **describe** the situation as much as possible, so that other people can understand you and provide meaningful answers.
+Otherwise, others have to ask or guess the details of your problem, which is frustrating for both parties.
+
+Should you need to paste lots of text (more than three lines), please use a `paste service <https://en.wikipedia.org/wiki/Pastebin>`_.
+For flashrom logs, feel free to use `paste.flashrom.org <https://paste.flashrom.org>`_.
+Other good paste services are `ix.io <http://ix.io/>`_, `paste.rs <https://paste.rs/>`_, `bpaste.net <https://bpaste.net/>`_,
+`gist.github.com <https://gist.github.com/>`_ and `dpaste.com <http://dpaste.com/>`_.
+
+Questions on `coreboot <https://coreboot.org>`_, `OpenBIOS <http://www.openbios.info/>`_, firmware and related topics are welcome in **#coreboot** on the same server.
+
+Discord
+"""""""
+
+Flashrom Discord channel is hosted on coreboot's server. Once you join, you will be able to see all coreboot's and flashrom's channels in one place.
+To join, use the `invite link <https://discord.gg/dgcrkwVyeR>`_.
+
IRC
----
-Some of the flashrom developers and users hang out in the `#flashrom <irc://irc.libera.chat/#flashrom>`_
+"""
+
+You can join `#flashrom <irc://irc.libera.chat/#flashrom>`_
channel on the `Libera.chat <https://www.libera.chat/>`_ `IRC <https://en.wikipedia.org/wiki/Internet_Relay_Chat>`_ network.
If you don't have an IRC client, you can use the Libera.chat `webchat <https://web.libera.chat/#flashrom>`_.
**#flashrom** channel is bridged to `Matrix <https://matrix.org/>`_.
If you would like to join, you can use `this invite link <https://matrix.to/#/#flashrom:libera.chat>`_.
-Here you have the chance to talk to people being involved or interested in this project.
-Most of the discussion is tech talk and user help.
-
Do note that IRC's nature has a significant effect on conversations. People from all over the world can join this channel
with many different cultures and timezones. Most people are in the `CET timezone <https://en.wikipedia.org/wiki/Central_European_Time>`_,
so the channel may be very quiet during `CET nighttime <https://time.is/CET>`_.
-If you have a problem and would like to get help, don't ask for help. Instead, just **explain** your problem right away,
-and make sure to **describe** the situation as much as possible, so that other people can understand you and provide meaningful answers.
-Otherwise, others have to ask or guess the details of your problem, which is frustrating for both parties.
-
If you receive no replies, **please be patient**.
After all, silence is better than getting replied with `"IDK" <https://en.wiktionary.org/wiki/IDK>`_.
Frequently, somebody knows the answer, but hasn't checked IRC yet. In any case, please **do not leave the channel while waiting for an answer!**
@@ -64,13 +83,6 @@
Instead of sending lots of tiny messages with only about two words, prefer using longer sentences, spaces and punctuation symbols.
If reading and understanding your messages is easy, replying to them is also easy.
-Should you need to paste lots of text (more than three lines), please use a `paste service <https://en.wikipedia.org/wiki/Pastebin>`_.
-For flashrom logs, feel free to use `paste.flashrom.org <https://paste.flashrom.org>`_.
-Other good paste services are `ix.io <http://ix.io/>`_, `paste.rs <https://paste.rs/>`_, `bpaste.net <https://bpaste.net/>`_,
-`gist.github.com <https://gist.github.com/>`_ and `dpaste.com <http://dpaste.com/>`_.
-
-Questions on `coreboot <https://coreboot.org>`_, `OpenBIOS <http://www.openbios.info/>`_, firmware and related topics are welcome in **#coreboot** on the same server.
-
Dev meeting
-----------
Flashrom developers community runs an online meeting every two weeks.
--
To view, visit https://review.coreboot.org/c/flashrom/+/75192
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ide57b8d04bd805cf42e402a79653e0b051a477da
Gerrit-Change-Number: 75192
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-MessageType: newchange
Attention is currently required from: Miklós Márton, Anastasia Klimchuk, Peter Marheine.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74963 )
Change subject: ni845x_spi: support building with Meson
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
> Miklos, what do you think about it? Thanks!
ni845x is neither compiling with make nor with meson. Also when fixing the compilation bugs, the linking is not working.
--
To view, visit https://review.coreboot.org/c/flashrom/+/74963
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I90e85c424f97898b47bf0a3d78672d6c25af12b0
Gerrit-Change-Number: 74963
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Comment-Date: Sun, 14 May 2023 09:25:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: comment