March 2022 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: board_enable.c: Fix dead assignment
by Keith Hui (Code Review) 15 Mar '22

15 Mar '22

Attention is currently required from: Idwer Vollering, Angel Pons, Light. Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62761 ) Change subject: board_enable.c: Fix dead assignment ...................................................................... Patch Set 4: Code-Review+1 (1 comment) Patchset: PS4: Okay. I did some build testing with and without the patch. The compiled object code turned out identical. That means the assignment is really not needed, and my compiler (gcc 11.2.1 as supplied by Fedora 34) did not complain. -- To view, visit https://review.coreboot.org/c/flashrom/+/62761 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7458b416a69fd5e2aa300ca49d1352b6074ad0bc Gerrit-Change-Number: 62761 Gerrit-PatchSet: 4 Gerrit-Owner: Light <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Idwer Vollering <vidwer(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Light <aarya.chaumal(a)gmail.com> Gerrit-Comment-Date: Tue, 15 Mar 2022 03:21:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: pcidev.c: Simplify by consolidating common logic
by Edward O'Callaghan (Code Review) 15 Mar '22

15 Mar '22

Attention is currently required from: Edward O'Callaghan. Hello build bot (Jenkins), Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/59281 to look at the new patch set (#3). Change subject: pcidev.c: Simplify by consolidating common logic ...................................................................... pcidev.c: Simplify by consolidating common logic BUG=b:220950271 TEST=builds Change-Id: I0048fc6ab816d230ff48c84bc17122431753d55d Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M pcidev.c 1 file changed, 24 insertions(+), 21 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/81/59281/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/59281 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0048fc6ab816d230ff48c84bc17122431753d55d Gerrit-Change-Number: 59281 Gerrit-PatchSet: 3 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: pcidev.c: Rename pci_dev_find() -> pcidev_find()
by Edward O'Callaghan (Code Review) 15 Mar '22

15 Mar '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/59282 to look at the new patch set (#4). Change subject: pcidev.c: Rename pci_dev_find() -> pcidev_find() ...................................................................... pcidev.c: Rename pci_dev_find() -> pcidev_find() Make symbol name consistent with the rest in pcidev.c BUG=b:220950271 TEST=builds Change-Id: I41e0922d5429b4389367dd98b4241d50b8013183 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M board_enable.c M chipset_enable.c M pcidev.c M programmer.h M sb600spi.c 5 files changed, 21 insertions(+), 21 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/82/59282/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/59282 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I41e0922d5429b4389367dd98b4241d50b8013183 Gerrit-Change-Number: 59282 Gerrit-PatchSet: 4 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: flashrom.8.tmpl: Add raiden_debug_spi doc entry
by Edward O'Callaghan (Code Review) 15 Mar '22

15 Mar '22

Attention is currently required from: Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62768 ) Change subject: flashrom.8.tmpl: Add raiden_debug_spi doc entry ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/flashrom/+/62768 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I186920006bdfcc7a9f89542f84b452dfc72b18e4 Gerrit-Change-Number: 62768 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 14 Mar 2022 23:38:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashrom.8.tmpl: Clarify man entries for -r/-w/-x
by Edward O'Callaghan (Code Review) 15 Mar '22

15 Mar '22

Attention is currently required from: Paul Menzel, Daniel Campello. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62794 ) Change subject: flashrom.8.tmpl: Clarify man entries for -r/-w/-x ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/62794 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0cba593da3926c8587027789f4e1e89a2329ca7f Gerrit-Change-Number: 62794 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Daniel Campello <campello(a)chromium.org> Gerrit-Comment-Date: Mon, 14 Mar 2022 23:38:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashrom.8.tmpl: Clarify man entries for -r/-w/-x
by Daniel Campello (Code Review) 15 Mar '22

15 Mar '22

Attention is currently required from: Paul Menzel, Edward O'Callaghan. Daniel Campello has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62794 ) Change subject: flashrom.8.tmpl: Clarify man entries for -r/-w/-x ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/62794/comment/3b98beec_3cc208a0 PS1, Line 7: clarifying > Imperative mood: Clarify Done https://review.coreboot.org/c/flashrom/+/62794/comment/d2fa842c_bc8ddfb1 PS1, Line 15: Change-Id: I0cba593da3926c8587027789f4e1e89a2329ca7f > Missing Signed-off-by line? Done -- To view, visit https://review.coreboot.org/c/flashrom/+/62794 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0cba593da3926c8587027789f4e1e89a2329ca7f Gerrit-Change-Number: 62794 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Mon, 14 Mar 2022 19:11:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashrom.8.tmpl: Clarify man entries for -r/-w/-x
by Daniel Campello (Code Review) 15 Mar '22

15 Mar '22

Attention is currently required from: Edward O'Callaghan, Daniel Campello. Hello build bot (Jenkins), Paul Menzel, Edward O'Callaghan, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62794 to look at the new patch set (#2). Change subject: flashrom.8.tmpl: Clarify man entries for -r/-w/-x ...................................................................... flashrom.8.tmpl: Clarify man entries for -r/-w/-x This change adds follow up changes to the man page: - Explain <-> argument for -r/-w operations - Expand on region name handling of -x operation BUG=b:224364316 Change-Id: I0cba593da3926c8587027789f4e1e89a2329ca7f Signed-off-by: Daniel Campello <campello(a)chromium.org> --- M flashrom.8.tmpl 1 file changed, 11 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/94/62794/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/62794 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0cba593da3926c8587027789f4e1e89a2329ca7f Gerrit-Change-Number: 62794 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Daniel Campello <campello(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: ich_descriptors.c: Initialize structures
by Light (Code Review) 15 Mar '22

15 Mar '22

Attention is currently required from: Nico Huber, Angel Pons. Hello build bot (Jenkins), Nico Huber, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62763 to look at the new patch set (#4). Change subject: ich_descriptors.c: Initialize structures ...................................................................... ich_descriptors.c: Initialize structures Initialize structures with memset so that they do not produce garbage values if the fields are not initialized later. Change-Id: I6e5bc84c6199a0731db0a9c8ef56f1215686dab2 Signed-off-by: Aarya Chaumal <aarya.chaumal(a)gmail.com> --- M ich_descriptors.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/63/62763/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/62763 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6e5bc84c6199a0731db0a9c8ef56f1215686dab2 Gerrit-Change-Number: 62763 Gerrit-PatchSet: 4 Gerrit-Owner: Light <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: flashrom.8.tmpl: clarifying man entries for -r/-w/-x
by Paul Menzel (Code Review) 15 Mar '22

15 Mar '22

Attention is currently required from: Edward O'Callaghan, Daniel Campello. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62794 ) Change subject: flashrom.8.tmpl: clarifying man entries for -r/-w/-x ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/62794/comment/6da1ebcd_99e7da8e PS1, Line 7: clarifying Imperative mood: Clarify https://review.coreboot.org/c/flashrom/+/62794/comment/d15a875c_4c8aa57d PS1, Line 15: Change-Id: I0cba593da3926c8587027789f4e1e89a2329ca7f Missing Signed-off-by line? -- To view, visit https://review.coreboot.org/c/flashrom/+/62794 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0cba593da3926c8587027789f4e1e89a2329ca7f Gerrit-Change-Number: 62794 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Daniel Campello <campello(a)chromium.org> Gerrit-Comment-Date: Mon, 14 Mar 2022 18:06:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashrom.8.tmpl: clarifying man entries for -r/-w/-x
by Daniel Campello (Code Review) 15 Mar '22

15 Mar '22

Daniel Campello has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/62794 ) Change subject: flashrom.8.tmpl: clarifying man entries for -r/-w/-x ...................................................................... flashrom.8.tmpl: clarifying man entries for -r/-w/-x This change adds follow up changes to the man page: - Explain <-> argument for -r/-w operations - Expand on region name handling of -x operation BUG=b:224364316 Change-Id: I0cba593da3926c8587027789f4e1e89a2329ca7f --- M flashrom.8.tmpl 1 file changed, 11 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/94/62794/1 diff --git a/flashrom.8.tmpl b/flashrom.8.tmpl index fe2d9d6..3274f07 100644 --- a/flashrom.8.tmpl +++ b/flashrom.8.tmpl @@ -77,16 +77,20 @@ .B -p/--programmer option to be used (please see below). .TP -.B "\-r, \-\-read <file>" +.B "\-r, \-\-read <file|->" Read flash ROM contents and save them into the given .BR <file> . -If the file already exists, it will be overwritten. +If the file already exists, it will be overwritten. If +.BR <-> +is provided instead, contents will be written to the stdout. .TP -.B "\-w, \-\-write <file>" +.B "\-w, \-\-write <file|->" Write .B <file> -into flash ROM. This will first automatically -.B erase +into flash ROM. If +.B <-> +is provided instead, contents will be read from stdin. This will first automatically + B erase the chip, then write to it. .sp In the process the chip is also read several times. First an in-memory backup @@ -133,7 +137,8 @@ .TP .B "\-x, \-\-extract" Extract every region defined on the layout from flash ROM chip to a -file with the same name as the extracted region. +file with the same name as the extracted region (replacing spaces with +underscores). .TP .B "\-V, \-\-verbose" More verbose output. This option can be supplied multiple times -- To view, visit https://review.coreboot.org/c/flashrom/+/62794 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0cba593da3926c8587027789f4e1e89a2329ca7f Gerrit-Change-Number: 62794 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Campello <campello(a)chromium.org> Gerrit-MessageType: newchange

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit March 2022