March 2022 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: ich_descriptors.c: Assert unsigned types >=0 on to prevent underflow ...
by Light (Code Review) 14 Mar '22

14 Mar '22

Attention is currently required from: Light. Hello build bot (Jenkins), Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62764 to look at the new patch set (#6). Change subject: ich_descriptors.c: Assert unsigned types >=0 on to prevent underflow error ...................................................................... ich_descriptors.c: Assert unsigned types >=0 on to prevent underflow error Unsigned types show undefined … [View More]

1 0

Change in flashrom[master]: ich_descriptors.c: Assert unsigned types >=0 on to prevent underflow ...
by Light (Code Review) 14 Mar '22

14 Mar '22

Attention is currently required from: Light. Hello build bot (Jenkins), Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62764 to look at the new patch set (#5). Change subject: ich_descriptors.c: Assert unsigned types >=0 on to prevent underflow error ...................................................................... ich_descriptors.c: Assert unsigned types >=0 on to prevent underflow error Unsigned types show undefined … [View More]

1 0

Change in flashrom[master]: ich_descriptors.c: Assert unsigned types >=0 on to prevent underflow ...
by Light (Code Review) 14 Mar '22

14 Mar '22

Attention is currently required from: Light. Hello build bot (Jenkins), Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62764 to look at the new patch set (#4). Change subject: ich_descriptors.c: Assert unsigned types >=0 on to prevent underflow error ...................................................................... ich_descriptors.c: Assert unsigned types >=0 on to prevent underflow error Unsigned types show undefined … [View More]

1 0

Change in flashrom[master]: ich_descriptors.c: Initialize structures with memset
by Light (Code Review) 14 Mar '22

14 Mar '22

Attention is currently required from: Nico Huber, Light. Hello build bot (Jenkins), Nico Huber, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62763 to look at the new patch set (#3). Change subject: ich_descriptors.c: Initialize structures with memset ...................................................................... ich_descriptors.c: Initialize structures with memset Initialize structures with memset so that they do not … [View More]

1 0

Change in flashrom[master]: ichspi: Add support for Meteor Lake
by Angel Pons (Code Review) 14 Mar '22

14 Mar '22

Attention is currently required from: Wonkyu Kim, Subrata Banik, Edward O'Callaghan, Anastasia Klimchuk. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62783 ) Change subject: ichspi: Add support for Meteor Lake ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/62783 To unsubscribe, or for help writing mail filters, visit https://review.… [View More]

1 0

Change in flashrom[master]: flashrom.c, sfdp.c: Initialize dynamically allocated memory using calloc
by Angel Pons (Code Review) 14 Mar '22

14 Mar '22

Attention is currently required from: Nico Huber, Light, Anastasia Klimchuk. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62747 ) Change subject: flashrom.c, sfdp.c: Initialize dynamically allocated memory using calloc ...................................................................... Patch Set 6: (1 comment) Patchset: PS5: > Angel, I have something in memory that you had a patch at some point to replace malloc with calloc? […] Ah, CB:… [View More]

1 0

Change in flashrom[master]: ich_descriptors.c: Assert unsigned types >=0 on to prevent underflow ...
by Angel Pons (Code Review) 14 Mar '22

14 Mar '22

Attention is currently required from: Light. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62764 ) Change subject: ich_descriptors.c: Assert unsigned types >=0 on to prevent underflow error ...................................................................... Patch Set 3: (1 comment) File ich_descriptors.c: https://review.coreboot.org/c/flashrom/+/62764/comment/5ff2f92b_7144b5f3 PS3, Line 507: { Please put this brace on the previous line … [View More]

1 0

Change in flashrom[master]: ich_descriptors.c: Assert unsigned types >=0 on to prevent underflow ...
by Angel Pons (Code Review) 14 Mar '22

14 Mar '22

Attention is currently required from: Light. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62764 ) Change subject: ich_descriptors.c: Assert unsigned types >=0 on to prevent underflow error ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File ich_descriptors.c: https://review.coreboot.org/c/flashrom/+/62764/comment/b4bfd3fa_b7e412e6 PS3, Line 508: >= nit: Please add spaces … [View More]

1 0

Change in flashrom[master]: ich_descriptors.c: Initialize structures with memset
by Angel Pons (Code Review) 14 Mar '22

14 Mar '22

Attention is currently required from: Nico Huber, Light. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62763 ) Change subject: ich_descriptors.c: Initialize structures with memset ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File ich_descriptors.c: https://review.coreboot.org/c/flashrom/+/62763/comment/610c0241_edac7e9d PS2, Line 1362: struct ich_descriptors desc; I think this … [View More]

1 0

Change in flashrom[master]: board_enable.c: Fix dead assignment
by Angel Pons (Code Review) 14 Mar '22

14 Mar '22

Attention is currently required from: Keith Hui, Light, Anastasia Klimchuk. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62761 ) Change subject: board_enable.c: Fix dead assignment ...................................................................... Patch Set 4: Code-Review+1 (1 comment) Patchset: PS1: > Maybe INB has some side-effects, for example doing something and then the assignment happens. […] `INB(0x80)` reads a byte from I/O port … [View More]

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit March 2022