March 2022 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: Makefile: build shared pci code as part of the programmer
by Thomas Heijligen (Code Review) 15 Mar '22

15 Mar '22

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/62835 ) Change subject: Makefile: build shared pci code as part of the programmer ...................................................................... Makefile: build shared pci code as part of the programmer Change-Id: I18a54cb0f728a670cc16b67c72e891d26918db19 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M Makefile 1 file changed, 18 insertions(+), 18 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/35/62835/1 diff --git a/Makefile b/Makefile index def0322..9a59538 100644 --- a/Makefile +++ b/Makefile @@ -580,12 +580,13 @@ FEATURE_FLAGS += -D'CONFIG_INTERNAL=1' PROGRAMMER_OBJS += processor_enable.o chipset_enable.o board_enable.o cbtable.o \ internal.o it87spi.o it85spi.o sb600spi.o amd_imc.o wbsio_spi.o mcp6x_spi.o \ - ichspi.o dmi.o + ichspi.o dmi.o pcidev.o endif else ifeq ($(CONFIG_INTERNAL), yes) FEATURE_FLAGS += -D'CONFIG_INTERNAL=1' -PROGRAMMER_OBJS += processor_enable.o chipset_enable.o board_enable.o cbtable.o internal.o +PROGRAMMER_OBJS += processor_enable.o chipset_enable.o board_enable.o cbtable.o \ + internal.o pcidev.o endif endif @@ -620,37 +621,37 @@ ifeq ($(CONFIG_NIC3COM), yes) FEATURE_FLAGS += -D'CONFIG_NIC3COM=1' -PROGRAMMER_OBJS += nic3com.o +PROGRAMMER_OBJS += nic3com.o pcidev.o endif ifeq ($(CONFIG_GFXNVIDIA), yes) FEATURE_FLAGS += -D'CONFIG_GFXNVIDIA=1' -PROGRAMMER_OBJS += gfxnvidia.o +PROGRAMMER_OBJS += gfxnvidia.o pcidev.o endif ifeq ($(CONFIG_SATASII), yes) FEATURE_FLAGS += -D'CONFIG_SATASII=1' -PROGRAMMER_OBJS += satasii.o +PROGRAMMER_OBJS += satasii.o pcidev.o endif ifeq ($(CONFIG_ATAHPT), yes) FEATURE_FLAGS += -D'CONFIG_ATAHPT=1' -PROGRAMMER_OBJS += atahpt.o +PROGRAMMER_OBJS += atahpt.o pcidev.o endif ifeq ($(CONFIG_ATAVIA), yes) FEATURE_FLAGS += -D'CONFIG_ATAVIA=1' -PROGRAMMER_OBJS += atavia.o +PROGRAMMER_OBJS += atavia.o pcidev.o endif ifeq ($(CONFIG_ATAPROMISE), yes) FEATURE_FLAGS += -D'CONFIG_ATAPROMISE=1' -PROGRAMMER_OBJS += atapromise.o +PROGRAMMER_OBJS += atapromise.o pcidev.o endif ifeq ($(CONFIG_IT8212), yes) FEATURE_FLAGS += -D'CONFIG_IT8212=1' -PROGRAMMER_OBJS += it8212.o +PROGRAMMER_OBJS += it8212.o pcidev.o endif ifeq ($(CONFIG_FT2232_SPI), yes) @@ -695,37 +696,37 @@ ifeq ($(CONFIG_DRKAISER), yes) FEATURE_FLAGS += -D'CONFIG_DRKAISER=1' -PROGRAMMER_OBJS += drkaiser.o +PROGRAMMER_OBJS += drkaiser.o pcidev.o endif ifeq ($(CONFIG_NICREALTEK), yes) FEATURE_FLAGS += -D'CONFIG_NICREALTEK=1' -PROGRAMMER_OBJS += nicrealtek.o +PROGRAMMER_OBJS += nicrealtek.o pcidev.o endif ifeq ($(CONFIG_NICNATSEMI), yes) FEATURE_FLAGS += -D'CONFIG_NICNATSEMI=1' -PROGRAMMER_OBJS += nicnatsemi.o +PROGRAMMER_OBJS += nicnatsemi.o pcidev.o endif ifeq ($(CONFIG_NICINTEL), yes) FEATURE_FLAGS += -D'CONFIG_NICINTEL=1' -PROGRAMMER_OBJS += nicintel.o +PROGRAMMER_OBJS += nicintel.o pcidev.o endif ifeq ($(CONFIG_NICINTEL_SPI), yes) FEATURE_FLAGS += -D'CONFIG_NICINTEL_SPI=1' -PROGRAMMER_OBJS += nicintel_spi.o +PROGRAMMER_OBJS += nicintel_spi.o pcidev.o endif ifeq ($(CONFIG_NICINTEL_EEPROM), yes) FEATURE_FLAGS += -D'CONFIG_NICINTEL_EEPROM=1' -PROGRAMMER_OBJS += nicintel_eeprom.o +PROGRAMMER_OBJS += nicintel_eeprom.o pcidev.o endif ifeq ($(CONFIG_OGP_SPI), yes) FEATURE_FLAGS += -D'CONFIG_OGP_SPI=1' -PROGRAMMER_OBJS += ogp_spi.o +PROGRAMMER_OBJS += ogp_spi.o pcidev.o endif ifeq ($(CONFIG_BUSPIRATE_SPI), yes) @@ -745,7 +746,7 @@ ifeq ($(CONFIG_SATAMV), yes) FEATURE_FLAGS += -D'CONFIG_SATAMV=1' -PROGRAMMER_OBJS += satamv.o +PROGRAMMER_OBJS += satamv.o pcidev.o endif ifeq ($(CONFIG_LINUX_MTD), yes) @@ -835,7 +836,6 @@ USE_LIBPCI := $(if $(call filter_deps,$(DEPENDS_ON_LIBPCI)),yes,no) ifeq ($(USE_LIBPCI), yes) -PROGRAMMER_OBJS += pcidev.o override CFLAGS += $(CONFIG_LIBPCI_CFLAGS) override LDFLAGS += $(CONFIG_LIBPCI_LDFLAGS) endif -- To view, visit https://review.coreboot.org/c/flashrom/+/62835 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I18a54cb0f728a670cc16b67c72e891d26918db19 Gerrit-Change-Number: 62835 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: NEED_PCI: remove macro
by Thomas Heijligen (Code Review) 15 Mar '22

15 Mar '22

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/62834 ) Change subject: NEED_PCI: remove macro ...................................................................... NEED_PCI: remove macro The NEED_PCI macro is meanwhile only used to guard prototypes. This is not needed. Change-Id: I6895b795bc96b3e251700bff4b0054407aac789a Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M Makefile M meson.build M programmer.h 3 files changed, 1 insertion(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/34/62834/1 diff --git a/Makefile b/Makefile index fc7c403..def0322 100644 --- a/Makefile +++ b/Makefile @@ -836,7 +836,6 @@ USE_LIBPCI := $(if $(call filter_deps,$(DEPENDS_ON_LIBPCI)),yes,no) ifeq ($(USE_LIBPCI), yes) PROGRAMMER_OBJS += pcidev.o -FEATURE_FLAGS += -D'NEED_PCI=1' override CFLAGS += $(CONFIG_LIBPCI_CFLAGS) override LDFLAGS += $(CONFIG_LIBPCI_LDFLAGS) endif diff --git a/meson.build b/meson.build index b7fc25f..446a8b6 100644 --- a/meson.build +++ b/meson.build @@ -155,7 +155,6 @@ if get_option('pciutils') srcs += 'pcidev.c' deps += dependency('libpci') - cargs += '-DNEED_PCI=1' elif need_libpci error('pciutils is disabled but one or more enabled programmer requires PCI access') endif diff --git a/programmer.h b/programmer.h index 6a0c3fa..97a5c19 100644 --- a/programmer.h +++ b/programmer.h @@ -115,7 +115,6 @@ unsigned int half_period; }; -#if NEED_PCI == 1 struct pci_dev; struct pci_filter; @@ -139,7 +138,7 @@ int rpci_write_byte(struct pci_dev *dev, int reg, uint8_t data); int rpci_write_word(struct pci_dev *dev, int reg, uint16_t data); int rpci_write_long(struct pci_dev *dev, int reg, uint32_t data); -#endif + #if CONFIG_INTERNAL == 1 struct penable { @@ -260,11 +259,9 @@ #define SUPERIO_VENDOR_ITE 0x1 #define SUPERIO_VENDOR_WINBOND 0x2 #endif -#if NEED_PCI == 1 struct pci_dev *pci_dev_find(uint16_t vendor, uint16_t device); struct pci_dev *pci_card_find(uint16_t vendor, uint16_t device, uint16_t card_vendor, uint16_t card_device); -#endif #if CONFIG_INTERNAL == 1 extern int is_laptop; extern int laptop_ok; -- To view, visit https://review.coreboot.org/c/flashrom/+/62834 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6895b795bc96b3e251700bff4b0054407aac789a Gerrit-Change-Number: 62834 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: print_buildinfo: remove unreachable print of libpci version
by Thomas Heijligen (Code Review) 15 Mar '22

15 Mar '22

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/62833 ) Change subject: print_buildinfo: remove unreachable print of libpci version ...................................................................... print_buildinfo: remove unreachable print of libpci version The libpci header is nether direct or indirect included in flashrom.c, `PCILIB_VERSION` is therefore never set and the folloing print statement is dead code. Since libpci is the only library in buildinfo, I drop it. Change-Id: I0b5dbf3bd82a2ffe64b73881383e92f7dad4c382 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M flashrom.c 1 file changed, 0 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/33/62833/1 diff --git a/flashrom.c b/flashrom.c index ac61259..51a9fbe 100644 --- a/flashrom.c +++ b/flashrom.c @@ -1646,13 +1646,6 @@ void print_buildinfo(void) { msg_gdbg("flashrom was built with"); -#if NEED_PCI == 1 -#ifdef PCILIB_VERSION - msg_gdbg(" libpci %s,", PCILIB_VERSION); -#else - msg_gdbg(" unknown PCI library,"); -#endif -#endif #ifdef __clang__ msg_gdbg(" LLVM Clang"); #ifdef __clang_version__ -- To view, visit https://review.coreboot.org/c/flashrom/+/62833 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0b5dbf3bd82a2ffe64b73881383e92f7dad4c382 Gerrit-Change-Number: 62833 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: Makefile: build shared usb code only when needed by programmer
by Thomas Heijligen (Code Review) 15 Mar '22

15 Mar '22

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/62832 ) Change subject: Makefile: build shared usb code only when needed by programmer ...................................................................... Makefile: build shared usb code only when needed by programmer Change-Id: I9a91c5801a573e7021686a183a1bd874122e35cc Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M Makefile 1 file changed, 2 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/32/62832/1 diff --git a/Makefile b/Makefile index f5ed409..fc7c403 100644 --- a/Makefile +++ b/Makefile @@ -605,7 +605,7 @@ ifeq ($(CONFIG_RAIDEN_DEBUG_SPI), yes) FEATURE_FLAGS += -D'CONFIG_RAIDEN_DEBUG_SPI=1' -PROGRAMMER_OBJS += raiden_debug_spi.o +PROGRAMMER_OBJS += raiden_debug_spi.o usb_device.o endif ifeq ($(CONFIG_PONY_SPI), yes) @@ -740,7 +740,7 @@ ifeq ($(CONFIG_DEVELOPERBOX_SPI), yes) FEATURE_FLAGS += -D'CONFIG_DEVELOPERBOX_SPI=1' -PROGRAMMER_OBJS += developerbox_spi.o +PROGRAMMER_OBJS += developerbox_spi.o usbdev.o endif ifeq ($(CONFIG_SATAMV), yes) @@ -845,7 +845,6 @@ ifeq ($(USE_LIBUSB1), yes) override CFLAGS += $(CONFIG_LIBUSB1_CFLAGS) override LDFLAGS += $(CONFIG_LIBUSB1_LDFLAGS) -PROGRAMMER_OBJS +=usbdev.o usb_device.o endif USE_LIBFTDI1 := $(if $(call filter_deps,$(DEPENDS_ON_LIBFTDI1)),yes,no) -- To view, visit https://review.coreboot.org/c/flashrom/+/62832 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9a91c5801a573e7021686a183a1bd874122e35cc Gerrit-Change-Number: 62832 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: gitignore: add libflashrom.a
by Thomas Heijligen (Code Review) 15 Mar '22

15 Mar '22

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/62826 ) Change subject: gitignore: add libflashrom.a ...................................................................... gitignore: add libflashrom.a Change-Id: I9258a1710780df5c6a7c864de246ebbe850d60fe Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M .gitignore 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/26/62826/1 diff --git a/.gitignore b/.gitignore index 7c45aba..d47cb9e 100644 --- a/.gitignore +++ b/.gitignore @@ -9,6 +9,7 @@ /flashrom-* /flashrom.exe /flashrom.8 +/libflashrom.a /libflashrom-doc/ /util/ich_descriptors_tool/ich_descriptors_tool -- To view, visit https://review.coreboot.org/c/flashrom/+/62826 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9258a1710780df5c6a7c864de246ebbe850d60fe Gerrit-Change-Number: 62826 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: writeprotect.c: refactor and fix wp_mode functions
by Nikolai Artemiev (Code Review) 15 Mar '22

15 Mar '22

Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62643 ) Change subject: writeprotect.c: refactor and fix wp_mode functions ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/62643/comment/aba7f6ea_696bf2f7 PS2, Line 11: > Given that is a follow up on previous patch, let's maybe add a reference. […] Done https://review.coreboot.org/c/flashrom/+/62643/comment/026fd27d_59cd8995 PS2, Line 16: builds > It might be fine, but just in case, maybe you have an environment with this patch already and you ca […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/62643 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib6c347453f9216e5816e4ed35bf9783fd3c720e0 Gerrit-Change-Number: 62643 Gerrit-PatchSet: 3 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 15 Mar 2022 04:35:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips.c: add writeprotect support for more chips
by Nikolai Artemiev (Code Review) 15 Mar '22

15 Mar '22

Attention is currently required from: Anastasia Klimchuk. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62214 ) Change subject: flashchips.c: add writeprotect support for more chips ...................................................................... Patch Set 22: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/62214/comment/acee77aa_d153848a PS22, Line 9: Chip(s) tested > which masters were used during the testing? Done -- To view, visit https://review.coreboot.org/c/flashrom/+/62214 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7f3d4c4148056098a845b5c64308b0333ebda395 Gerrit-Change-Number: 62214 Gerrit-PatchSet: 22 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 15 Mar 2022 04:34:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: writeprotect.c: refactor and fix wp_mode functions
by Nikolai Artemiev (Code Review) 15 Mar '22

15 Mar '22

Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Nikolai Artemiev. Hello build bot (Jenkins), Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62643 to look at the new patch set (#3). Change subject: writeprotect.c: refactor and fix wp_mode functions ...................................................................... writeprotect.c: refactor and fix wp_mode functions Use a lookup table in get_wp_mode() and drop the srp_bit_present check, since a chip without SRP is just FLASHROM_WP_MODE_DISABLED. Add a srp_bit_present check to set_wp_mode() if the mode requires it. BUG=b:182223106 BRANCH=none TEST=flashrom --wp-{enable,disable,status} on AMD dut Change-Id: Ib6c347453f9216e5816e4ed35bf9783fd3c720e0 Signed-off-by: Nikolai Artemiev <nartemiev(a)google.com> --- M writeprotect.c 1 file changed, 13 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/43/62643/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/62643 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib6c347453f9216e5816e4ed35bf9783fd3c720e0 Gerrit-Change-Number: 62643 Gerrit-PatchSet: 3 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: libflashrom,linux_mtd: add linux_mtd writeprotect support
by Nikolai Artemiev (Code Review) 15 Mar '22

15 Mar '22

Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev, Anastasia Klimchuk. Hello build bot (Jenkins), Edward O'Callaghan, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/61897 to look at the new patch set (#30). Change subject: libflashrom,linux_mtd: add linux_mtd writeprotect support ...................................................................... libflashrom,linux_mtd: add linux_mtd writeprotect support BUG=b:182223106 BRANCH=none TEST=make Change-Id: I5c86e28cdec44bec49ba1d36f8ab62241b9b01da Signed-off-by: Nikolai Artemiev <nartemiev(a)google.com> --- M libflashrom.c M linux_mtd.c M programmer.h 3 files changed, 126 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/97/61897/30 -- To view, visit https://review.coreboot.org/c/flashrom/+/61897 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5c86e28cdec44bec49ba1d36f8ab62241b9b01da Gerrit-Change-Number: 61897 Gerrit-PatchSet: 30 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: flashchips.c: add writeprotect support for more chips
by Nikolai Artemiev (Code Review) 15 Mar '22

15 Mar '22

Attention is currently required from: Nikolai Artemiev, Anastasia Klimchuk. Hello build bot (Jenkins), Edward O'Callaghan, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62214 to look at the new patch set (#23). Change subject: flashchips.c: add writeprotect support for more chips ...................................................................... flashchips.c: add writeprotect support for more chips Physical chips were tested with an FT232H adapter where possible, others were checked against datasheets. Flashrom Chip name | Chip(s) tested ---------------------------------+---------------------------- AT25SL128A | EN25QH128 | GD25LQ128C/GD25LQ128D/GD25LQ128E | GD25LQ128DSIG GD25LQ64(B) | GD25LQ64CWIG GD25Q127C/GD25Q128C | GD25Q127CSIG, GD25Q128ESIG GD25Q256D | GD25Q256DYIG GD25Q64(B) | GD25Q64CSIG W25Q128.JW.DTR | W25Q128.V..M | W25Q128.W | W25Q256JV_M | W25Q256.V | W25Q64.W | XM25QH128C | XM25QH256C | BUG=b:182223106 BRANCH=none TEST=flashrom --wp-{enable,disable,range,list,status} Change-Id: I7f3d4c4148056098a845b5c64308b0333ebda395 Signed-off-by: Nikolai Artemiev <nartemiev(a)google.com> --- M flashchips.c 1 file changed, 138 insertions(+), 14 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/14/62214/23 -- To view, visit https://review.coreboot.org/c/flashrom/+/62214 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7f3d4c4148056098a845b5c64308b0333ebda395 Gerrit-Change-Number: 62214 Gerrit-PatchSet: 23 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit March 2022