March 2022 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: libflashrom,linux_mtd: add linux_mtd writeprotect support
by Nikolai Artemiev (Code Review) 16 Mar '22

16 Mar '22

Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev, Anastasia Klimchuk. Hello build bot (Jenkins), Edward O'Callaghan, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/61897 to look at the new patch set (#31). Change subject: libflashrom,linux_mtd: add linux_mtd writeprotect support ...................................................................... libflashrom,linux_mtd: add linux_mtd writeprotect support BUG=b:182223106 BRANCH=none TEST=WP ops on hana DUT (MT8173) with W25Q32DW flash TEST=flashrom --wp-enable --wp-range <non-empty> succeeds TEST=flashrom --wp-enable --wp-range <empty> fails as expected TEST=flashrom --wp-disable --wp-range <empty> succeeds TEST=flashrom --wp-disable --wp-range <non-empty> fails as expected TEST=flashrom --wp-status succeeds Change-Id: I5c86e28cdec44bec49ba1d36f8ab62241b9b01da Signed-off-by: Nikolai Artemiev <nartemiev(a)google.com> --- M libflashrom.c M linux_mtd.c M programmer.h 3 files changed, 138 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/97/61897/31 -- To view, visit https://review.coreboot.org/c/flashrom/+/61897 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5c86e28cdec44bec49ba1d36f8ab62241b9b01da Gerrit-Change-Number: 61897 Gerrit-PatchSet: 31 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: ichspi: Add support for Meteor Lake
by Edward O'Callaghan (Code Review) 16 Mar '22

16 Mar '22

Attention is currently required from: Wonkyu Kim, Subrata Banik, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62783 ) Change subject: ichspi: Add support for Meteor Lake ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/62783 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0a2ffe2ba8d96c90d89b77e0d8583d179ff02a75 Gerrit-Change-Number: 62783 Gerrit-PatchSet: 5 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Wonkyu Kim Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Wonkyu Kim Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Wed, 16 Mar 2022 04:26:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tests: Add padding to pci_dev struct for ASAN
by Daniel Campello (Code Review) 16 Mar '22

16 Mar '22

Daniel Campello has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/62845 ) Change subject: tests: Add padding to pci_dev struct for ASAN ...................................................................... tests: Add padding to pci_dev struct for ASAN This change addresses the following ASAN error: * ASAN error detected: * ================================================================= * ==12==ERROR: AddressSanitizer: global-buffer-overflow on address 0x55a8a046c916 at pc 0x55a8a038a21d bp 0x7ffd5dbc9ed0 sp 0x7ffd5dbc9ec8 * READ of size 2 at 0x55a8a046c916 thread T0 * #0 0x55a8a038a21c in nicrealtek_init /build/amd64-generic/tmp/portage/sys-apps/flashrom-9999/work/flashrom-9999-build/../flashrom-9999/nicrealtek.c:119:15 * #1 0x55a8a032f172 in __sanitizer::BufferedStackTrace::UnwindImpl(unsigned long, unsigned long, void*, bool, unsigned int) ??:0:0 * #2 0x55a8a02b65b8 in __asan::ErrorGeneric::Print() ??:0:0 * #3 0x55a8a03294d5 in __asan::ScopedInErrorReport::~ScopedInErrorReport() ??:0:0 * #4 0x55a8a032c5ae in __asan::ReportGenericError(unsigned long, unsigned long, unsigned long, unsigned long, bool, unsigned long, unsigned int, bool) ??:0:0 * #5 0x55a8a032d0f7 in __asan_report_load2 ??:0:0 * * 0x55a8a046c916 is located 18 bytes to the right of global variable 'mock_pci_dev' defined in '../flashrom-9999/tests/tests.c:50:16' (0x55a8a046c900) of size 4 * SUMMARY: AddressSanitizer: global-buffer-overflow (/tmp/portage/sys-apps/flashrom-9999/work/flashrom-9999-build/tests/flashrom_unit_tests+0x19a21c) * Shadow bytes around the buggy address: * 0x0ab5940858d0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 * 0x0ab5940858e0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 * 0x0ab5940858f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 * 0x0ab594085900: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 * 0x0ab594085910: 00 00 00 00 00 00 f9 f9 f9 f9 f9 f9 f9 f9 00 00 * =>0x0ab594085920: 04 f9[f9]f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 * 0x0ab594085930: f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 * 0x0ab594085940: f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 * 0x0ab594085950: f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 * 0x0ab594085960: f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 * 0x0ab594085970: f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 * Shadow byte legend (one shadow byte represents 8 application bytes): * Addressable: 00 * Partially addressable: 01 02 03 04 05 06 07 * Heap left redzone: fa * Freed heap region: fd * Stack left redzone: f1 * Stack mid redzone: f2 * Stack right redzone: f3 * Stack after return: f5 * Stack use after scope: f8 * Global redzone: f9 * Global init order: f6 * Poisoned by user: f7 * Container overflow: fc * Array cookie: ac * Intra object redzone: bb * ASan internal: fe * Left alloca redzone: ca * Right alloca redzone: cb * ==12==ABORTING BUG=b:224828279 TEST=FEATURES=test emerge-amd64-generic flashrom BRANCH=none Signed-off-by: Daniel Campello <campello(a)chromium.org> Change-Id: I47943bf70181a9041f287df3ece0f7067a112de8 --- M tests/io_mock.h 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/45/62845/1 diff --git a/tests/io_mock.h b/tests/io_mock.h index 8734774..f8f75ad 100644 --- a/tests/io_mock.h +++ b/tests/io_mock.h @@ -45,6 +45,7 @@ /* Define struct pci_dev to avoid dependency on pci.h */ struct pci_dev { + char padding[18]; unsigned int device_id; }; -- To view, visit https://review.coreboot.org/c/flashrom/+/62845 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I47943bf70181a9041f287df3ece0f7067a112de8 Gerrit-Change-Number: 62845 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Campello <campello(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: flashrom.8.tmpl: Clarify man entries for -w/-v/-x
by Daniel Campello (Code Review) 16 Mar '22

16 Mar '22

Attention is currently required from: Nico Huber, Paul Menzel. Daniel Campello has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62794 ) Change subject: flashrom.8.tmpl: Clarify man entries for -w/-v/-x ...................................................................... Patch Set 4: (2 comments) File flashrom.8.tmpl: https://review.coreboot.org/c/flashrom/+/62794/comment/649a98dd_7be12753 PS2, Line 80: .B "\-r, \-\-read <file|->" > Ups.... I just noticed my mistake.... Done https://review.coreboot.org/c/flashrom/+/62794/comment/2cb404f9_694f9c3e PS2, Line 80: |- > Technically, what we put in <> is a placeholder. But the - is meant […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/62794 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0cba593da3926c8587027789f4e1e89a2329ca7f Gerrit-Change-Number: 62794 Gerrit-PatchSet: 4 Gerrit-Owner: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 15 Mar 2022 22:19:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Daniel Campello <campello(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashrom.8.tmpl: Clarify man entries for -w/-v/-x
by Daniel Campello (Code Review) 16 Mar '22

16 Mar '22

Attention is currently required from: Nico Huber, Paul Menzel. Hello build bot (Jenkins), Paul Menzel, Edward O'Callaghan, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62794 to look at the new patch set (#4). Change subject: flashrom.8.tmpl: Clarify man entries for -w/-v/-x ...................................................................... flashrom.8.tmpl: Clarify man entries for -w/-v/-x This change adds follow up changes to the man page: - Explain (-) argument for -w/-v operations - Expand on region name handling of -x operation Also updates cli_classic.c to match with --help output. BUG=b:224364316 Change-Id: I0cba593da3926c8587027789f4e1e89a2329ca7f Signed-off-by: Daniel Campello <campello(a)chromium.org> --- M cli_classic.c M flashrom.8.tmpl 2 files changed, 13 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/94/62794/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/62794 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0cba593da3926c8587027789f4e1e89a2329ca7f Gerrit-Change-Number: 62794 Gerrit-PatchSet: 4 Gerrit-Owner: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: flashrom.8.tmpl: Clarify man entries for -r/-w/-x
by Daniel Campello (Code Review) 16 Mar '22

16 Mar '22

Attention is currently required from: Nico Huber, Paul Menzel. Hello build bot (Jenkins), Paul Menzel, Edward O'Callaghan, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62794 to look at the new patch set (#3). Change subject: flashrom.8.tmpl: Clarify man entries for -r/-w/-x ...................................................................... flashrom.8.tmpl: Clarify man entries for -r/-w/-x This change adds follow up changes to the man page: - Explain <-> argument for -r/-w operations - Expand on region name handling of -x operation Also updates cli_classic.c to match with --help output. BUG=b:224364316 Change-Id: I0cba593da3926c8587027789f4e1e89a2329ca7f Signed-off-by: Daniel Campello <campello(a)chromium.org> --- M cli_classic.c M flashrom.8.tmpl 2 files changed, 13 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/94/62794/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/62794 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0cba593da3926c8587027789f4e1e89a2329ca7f Gerrit-Change-Number: 62794 Gerrit-PatchSet: 3 Gerrit-Owner: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: flashrom.8.tmpl: Clarify man entries for -r/-w/-x
by Daniel Campello (Code Review) 16 Mar '22

16 Mar '22

Attention is currently required from: Nico Huber, Paul Menzel. Daniel Campello has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62794 ) Change subject: flashrom.8.tmpl: Clarify man entries for -r/-w/-x ...................................................................... Patch Set 2: (1 comment) File flashrom.8.tmpl: https://review.coreboot.org/c/flashrom/+/62794/comment/a3081acb_924679e3 PS2, Line 80: .B "\-r, \-\-read <file|->" > review.coreboot. […] Ups.... I just noticed my mistake.... -- To view, visit https://review.coreboot.org/c/flashrom/+/62794 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0cba593da3926c8587027789f4e1e89a2329ca7f Gerrit-Change-Number: 62794 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 15 Mar 2022 22:13:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Daniel Campello <campello(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashrom.8.tmpl: Clarify man entries for -r/-w/-x
by Daniel Campello (Code Review) 16 Mar '22

16 Mar '22

Attention is currently required from: Nico Huber, Paul Menzel. Daniel Campello has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62794 ) Change subject: flashrom.8.tmpl: Clarify man entries for -r/-w/-x ...................................................................... Patch Set 2: (1 comment) File flashrom.8.tmpl: https://review.coreboot.org/c/flashrom/+/62794/comment/0695f95b_184fc747 PS2, Line 80: .B "\-r, \-\-read <file|->" > Is this implemented? review.coreboot.org/c/flashrom/+/52383 -- To view, visit https://review.coreboot.org/c/flashrom/+/62794 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0cba593da3926c8587027789f4e1e89a2329ca7f Gerrit-Change-Number: 62794 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 15 Mar 2022 22:09:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashrom.8.tmpl: Add raiden_debug_spi doc entry
by Nico Huber (Code Review) 16 Mar '22

16 Mar '22

Attention is currently required from: Edward O'Callaghan, Angel Pons, Nikolai Artemiev, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62768 ) Change subject: flashrom.8.tmpl: Add raiden_debug_spi doc entry ...................................................................... Patch Set 1: (2 comments) File flashrom.8.tmpl: https://review.coreboot.org/c/flashrom/+/62768/comment/262522ea_0f947c9e PS1, Line 361: .BR "* raiden_debug_spi" " (for SPI flash ROMs attached to a ChromiumOS servo debug board)" ft2232_spi also works with Servo. I guess it's about the version? Also, how does it relate to Suzy Qable? is that considered a version of the Servo or not supported at all? https://review.coreboot.org/c/flashrom/+/62768/comment/28f3278a_f84f2dce PS1, Line 1156: syntax. So it's a (reset) recovery delay? -- To view, visit https://review.coreboot.org/c/flashrom/+/62768 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I186920006bdfcc7a9f89542f84b452dfc72b18e4 Gerrit-Change-Number: 62768 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 15 Mar 2022 21:27:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashrom.8.tmpl: Clarify man entries for -r/-w/-x
by Nico Huber (Code Review) 16 Mar '22

16 Mar '22

Attention is currently required from: Paul Menzel, Daniel Campello. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62794 ) Change subject: flashrom.8.tmpl: Clarify man entries for -r/-w/-x ...................................................................... Patch Set 2: (2 comments) File flashrom.8.tmpl: https://review.coreboot.org/c/flashrom/+/62794/comment/2769c93d_e23be084 PS2, Line 80: .B "\-r, \-\-read <file|->" Is this implemented? https://review.coreboot.org/c/flashrom/+/62794/comment/a6aeef9c_4b9c1e51 PS2, Line 80: |- Technically, what we put in <> is a placeholder. But the - is meant literally. So I guess what we'd want is (<file>|-) -- To view, visit https://review.coreboot.org/c/flashrom/+/62794 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0cba593da3926c8587027789f4e1e89a2329ca7f Gerrit-Change-Number: 62794 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Daniel Campello <campello(a)chromium.org> Gerrit-Comment-Date: Tue, 15 Mar 2022 21:18:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit March 2022