March 2022 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: print_buildinfo: remove unreachable print of libpci version
by Thomas Heijligen (Code Review) 15 Mar '22

15 Mar '22

Attention is currently required from: Nico Huber, Angel Pons. Hello build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62833 to look at the new patch set (#2). Change subject: print_buildinfo: remove unreachable print of libpci version ...................................................................... print_buildinfo: remove unreachable print of libpci version The libpci header is neither directly nor indirectly included in flashrom.c. `PCILIB_VERSION` is therefore never set and the follwoing print statement is dead code. Since libpci is the only library in buildinfo, Drop it. Change-Id: I0b5dbf3bd82a2ffe64b73881383e92f7dad4c382 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M flashrom.c 1 file changed, 0 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/33/62833/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/62833 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0b5dbf3bd82a2ffe64b73881383e92f7dad4c382 Gerrit-Change-Number: 62833 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: print_buildinfo: remove unreachable print of libpci version
by Thomas Heijligen (Code Review) 15 Mar '22

15 Mar '22

Attention is currently required from: Nico Huber, Angel Pons. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62833 ) Change subject: print_buildinfo: remove unreachable print of libpci version ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Why not include the header instead? It would make the build more complex. Especially if you want to unify the behavior for all libraries. As alternative a build time generated struct with those information may me a good solution. Then there would be no need to include header files. -- To view, visit https://review.coreboot.org/c/flashrom/+/62833 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0b5dbf3bd82a2ffe64b73881383e92f7dad4c382 Gerrit-Change-Number: 62833 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 15 Mar 2022 15:40:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: print_buildinfo: remove unreachable print of libpci version
by Felix Singer (Code Review) 15 Mar '22

15 Mar '22

Attention is currently required from: Nico Huber, Thomas Heijligen. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62833 ) Change subject: print_buildinfo: remove unreachable print of libpci version ...................................................................... Patch Set 1: (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/62833/comment/83dfbb77_ecf301c9 PS1, Line 9: nether neither https://review.coreboot.org/c/flashrom/+/62833/comment/0221559e_18ddada1 PS1, Line 9: or nor https://review.coreboot.org/c/flashrom/+/62833/comment/976c8a8a_987463fd PS1, Line 10: folloing following -- To view, visit https://review.coreboot.org/c/flashrom/+/62833 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0b5dbf3bd82a2ffe64b73881383e92f7dad4c382 Gerrit-Change-Number: 62833 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Tue, 15 Mar 2022 14:30:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: build shared usb code only when needed by programmer
by Felix Singer (Code Review) 15 Mar '22

15 Mar '22

Attention is currently required from: Thomas Heijligen. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62832 ) Change subject: Makefile: build shared usb code only when needed by programmer ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/62832 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9a91c5801a573e7021686a183a1bd874122e35cc Gerrit-Change-Number: 62832 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Tue, 15 Mar 2022 14:28:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: README: add C compiler and pkg-config as build dependency
by Angel Pons (Code Review) 15 Mar '22

15 Mar '22

Attention is currently required from: Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62836 ) Change subject: README: add C compiler and pkg-config as build dependency ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/62836 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I64874dee905d8620f74acee98e0c8a149b067745 Gerrit-Change-Number: 62836 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Tue, 15 Mar 2022 13:35:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: README: add C compiler and pkg-config as build dependency
by Thomas Heijligen (Code Review) 15 Mar '22

15 Mar '22

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/62836 ) Change subject: README: add C compiler and pkg-config as build dependency ...................................................................... README: add C compiler and pkg-config as build dependency Change-Id: I64874dee905d8620f74acee98e0c8a149b067745 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M README 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/36/62836/1 diff --git a/README b/README index 71e8735..160d364 100644 --- a/README +++ b/README @@ -47,6 +47,9 @@ To build flashrom you need to install the following software: + * C compiler (GCC / clang) + * pkg-config + * pciutils+libpci (if you want support for mainboard or PCI device flashing) * libusb (if you want FT2232, Dediprog or USB-Blaster support) * libftdi (if you want FT2232 or USB-Blaster support) -- To view, visit https://review.coreboot.org/c/flashrom/+/62836 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I64874dee905d8620f74acee98e0c8a149b067745 Gerrit-Change-Number: 62836 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: print_buildinfo: remove unreachable print of libpci version
by Angel Pons (Code Review) 15 Mar '22

15 Mar '22

Attention is currently required from: Nico Huber, Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62833 ) Change subject: print_buildinfo: remove unreachable print of libpci version ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Why not include the header instead? -- To view, visit https://review.coreboot.org/c/flashrom/+/62833 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0b5dbf3bd82a2ffe64b73881383e92f7dad4c382 Gerrit-Change-Number: 62833 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Tue, 15 Mar 2022 13:34:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: print_buildinfo: remove unreachable print of libpci version
by Angel Pons (Code Review) 15 Mar '22

15 Mar '22

Attention is currently required from: Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62833 ) Change subject: print_buildinfo: remove unreachable print of libpci version ...................................................................... Patch Set 1: (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/62833/comment/9688aeba_42f22142 PS1, Line 9: direct directly https://review.coreboot.org/c/flashrom/+/62833/comment/7fd04b3a_ceb4b325 PS1, Line 9: indirect indirectly https://review.coreboot.org/c/flashrom/+/62833/comment/f85ea1dc_3f78e893 PS1, Line 11: I I'd drop this -- To view, visit https://review.coreboot.org/c/flashrom/+/62833 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0b5dbf3bd82a2ffe64b73881383e92f7dad4c382 Gerrit-Change-Number: 62833 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Tue, 15 Mar 2022 13:34:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: NEED_PCI: remove macro
by Angel Pons (Code Review) 15 Mar '22

15 Mar '22

Attention is currently required from: Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62834 ) Change subject: NEED_PCI: remove macro ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/62834/comment/c5694c62_7c7bf9e6 PS1, Line 9: meanwhile I'd drop this -- To view, visit https://review.coreboot.org/c/flashrom/+/62834 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6895b795bc96b3e251700bff4b0054407aac789a Gerrit-Change-Number: 62834 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Tue, 15 Mar 2022 13:31:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: gitignore: add libflashrom.a
by Felix Singer (Code Review) 15 Mar '22

15 Mar '22

Attention is currently required from: Thomas Heijligen. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62826 ) Change subject: gitignore: add libflashrom.a ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/62826 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9258a1710780df5c6a7c864de246ebbe850d60fe Gerrit-Change-Number: 62826 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Tue, 15 Mar 2022 13:00:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit March 2022