Edward O'Callaghan has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/64374 )
Change subject: flashrom.c: wrap chip->write() with a helper
......................................................................
Abandoned
we have this now with flashchips using a enum.
--
To view, visit https://review.coreboot.org/c/flashrom/+/64374
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I46490eba664f96df37310972141ee5db13e48877
Gerrit-Change-Number: 64374
Gerrit-PatchSet: 6
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: abandon
Edward O'Callaghan has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/64800 )
Change subject: flashrom.c: wrap chip->read() with a helper
......................................................................
Abandoned
we have this now with flashchips using a enum.
--
To view, visit https://review.coreboot.org/c/flashrom/+/64800
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7ebb45fba241c8d6041032df5f22fd3b03fca9f5
Gerrit-Change-Number: 64800
Gerrit-PatchSet: 4
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: abandon
Attention is currently required from: Felix Singer, Edward O'Callaghan.
Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70031 )
Change subject: internal,board_enable: Remove force_boardenable from globals
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/flashrom/+/70031
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3324681f024003694a5531d9d35bb13d2c583eb0
Gerrit-Change-Number: 70031
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Sam McNally <sammc(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Comment-Date: Fri, 02 Dec 2022 06:12:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70243 )
Change subject: util/lint: Introduce linter for git sign-off-by line
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/flashrom/+/70243
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: 1.3.x
Gerrit-Change-Id: I03f1827803f8492d60a0a44174d5822c2265bfcb
Gerrit-Change-Number: 70243
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Comment-Date: Fri, 02 Dec 2022 06:04:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Anastasia Klimchuk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70204 )
Change subject: flashchips.c: Add 4BA write to XM25Qx256C
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/flashrom/+/70204
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: 1.3.x
Gerrit-Change-Id: I96c80762fcda2af6028c7a53d8c545b0c6565cbd
Gerrit-Change-Number: 70204
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Liam Flaherty <liamflaherty(a)chromium.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Comment-Date: Fri, 02 Dec 2022 06:04:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Thomas Heijligen, Alexander Goncharov.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68247 )
Change subject: util: add bash completion script
......................................................................
Patch Set 9: Code-Review+1
(5 comments)
Patchset:
PS9:
Just some minor issues. Otherwise looks good to me.
File Makefile:
https://review.coreboot.org/c/flashrom/+/68247/comment/548f9631_ce2d77a1
PS9, Line 589: ACTIVE_PROGRAMMERS += internal
It took a little until I understood this programmer list is needed for the substitution. Please add a short note in the commit message mentioning that this is added in the Makefile and its purpose.
https://review.coreboot.org/c/flashrom/+/68247/comment/e720674b_819ef42a
PS9, Line 1032: $(PROGRAM).8 $(PROGRAM).8.html $(PROGRAM).bash $(BUILD_DETAILS_FILE)
One tab too much
https://review.coreboot.org/c/flashrom/+/68247/comment/e391935a_689a6738
PS9, Line 1041: .bash
> IIRC there should be no `. […]
That's just the file in the source directory. I think we can't remove the file suffix that easily, else it gets in conflict with the flashrom binary since both have the same same. Though I agree the installed file shouldn't have an suffix anymore.
Actually, I like that the resulting file has a suffix. I suggest using `.bash-completion` for that file lying in the source directory. Then it's consistent with the template file (not two different suffixes). Just remove the suffix for the destination in the install command.
File util/flashrom.bash-completion.tmpl:
https://review.coreboot.org/c/flashrom/+/68247/comment/74b2f75f_06fe7c64
PS9, Line 43: OPTS="--help
Missing \ at the end of each line.
--
To view, visit https://review.coreboot.org/c/flashrom/+/68247
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie68bc91c3cea4de2ffdbeffd07e48edd8d5590e1
Gerrit-Change-Number: 68247
Gerrit-PatchSet: 9
Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Comment-Date: Fri, 02 Dec 2022 05:35:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de>
Gerrit-MessageType: comment
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/70247
to look at the new patch set (#3).
Change subject: cbtables.c/search_lb_records: Drop unused variable `count`
......................................................................
cbtables.c/search_lb_records: Drop unused variable `count`
Clang 15 complains about it. Remove it.
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
Change-Id: I340208f513bed57a9cc2bba880a2400352c5cc42
---
M cbtable.c
1 file changed, 12 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/47/70247/3
--
To view, visit https://review.coreboot.org/c/flashrom/+/70247
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I340208f513bed57a9cc2bba880a2400352c5cc42
Gerrit-Change-Number: 70247
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70247 )
Change subject: cbtables.c/search_lb_records: Drop unused variable `count`
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Sorry for the mess. For whatever reason the other review is removed when I add a new one.
--
To view, visit https://review.coreboot.org/c/flashrom/+/70247
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I340208f513bed57a9cc2bba880a2400352c5cc42
Gerrit-Change-Number: 70247
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 02 Dec 2022 02:23:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Felix Singer has uploaded a new patch set (#2). ( https://review.coreboot.org/c/flashrom/+/70247 )
Change subject: cbtables.c/search_lb_records: Drop unused variable `count`
......................................................................
cbtables.c/search_lb_records: Drop unused variable `count`
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
Change-Id: I340208f513bed57a9cc2bba880a2400352c5cc42
---
M cbtable.c
1 file changed, 10 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/47/70247/2
--
To view, visit https://review.coreboot.org/c/flashrom/+/70247
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I340208f513bed57a9cc2bba880a2400352c5cc42
Gerrit-Change-Number: 70247
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-MessageType: newpatchset