December 2022 - flashrom-gerrit

[S] Change in flashrom[master]: flashrom.8.tmpl: Clarify supported ft2232_spi frequencies
by Nicholas Chin (Code Review) 01 Dec '22

01 Dec '22

Nicholas Chin has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/70218 ) Change subject: flashrom.8.tmpl: Clarify supported ft2232_spi frequencies ...................................................................... flashrom.8.tmpl: Clarify supported ft2232_spi frequencies The manpage suggests that ft2232_spi chips are only capable of up to 12 MHz SPI clock frequencies, whereas flashrom disables the divide-by-5 prescaler on the 'H' chips allowing up to 60 MHz frequencies. This detail was already present in the comments of ft2232_spi.c. Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com> Change-Id: Id7690e1d4e11a3d0495afbc650f3c67430946468 --- M flashrom.8.tmpl 1 file changed, 17 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/18/70218/1 diff --git a/flashrom.8.tmpl b/flashrom.8.tmpl index e672869..26ddad0 100644 --- a/flashrom.8.tmpl +++ b/flashrom.8.tmpl @@ -939,8 +939,8 @@ expressible divisors are all .B even numbers between 2 and 2^17 (=131072) resulting in SPI clock frequencies of -6 MHz down to about 92 Hz for 12 MHz inputs. The default divisor is set to 2, but you can use another one by -specifying the optional +6 MHz down to about 92 Hz for 12 MHz inputs (non-H chips) and 30 MHz down to about 458 Hz for 60 MHz inputs ('H' chips). The default +divisor is set to 2, but you can use another one by specifying the optional .B divisor parameter with the .sp -- To view, visit https://review.coreboot.org/c/flashrom/+/70218 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id7690e1d4e11a3d0495afbc650f3c67430946468 Gerrit-Change-Number: 70218 Gerrit-PatchSet: 1 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-MessageType: newchange

1 0

[M] Change in flashrom[master]: util/lint: Introduce linter for git sign-off-by line
by Felix Singer (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Edward O'Callaghan. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70079 ) Change subject: util/lint: Introduce linter for git sign-off-by line ...................................................................... Patch Set 9: (1 comment) Patchset: PS9: Unfortunately the +2 got dropped :/ -- To view, visit https://review.coreboot.org/c/flashrom/+/70079 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I03f1827803f8492d60a0a44174d5822c2265bfcb Gerrit-Change-Number: 70079 Gerrit-PatchSet: 9 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Thu, 01 Dec 2022 18:58:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: util/lint: Introduce linter for git sign-off-by line
by Felix Singer (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Edward O'Callaghan. Hello build bot (Jenkins), Edward O'Callaghan, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/70079 to look at the new patch set (#9). Change subject: util/lint: Introduce linter for git sign-off-by line ...................................................................... util/lint: Introduce linter for git sign-off-by line For compliance and to check if the commit message matches the development guidelines, add a linter checking for the sign-off-by line in the commit message. Also, hook it up to the test_build.sh script which is used for CI builds. These scripts were copied from the coreboot repository and were adjusted so that they work for flashrom. Change-Id: I03f1827803f8492d60a0a44174d5822c2265bfcb Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M test_build.sh A util/lint/helper_functions.sh A util/lint/lint-extended-020-signed-off-by 3 files changed, 93 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/79/70079/9 -- To view, visit https://review.coreboot.org/c/flashrom/+/70079 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I03f1827803f8492d60a0a44174d5822c2265bfcb Gerrit-Change-Number: 70079 Gerrit-PatchSet: 9 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[master]: Added support for Macronix MX25V1635F
by Gabriel Tremblay (Code Review) 01 Dec '22

01 Dec '22

Gabriel Tremblay has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/70213 ) Change subject: Added support for Macronix MX25V1635F ...................................................................... Added support for Macronix MX25V1635F Implentation was tested with a chip I had on hand and a RaspberryPI using the built-in SPI implementation and GPIO Pins Signed-off-by: Gabriel Tremblay <tremblay.gabriel(a)gmail.com> Change-Id: Id688f66ecbbb4ad2ea2f413db90974d917470b32 --- M flashchips.c M include/flashchips.h 2 files changed, 52 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/13/70213/1 diff --git a/flashchips.c b/flashchips.c index 6f65389..b3fa85e 100644 --- a/flashchips.c +++ b/flashchips.c @@ -9576,6 +9576,44 @@ { .vendor = "Macronix", + .name = "MX25V1635F", + .bustype = BUS_SPI, + .manufacture_id = MACRONIX_ID, + .model_id = MACRONIX_MX25V1635F, + .total_size = 16384, + .page_size = 256, + /* MX25V1635F supports SFDP */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP, + .probe = PROBE_SPI_RDID, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 4096} }, + .block_erase = SPI_BLOCK_ERASE_20, + }, { + .eraseblocks = { {32 * 1024, 512} }, + .block_erase = SPI_BLOCK_ERASE_52, + }, { + .eraseblocks = { {64 * 1024, 256} }, + .block_erase = SPI_BLOCK_ERASE_D8, + }, { + .eraseblocks = { {16 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_60, + }, { + .eraseblocks = { {16 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_C7, + }, + }, + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_BP3_SRWD, + .unlock = SPI_DISABLE_BLOCKPROTECT_BP3_SRWD, + .write = SPI_CHIP_WRITE256, + .read = SPI_CHIP_READ, /* Fast read (0x0B) supported, MX25V1635F supports dual I/O */ + .voltage = {2700, 3600}, /* 2.35-3.6V for MX25V1635F */ + }, + + { + .vendor = "Macronix", .name = "MX25U12835F", .bustype = BUS_SPI, .manufacture_id = MACRONIX_ID, diff --git a/include/flashchips.h b/include/flashchips.h index 5df42dc..42d9b07 100644 --- a/include/flashchips.h +++ b/include/flashchips.h @@ -524,7 +524,7 @@ #define MACRONIX_MX25R3235F 0x2816 #define MACRONIX_MX25R6435F 0x2817 - +#define MACRONIX_MX25V1635F 0x2315 #define MACRONIX_MX29F001B 0x19 #define MACRONIX_MX29F001T 0x18 #define MACRONIX_MX29F002B 0x34 /* Same as MX29F002NB; N has reset pin n/c. */ -- To view, visit https://review.coreboot.org/c/flashrom/+/70213 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id688f66ecbbb4ad2ea2f413db90974d917470b32 Gerrit-Change-Number: 70213 Gerrit-PatchSet: 1 Gerrit-Owner: Gabriel Tremblay Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[master]: Reverted typo
by Gabriel Tremblay (Code Review) 01 Dec '22

01 Dec '22

Gabriel Tremblay has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/70212 ) Change subject: Reverted typo ...................................................................... Reverted typo Change-Id: I0b3b31b918776df077cf1d3e3377e35f1cd0c25a --- M flashchips.c 1 file changed, 10 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/12/70212/1 diff --git a/flashchips.c b/flashchips.c index 7a12dec..b3fa85e 100644 --- a/flashchips.c +++ b/flashchips.c @@ -8708,8 +8708,7 @@ } }, .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_BP3_SRWD, /* bit6 is quad enable */ - /*.unlock = SPI_DISABLE_BLOCKPROTECT_BP3_SRWD,*/ - .unlock = SPI_DISABLE_BLOCKPROTECT, + .unlock = SPI_DISABLE_BLOCKPROTECT_BP3_SRWD, .write = SPI_CHIP_WRITE256, .read = SPI_CHIP_READ, /* Fast read (0x0B) and multi I/O supported */ .voltage = {2700, 3600}, -- To view, visit https://review.coreboot.org/c/flashrom/+/70212 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0b3b31b918776df077cf1d3e3377e35f1cd0c25a Gerrit-Change-Number: 70212 Gerrit-PatchSet: 1 Gerrit-Owner: Gabriel Tremblay Gerrit-MessageType: newchange

1 0

[M] Change in flashrom[master]: Added support for Macronix MX25V1635F Tested working on a new chip wi...
by Gabriel Tremblay (Code Review) 01 Dec '22

01 Dec '22

Gabriel Tremblay has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/70211 ) Change subject: Added support for Macronix MX25V1635F Tested working on a new chip with raspberrypi spi. ...................................................................... Abandoned Some side modifications polluted the commit. -- To view, visit https://review.coreboot.org/c/flashrom/+/70211 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I86088b663d6eb26895956c4c8b4ca5a79c619535 Gerrit-Change-Number: 70211 Gerrit-PatchSet: 1 Gerrit-Owner: Gabriel Tremblay Gerrit-MessageType: abandon

1 0

[M] Change in flashrom[master]: Added support for Macronix MX25V1635F Tested working on a new chip wi...
by Gabriel Tremblay (Code Review) 01 Dec '22

01 Dec '22

Gabriel Tremblay has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/70211 ) Change subject: Added support for Macronix MX25V1635F Tested working on a new chip with raspberrypi spi. ...................................................................... Added support for Macronix MX25V1635F Tested working on a new chip with raspberrypi spi. Change-Id: I86088b663d6eb26895956c4c8b4ca5a79c619535 --- M flashchips.c M include/flashchips.h 2 files changed, 51 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/11/70211/1 diff --git a/flashchips.c b/flashchips.c index 6f65389..7a12dec 100644 --- a/flashchips.c +++ b/flashchips.c @@ -8708,7 +8708,8 @@ } }, .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_BP3_SRWD, /* bit6 is quad enable */ - .unlock = SPI_DISABLE_BLOCKPROTECT_BP3_SRWD, + /*.unlock = SPI_DISABLE_BLOCKPROTECT_BP3_SRWD,*/ + .unlock = SPI_DISABLE_BLOCKPROTECT, .write = SPI_CHIP_WRITE256, .read = SPI_CHIP_READ, /* Fast read (0x0B) and multi I/O supported */ .voltage = {2700, 3600}, @@ -9576,6 +9577,44 @@ { .vendor = "Macronix", + .name = "MX25V1635F", + .bustype = BUS_SPI, + .manufacture_id = MACRONIX_ID, + .model_id = MACRONIX_MX25V1635F, + .total_size = 16384, + .page_size = 256, + /* MX25V1635F supports SFDP */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP, + .probe = PROBE_SPI_RDID, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 4096} }, + .block_erase = SPI_BLOCK_ERASE_20, + }, { + .eraseblocks = { {32 * 1024, 512} }, + .block_erase = SPI_BLOCK_ERASE_52, + }, { + .eraseblocks = { {64 * 1024, 256} }, + .block_erase = SPI_BLOCK_ERASE_D8, + }, { + .eraseblocks = { {16 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_60, + }, { + .eraseblocks = { {16 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_C7, + }, + }, + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_BP3_SRWD, + .unlock = SPI_DISABLE_BLOCKPROTECT_BP3_SRWD, + .write = SPI_CHIP_WRITE256, + .read = SPI_CHIP_READ, /* Fast read (0x0B) supported, MX25V1635F supports dual I/O */ + .voltage = {2700, 3600}, /* 2.35-3.6V for MX25V1635F */ + }, + + { + .vendor = "Macronix", .name = "MX25U12835F", .bustype = BUS_SPI, .manufacture_id = MACRONIX_ID, diff --git a/include/flashchips.h b/include/flashchips.h index 5df42dc..42d9b07 100644 --- a/include/flashchips.h +++ b/include/flashchips.h @@ -524,7 +524,7 @@ #define MACRONIX_MX25R3235F 0x2816 #define MACRONIX_MX25R6435F 0x2817 - +#define MACRONIX_MX25V1635F 0x2315 #define MACRONIX_MX29F001B 0x19 #define MACRONIX_MX29F001T 0x18 #define MACRONIX_MX29F002B 0x34 /* Same as MX29F002NB; N has reset pin n/c. */ -- To view, visit https://review.coreboot.org/c/flashrom/+/70211 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I86088b663d6eb26895956c4c8b4ca5a79c619535 Gerrit-Change-Number: 70211 Gerrit-PatchSet: 1 Gerrit-Owner: Gabriel Tremblay Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[master]: meson.build: Rename conf object to config_manfile
by Felix Singer (Code Review) 01 Dec '22

01 Dec '22

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/70209 ) Change subject: meson.build: Rename conf object to config_manfile ...................................................................... meson.build: Rename conf object to config_manfile The config data in the conf object is specific to the man file. Thus, rename it accordingly and also move the declaration to the place where it is used. Change-Id: Icf24b9c47d4c7553f1ec045a9dfd3685b1376445 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M meson.build 1 file changed, 18 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/09/70209/1 diff --git a/meson.build b/meson.build index 14a84ac..859256f 100644 --- a/meson.build +++ b/meson.build @@ -28,8 +28,6 @@ '-Wno-missing-braces', ] -conf = configuration_data() - cc = meson.get_compiler('c') add_project_arguments(cc.get_supported_arguments(warning_flags), language : 'c') add_project_arguments('-D_DEFAULT_SOURCE', language : 'c') @@ -591,12 +589,13 @@ description : 'library to interact with flashrom', ) -conf.set('VERSION', version) -conf.set('MAN_DATE', run_command('util/getversion.sh', '--man-date', check : true).stdout().strip()) +config_manfile = configuration_data() +config_manfile.set('VERSION', version) +config_manfile.set('MAN_DATE', run_command('util/getversion.sh', '--man-date', check : true).stdout().strip()) configure_file( input : 'flashrom.8.tmpl', output : 'flashrom.8', - configuration : conf, + configuration : config_manfile, install: true, install_dir: join_paths(get_option('mandir'), 'man8'), ) -- To view, visit https://review.coreboot.org/c/flashrom/+/70209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Icf24b9c47d4c7553f1ec045a9dfd3685b1376445 Gerrit-Change-Number: 70209 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

[M] Change in flashrom[master]: util/lint: Introduce linter for git sign-off-by line
by Felix Singer (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Edward O'Callaghan. Hello build bot (Jenkins), Edward O'Callaghan, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/70079 to look at the new patch set (#7). Change subject: util/lint: Introduce linter for git sign-off-by line ...................................................................... util/lint: Introduce linter for git sign-off-by line For compliance and to check if the commit message matches the development guidelines, add a linter checking for the sign-off-by line from the commit message. Also, hook it up to the test_build.sh script which is used for CI builds. These scripts were copied from the coreboot repository and were adjusted so that they work for flashrom. Change-Id: I03f1827803f8492d60a0a44174d5822c2265bfcb Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M test_build.sh A util/lint/helper_functions.sh A util/lint/lint-extended-020-signed-off-by 3 files changed, 93 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/79/70079/7 -- To view, visit https://review.coreboot.org/c/flashrom/+/70079 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I03f1827803f8492d60a0a44174d5822c2265bfcb Gerrit-Change-Number: 70079 Gerrit-PatchSet: 7 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[master]: util/lint: Introduce linter for git sign-off-by line
by Felix Singer (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Edward O'Callaghan. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70079 ) Change subject: util/lint: Introduce linter for git sign-off-by line ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/flashrom/+/70079 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I03f1827803f8492d60a0a44174d5822c2265bfcb Gerrit-Change-Number: 70079 Gerrit-PatchSet: 5 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Thu, 01 Dec 2022 12:25:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit December 2022