December 2022 - flashrom-gerrit

[M] Change in flashrom[master]: tree/: Drop default_spi_probe_opcode for NULL case
by Edward O'Callaghan (Code Review) 03 Dec '22

03 Dec '22

Attention is currently required from: Felix Singer, Thomas Heijligen, Peter Marheine. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70264 ) Change subject: tree/: Drop default_spi_probe_opcode for NULL case ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/70264/comment/a0ac6f64_8f05d5fe PS1, Line 9: A NULL func pointer is necessary and sufficient for the > Maybe give a bit more context about what the default function does. Suggestion: […] It is also necessary as well as sufficient. That phrasing is less exact. Patchset: PS1: > I want to get the erase optimizations from Aarya merged as soon as possible. They touch this also. […] Absolutely! -- To view, visit https://review.coreboot.org/c/flashrom/+/70264 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id502c5d2596ad1db52faf05723083620e4c52c12 Gerrit-Change-Number: 70264 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Fri, 02 Dec 2022 23:12:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: cli_classic.c: Factor out rom bus limits exceeded validation
by Edward O'Callaghan (Code Review) 03 Dec '22

03 Dec '22

Attention is currently required from: Felix Singer, Angel Pons. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68661 ) Change subject: cli_classic.c: Factor out rom bus limits exceeded validation ...................................................................... Patch Set 4: (7 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/68661/comment/d2eed255_c4b20004 PS3, Line 9: Cave > nit: `Carve` with an `r`? Done https://review.coreboot.org/c/flashrom/+/68661/comment/0e184d84_5db857ff PS3, Line 11: pairingings > nit: There's an extra `ing` in `pairings` Done https://review.coreboot.org/c/flashrom/+/68661/comment/41f23286_1e8a279d PS3, Line 11: it's > nit: possessive `its` Done Patchset: PS4: > Looks good to me but some issues are open Done. File cli_classic.c: https://review.coreboot.org/c/flashrom/+/68661/comment/926a3e11_efda8b66 PS3, Line 565: exceed > nit: exceed*ed* Done https://review.coreboot.org/c/flashrom/+/68661/comment/fa5896e7_c4a30af3 PS3, Line 565: relevent > nit: relev*a*nt Done https://review.coreboot.org/c/flashrom/+/68661/comment/be7743db_682f6991 PS3, Line 575: (bitcount(commonbuses) > limitexceeded) > nit: drop extra set of parentheses Done -- To view, visit https://review.coreboot.org/c/flashrom/+/68661 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iba1c3c8ab2edc094ede59156ae5e846900fc0777 Gerrit-Change-Number: 68661 Gerrit-PatchSet: 4 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 02 Dec 2022 23:08:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: cli_classic.c: Factor out rom bus limits exceeded validation
by Edward O'Callaghan (Code Review) 03 Dec '22

03 Dec '22

Attention is currently required from: Edward O'Callaghan. Hello Felix Singer, build bot (Jenkins), Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/68661 to look at the new patch set (#5). Change subject: cli_classic.c: Factor out rom bus limits exceeded validation ...................................................................... cli_classic.c: Factor out rom bus limits exceeded validation Carve out relevant logic relating to validating the rom decode limits fit within the common buses with certain flash-programmer pairings into its own function. Move the comment to the top of the new symbol while we are here and rewrite the grammar to be a bit more understandable. Change-Id: Iba1c3c8ab2edc094ede59156ae5e846900fc0777 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M cli_classic.c 1 file changed, 43 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/61/68661/5 -- To view, visit https://review.coreboot.org/c/flashrom/+/68661 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iba1c3c8ab2edc094ede59156ae5e846900fc0777 Gerrit-Change-Number: 68661 Gerrit-PatchSet: 5 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: test_build.sh: build all programmers with meson
by Thomas Heijligen (Code Review) 02 Dec '22

02 Dec '22

Thomas Heijligen has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/67551 ) Change subject: test_build.sh: build all programmers with meson ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/67551 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I43c7abdf07c41746f23200cae03148c152c5fd28 Gerrit-Change-Number: 67551 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[master]: test_build.sh: remove mesons builddir before rebuilding
by Thomas Heijligen (Code Review) 02 Dec '22

02 Dec '22

Thomas Heijligen has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/67550 ) Change subject: test_build.sh: remove mesons builddir before rebuilding ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/67550 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I17de6cbb44ada946280846a387b9ceb9c2c2f566 Gerrit-Change-Number: 67550 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[master]: [DO NOT MERGE] test_buils.sh: force tests
by Thomas Heijligen (Code Review) 02 Dec '22

02 Dec '22

Thomas Heijligen has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/67172 ) Change subject: [DO NOT MERGE] test_buils.sh: force tests ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/67172 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ieeb9edf6e32e7fee0852e8535896ee134eeff59d Gerrit-Change-Number: 67172 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[M] Change in flashrom[master]: tree/: Drop default_spi_probe_opcode for NULL case
by Thomas Heijligen (Code Review) 02 Dec '22

02 Dec '22

Attention is currently required from: Edward O'Callaghan, Peter Marheine. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70264 ) Change subject: tree/: Drop default_spi_probe_opcode for NULL case ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I want to get the erase optimizations from Aarya merged as soon as possible. They touch this also. Can we move this patch behind it? -- To view, visit https://review.coreboot.org/c/flashrom/+/70264 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id502c5d2596ad1db52faf05723083620e4c52c12 Gerrit-Change-Number: 70264 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Fri, 02 Dec 2022 18:35:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashrom.c: Update check_block_eraser function to use probe opcode
by Thomas Heijligen (Code Review) 02 Dec '22

02 Dec '22

Attention is currently required from: Simon Buhrow, Nico Huber, Aarya. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66717 ) Change subject: flashrom.c: Update check_block_eraser function to use probe opcode ...................................................................... Patch Set 18: (1 comment) Patchset: PS3: > In which commit should I add the const.. Insert one before this. Thanks. -- To view, visit https://review.coreboot.org/c/flashrom/+/66717 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6591a84ae1fe5bc1648051cc30b9393450033852 Gerrit-Change-Number: 66717 Gerrit-PatchSet: 18 Gerrit-Owner: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Simon Buhrow Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Comment-Date: Fri, 02 Dec 2022 18:33:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Aarya <aarya.chaumal(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: spi.c: Add AT45 & SF25F erasefn opcode mapping
by Thomas Heijligen (Code Review) 02 Dec '22

02 Dec '22

Attention is currently required from: Simon Buhrow, Aarya. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67717 ) Change subject: spi.c: Add AT45 & SF25F erasefn opcode mapping ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/67717 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I798a91f1e20b63662715c68e6d43d03fc6005d51 Gerrit-Change-Number: 67717 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Attention: Simon Buhrow Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Comment-Date: Fri, 02 Dec 2022 18:30:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: spi25.c: Rename spi_get_erasefn_from_opcode to spi25_get_erasefn_from...
by Thomas Heijligen (Code Review) 02 Dec '22

02 Dec '22

Attention is currently required from: Simon Buhrow, Aarya. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67716 ) Change subject: spi25.c: Rename spi_get_erasefn_from_opcode to spi25_get_erasefn_from_opcode ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/67716 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie054160b0fdd34bcb128285c6a047e3a3fa8be0c Gerrit-Change-Number: 67716 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Simon Buhrow Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Comment-Date: Fri, 02 Dec 2022 18:30:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit December 2022