July 2021 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: Enable probing for IT8620 allowing to use the `dualbiosindex` parameter.
by Felix Singer (Code Review) 04 Jul '21

04 Jul '21

Attention is currently required from: Daniel Maslowski, Sophie van Soest, Paul Menzel. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56055 ) Change subject: Enable probing for IT8620 allowing to use the `dualbiosindex` parameter. ...................................................................... Patch Set 8: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/56055/comment/c5bc28b7_72bcf80c PS4, Line 7: Enable chipset it97spi: 0x8620 Gigabyte-Z97-HD3 > I squashed them into one commit to have a clean patch. […] From this headline one can not relate that you are marking Z97 as OK. That's why I suggested you create a seperate patch for this since it might be hard finding a meaningful headline for both changes. We try to follow the common 50/72 rule for commit messages, 50 characters for headlines and 72 for the body. -- To view, visit https://review.coreboot.org/c/flashrom/+/56055 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0be9effe4a2f1f9699e016c7fc45018c9c522cbc Gerrit-Change-Number: 56055 Gerrit-PatchSet: 8 Gerrit-Owner: Sophie van Soest <sophie(a)entropie.rocks> Gerrit-Reviewer: Daniel Maslowski <info(a)orangecms.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Daniel Maslowski <info(a)orangecms.org> Gerrit-Attention: Sophie van Soest <sophie(a)entropie.rocks> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Sun, 04 Jul 2021 12:25:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Sophie van Soest <sophie(a)entropie.rocks> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Enable probing for IT8620 allowing to use the `dualbiosindex` parameter.
by Sophie van Soest (Code Review) 04 Jul '21

04 Jul '21

Attention is currently required from: Felix Singer, Daniel Maslowski, Paul Menzel. Hello build bot (Jenkins), Daniel Maslowski, Paul Menzel, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/56055 to look at the new patch set (#7). Change subject: Enable probing for IT8620 allowing to use the `dualbiosindex` parameter. ...................................................................... Enable probing for IT8620 allowing to use the `dualbiosindex` parameter. Dumped and verified both firmwares. Tested on GIGABYTE GA-Z97-HD3. Signed-off-by: Sophie van Soest <sophie(a)entropie.rocks> Change-Id: I0be9effe4a2f1f9699e016c7fc45018c9c522cbc --- M chipset_enable.c M it87spi.c 2 files changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/55/56055/7 -- To view, visit https://review.coreboot.org/c/flashrom/+/56055 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0be9effe4a2f1f9699e016c7fc45018c9c522cbc Gerrit-Change-Number: 56055 Gerrit-PatchSet: 7 Gerrit-Owner: Sophie van Soest <sophie(a)entropie.rocks> Gerrit-Reviewer: Daniel Maslowski <info(a)orangecms.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Daniel Maslowski <info(a)orangecms.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Enable probing for IT8620 allowing to use the `dualbiosindex` parameter.
by Sophie van Soest (Code Review) 04 Jul '21

04 Jul '21

Sophie van Soest has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/56061 ) Change subject: Enable probing for IT8620 allowing to use the `dualbiosindex` parameter. ...................................................................... Enable probing for IT8620 allowing to use the `dualbiosindex` parameter. Dumped and verified both firmwares. Tested on GIGABYTE GA-Z97-HD3. Signed-off-by: Sophie van Soest <sophie(a)entropie.rocks> Change-Id: Icfa9d1be79ff1091c138e79a0fe254c6a0e56008 --- M it87spi.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/61/56061/1 diff --git a/it87spi.c b/it87spi.c index cbf830b..8490bdd 100644 --- a/it87spi.c +++ b/it87spi.c @@ -454,6 +454,7 @@ case 0x8705: ret |= it8705f_write_enable(superios[i].port); break; + case 0x8620: case 0x8716: case 0x8718: case 0x8720: -- To view, visit https://review.coreboot.org/c/flashrom/+/56061 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Icfa9d1be79ff1091c138e79a0fe254c6a0e56008 Gerrit-Change-Number: 56061 Gerrit-PatchSet: 1 Gerrit-Owner: Sophie van Soest <sophie(a)entropie.rocks> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: Mark Z97 as OK
by Sophie van Soest (Code Review) 04 Jul '21

04 Jul '21

Sophie van Soest has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/56060 ) Change subject: Mark Z97 as OK ...................................................................... Mark Z97 as OK Change-Id: I73bdd9afefae8e7c013d400e17a15e56d84322f4 --- M chipset_enable.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/60/56060/1 diff --git a/chipset_enable.c b/chipset_enable.c index cdd51ae..2540692 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -1969,7 +1969,7 @@ {0x8086, 0x8cc1, B_FS, NT, "Intel", "9 Series", enable_flash_pch9}, {0x8086, 0x8cc2, B_FS, NT, "Intel", "9 Series Engineering Sample", enable_flash_pch9}, {0x8086, 0x8cc3, B_FS, NT, "Intel", "9 Series", enable_flash_pch9}, - {0x8086, 0x8cc4, B_FS, NT, "Intel", "Z97", enable_flash_pch9}, + {0x8086, 0x8cc4, B_FS, OK, "Intel", "Z97", enable_flash_pch9}, {0x8086, 0x8cc6, B_FS, NT, "Intel", "H97", enable_flash_pch9}, {0x8086, 0x8d40, B_FS, NT, "Intel", "C610/X99 (Wellsburg)", enable_flash_pch8_wb}, {0x8086, 0x8d41, B_FS, NT, "Intel", "C610/X99 (Wellsburg)", enable_flash_pch8_wb}, -- To view, visit https://review.coreboot.org/c/flashrom/+/56060 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I73bdd9afefae8e7c013d400e17a15e56d84322f4 Gerrit-Change-Number: 56060 Gerrit-PatchSet: 1 Gerrit-Owner: Sophie van Soest <sophie(a)entropie.rocks> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: Enable probing for IT8620 allowing to use the `dualbiosindex` parameter.
by Sophie van Soest (Code Review) 04 Jul '21

04 Jul '21

Attention is currently required from: Felix Singer, Daniel Maslowski, Paul Menzel. Sophie van Soest has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56055 ) Change subject: Enable probing for IT8620 allowing to use the `dualbiosindex` parameter. ...................................................................... Patch Set 6: (5 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/56055/comment/34452638_32274c4e PS1, Line 7: Enabled > Enable Done https://review.coreboot.org/c/flashrom/+/56055/comment/b2b4abe6_ff2551fd PS1, Line 9: Added missing address: 0x8620 for the it97 to use the parameter dualbootbios. : Marked Z97 as OK. : : Dumped and verified both bios. > Nit: I’d use present tense. Done Commit Message: https://review.coreboot.org/c/flashrom/+/56055/comment/579b0f9b_f53b5073 PS4, Line 7: Enable chipset it97spi: 0x8620 Gigabyte-Z97-HD3 > I find the summary a little bit irritating. […] I squashed them into one commit to have a clean patch. I see there no benefit to split the commits up again. https://review.coreboot.org/c/flashrom/+/56055/comment/0b5f7f9a_48b9f017 PS4, Line 9: Add missing address: 0x8620 for the it97 to use the parameter dualbootbios. : Mark Z97 as OK. > It's not an address, but the ID number of the controller. […] Done https://review.coreboot.org/c/flashrom/+/56055/comment/62da7d70_5eb84769 PS4, Line 12: Dumped and verified both bios. > Dumped and verified both firmwares. Tested on GIGABYTE Z97-HD3. Done -- To view, visit https://review.coreboot.org/c/flashrom/+/56055 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0be9effe4a2f1f9699e016c7fc45018c9c522cbc Gerrit-Change-Number: 56055 Gerrit-PatchSet: 6 Gerrit-Owner: Sophie van Soest <sophie(a)entropie.rocks> Gerrit-Reviewer: Daniel Maslowski <info(a)orangecms.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Daniel Maslowski <info(a)orangecms.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Sun, 04 Jul 2021 11:37:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Enable probing for IT8620 allowing to use the `dualbiosindex` parameter.
by Sophie van Soest (Code Review) 04 Jul '21

04 Jul '21

Attention is currently required from: Sophie van Soest, Paul Menzel. Hello build bot (Jenkins), Daniel Maslowski, Paul Menzel, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/56055 to look at the new patch set (#6). Change subject: Enable probing for IT8620 allowing to use the `dualbiosindex` parameter. ...................................................................... Enable probing for IT8620 allowing to use the `dualbiosindex` parameter. * Enable probing of IT8620. * Mark Z97 as OK. Dumped and verified both firmwares. Tested on GIGABYTE GA-Z97-HD3. Signed-off-by: Sophie van Soest <sophie(a)entropie.rocks> Change-Id: I0be9effe4a2f1f9699e016c7fc45018c9c522cbc --- M chipset_enable.c M it87spi.c 2 files changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/55/56055/6 -- To view, visit https://review.coreboot.org/c/flashrom/+/56055 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0be9effe4a2f1f9699e016c7fc45018c9c522cbc Gerrit-Change-Number: 56055 Gerrit-PatchSet: 6 Gerrit-Owner: Sophie van Soest <sophie(a)entropie.rocks> Gerrit-Reviewer: Daniel Maslowski <info(a)orangecms.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Sophie van Soest <sophie(a)entropie.rocks> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Enable probing for IT8620 allowing to use the `dualbiosindex` parameter.
by Sophie van Soest (Code Review) 04 Jul '21

04 Jul '21

Attention is currently required from: Sophie van Soest, Paul Menzel. Hello build bot (Jenkins), Daniel Maslowski, Paul Menzel, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/56055 to look at the new patch set (#5). Change subject: Enable probing for IT8620 allowing to use the `dualbiosindex` parameter. ...................................................................... Enable probing for IT8620 allowing to use the `dualbiosindex` parameter. Enable probing of IT8620 Mark Z97 as OK Dumped and verified both firmwares. Tested on GIGABYTE GA-Z97-HD3. Signed-off-by: Sophie van Soest <sophie(a)entropie.rocks> Change-Id: I0be9effe4a2f1f9699e016c7fc45018c9c522cbc --- M chipset_enable.c M it87spi.c 2 files changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/55/56055/5 -- To view, visit https://review.coreboot.org/c/flashrom/+/56055 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0be9effe4a2f1f9699e016c7fc45018c9c522cbc Gerrit-Change-Number: 56055 Gerrit-PatchSet: 5 Gerrit-Owner: Sophie van Soest <sophie(a)entropie.rocks> Gerrit-Reviewer: Daniel Maslowski <info(a)orangecms.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Sophie van Soest <sophie(a)entropie.rocks> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Enable chipset it97spi: 0x8620 Gigabyte-Z97-HD3
by Felix Singer (Code Review) 04 Jul '21

04 Jul '21

Attention is currently required from: Sophie van Soest, Paul Menzel. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56055 ) Change subject: Enable chipset it97spi: 0x8620 Gigabyte-Z97-HD3 ...................................................................... Patch Set 4: (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/56055/comment/9ae8e60a_5fab64ff PS4, Line 7: Enable chipset it97spi: 0x8620 Gigabyte-Z97-HD3 I find the summary a little bit irritating. Also, I think these changes aren't related to each other, so I would split this patch up into two. This way it's also easier to write a meaningful commit summary :) For this one: it87spi.c: Enable probing of IT8620 For the Z97 change: chipset_enable.c: Mark Z97 as OK https://review.coreboot.org/c/flashrom/+/56055/comment/f76f3efc_ba1f652b PS4, Line 9: Add missing address: 0x8620 for the it97 to use the parameter dualbootbios. : Mark Z97 as OK. It's not an address, but the ID number of the controller. I suggest: Enable probing for IT8620 allowing to use the `dualbiosindex` parameter. https://review.coreboot.org/c/flashrom/+/56055/comment/0cdefc4c_259e06ec PS4, Line 12: Dumped and verified both bios. Dumped and verified both firmwares. Tested on GIGABYTE Z97-HD3. -- To view, visit https://review.coreboot.org/c/flashrom/+/56055 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0be9effe4a2f1f9699e016c7fc45018c9c522cbc Gerrit-Change-Number: 56055 Gerrit-PatchSet: 4 Gerrit-Owner: Sophie van Soest <sophie(a)entropie.rocks> Gerrit-Reviewer: Daniel Maslowski <info(a)orangecms.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Sophie van Soest <sophie(a)entropie.rocks> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Sun, 04 Jul 2021 01:35:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Enable chipset it97spi: 0x8620 Gigabyte-Z97-HD3
by Daniel Maslowski (Code Review) 03 Jul '21

03 Jul '21

Attention is currently required from: Sophie van Soest, Paul Menzel. Daniel Maslowski has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56055 ) Change subject: Enable chipset it97spi: 0x8620 Gigabyte-Z97-HD3 ...................................................................... Patch Set 4: (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/56055/comment/7f1ac38d_4397b95f PS1, Line 7: Enabled > Enable Done https://review.coreboot.org/c/flashrom/+/56055/comment/69130c9d_7f3e7515 PS1, Line 9: Added missing address: 0x8620 for the it97 to use the parameter dualbootbios. : Marked Z97 as OK. : : Dumped and verified both bios. > Nit: I’d use present tense. Done Patchset: PS4: all good now :) -- To view, visit https://review.coreboot.org/c/flashrom/+/56055 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0be9effe4a2f1f9699e016c7fc45018c9c522cbc Gerrit-Change-Number: 56055 Gerrit-PatchSet: 4 Gerrit-Owner: Sophie van Soest <sophie(a)entropie.rocks> Gerrit-Reviewer: Daniel Maslowski <info(a)orangecms.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sophie van Soest <sophie(a)entropie.rocks> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Sat, 03 Jul 2021 21:31:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Enable chipset it97spi: 0x8620 Gigabyte-Z97-HD3
by Sophie van Soest (Code Review) 03 Jul '21

03 Jul '21

Attention is currently required from: Sophie van Soest. Hello build bot (Jenkins), Daniel Maslowski, Paul Menzel, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/56055 to look at the new patch set (#4). Change subject: Enable chipset it97spi: 0x8620 Gigabyte-Z97-HD3 ...................................................................... Enable chipset it97spi: 0x8620 Gigabyte-Z97-HD3 Add missing address: 0x8620 for the it97 to use the parameter dualbootbios. Mark Z97 as OK. Dumped and verified both bios. Signed-off-by: Sophie van Soest <sophie(a)entropie.rocks> Change-Id: I0be9effe4a2f1f9699e016c7fc45018c9c522cbc --- M chipset_enable.c M it87spi.c 2 files changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/55/56055/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/56055 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0be9effe4a2f1f9699e016c7fc45018c9c522cbc Gerrit-Change-Number: 56055 Gerrit-PatchSet: 4 Gerrit-Owner: Sophie van Soest <sophie(a)entropie.rocks> Gerrit-Reviewer: Daniel Maslowski <info(a)orangecms.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sophie van Soest <sophie(a)entropie.rocks> Gerrit-MessageType: newpatchset

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit July 2021