Attention is currently required from: Nico Huber, Thomas Heijligen, Angel Pons, Anastasia Klimchuk.
Hello build bot (Jenkins), Nico Huber, Thomas Heijligen, Edward O'Callaghan, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/55932
to look at the new patch set (#3).
Change subject: spi_master: Add shutdown function in spi_master struct
......................................................................
spi_master: Add shutdown function in spi_master struct
With this, register_spi_master can take care of register_shutdown
as well, and every spi master only needs to call register_spi_master
instead of calling both register_spi_master and register_shutdown.
Testing:
In dummyflasher, comment out free(data) in shutdown. Test fails with error:
../dummyflasher.c:949: note: block 0x55e0727a6e40 allocated here
ERROR: dummy_init_and_shutdown_test_success leaked 1 block(s)
Means, shutdown function is invoked for drivers with "old" API
(so, transitioning from old to new API is not breaking anything).
Next patch in the chain converts spi masters to use new API.
BUG=b:185191942
TEST=builds and ninja test
Change-Id: I2dc80dceca2f8204bcd0dad1f51753d7e79f1af5
Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org>
---
M programmer.h
M spi.c
2 files changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/32/55932/3
--
To view, visit https://review.coreboot.org/c/flashrom/+/55932
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2dc80dceca2f8204bcd0dad1f51753d7e79f1af5
Gerrit-Change-Number: 55932
Gerrit-PatchSet: 3
Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Sophie van Soest, Michael Niewöhner.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56060 )
Change subject: chipset_enable.c: Mark Z97 as OK
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/56060/comment/7a4bec9f_e76af6eb
PS2, Line 12:
> missing Sign-off
Done
--
To view, visit https://review.coreboot.org/c/flashrom/+/56060
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I73bdd9afefae8e7c013d400e17a15e56d84322f4
Gerrit-Change-Number: 56060
Gerrit-PatchSet: 3
Gerrit-Owner: Sophie van Soest <sophie(a)entropie.rocks>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Sophie van Soest <sophie(a)entropie.rocks>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Comment-Date: Sun, 04 Jul 2021 18:13:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-MessageType: comment
Attention is currently required from: Sophie van Soest.
Hello Felix Singer, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/56060
to look at the new patch set (#3).
Change subject: chipset_enable.c: Mark Z97 as OK
......................................................................
chipset_enable.c: Mark Z97 as OK
Tested on GIGABYTE GA-Z97-HD3.
Signed-off-by: Sophie van Soest <sophie(a)entropie.rocks>
Change-Id: I73bdd9afefae8e7c013d400e17a15e56d84322f4
---
M chipset_enable.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/60/56060/3
--
To view, visit https://review.coreboot.org/c/flashrom/+/56060
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I73bdd9afefae8e7c013d400e17a15e56d84322f4
Gerrit-Change-Number: 56060
Gerrit-PatchSet: 3
Gerrit-Owner: Sophie van Soest <sophie(a)entropie.rocks>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Attention: Sophie van Soest <sophie(a)entropie.rocks>
Gerrit-MessageType: newpatchset
Attention is currently required from: Sophie van Soest.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56060 )
Change subject: chipset_enable.c: Mark Z97 as OK
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/56060/comment/cd69c7aa_71df6d8a
PS2, Line 12:
missing Sign-off
--
To view, visit https://review.coreboot.org/c/flashrom/+/56060
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I73bdd9afefae8e7c013d400e17a15e56d84322f4
Gerrit-Change-Number: 56060
Gerrit-PatchSet: 2
Gerrit-Owner: Sophie van Soest <sophie(a)entropie.rocks>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Attention: Sophie van Soest <sophie(a)entropie.rocks>
Gerrit-Comment-Date: Sun, 04 Jul 2021 14:24:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Daniel Maslowski, Sophie van Soest, Paul Menzel, Michael Niewöhner.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56055 )
Change subject: it87spi.c: Enable probing of IT8620
......................................................................
Patch Set 10:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/56055/comment/683644ee_f9cfcfa4
PS4, Line 7: Enable chipset it97spi: 0x8620 Gigabyte-Z97-HD3
> Simple rule: if the changes can stand on their own, split them
Done
--
To view, visit https://review.coreboot.org/c/flashrom/+/56055
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I0be9effe4a2f1f9699e016c7fc45018c9c522cbc
Gerrit-Change-Number: 56055
Gerrit-PatchSet: 10
Gerrit-Owner: Sophie van Soest <sophie(a)entropie.rocks>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Daniel Maslowski <info(a)orangecms.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Attention: Daniel Maslowski <info(a)orangecms.org>
Gerrit-Attention: Sophie van Soest <sophie(a)entropie.rocks>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Comment-Date: Sun, 04 Jul 2021 13:21:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Comment-In-Reply-To: Sophie van Soest <sophie(a)entropie.rocks>
Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-MessageType: comment