Attention is currently required from: Sophie van Soest.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56060 )
Change subject: chipset_enable.c: Mark Z97 as OK
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/56060/comment/8d89647a_92d54399
PS1, Line 7: Mark Z97 as OK
> Add `chipset_enable:` before that
Done
Patchset:
PS2:
Looks good to me :)
--
To view, visit https://review.coreboot.org/c/flashrom/+/56060
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I73bdd9afefae8e7c013d400e17a15e56d84322f4
Gerrit-Change-Number: 56060
Gerrit-PatchSet: 2
Gerrit-Owner: Sophie van Soest <sophie(a)entropie.rocks>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Sophie van Soest <sophie(a)entropie.rocks>
Gerrit-Comment-Date: Sun, 04 Jul 2021 13:20:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Gerrit-MessageType: comment
Attention is currently required from: Sophie van Soest.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/56060
to look at the new patch set (#2).
Change subject: chipset_enable.c: Mark Z97 as OK
......................................................................
chipset_enable.c: Mark Z97 as OK
Tested on GIGABYTE GA-Z97-HD3.
Change-Id: I73bdd9afefae8e7c013d400e17a15e56d84322f4
---
M chipset_enable.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/60/56060/2
--
To view, visit https://review.coreboot.org/c/flashrom/+/56060
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I73bdd9afefae8e7c013d400e17a15e56d84322f4
Gerrit-Change-Number: 56060
Gerrit-PatchSet: 2
Gerrit-Owner: Sophie van Soest <sophie(a)entropie.rocks>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Sophie van Soest <sophie(a)entropie.rocks>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Singer, Daniel Maslowski, Sophie van Soest, Paul Menzel.
Hello build bot (Jenkins), Daniel Maslowski, Paul Menzel,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/56055
to look at the new patch set (#10).
Change subject: it87spi.c: Enable probing of IT8620
......................................................................
it87spi.c: Enable probing of IT8620
Enable probing for IT8620 allowing to use the `dualbiosindex` parameter.
Dumped and verified both firmwares. Tested on GIGABYTE GA-Z97-HD3.
Signed-off-by: Sophie van Soest <sophie(a)entropie.rocks>
Change-Id: I0be9effe4a2f1f9699e016c7fc45018c9c522cbc
---
M it87spi.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/55/56055/10
--
To view, visit https://review.coreboot.org/c/flashrom/+/56055
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I0be9effe4a2f1f9699e016c7fc45018c9c522cbc
Gerrit-Change-Number: 56055
Gerrit-PatchSet: 10
Gerrit-Owner: Sophie van Soest <sophie(a)entropie.rocks>
Gerrit-Reviewer: Daniel Maslowski <info(a)orangecms.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Daniel Maslowski <info(a)orangecms.org>
Gerrit-Attention: Sophie van Soest <sophie(a)entropie.rocks>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Singer, Daniel Maslowski, Sophie van Soest, Paul Menzel.
Hello build bot (Jenkins), Daniel Maslowski, Paul Menzel,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/56055
to look at the new patch set (#9).
Change subject: it87spi.c: Enable probing of IT8620
......................................................................
it87spi.c: Enable probing of IT8620
Enable probing for IT8620 allowing to use the `dualbiosindex` parameter.
Dumped and verified both firmwares. Tested on GIGABYTE GA-Z97-HD3.
Signed-off-by: Sophie van Soest <sophie(a)entropie.rocks>
Change-Id: I0be9effe4a2f1f9699e016c7fc45018c9c522cbc
---
M it87spi.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/55/56055/9
--
To view, visit https://review.coreboot.org/c/flashrom/+/56055
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I0be9effe4a2f1f9699e016c7fc45018c9c522cbc
Gerrit-Change-Number: 56055
Gerrit-PatchSet: 9
Gerrit-Owner: Sophie van Soest <sophie(a)entropie.rocks>
Gerrit-Reviewer: Daniel Maslowski <info(a)orangecms.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Daniel Maslowski <info(a)orangecms.org>
Gerrit-Attention: Sophie van Soest <sophie(a)entropie.rocks>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Singer, Daniel Maslowski, Sophie van Soest, Paul Menzel.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56055 )
Change subject: Enable probing for IT8620 allowing to use the `dualbiosindex` parameter.
......................................................................
Patch Set 8:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/56055/comment/3ba2193a_639ad323
PS4, Line 7: Enable chipset it97spi: 0x8620 Gigabyte-Z97-HD3
> From this headline one can not relate that you are marking Z97 as OK. […]
Simple rule: if the changes can stand on their own, split them
--
To view, visit https://review.coreboot.org/c/flashrom/+/56055
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I0be9effe4a2f1f9699e016c7fc45018c9c522cbc
Gerrit-Change-Number: 56055
Gerrit-PatchSet: 8
Gerrit-Owner: Sophie van Soest <sophie(a)entropie.rocks>
Gerrit-Reviewer: Daniel Maslowski <info(a)orangecms.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Daniel Maslowski <info(a)orangecms.org>
Gerrit-Attention: Sophie van Soest <sophie(a)entropie.rocks>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Sun, 04 Jul 2021 12:27:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Comment-In-Reply-To: Sophie van Soest <sophie(a)entropie.rocks>
Gerrit-MessageType: comment
Attention is currently required from: Sophie van Soest.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56060 )
Change subject: Mark Z97 as OK
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/56060/comment/290a44ec_ae587bda
PS1, Line 7: Mark Z97 as OK
Add `chipset_enable:` before that
--
To view, visit https://review.coreboot.org/c/flashrom/+/56060
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I73bdd9afefae8e7c013d400e17a15e56d84322f4
Gerrit-Change-Number: 56060
Gerrit-PatchSet: 1
Gerrit-Owner: Sophie van Soest <sophie(a)entropie.rocks>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Sophie van Soest <sophie(a)entropie.rocks>
Gerrit-Comment-Date: Sun, 04 Jul 2021 12:27:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Daniel Maslowski, Sophie van Soest, Paul Menzel.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56055 )
Change subject: Enable probing for IT8620 allowing to use the `dualbiosindex` parameter.
......................................................................
Patch Set 8:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/56055/comment/c5bc28b7_72bcf80c
PS4, Line 7: Enable chipset it97spi: 0x8620 Gigabyte-Z97-HD3
> I squashed them into one commit to have a clean patch. […]
From this headline one can not relate that you are marking Z97 as OK. That's why I suggested you create a seperate patch for this since it might be hard finding a meaningful headline for both changes. We try to follow the common 50/72 rule for commit messages, 50 characters for headlines and 72 for the body.
--
To view, visit https://review.coreboot.org/c/flashrom/+/56055
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I0be9effe4a2f1f9699e016c7fc45018c9c522cbc
Gerrit-Change-Number: 56055
Gerrit-PatchSet: 8
Gerrit-Owner: Sophie van Soest <sophie(a)entropie.rocks>
Gerrit-Reviewer: Daniel Maslowski <info(a)orangecms.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Daniel Maslowski <info(a)orangecms.org>
Gerrit-Attention: Sophie van Soest <sophie(a)entropie.rocks>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Sun, 04 Jul 2021 12:25:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Comment-In-Reply-To: Sophie van Soest <sophie(a)entropie.rocks>
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Daniel Maslowski, Paul Menzel.
Hello build bot (Jenkins), Daniel Maslowski, Paul Menzel,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/56055
to look at the new patch set (#7).
Change subject: Enable probing for IT8620 allowing to use the `dualbiosindex` parameter.
......................................................................
Enable probing for IT8620 allowing to use the `dualbiosindex` parameter.
Dumped and verified both firmwares. Tested on GIGABYTE GA-Z97-HD3.
Signed-off-by: Sophie van Soest <sophie(a)entropie.rocks>
Change-Id: I0be9effe4a2f1f9699e016c7fc45018c9c522cbc
---
M chipset_enable.c
M it87spi.c
2 files changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/55/56055/7
--
To view, visit https://review.coreboot.org/c/flashrom/+/56055
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I0be9effe4a2f1f9699e016c7fc45018c9c522cbc
Gerrit-Change-Number: 56055
Gerrit-PatchSet: 7
Gerrit-Owner: Sophie van Soest <sophie(a)entropie.rocks>
Gerrit-Reviewer: Daniel Maslowski <info(a)orangecms.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Daniel Maslowski <info(a)orangecms.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: newpatchset
Sophie van Soest has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/56061 )
Change subject: Enable probing for IT8620 allowing to use the `dualbiosindex` parameter.
......................................................................
Enable probing for IT8620 allowing to use the `dualbiosindex` parameter.
Dumped and verified both firmwares. Tested on GIGABYTE GA-Z97-HD3.
Signed-off-by: Sophie van Soest <sophie(a)entropie.rocks>
Change-Id: Icfa9d1be79ff1091c138e79a0fe254c6a0e56008
---
M it87spi.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/61/56061/1
diff --git a/it87spi.c b/it87spi.c
index cbf830b..8490bdd 100644
--- a/it87spi.c
+++ b/it87spi.c
@@ -454,6 +454,7 @@
case 0x8705:
ret |= it8705f_write_enable(superios[i].port);
break;
+ case 0x8620:
case 0x8716:
case 0x8718:
case 0x8720:
--
To view, visit https://review.coreboot.org/c/flashrom/+/56061
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Icfa9d1be79ff1091c138e79a0fe254c6a0e56008
Gerrit-Change-Number: 56061
Gerrit-PatchSet: 1
Gerrit-Owner: Sophie van Soest <sophie(a)entropie.rocks>
Gerrit-MessageType: newchange