Attention is currently required from: Angel Pons.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56031 )
Change subject: Replace freenode references
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
I'm not sure if we want to scrap the mailing list reference too?
If https://flashrom.org/ doesn't change, neither should the email
address.
Thoughts?
File flashrom.8.tmpl:
https://review.coreboot.org/c/flashrom/+/56031/comment/3e8a66d4_fa63f56f
PS1, Line 1457: Please report any bugs using one of the contact methods at
How about
You can report bugs, ask us questions or send success reports via our communication channels listed here:
--
To view, visit https://review.coreboot.org/c/flashrom/+/56031
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I75e8f43c50dc4c3feede0250334a877cdaac8103
Gerrit-Change-Number: 56031
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-CC: Idwer Vollering <vidwer(a)gmail.com>
Gerrit-CC: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Fri, 02 Jul 2021 10:57:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/56031 )
Change subject: Replace freenode references
......................................................................
Replace freenode references
The flashrom project no longer uses freenode. To avoid having outdated
man pages in the future, the contact methods are now listed in the wiki.
Change-Id: I75e8f43c50dc4c3feede0250334a877cdaac8103
Signed-off-by: Angel Pons <th3fanbus(a)gmail.com>
---
M README
M flashrom.8.tmpl
M flashrom.c
3 files changed, 11 insertions(+), 30 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/31/56031/1
diff --git a/README b/README
index 4e7bd4f..71e8735 100644
--- a/README
+++ b/README
@@ -183,10 +183,6 @@
http://www.flashrom.org/
-The IRC channel is
+Available contact methods are
- #flashrom at irc.freenode.net
-
-The mailing list address is
-
- flashrom(a)flashrom.org
+ https://www.flashrom.org/Contact
diff --git a/flashrom.8.tmpl b/flashrom.8.tmpl
index 228e17b..3dd9a45 100644
--- a/flashrom.8.tmpl
+++ b/flashrom.8.tmpl
@@ -1454,24 +1454,12 @@
.B "/etc/rc.securelevel"
and rebooting, or rebooting into single user mode.
.SH BUGS
-Please report any bugs to the
-.MTOB "flashrom(a)flashrom.org" "flashrom mailing list" .
+Please report any bugs using one of the contact methods at
+.URLB "https://www.flashrom.org/Contact" "" .
.sp
-We recommend to subscribe first at
-.URLB "https://flashrom.org/mailman/listinfo/flashrom" "" .
-.sp
-Many of the developers communicate via the
-.B "#flashrom"
-IRC channel on
-.BR chat.freenode.net .
-If you don't have an IRC client, you can use the
-.URLB http://webchat.freenode.net/?channels=flashrom "freenode webchat" .
-You are welcome to join and ask questions, send us bug and success reports there
-too. Please provide a way to contact you later (e.g.\& a mail address) and be
-patient if there is no immediate reaction. Also, we provide a
+Also, we provide a
.URLB https://paste.flashrom.org "pastebin service"
-that is very useful when you want to share logs etc.\& without spamming the
-channel.
+that is very useful to share logs without spamming the communication channels.
.SS
.B Laptops
.sp
diff --git a/flashrom.c b/flashrom.c
index 6cc899f..a6f0b8b 100644
--- a/flashrom.c
+++ b/flashrom.c
@@ -1546,16 +1546,14 @@
#if CONFIG_INTERNAL == 1
if (programmer == &programmer_internal)
msg_gerr("This means we have to add special support for your board, programmer or flash\n"
- "chip. Please report this on IRC at chat.freenode.net (channel #flashrom) or\n"
- "mail flashrom(a)flashrom.org, thanks!\n"
+ "chip. Please report this (see https://www.flashrom.org/Contact for details), thanks!\n"
"-------------------------------------------------------------------------------\n"
"You may now reboot or simply leave the machine running.\n");
else
#endif
msg_gerr("Please check the connections (especially those to write protection pins) between\n"
"the programmer and the flash chip. If you think the error is caused by flashrom\n"
- "please report this on IRC at chat.freenode.net (channel #flashrom) or\n"
- "mail flashrom(a)flashrom.org, thanks!\n");
+ "please report this (see https://www.flashrom.org/Contact for details), thanks!\n");
}
static void emergency_help_message(void)
@@ -1563,14 +1561,13 @@
msg_gerr("Your flash chip is in an unknown state.\n");
#if CONFIG_INTERNAL == 1
if (programmer == &programmer_internal)
- msg_gerr("Get help on IRC at chat.freenode.net (channel #flashrom) or\n"
- "mail flashrom(a)flashrom.org with the subject \"FAILED: <your board name>\"!\n"
+ msg_gerr("Refer to https://www.flashrom.org/Contact on how to get help. Please specify\n"
+ "your board name when asking for help!\n"
"-------------------------------------------------------------------------------\n"
"DO NOT REBOOT OR POWEROFF!\n");
else
#endif
- msg_gerr("Please report this on IRC at chat.freenode.net (channel #flashrom) or\n"
- "mail flashrom(a)flashrom.org, thanks!\n");
+ msg_gerr("Please report this (see https://www.flashrom.org/Contact for details), thanks!\n");
}
void list_programmers_linebreak(int startcol, int cols, int paren)
--
To view, visit https://review.coreboot.org/c/flashrom/+/56031
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I75e8f43c50dc4c3feede0250334a877cdaac8103
Gerrit-Change-Number: 56031
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: newchange
Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/56030 )
Change subject: print_wiki.c: Update mailing list reference
......................................................................
print_wiki.c: Update mailing list reference
Change-Id: I5c67b5b3be2f306132d8565539bbf10477222026
Signed-off-by: Angel Pons <th3fanbus(a)gmail.com>
---
M print_wiki.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/30/56030/1
diff --git a/print_wiki.c b/print_wiki.c
index 9af2e3e..2c8c109 100644
--- a/print_wiki.c
+++ b/print_wiki.c
@@ -80,7 +80,7 @@
or may not be added later.\n\n\
Mainboards (or individual revisions) which don't appear in the list may or may \
not work (we don't know, someone has to give it a try). Please report any \
-further verified mainboards on the [[Mailinglist|mailing list]].\n";
+further verified mainboards on the [[Contact#Mailing_List|mailing list]].\n";
#endif
static const char chip_th[] = "\
--
To view, visit https://review.coreboot.org/c/flashrom/+/56030
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5c67b5b3be2f306132d8565539bbf10477222026
Gerrit-Change-Number: 56030
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: newchange
Attention is currently required from: Nico Huber, Michał Żygowski.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56023 )
Change subject: board_enable.c: Add ME unlock function for TUXEDO laptops
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/56023/comment/aade2173_d0bfded7
PS1, Line 7: board_enable.c: Add ME unlock function for TUXEDO laptops
I'd appreciate if you could explain in the commit message what this "ME unlock" is about. Also missing is information on how to undo this unlocking (the code only implements unlocking).
Wild guess after a very quick glance: this code tells the EC to assert the HDA_SDO strap using a GPIO.
File board_enable.c:
https://review.coreboot.org/c/flashrom/+/56023/comment/0a6a6720_b9534deb
PS1, Line 2315: if (!arg && strcmp(arg, "yes"))
: return 0;
Hmmm, this check will call `strcmp()` only when `arg` is NULL. I don't think undefined behavior is what you wanted to do? 😄
If you want to bail out unless the param exists and equals `yes`, I would do:
char *arg = extract_programmer_param("unlockmeonly");
const bool proceed = arg && strcmp(arg, "yes") == 0;
free(arg);
if (!proceed)
return 0;
Note that `free()` is unconditionally called, even when `arg` is NULL. This is a non-issue because the C standard explicitly states the following about the `free()` function:
> If ptr is a null pointer, no action occurs.
--
To view, visit https://review.coreboot.org/c/flashrom/+/56023
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6bf1c40900aa674e3ea4f6add12dae8b73759fbb
Gerrit-Change-Number: 56023
Gerrit-PatchSet: 1
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Comment-Date: Fri, 02 Jul 2021 09:45:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment