October 2021 - flashrom-gerrit

Change in flashrom[master]: flashchips.c: big erase blocksize first
by Simon Buhrow (Code Review) 29 Oct '21

29 Oct '21

Attention is currently required from: Simon Buhrow, Nico Huber, Angel Pons. Hello build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58467 to look at the new patch set (#4). Change subject: flashchips.c: big erase blocksize first ...................................................................... flashchips.c: big erase blocksize first Choosing the best fitting erase block size can safe a significant amount of runtime. Changing the order of entries of block_erasers in flashchips.c going from the bigger block size to lower block size does a better job. I am running flashrom inside a VirtualBox so the gained time is quite big. Setup: IS25LP064 flash + ft2232H programmer Saved time: > 2 min for single '-E' operation Change-Id: I862ce0b5f8912565e43c340578d8126aa2e6aa3b Signed-off-by: Simon Buhrow <simon.buhrow(a)posteo.de> --- M flashrom.c 1 file changed, 67 insertions(+), 20 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/67/58467/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/58467 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I862ce0b5f8912565e43c340578d8126aa2e6aa3b Gerrit-Change-Number: 58467 Gerrit-PatchSet: 4 Gerrit-Owner: Simon Buhrow Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Simon Buhrow Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: flashchips.c: big erase blocksize first
by Simon Buhrow (Code Review) 29 Oct '21

29 Oct '21

Attention is currently required from: Simon Buhrow, Nico Huber, Angel Pons. Hello build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58467 to look at the new patch set (#3). Change subject: flashchips.c: big erase blocksize first ...................................................................... flashchips.c: big erase blocksize first Choosing the best fitting erase block size can safe a significant amount of runtime. Changing the order of entries of block_erasers in flashchips.c going from the bigger block size to lower block size does a better job. I am running flashrom inside a VirtualBox so the gained time is quite big. Setup: IS25LP064 flash + ft2232H programmer Saved time: > 2 min for single '-E' operation Change-Id: I862ce0b5f8912565e43c340578d8126aa2e6aa3b Signed-off-by: Simon Buhrow <simon.buhrow(a)posteo.de> --- M flashchips.c M flashrom.c 2 files changed, 68 insertions(+), 21 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/67/58467/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/58467 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I862ce0b5f8912565e43c340578d8126aa2e6aa3b Gerrit-Change-Number: 58467 Gerrit-PatchSet: 3 Gerrit-Owner: Simon Buhrow Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Simon Buhrow Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: flashchips.c: big erase blocksize first
by Simon Buhrow (Code Review) 29 Oct '21

29 Oct '21

Attention is currently required from: Nico Huber, Angel Pons. Hello build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58467 to look at the new patch set (#2). Change subject: flashchips.c: big erase blocksize first ...................................................................... flashchips.c: big erase blocksize first Choosing the best fitting erase block size can safe a significant amount of runtime. Changing the order of entries of block_erasers in flashchips.c going from the bigger block size to lower block size does a better job. I am running flashrom inside a VirtualBox so the gained time is quite big. Setup: IS25LP064 flash + ft2232H programmer Saved time: > 2 min for single '-E' operation Change-Id: I862ce0b5f8912565e43c340578d8126aa2e6aa3b Signed-off-by: Simon Buhrow <simon.buhrow(a)posteo.de> --- M flashchips.c M flashrom.c 2 files changed, 70 insertions(+), 23 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/67/58467/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/58467 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I862ce0b5f8912565e43c340578d8126aa2e6aa3b Gerrit-Change-Number: 58467 Gerrit-PatchSet: 2 Gerrit-Owner: Simon Buhrow Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: flashrom.c: Delete obsolete comment
by Simon Buhrow (Code Review) 29 Oct '21

29 Oct '21

Simon Buhrow has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/58742 ) Change subject: flashrom.c: Delete obsolete comment ...................................................................... flashrom.c: Delete obsolete comment Change-Id: Ibd53fe34c05f87d7ecc0d6eee6463f9da3a174d4 Signed-off-by: Simon Buhrow <simon.buhrow(a)posteo.de> --- M flashrom.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/42/58742/1 diff --git a/flashrom.c b/flashrom.c index 3987bb9..48d953b 100644 --- a/flashrom.c +++ b/flashrom.c @@ -1377,7 +1377,6 @@ * be erased. * * @param flashctx Flash context to be used. - * @param buffer Buffer of full chip size to read into. * @return 0 on success, * 1 if all available erase functions failed. */ -- To view, visit https://review.coreboot.org/c/flashrom/+/58742 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ibd53fe34c05f87d7ecc0d6eee6463f9da3a174d4 Gerrit-Change-Number: 58742 Gerrit-PatchSet: 1 Gerrit-Owner: Simon Buhrow Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: [RFC] spi25_statusreg: make register read/write functions generic
by Nikolai Artemiev (Code Review) 29 Oct '21

29 Oct '21

Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58475 ) Change subject: [RFC] spi25_statusreg: make register read/write functions generic ...................................................................... Patch Set 6: (1 comment) File chipdrivers.h: https://review.coreboot.org/c/flashrom/+/58475/comment/1bec0e70_0fb0e99c PS6, Line 65: /* FIXME: replace spi_read_status_register() calls with spi_read_register() */ I have a separate patch for this, but it touches a lot of files so I'm leaving it out for now. -- To view, visit https://review.coreboot.org/c/flashrom/+/58475 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0a3951bbf993f2d8d830143b29d3ce16cc6901d7 Gerrit-Change-Number: 58475 Gerrit-PatchSet: 6 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Fri, 29 Oct 2021 05:08:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: [RFC] writeprotect: add functions to read and write wp_chip_state
by Nikolai Artemiev (Code Review) 29 Oct '21

29 Oct '21

Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Nikolai Artemiev has removed Paul Menzel from this change. ( https://review.coreboot.org/c/flashrom/+/58479 ) Change subject: [RFC] writeprotect: add functions to read and write wp_chip_state ...................................................................... Removed cc Paul Menzel. -- To view, visit https://review.coreboot.org/c/flashrom/+/58479 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3ad25708c3321b8fb0216c3eaf6ffc07616537ad Gerrit-Change-Number: 58479 Gerrit-PatchSet: 6 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: deleteReviewer

1 0

Change in flashrom[master]: [RFC] writeprotect, cli_classic: delete old writeprotect code
by Nikolai Artemiev (Code Review) 29 Oct '21

29 Oct '21

Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58474 ) Change subject: [RFC] writeprotect, cli_classic: delete old writeprotect code ...................................................................... Patch Set 6: (3 comments) File cli_classic.c: https://review.coreboot.org/c/flashrom/+/58474/comment/849a7fdb_8885f4d0 PS5, Line 778: set_wp_disable should be done before setting the range > Or even have `set_wp_range` disable WP beforehand (bail out if it fails) and restore the WP state af […] The comment is misleading, the only real requirement is that wp_set_range() should be called before before wp_enable() to avoid locking the status register before the desired range is selected. However calling wp_disable() before wp_set_range() won't help, since wp_disable() will only succeed if protection is already disabled or if the WP pin is inactive, and in either case wp_set_range() would succeed anyway. https://review.coreboot.org/c/flashrom/+/58474/comment/ec3a1c99_3d6c7f8e PS5, Line 783: set_wp_range must happen before set_wp_enable > Same question as previous, can set_wp_enable check that set_wp_range has been called? […] There isn't really anything to check, though we probably should keep the comment in some form. Something like "do this last" before the wp_enable code. File writeprotect.c: PS3: > The only reason I was thinking to temporarily keep struct wp, is to keep cli_classic compiling. So that _wp_ functions can be added one at a time, with implementation. At the end of the patch series there would be no struct wp, one way or the other. > I thought this can be another approach on how to add one function at a time. In the end I decided to delete all the old code in this commit and add things back as when they are ready. I think that will be easiest to review. -- To view, visit https://review.coreboot.org/c/flashrom/+/58474 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I67e9b31f86465e5a8f7d3def637198671ee818a8 Gerrit-Change-Number: 58474 Gerrit-PatchSet: 6 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Fri, 29 Oct 2021 05:04:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: [RFC] writeprotect, cli_classic: enable writeprotect
by Nikolai Artemiev (Code Review) 29 Oct '21

29 Oct '21

Nikolai Artemiev has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/58739 ) Change subject: [RFC] writeprotect, cli_classic: enable writeprotect ...................................................................... [RFC] writeprotect, cli_classic: enable writeprotect Enable writeprotect. Tested with: GD25LQ128, GD25Q32, GD25Q64, GD25Q256, MX25L2006E, and W25X40. TEST=flashrom --wp-{enable,disable,range,list,status} BRANCH=none Change-Id: Id64a0789b05c5bc362865f7888f037367d6d566b Signed-off-by: Nikolai Artemiev <nartemiev(a)google.com> --- M cli_classic.c M writeprotect.c M writeprotect.h 3 files changed, 8 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/39/58739/1 diff --git a/cli_classic.c b/cli_classic.c index f078fb3..c735bfd 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -712,8 +712,7 @@ goto out_shutdown; } - /* Disable writeprotect until support is complete */ - if (any_wp_op) { + if (any_wp_op && !wp_supported(fill_flash)) { msg_gerr("Error: write protect is not supported on this flash chip.\n"); ret = 1; goto out_shutdown; diff --git a/writeprotect.c b/writeprotect.c index 011f5d0..b35136e 100644 --- a/writeprotect.c +++ b/writeprotect.c @@ -240,6 +240,11 @@ return 0; } +bool wp_supported(struct flashctx *flash) +{ + return flash->chip->decode_range != NULL; +} + int wp_get_ranges(struct flashctx *flash, struct wp_range *ranges, size_t *count) { struct wp_range_wpst_pair range_wpst_pairs[MAX_WP_RANGES]; diff --git a/writeprotect.h b/writeprotect.h index 0cfb2da..8080937 100644 --- a/writeprotect.h +++ b/writeprotect.h @@ -53,6 +53,8 @@ uint32_t len; }; +bool wp_supported(struct flashctx *flash); + #define MAX_WP_RANGES 128 int wp_get_ranges(struct flashctx *flash, struct wp_range *ranges, size_t *count); -- To view, visit https://review.coreboot.org/c/flashrom/+/58739 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id64a0789b05c5bc362865f7888f037367d6d566b Gerrit-Change-Number: 58739 Gerrit-PatchSet: 1 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: [RFC] writeprotect: implement wp_print_status()
by Nikolai Artemiev (Code Review) 29 Oct '21

29 Oct '21

Nikolai Artemiev has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/58738 ) Change subject: [RFC] writeprotect: implement wp_print_status() ...................................................................... [RFC] writeprotect: implement wp_print_status() BUG=b:195381327,b:153800563 TEST=flashrom --wp-status BRANCH=none Change-Id: I499f521781ee8999921996517802c0c0c641d869 Signed-off-by: Nikolai Artemiev <nartemiev(a)google.com> --- M cli_classic.c M writeprotect.c M writeprotect.h 3 files changed, 41 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/38/58738/1 diff --git a/cli_classic.c b/cli_classic.c index a9eb43b..f078fb3 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -805,6 +805,9 @@ ret |= wp_print_ranges(fill_flash); } + if (wp_status) { + ret |= wp_print_status(fill_flash); + } flashrom_flag_set(fill_flash, FLASHROM_FLAG_FORCE, !!force); #if CONFIG_INTERNAL == 1 diff --git a/writeprotect.c b/writeprotect.c index 3a52d99..011f5d0 100644 --- a/writeprotect.c +++ b/writeprotect.c @@ -441,3 +441,39 @@ return 0; } + +static void print_wp_mode(enum wp_mode mode) +{ + if (mode == WP_MODE_DISABLED) msg_ginfo("disabled"); + if (mode == WP_MODE_HARDWARE) msg_ginfo("hardware"); + if (mode == WP_MODE_POWER_CYCLE) msg_ginfo("powercycle"); + if (mode == WP_MODE_PERMANENT) msg_ginfo("permanent"); +} + +int wp_print_status(struct flashctx *flash) +{ + struct wp_chip_state wpst; + struct wp_range range; + enum wp_mode mode; + + if (read_wp_chip_state(flash, &wpst)) + return 1; + + if (decode_wp_mode(&wpst, &mode)) + return 1; + + range.chip_len = flash->chip->total_size * 1024; + flash->chip->decode_range(&wpst, &range); + + msg_ginfo("\nWrite protect chip state: "); + print_wp_chip_state(&wpst); + + msg_ginfo("\n\nProtection range: "); + print_range(&range); + + msg_ginfo("\n\nProtection mode: "); + print_wp_mode(mode); + msg_ginfo("\n"); + + return 0; +} diff --git a/writeprotect.h b/writeprotect.h index 5d23d2e..0cfb2da 100644 --- a/writeprotect.h +++ b/writeprotect.h @@ -64,4 +64,6 @@ int wp_print_ranges(struct flashctx *flash); +int wp_print_status(struct flashctx *flash); + #endif -- To view, visit https://review.coreboot.org/c/flashrom/+/58738 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I499f521781ee8999921996517802c0c0c641d869 Gerrit-Change-Number: 58738 Gerrit-PatchSet: 1 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: [RFC] writeprotect: implement wp_print_ranges()
by Nikolai Artemiev (Code Review) 29 Oct '21

29 Oct '21

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58484 to look at the new patch set (#6). Change subject: [RFC] writeprotect: implement wp_print_ranges() ...................................................................... [RFC] writeprotect: implement wp_print_ranges() BUG=b:195381327,b:153800563 TEST=flashrom --wp-list BRANCH=none Change-Id: I82441c60c239a5b947b5a2a87b61e7bdf60bee89 Signed-off-by: Nikolai Artemiev <nartemiev(a)google.com> --- M cli_classic.c M writeprotect.c M writeprotect.h 3 files changed, 52 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/84/58484/6 -- To view, visit https://review.coreboot.org/c/flashrom/+/58484 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I82441c60c239a5b947b5a2a87b61e7bdf60bee89 Gerrit-Change-Number: 58484 Gerrit-PatchSet: 6 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit October 2021