October 2021 - flashrom-gerrit

Change in flashrom[master]: it87spi.c: ITE IT8792E Super IO probing support
by melvyn2 (Code Review) 31 Oct '21

31 Oct '21

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58773 to look at the new patch set (#3). Change subject: it87spi.c: ITE IT8792E Super IO probing support ...................................................................... it87spi.c: ITE IT8792E Super IO probing support Tested read of both flash chips with the `dualbiosindex` parameter on a GIGABYTE Z390 AORUS MASTER. Signed-off-by: melvyn2 <melvyn2(a)brcok.tk> Change-Id: Iea2d4097129b8f70d3112aec92f3b4e78d68bc8d --- M it87spi.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/73/58773/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/58773 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iea2d4097129b8f70d3112aec92f3b4e78d68bc8d Gerrit-Change-Number: 58773 Gerrit-PatchSet: 3 Gerrit-Owner: melvyn2 <melvyn2(a)brcok.tk> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: chipset_enable.c: Mark Intel Z390 as DEP
by melvyn2 (Code Review) 31 Oct '21

31 Oct '21

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58774 to look at the new patch set (#3). Change subject: chipset_enable.c: Mark Intel Z390 as DEP ...................................................................... chipset_enable.c: Mark Intel Z390 as DEP Tested read/write on GIGABYTE Z390 AORUS MASTER, incl. ME region with me_cleaner Change-Id: If14d45c144bb32a1d1046185d4476ea29e4d0912 Signed-off-by: melvyn2 <melvyn2(a)brcok.tk> --- M chipset_enable.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/74/58774/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/58774 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If14d45c144bb32a1d1046185d4476ea29e4d0912 Gerrit-Change-Number: 58774 Gerrit-PatchSet: 3 Gerrit-Owner: melvyn2 <melvyn2(a)brcok.tk> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: chipset_enable.c: Mark Intel Z390 as DEP
by melvyn2 (Code Review) 31 Oct '21

31 Oct '21

melvyn2 has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/58774 ) Change subject: chipset_enable.c: Mark Intel Z390 as DEP ...................................................................... chipset_enable.c: Mark Intel Z390 as DEP Tested read/write on GIGABYTE Z390 AORUS MASTER, incl. ME region with me_cleaner Change-Id: If14d45c144bb32a1d1046185d4476ea29e4d0912 Signed-off-by: melvyn2 <melvyn2(a)brcok.tk> --- M chipset_enable.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/74/58774/1 diff --git a/chipset_enable.c b/chipset_enable.c index cb0fbf1..2f827bb 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -2089,7 +2089,7 @@ {0x8086, 0x31e8, B_S, DEP, "Intel", "Gemini Lake", enable_flash_glk}, {0x8086, 0xa303, B_S, NT, "Intel", "H310", enable_flash_pch300}, {0x8086, 0xa304, B_S, NT, "Intel", "H370", enable_flash_pch300}, - {0x8086, 0xa305, B_S, NT, "Intel", "Z390", enable_flash_pch300}, + {0x8086, 0xa305, B_S, DEP, "Intel", "Z390", enable_flash_pch300}, {0x8086, 0xa306, B_S, NT, "Intel", "Q370", enable_flash_pch300}, {0x8086, 0xa308, B_S, NT, "Intel", "B360", enable_flash_pch300}, {0x8086, 0xa309, B_S, NT, "Intel", "C246", enable_flash_pch300}, -- To view, visit https://review.coreboot.org/c/flashrom/+/58774 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If14d45c144bb32a1d1046185d4476ea29e4d0912 Gerrit-Change-Number: 58774 Gerrit-PatchSet: 1 Gerrit-Owner: melvyn2 <melvyn2(a)brcok.tk> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: it87spi.c: ITE IT8792E Super IO probing support
by Melvyn (Code Review) 31 Oct '21

31 Oct '21

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58773 to look at the new patch set (#2). Change subject: it87spi.c: ITE IT8792E Super IO probing support ...................................................................... it87spi.c: ITE IT8792E Super IO probing support Tested read of both flash chips with the `dualbiosindex` parameter on a GIGABYTE Z390 AORUS MASTER. Signed-off-by: melvyn2 <melvyn2(a)brcok.tk> Change-Id: Iea2d4097129b8f70d3112aec92f3b4e78d68bc8d --- M it87spi.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/73/58773/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/58773 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iea2d4097129b8f70d3112aec92f3b4e78d68bc8d Gerrit-Change-Number: 58773 Gerrit-PatchSet: 2 Gerrit-Owner: Melvyn <melvyn2(a)brcok.tk> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Add ITE IT8792E Super IO probing support for DualBIOS support Signed-...
by Melvyn (Code Review) 31 Oct '21

31 Oct '21

Melvyn has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/58773 ) Change subject: Add ITE IT8792E Super IO probing support for DualBIOS support Signed-off-by: melvyn2 <melvyn2(a)brcok.tk> ...................................................................... Add ITE IT8792E Super IO probing support for DualBIOS support Signed-off-by: melvyn2 <melvyn2(a)brcok.tk> Change-Id: Iea2d4097129b8f70d3112aec92f3b4e78d68bc8d --- M it87spi.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/73/58773/1 diff --git a/it87spi.c b/it87spi.c index 5f6fb65..bd2f7bc 100644 --- a/it87spi.c +++ b/it87spi.c @@ -449,6 +449,7 @@ case 0x8705: ret |= it8705f_write_enable(superios[i].port); break; + case 0x8688: case 0x8716: case 0x8718: case 0x8720: -- To view, visit https://review.coreboot.org/c/flashrom/+/58773 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iea2d4097129b8f70d3112aec92f3b4e78d68bc8d Gerrit-Change-Number: 58773 Gerrit-PatchSet: 1 Gerrit-Owner: Melvyn <melvyn2(a)brcok.tk> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: [RFC] writeprotect: implement wp_get_ranges()
by Sergii Dmytruk (Code Review) 30 Oct '21

30 Oct '21

Attention is currently required from: Nikolai Artemiev. Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58481 ) Change subject: [RFC] writeprotect: implement wp_get_ranges() ...................................................................... Patch Set 6: (1 comment) File writeprotect.h: https://review.coreboot.org/c/flashrom/+/58481/comment/fcf1027d_e315eaa2 PS6, Line 57: wp_get_ranges How about renaming it to, say, `wp_list_ranges` to make it less confusing? This will separate it from `wp_get_range` and be less suggestive of getting ranges from somewhere as they are actually generated by this function. -- To view, visit https://review.coreboot.org/c/flashrom/+/58481 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id51f038f03305c8536d80313e52f77d27835f34d Gerrit-Change-Number: 58481 Gerrit-PatchSet: 6 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Sat, 30 Oct 2021 16:30:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips.c: big erase blocksize first
by Angel Pons (Code Review) 29 Oct '21

29 Oct '21

Attention is currently required from: Simon Buhrow, Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58467 ) Change subject: flashchips.c: big erase blocksize first ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: > Just a proof of concept for discussion. Sorry for the ugly code. […] I didn't take a look at the code, but I imagine this tries to use a full chip erase command where possible. Does it work when partially erasing a flash chip with a layout? -- To view, visit https://review.coreboot.org/c/flashrom/+/58467 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I862ce0b5f8912565e43c340578d8126aa2e6aa3b Gerrit-Change-Number: 58467 Gerrit-PatchSet: 5 Gerrit-Owner: Simon Buhrow Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Simon Buhrow Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Fri, 29 Oct 2021 14:30:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Simon Buhrow Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashrom.c: Delete obsolete comment
by Angel Pons (Code Review) 29 Oct '21

29 Oct '21

Attention is currently required from: Simon Buhrow. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58742 ) Change subject: flashrom.c: Delete obsolete comment ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/58742 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ibd53fe34c05f87d7ecc0d6eee6463f9da3a174d4 Gerrit-Change-Number: 58742 Gerrit-PatchSet: 1 Gerrit-Owner: Simon Buhrow Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Simon Buhrow Gerrit-Comment-Date: Fri, 29 Oct 2021 14:09:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips.c: big erase blocksize first
by Simon Buhrow (Code Review) 29 Oct '21

29 Oct '21

Attention is currently required from: Nico Huber, Angel Pons. Simon Buhrow has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58467 ) Change subject: flashchips.c: big erase blocksize first ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: Just a proof of concept for discussion. Sorry for the ugly code. This just makes "-E" faster when whole chip shall be erased and lets the other scenarios untouched. It was just much easier than what Angel proposed which will take me more time (I´m not sure when I´ll enough for that). With this approach a user can also accelerate rewriting a chip by manually run '-E' before '-w' (only few cases). -- To view, visit https://review.coreboot.org/c/flashrom/+/58467 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I862ce0b5f8912565e43c340578d8126aa2e6aa3b Gerrit-Change-Number: 58467 Gerrit-PatchSet: 5 Gerrit-Owner: Simon Buhrow Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 29 Oct 2021 11:54:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips.c: big erase blocksize first
by Simon Buhrow (Code Review) 29 Oct '21

29 Oct '21

Attention is currently required from: Simon Buhrow, Nico Huber, Angel Pons. Hello build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58467 to look at the new patch set (#5). Change subject: flashchips.c: big erase blocksize first ...................................................................... flashchips.c: big erase blocksize first Choosing the best fitting erase block size can safe a significant amount of runtime. Changing the order of entries of block_erasers in flashchips.c going from the bigger block size to lower block size does a better job. I am running flashrom inside a VirtualBox so the gained time is quite big. Setup: IS25LP064 flash + ft2232H programmer Saved time: > 2 min for single '-E' operation Change-Id: I862ce0b5f8912565e43c340578d8126aa2e6aa3b Signed-off-by: Simon Buhrow <simon.buhrow(a)posteo.de> --- M flashrom.c 1 file changed, 69 insertions(+), 21 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/67/58467/5 -- To view, visit https://review.coreboot.org/c/flashrom/+/58467 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I862ce0b5f8912565e43c340578d8126aa2e6aa3b Gerrit-Change-Number: 58467 Gerrit-PatchSet: 5 Gerrit-Owner: Simon Buhrow Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Simon Buhrow Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit October 2021