October 2021 - flashrom-gerrit

Change in flashrom[master]: Makefile, ich_descriptors_tool/Makefile: unify behavior
by Thomas Heijligen (Code Review) 22 Oct '21

22 Oct '21

Attention is currently required from: Nico Huber, Thomas Heijligen. Hello build bot (Jenkins), Nico Huber, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58468 to look at the new patch set (#3). Change subject: Makefile, ich_descriptors_tool/Makefile: unify behavior ...................................................................... Makefile, ich_descriptors_tool/Makefile: unify behavior make clean: use $(PROGRAMM)$(EXEC_SUFFIX) instead of removing the Unix and Windows binary separately. ich_descriptors_tool/Makefile: have the same behavior like the main flashrom Makefile - only set gcc explicit on MinGW HOST_OS - don't fallback to gcc if CC was not set - set CFLAGS and EXEC_SUFFIX for TARGET_OS, not for HOST_OS Don't pass the TARGET_OS and EXEC_SUFFIX from the main Makefile to ich_descriptors_tool/Makefile. Change-Id: I353c3de250167994a4aea1edfef57d839e900d78 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de> --- M Makefile M util/ich_descriptors_tool/Makefile 2 files changed, 8 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/68/58468/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/58468 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I353c3de250167994a4aea1edfef57d839e900d78 Gerrit-Change-Number: 58468 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Makefile: remove NEED_LIBUSB1 from FEATURE_CFLAGS
by Angel Pons (Code Review) 22 Oct '21

22 Oct '21

Attention is currently required from: Nico Huber, Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58518 ) Change subject: Makefile: remove NEED_LIBUSB1 from FEATURE_CFLAGS ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/58518 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie7cb3df39daf22cb954186d38ba32812b05d92f9 Gerrit-Change-Number: 58518 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Fri, 22 Oct 2021 09:29:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: remove unused CONFIG_I2C_SUPPORT
by Angel Pons (Code Review) 22 Oct '21

22 Oct '21

Attention is currently required from: Nico Huber, Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58495 ) Change subject: Makefile: remove unused CONFIG_I2C_SUPPORT ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/58495 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2e19335e1b8d39f44dda14edc0a496dda6bc8c9c Gerrit-Change-Number: 58495 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Fri, 22 Oct 2021 09:24:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile, ich_descriptor_tool/Makefile: unify behavior
by Angel Pons (Code Review) 22 Oct '21

22 Oct '21

Attention is currently required from: Nico Huber, Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58468 ) Change subject: Makefile, ich_descriptor_tool/Makefile: unify behavior ...................................................................... Patch Set 2: Code-Review+1 (8 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/58468/comment/9634aead_9e046e9f PS2, Line 7: descriptor nit: missing plural `s` in `descriptors` https://review.coreboot.org/c/flashrom/+/58468/comment/24c8b972_ab7bef3a PS2, Line 9: remove use gerund form: `removing` https://review.coreboot.org/c/flashrom/+/58468/comment/43774a7f_e639a7bc PS2, Line 12: descriptor nit: missing plural `s` in `descriptors` https://review.coreboot.org/c/flashrom/+/58468/comment/e39a513a_43f51a34 PS2, Line 13: Makefie typo: missing `l` in `Makefile` https://review.coreboot.org/c/flashrom/+/58468/comment/ae193be4_87ba5757 PS2, Line 16: set CFLAGS and EXEC_SUFFIX for TARGET_OS not for the HOST_OS Two nits: - Drop `the` in `for the HOST_OS` for consistency with `for TARGET_OS` - Add a comma after `TARGET_OS` set CFLAGS and EXEC_SUFFIX for TARGET_OS, not for HOST_OS https://review.coreboot.org/c/flashrom/+/58468/comment/48f95a1c_1d2cd81d PS2, Line 19: descriptor nit: missing plural `s` in `descriptors` https://review.coreboot.org/c/flashrom/+/58468/comment/04447544_2787905c PS2, Line 18: Don't pass the EXEC_SUFFIX from the main Makefile to : ich_descriptor_tool/Makefile. I see that `TARGET_OS` is no longer passed either. I imagine it wasn't mentioned in the commit message because `util/ich_descriptors_tool/Makefile` overrides it anyway. Still, I'd mention `TARGET_OS` in the commit message. File util/ich_descriptors_tool/Makefile: https://review.coreboot.org/c/flashrom/+/58468/comment/d7472dfe_f7cd5986 PS2, Line 42: */ nit: remove? -- To view, visit https://review.coreboot.org/c/flashrom/+/58468 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I353c3de250167994a4aea1edfef57d839e900d78 Gerrit-Change-Number: 58468 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Fri, 22 Oct 2021 08:42:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: unify the use of filter
by Angel Pons (Code Review) 22 Oct '21

22 Oct '21

Attention is currently required from: Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58451 ) Change subject: Makefile: unify the use of filter ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/58451/comment/929f618b_13aa470c PS2, Line 9: Make a filter statement easier to read I imagine it's the first one, in which a trailing comma gets dropped. -- To view, visit https://review.coreboot.org/c/flashrom/+/58451 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6cd1e169b435cadb06423836cd9d64cdd2f51a94 Gerrit-Change-Number: 58451 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Fri, 22 Oct 2021 08:26:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: unify the use of filter
by Angel Pons (Code Review) 22 Oct '21

22 Oct '21

Attention is currently required from: Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58451 ) Change subject: Makefile: unify the use of filter ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/58451 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6cd1e169b435cadb06423836cd9d64cdd2f51a94 Gerrit-Change-Number: 58451 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Fri, 22 Oct 2021 08:25:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: sb600spi: Cleanup spispeed and spireamode warnings
by Raul Rangel (Code Review) 21 Oct '21

21 Oct '21

Attention is currently required from: Rob Barnes. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58529 ) Change subject: sb600spi: Cleanup spispeed and spireamode warnings ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: lol, I thought Github was upstream. -- To view, visit https://review.coreboot.org/c/flashrom/+/58529 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idf5e735b9e504c943bf93a428da64976d723eb2c Gerrit-Change-Number: 58529 Gerrit-PatchSet: 1 Gerrit-Owner: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Comment-Date: Thu, 21 Oct 2021 21:33:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: sb600spi: Cleanup spispeed and spireamode warnings
by Rob Barnes (Code Review) 21 Oct '21

21 Oct '21

Attention is currently required from: Raul Rangel. Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58529 ) Change subject: sb600spi: Cleanup spispeed and spireamode warnings ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Can you push this upstream first? I thought this was upstream? https://www.flashrom.org/Development_Guidelines#Sending_a_patch -- To view, visit https://review.coreboot.org/c/flashrom/+/58529 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idf5e735b9e504c943bf93a428da64976d723eb2c Gerrit-Change-Number: 58529 Gerrit-PatchSet: 1 Gerrit-Owner: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Comment-Date: Thu, 21 Oct 2021 21:25:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: sb600spi: Cleanup spispeed and spireamode warnings
by Raul Rangel (Code Review) 21 Oct '21

21 Oct '21

Attention is currently required from: Rob Barnes. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58529 ) Change subject: sb600spi: Cleanup spispeed and spireamode warnings ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Can you push this upstream first? -- To view, visit https://review.coreboot.org/c/flashrom/+/58529 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idf5e735b9e504c943bf93a428da64976d723eb2c Gerrit-Change-Number: 58529 Gerrit-PatchSet: 1 Gerrit-Owner: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Comment-Date: Thu, 21 Oct 2021 21:18:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: sb600spi: Cleanup spispeed and spireamode warnings
by Rob Barnes (Code Review) 21 Oct '21

21 Oct '21

Rob Barnes has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/58529 ) Change subject: sb600spi: Cleanup spispeed and spireamode warnings ...................................................................... sb600spi: Cleanup spispeed and spireamode warnings These warnings are printed at error level so they are displayed with every invocation of flashrom. This clutters the flashrom output in the usual case. Move warnings to debug level, add newline and clean up text. TEST=Deploy to guybrush, observe messages are only seen when --verbose is enabled BUG=None BRANCH=None Change-Id: Idf5e735b9e504c943bf93a428da64976d723eb2c Signed-off-by: Rob Barnes <robbarnes(a)google.com> --- M sb600spi.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/29/58529/1 diff --git a/sb600spi.c b/sb600spi.c index 7fa01af..d5e228c 100644 --- a/sb600spi.c +++ b/sb600spi.c @@ -458,8 +458,8 @@ msg_pdbg("SPI read mode is %s (%i)\n", spireadmodes[read_mode], read_mode); if (spireadmode_idx < 0) { - msg_perr("Warning: spireadmode not set, " - "leaving spireadmode unchanged."); + msg_pdbg("spireadmode is not set, " + "leaving SPI read mode unchanged.\n"); } else if (set_mode(dev, spireadmode_idx, sb600_spibar) != 0) { return 1; @@ -501,7 +501,7 @@ } } if (spispeed_idx < 0) { - msg_perr("Warning: spispeed not set, leaving spispeed unchanged."); + msg_pdbg("spispeed is not set, leaving SPI speed unchanged.\n"); return 0; } return set_speed(dev, amd_gen, spispeed_idx, sb600_spibar); -- To view, visit https://review.coreboot.org/c/flashrom/+/58529 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idf5e735b9e504c943bf93a428da64976d723eb2c Gerrit-Change-Number: 58529 Gerrit-PatchSet: 1 Gerrit-Owner: Rob Barnes <robbarnes(a)google.com> Gerrit-MessageType: newchange

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit October 2021