October 2021 - flashrom-gerrit

Change in flashrom[master]: flashrom_tester: Use elogtool to list firmware eventlog
by Ricardo Quesada (Code Review) 21 Oct '21

21 Oct '21

Attention is currently required from: Furquan Shaikh, Jack Rosenthal, Edward O'Callaghan. Ricardo Quesada has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58527 ) Change subject: flashrom_tester: Use elogtool to list firmware eventlog ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/58527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8c4be82fed28b6a19746e6b93fafce23bd8ede5d Gerrit-Change-Number: 58527 Gerrit-PatchSet: 2 Gerrit-Owner: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Ricardo Quesada <ricardoq(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Thu, 21 Oct 2021 20:20:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashrom_tester: Use elogtool to list firmware eventlog
by Jack Rosenthal (Code Review) 21 Oct '21

21 Oct '21

Attention is currently required from: Furquan Shaikh, Ricardo Quesada, Edward O'Callaghan. Hello build bot (Jenkins), Furquan Shaikh, Ricardo Quesada, Edward O'Callaghan, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58527 to look at the new patch set (#2). Change subject: flashrom_tester: Use elogtool to list firmware eventlog ...................................................................... flashrom_tester: Use elogtool to list firmware eventlog Mosys is dropping the eventlog command, in favor of the elogtool command provided in coreboot. The output is compatible with what mosys used to output. Signed-off-by: Jack Rosenthal <jrosenth(a)chromium.org> Change-Id: I8c4be82fed28b6a19746e6b93fafce23bd8ede5d --- M util/flashrom_tester/src/cros_sysinfo.rs M util/flashrom_tester/src/tests.rs 2 files changed, 7 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/27/58527/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/58527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8c4be82fed28b6a19746e6b93fafce23bd8ede5d Gerrit-Change-Number: 58527 Gerrit-PatchSet: 2 Gerrit-Owner: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Ricardo Quesada <ricardoq(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Ricardo Quesada <ricardoq(a)google.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: flashrom_tester: Use elogtool to list firmware eventlog
by Jack Rosenthal (Code Review) 21 Oct '21

21 Oct '21

Attention is currently required from: Furquan Shaikh, Ricardo Quesada, Edward O'Callaghan. Hello Furquan Shaikh, Ricardo Quesada, Edward O'Callaghan, I'd like you to do a code review. Please visit https://review.coreboot.org/c/flashrom/+/58527 to review the following change. Change subject: flashrom_tester: Use elogtool to list firmware eventlog ...................................................................... flashrom_tester: Use elogtool to list firmware eventlog Mosys is dropping the eventlog command, in favor of the elogtool command provided in coreboot. The output is compatible with what mosys used to output. Signed-off-by: Jack Rosenthal <jrosenth(a)chromium.org> Change-Id: I8c4be82fed28b6a19746e6b93fafce23bd8ede5d --- M util/flashrom_tester/src/cros_sysinfo.rs M util/flashrom_tester/src/tests.rs 2 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/27/58527/1 diff --git a/util/flashrom_tester/src/cros_sysinfo.rs b/util/flashrom_tester/src/cros_sysinfo.rs index ddb0802..4d1b347 100644 --- a/util/flashrom_tester/src/cros_sysinfo.rs +++ b/util/flashrom_tester/src/cros_sysinfo.rs @@ -61,13 +61,13 @@ } pub fn eventlog_list() -> Result<String, std::io::Error> { - mosys_dispatch(&["eventlog", "list"]) + elogtool_dispatch(&["list"]) } -fn mosys_dispatch<S: AsRef<OsStr> + Debug>(args: &[S]) -> IoResult<String> { - info!("mosys_dispatch() running: /usr/sbin/mosys {:?}", args); +fn elogtool_dispatch<S: AsRef<OsStr> + Debug>(args: &[S]) -> IoResult<String> { + info!("elogtool_dispatch() running: /usr/bin/elogtool {:?}", args); - let output = Command::new("/usr/sbin/mosys") + let output = Command::new("/usr/bin/elogtool") .args(args) .stdin(Stdio::null()) .output()?; diff --git a/util/flashrom_tester/src/tests.rs b/util/flashrom_tester/src/tests.rs index 9ef98e5..c9ad603 100644 --- a/util/flashrom_tester/src/tests.rs +++ b/util/flashrom_tester/src/tests.rs @@ -234,8 +234,8 @@ fn elog_sanity_test(env: &mut TestEnv) -> TestResult { // Check that the elog contains *something*, as an indication that Coreboot - // is actually able to write to the Flash. Because this invokes mosys on the - // host, it doesn't make sense to run for other chips. + // is actually able to write to the Flash. Because this invokes elogtool on + // the host, it doesn't make sense to run for other chips. if env.chip_type() != FlashChip::HOST { info!("Skipping ELOG sanity check for non-host chip"); return Ok(()); -- To view, visit https://review.coreboot.org/c/flashrom/+/58527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8c4be82fed28b6a19746e6b93fafce23bd8ede5d Gerrit-Change-Number: 58527 Gerrit-PatchSet: 1 Gerrit-Owner: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Ricardo Quesada <ricardoq(a)google.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Ricardo Quesada <ricardoq(a)google.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: Add Tiger Lake U Premium support
by Tim Crawford (Code Review) 21 Oct '21

21 Oct '21

Attention is currently required from: Michał Żygowski. Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55578 ) Change subject: Add Tiger Lake U Premium support ...................................................................... Patch Set 12: (1 comment) Patchset: PS12: > Michał can you rebase this to resolve the conflict? This doesn't seem to depend on the other commits in the chain. Can I rebase it on master so it can be merged? -- To view, visit https://review.coreboot.org/c/flashrom/+/55578 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I28f3b6fe9f8ce9e976a6808683f46b6f4ec72bdd Gerrit-Change-Number: 55578 Gerrit-PatchSet: 12 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Comment-Date: Thu, 21 Oct 2021 17:04:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Crawford <tcrawford(a)system76.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: remove NEED_LIBUSB1 from FEATURE_CFLAGS
by Thomas Heijligen (Code Review) 21 Oct '21

21 Oct '21

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/58518 ) Change subject: Makefile: remove NEED_LIBUSB1 from FEATURE_CFLAGS ...................................................................... Makefile: remove NEED_LIBUSB1 from FEATURE_CFLAGS NEED_LIBUSB1 is not used outside of the Makefile. No need to pass it to the compiler. Change-Id: Ie7cb3df39daf22cb954186d38ba32812b05d92f9 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de> --- M Makefile 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/18/58518/1 diff --git a/Makefile b/Makefile index 2f99bc0..fe737ad 100644 --- a/Makefile +++ b/Makefile @@ -801,7 +801,6 @@ NEED_LIBUSB1 := $(call filter_deps,$(DEPENDS_ON_LIBUSB1)) ifneq ($(NEED_LIBUSB1), ) CHECK_LIBUSB1 = yes -FEATURE_CFLAGS += -D'NEED_LIBUSB1=1' PROGRAMMER_OBJS += usbdev.o usb_device.o # FreeBSD and DragonflyBSD use a reimplementation of libusb-1.0 that is simply called libusb ifeq ($(TARGET_OS), $(filter $(TARGET_OS), FreeBSD DragonFlyBSD)) -- To view, visit https://review.coreboot.org/c/flashrom/+/58518 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie7cb3df39daf22cb954186d38ba32812b05d92f9 Gerrit-Change-Number: 58518 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: Makefile, ich_descriptor_tool/Makefile: unify behavior
by Thomas Heijligen (Code Review) 20 Oct '21

20 Oct '21

Attention is currently required from: Nico Huber. Hello build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58468 to look at the new patch set (#2). Change subject: Makefile, ich_descriptor_tool/Makefile: unify behavior ...................................................................... Makefile, ich_descriptor_tool/Makefile: unify behavior make clean: use $(PROGRAMM)$(EXEC_SUFFIX) instead of remove the Unix and Windows binary separately. ich_descriptor_tool/Makefile: have the same behavior like the main flashrom Makefie - only set gcc explicit on MinGW HOST_OS - don't fallback to gcc if CC was not set - set CFLAGS and EXEC_SUFFIX for TARGET_OS not for the HOST_OS Don't pass the EXEC_SUFFIX from the main Makefile to ich_descriptor_tool/Makefile. Change-Id: I353c3de250167994a4aea1edfef57d839e900d78 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de> --- M Makefile M util/ich_descriptors_tool/Makefile 2 files changed, 8 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/68/58468/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/58468 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I353c3de250167994a4aea1edfef57d839e900d78 Gerrit-Change-Number: 58468 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: ich_descriptors_tool/Makefile: TARGET_OS is given as cmdline argument
by Thomas Heijligen (Code Review) 20 Oct '21

20 Oct '21

Attention is currently required from: Nico Huber. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58468 ) Change subject: ich_descriptors_tool/Makefile: TARGET_OS is given as cmdline argument ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > > When building stand-alone for MinGW or DOS you have to pass TARGET_OS=MinGW/DOS ¯\_(ツ)_/¯ […] When the goal is to run just `make` in the ich_descriptor_tool folder, than the EXEC_SUFFIX should also not get passed. I'll than change that -- To view, visit https://review.coreboot.org/c/flashrom/+/58468 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I353c3de250167994a4aea1edfef57d839e900d78 Gerrit-Change-Number: 58468 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Wed, 20 Oct 2021 19:20:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: remove unused CONFIG_I2C_SUPPORT
by Thomas Heijligen (Code Review) 20 Oct '21

20 Oct '21

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/58495 ) Change subject: Makefile: remove unused CONFIG_I2C_SUPPORT ...................................................................... Makefile: remove unused CONFIG_I2C_SUPPORT Change-Id: I2e19335e1b8d39f44dda14edc0a496dda6bc8c9c Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de> --- M Makefile M meson.build 2 files changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/95/58495/1 diff --git a/Makefile b/Makefile index e8bf8fc..e4d4a05 100644 --- a/Makefile +++ b/Makefile @@ -738,7 +738,6 @@ ifeq ($(CONFIG_LINUX_I2C_HELPER), yes) LIB_OBJS += i2c_helper_linux.o -FEATURE_CFLAGS += -D'CONFIG_I2C_SUPPORT=1' endif ifneq ($(NEED_SERIAL), ) diff --git a/meson.build b/meson.build index 86657ce..85f40ba 100644 --- a/meson.build +++ b/meson.build @@ -342,7 +342,6 @@ if host_machine.system() == 'linux' srcs += 'i2c_helper_linux.c' - cargs += '-DCONFIG_I2C_SUPPORT=1' endif # raw memory, MSR or PCI port I/O access -- To view, visit https://review.coreboot.org/c/flashrom/+/58495 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2e19335e1b8d39f44dda14edc0a496dda6bc8c9c Gerrit-Change-Number: 58495 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: ich_descriptors_tool/Makefile: TARGET_OS is given as cmdline argument
by Nico Huber (Code Review) 20 Oct '21

20 Oct '21

Attention is currently required from: Thomas Heijligen. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58468 ) Change subject: ich_descriptors_tool/Makefile: TARGET_OS is given as cmdline argument ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > When building stand-alone for MinGW or DOS you have to pass TARGET_OS=MinGW/DOS ¯\_(ツ)_/¯ > Was that the case before? -- To view, visit https://review.coreboot.org/c/flashrom/+/58468 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I353c3de250167994a4aea1edfef57d839e900d78 Gerrit-Change-Number: 58468 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Wed, 20 Oct 2021 18:57:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ich_descriptors_tool/Makefile: TARGET_OS is given as cmdline argument
by Thomas Heijligen (Code Review) 20 Oct '21

20 Oct '21

Attention is currently required from: Nico Huber. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58468 ) Change subject: ich_descriptors_tool/Makefile: TARGET_OS is given as cmdline argument ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Doesn't this break standalone builds? When building stand-alone for MinGW or DOS you have to pass TARGET_OS=MinGW/DOS ¯\_(ツ)_/¯ EXEC_SUFFIX get also passed to ich_descriptor_tool and the Makefile has some logic to determinate that too -- To view, visit https://review.coreboot.org/c/flashrom/+/58468 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I353c3de250167994a4aea1edfef57d839e900d78 Gerrit-Change-Number: 58468 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Wed, 20 Oct 2021 18:53:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit October 2021