October 2021 - flashrom-gerrit

Change in flashrom[master]: sb600spi: Cleanup spispeed and spireamode warnings
by Rob Barnes (Code Review) 21 Oct '21

21 Oct '21

Rob Barnes has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/58529 ) Change subject: sb600spi: Cleanup spispeed and spireamode warnings ...................................................................... sb600spi: Cleanup spispeed and spireamode warnings These warnings are printed at error level so they are displayed with every invocation of flashrom. This clutters the flashrom output in the usual case. Move warnings to debug level, add newline and clean up … [View More]

1 0

Change in flashrom[master]: flashrom_tester: Use elogtool to list firmware eventlog
by Ricardo Quesada (Code Review) 21 Oct '21

21 Oct '21

Attention is currently required from: Furquan Shaikh, Jack Rosenthal, Edward O'Callaghan. Ricardo Quesada has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58527 ) Change subject: flashrom_tester: Use elogtool to list firmware eventlog ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/58527 To unsubscribe, or for help writing mail filters, visit https://… [View More]

1 0

Change in flashrom[master]: flashrom_tester: Use elogtool to list firmware eventlog
by Jack Rosenthal (Code Review) 21 Oct '21

21 Oct '21

Attention is currently required from: Furquan Shaikh, Ricardo Quesada, Edward O'Callaghan. Hello build bot (Jenkins), Furquan Shaikh, Ricardo Quesada, Edward O'Callaghan, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58527 to look at the new patch set (#2). Change subject: flashrom_tester: Use elogtool to list firmware eventlog ...................................................................... flashrom_tester: Use elogtool to list … [View More]

1 0

Change in flashrom[master]: flashrom_tester: Use elogtool to list firmware eventlog
by Jack Rosenthal (Code Review) 21 Oct '21

21 Oct '21

Attention is currently required from: Furquan Shaikh, Ricardo Quesada, Edward O'Callaghan. Hello Furquan Shaikh, Ricardo Quesada, Edward O'Callaghan, I'd like you to do a code review. Please visit https://review.coreboot.org/c/flashrom/+/58527 to review the following change. Change subject: flashrom_tester: Use elogtool to list firmware eventlog ...................................................................... flashrom_tester: Use elogtool to list firmware eventlog Mosys is … [View More]dropping the eventlog command, in favor of the elogtool command provided in coreboot. The output is compatible with what mosys used to output. Signed-off-by: Jack Rosenthal <jrosenth(a)chromium.org> Change-Id: I8c4be82fed28b6a19746e6b93fafce23bd8ede5d --- M util/flashrom_tester/src/cros_sysinfo.rs M util/flashrom_tester/src/tests.rs 2 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/27/58527/1 diff --git a/util/flashrom_tester/src/cros_sysinfo.rs b/util/flashrom_tester/src/cros_sysinfo.rs index ddb0802..4d1b347 100644 --- a/util/flashrom_tester/src/cros_sysinfo.rs +++ b/util/flashrom_tester/src/cros_sysinfo.rs @@ -61,13 +61,13 @@ } pub fn eventlog_list() -> Result<String, std::io::Error> { - mosys_dispatch(&["eventlog", "list"]) + elogtool_dispatch(&["list"]) } -fn mosys_dispatch<S: AsRef<OsStr> + Debug>(args: &[S]) -> IoResult<String> { - info!("mosys_dispatch() running: /usr/sbin/mosys {:?}", args); +fn elogtool_dispatch<S: AsRef<OsStr> + Debug>(args: &[S]) -> IoResult<String> { + info!("elogtool_dispatch() running: /usr/bin/elogtool {:?}", args); - let output = Command::new("/usr/sbin/mosys") + let output = Command::new("/usr/bin/elogtool") .args(args) .stdin(Stdio::null()) .output()?; diff --git a/util/flashrom_tester/src/tests.rs b/util/flashrom_tester/src/tests.rs index 9ef98e5..c9ad603 100644 --- a/util/flashrom_tester/src/tests.rs +++ b/util/flashrom_tester/src/tests.rs @@ -234,8 +234,8 @@ fn elog_sanity_test(env: &mut TestEnv) -> TestResult { // Check that the elog contains *something*, as an indication that Coreboot - // is actually able to write to the Flash. Because this invokes mosys on the - // host, it doesn't make sense to run for other chips. + // is actually able to write to the Flash. Because this invokes elogtool on + // the host, it doesn't make sense to run for other chips. if env.chip_type() != FlashChip::HOST { info!("Skipping ELOG sanity check for non-host chip"); return Ok(()); -- To view, visit https://review.coreboot.org/c/flashrom/+/58527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8c4be82fed28b6a19746e6b93fafce23bd8ede5d Gerrit-Change-Number: 58527 Gerrit-PatchSet: 1 Gerrit-Owner: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Ricardo Quesada <ricardoq(a)google.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Ricardo Quesada <ricardoq(a)google.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newchange [View Less]

1 0

Change in flashrom[master]: Add Tiger Lake U Premium support
by Tim Crawford (Code Review) 21 Oct '21

21 Oct '21

Attention is currently required from: Michał Żygowski. Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55578 ) Change subject: Add Tiger Lake U Premium support ...................................................................... Patch Set 12: (1 comment) Patchset: PS12: > Michał can you rebase this to resolve the conflict? This doesn't seem to depend on the other commits in the chain. Can I rebase it on master so it can be merged? -- … [View More]

1 0

Change in flashrom[master]: Makefile: remove NEED_LIBUSB1 from FEATURE_CFLAGS
by Thomas Heijligen (Code Review) 21 Oct '21

21 Oct '21

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/58518 ) Change subject: Makefile: remove NEED_LIBUSB1 from FEATURE_CFLAGS ...................................................................... Makefile: remove NEED_LIBUSB1 from FEATURE_CFLAGS NEED_LIBUSB1 is not used outside of the Makefile. No need to pass it to the compiler. Change-Id: Ie7cb3df39daf22cb954186d38ba32812b05d92f9 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.… [View More]

1 0

Change in flashrom[master]: Makefile, ich_descriptor_tool/Makefile: unify behavior
by Thomas Heijligen (Code Review) 20 Oct '21

20 Oct '21

Attention is currently required from: Nico Huber. Hello build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58468 to look at the new patch set (#2). Change subject: Makefile, ich_descriptor_tool/Makefile: unify behavior ...................................................................... Makefile, ich_descriptor_tool/Makefile: unify behavior make clean: use $(PROGRAMM)$(EXEC_SUFFIX) instead of remove the Unix … [View More]

1 0

Change in flashrom[master]: ich_descriptors_tool/Makefile: TARGET_OS is given as cmdline argument
by Thomas Heijligen (Code Review) 20 Oct '21

20 Oct '21

Attention is currently required from: Nico Huber. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58468 ) Change subject: ich_descriptors_tool/Makefile: TARGET_OS is given as cmdline argument ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > > When building stand-alone for MinGW or DOS you have to pass TARGET_OS=MinGW/DOS ¯\_(ツ)_/¯ […] When the goal is to run just `make` … [View More]

1 0

Change in flashrom[master]: Makefile: remove unused CONFIG_I2C_SUPPORT
by Thomas Heijligen (Code Review) 20 Oct '21

20 Oct '21

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/58495 ) Change subject: Makefile: remove unused CONFIG_I2C_SUPPORT ...................................................................... Makefile: remove unused CONFIG_I2C_SUPPORT Change-Id: I2e19335e1b8d39f44dda14edc0a496dda6bc8c9c Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de> --- M Makefile M meson.build 2 files changed, 0 insertions(+), 2 deletions(-) git pull … [View More]

1 0

Change in flashrom[master]: ich_descriptors_tool/Makefile: TARGET_OS is given as cmdline argument
by Nico Huber (Code Review) 20 Oct '21

20 Oct '21

Attention is currently required from: Thomas Heijligen. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58468 ) Change subject: ich_descriptors_tool/Makefile: TARGET_OS is given as cmdline argument ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > When building stand-alone for MinGW or DOS you have to pass TARGET_OS=MinGW/DOS ¯\_(ツ)_/¯ > Was that the case before? -- To … [View More]

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit October 2021