October 2021 - flashrom-gerrit

Change in flashrom[master]: flashrom_tester: Use elogtool to list firmware eventlog
by Edward O'Callaghan (Code Review) 24 Oct '21

24 Oct '21

Attention is currently required from: Furquan Shaikh, Jack Rosenthal. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58527 ) Change subject: flashrom_tester: Use elogtool to list firmware eventlog ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File util/flashrom_tester/src/cros_sysinfo.rs: https://review.coreboot.org/c/flashrom/+/58527/comment/1dc75c3c_f9905785 PS2, Line 70: "/usr/bin/elogtool" > Idea: Put this path in a constant to avoid repeating it here and in the log message above? Jack, thanks for the patch and sending to upstream first! -- To view, visit https://review.coreboot.org/c/flashrom/+/58527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8c4be82fed28b6a19746e6b93fafce23bd8ede5d Gerrit-Change-Number: 58527 Gerrit-PatchSet: 2 Gerrit-Owner: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Ricardo Quesada <ricardoq(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Comment-Date: Sun, 24 Oct 2021 23:58:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips.c: big erase blocksize first
by Angel Pons (Code Review) 23 Oct '21

23 Oct '21

Attention is currently required from: Simon Buhrow, Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58467 ) Change subject: flashchips.c: big erase blocksize first ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Just a starting point for discussion. […] Have you tried with random data? You can create a file with random data like this: dd if=/dev/urandom of=random_data_1.bin count=1 bs=8MiB Replace `8MiB` with the size of your flash chip. Then, make a copy of the file (I use `random_data_2.bin` in the commands) and change the first 16 bytes with this: dd if=/dev/urandom of=random_data_2.bin count=1 bs=16 conv=notrunc Then, flash the first file and measure how long flashing the second file takes, without erasing anything manually: sudo flashrom -p ft2232_spi:type=2232H,port=A -w random_data_1.bin -VV time sudo flashrom -p ft2232_spi:type=2232H,port=A -w random_data_2.bin -VV I expect the measured time to increase dramatically with this change. This is because flashrom is smart and only rewrites the parts of the chip which have changed. With a larger erase block size, the part of the flash chip that needs to be rewritten is much larger. Instead, it would be much better to have flashrom automatically choose the optimal erase block size. I think something like this would be a good start: 1. Using the smallest erase block size as unit, determine which blocks need to be erased. 2. Try to use larger erase block sizes: check if multiple successive small blocks that need to be erased can instead be erased at once with a larger block eraser. 3. Proceed with erasing and rewriting with the obtained results. IIRC, flashrom currently erases and writes one block at a time. Even though erasing all the blocks first would be easier to implement, it would be significantly more dangerous in case something goes wrong. This is especially important when flashing internally (i.e. firmware updates) because errors can result in a non-booting computer. -- To view, visit https://review.coreboot.org/c/flashrom/+/58467 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I862ce0b5f8912565e43c340578d8126aa2e6aa3b Gerrit-Change-Number: 58467 Gerrit-PatchSet: 1 Gerrit-Owner: Simon Buhrow Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Simon Buhrow Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Sat, 23 Oct 2021 10:06:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Simon Buhrow Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: remove NEED_LIBUSB1 from FEATURE_CFLAGS
by Thomas Heijligen (Code Review) 22 Oct '21

22 Oct '21

Attention is currently required from: Nico Huber, Thomas Heijligen. Hello build bot (Jenkins), Nico Huber, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58518 to look at the new patch set (#3). Change subject: Makefile: remove NEED_LIBUSB1 from FEATURE_CFLAGS ...................................................................... Makefile: remove NEED_LIBUSB1 from FEATURE_CFLAGS NEED_LIBUSB1 is not used outside of the Makefile. No need to pass it to the compiler. Change-Id: Ie7cb3df39daf22cb954186d38ba32812b05d92f9 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M Makefile 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/18/58518/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/58518 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie7cb3df39daf22cb954186d38ba32812b05d92f9 Gerrit-Change-Number: 58518 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Makefile: meson.build: remove unused CONFIG_I2C_SUPPORT
by Thomas Heijligen (Code Review) 22 Oct '21

22 Oct '21

Attention is currently required from: Nico Huber, Thomas Heijligen. Hello build bot (Jenkins), Nico Huber, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58495 to look at the new patch set (#4). Change subject: Makefile: meson.build: remove unused CONFIG_I2C_SUPPORT ...................................................................... Makefile: meson.build: remove unused CONFIG_I2C_SUPPORT CONFIG_I2C_SUPPORT has no mention in the source code. No need to pass it to the compiler. Change-Id: I2e19335e1b8d39f44dda14edc0a496dda6bc8c9c Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M Makefile M meson.build 2 files changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/95/58495/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/58495 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2e19335e1b8d39f44dda14edc0a496dda6bc8c9c Gerrit-Change-Number: 58495 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Makefile, ich_descriptors_tool/Makefile: unify behavior
by Thomas Heijligen (Code Review) 22 Oct '21

22 Oct '21

Attention is currently required from: Nico Huber, Angel Pons. Hello build bot (Jenkins), Nico Huber, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58468 to look at the new patch set (#4). Change subject: Makefile, ich_descriptors_tool/Makefile: unify behavior ...................................................................... Makefile, ich_descriptors_tool/Makefile: unify behavior make clean: use $(PROGRAMM)$(EXEC_SUFFIX) instead of removing the Unix and Windows binary separately. ich_descriptors_tool/Makefile: have the same behavior like the main flashrom Makefile - only set gcc explicit on MinGW HOST_OS - don't fallback to gcc if CC was not set - set CFLAGS and EXEC_SUFFIX for TARGET_OS, not for HOST_OS Don't pass the TARGET_OS and EXEC_SUFFIX from the main Makefile to ich_descriptors_tool/Makefile. Change-Id: I353c3de250167994a4aea1edfef57d839e900d78 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M Makefile M util/ich_descriptors_tool/Makefile 2 files changed, 8 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/68/58468/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/58468 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I353c3de250167994a4aea1edfef57d839e900d78 Gerrit-Change-Number: 58468 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Makefile: unify the use of filter
by Thomas Heijligen (Code Review) 22 Oct '21

22 Oct '21

Attention is currently required from: Thomas Heijligen. Hello build bot (Jenkins), Nico Huber, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58451 to look at the new patch set (#3). Change subject: Makefile: unify the use of filter ...................................................................... Makefile: unify the use of filter Make a filter statement easier to read and fix some cosmetics. Change-Id: I6cd1e169b435cadb06423836cd9d64cdd2f51a94 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M Makefile 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/51/58451/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/58451 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6cd1e169b435cadb06423836cd9d64cdd2f51a94 Gerrit-Change-Number: 58451 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: flashrom_tester: Use elogtool to list firmware eventlog
by Angel Pons (Code Review) 22 Oct '21

22 Oct '21

Attention is currently required from: Furquan Shaikh, Jack Rosenthal, Edward O'Callaghan. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58527 ) Change subject: flashrom_tester: Use elogtool to list firmware eventlog ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File util/flashrom_tester/src/cros_sysinfo.rs: https://review.coreboot.org/c/flashrom/+/58527/comment/bef6bb02_892c0ec1 PS2, Line 70: "/usr/bin/elogtool" Idea: Put this path in a constant to avoid repeating it here and in the log message above? -- To view, visit https://review.coreboot.org/c/flashrom/+/58527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8c4be82fed28b6a19746e6b93fafce23bd8ede5d Gerrit-Change-Number: 58527 Gerrit-PatchSet: 2 Gerrit-Owner: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Ricardo Quesada <ricardoq(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Fri, 22 Oct 2021 09:47:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: sb600spi: Cleanup spispeed and spireamode warnings
by Angel Pons (Code Review) 22 Oct '21

22 Oct '21

Attention is currently required from: Rob Barnes. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58529 ) Change subject: sb600spi: Cleanup spispeed and spireamode warnings ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/58529 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idf5e735b9e504c943bf93a428da64976d723eb2c Gerrit-Change-Number: 58529 Gerrit-PatchSet: 1 Gerrit-Owner: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Comment-Date: Fri, 22 Oct 2021 09:41:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile, ich_descriptors_tool/Makefile: unify behavior
by Thomas Heijligen (Code Review) 22 Oct '21

22 Oct '21

Attention is currently required from: Nico Huber, Angel Pons. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58468 ) Change subject: Makefile, ich_descriptors_tool/Makefile: unify behavior ...................................................................... Patch Set 3: (7 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/58468/comment/9be0a697_9179f5d2 PS2, Line 7: descriptor > nit: missing plural `s` in `descriptors` Done https://review.coreboot.org/c/flashrom/+/58468/comment/baeebb51_5460b001 PS2, Line 9: remove > use gerund form: `removing` Done https://review.coreboot.org/c/flashrom/+/58468/comment/a3f8a67a_4deb6c85 PS2, Line 12: descriptor > nit: missing plural `s` in `descriptors` Done https://review.coreboot.org/c/flashrom/+/58468/comment/84bdffea_a5bbf48b PS2, Line 13: Makefie > typo: missing `l` in `Makefile` Done https://review.coreboot.org/c/flashrom/+/58468/comment/79b9cb47_103fded5 PS2, Line 16: set CFLAGS and EXEC_SUFFIX for TARGET_OS not for the HOST_OS > Two nits: […] Done https://review.coreboot.org/c/flashrom/+/58468/comment/6bdac599_40f40b2f PS2, Line 19: descriptor > nit: missing plural `s` in `descriptors` Done File util/ich_descriptors_tool/Makefile: https://review.coreboot.org/c/flashrom/+/58468/comment/1c6daba0_f558cac1 PS2, Line 42: */ > nit: remove? Done -- To view, visit https://review.coreboot.org/c/flashrom/+/58468 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I353c3de250167994a4aea1edfef57d839e900d78 Gerrit-Change-Number: 58468 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 22 Oct 2021 09:34:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: meson.build: remove unused CONFIG_I2C_SUPPORT
by Thomas Heijligen (Code Review) 22 Oct '21

22 Oct '21

Attention is currently required from: Nico Huber, Thomas Heijligen. Hello build bot (Jenkins), Nico Huber, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58495 to look at the new patch set (#3). Change subject: Makefile: meson.build: remove unused CONFIG_I2C_SUPPORT ...................................................................... Makefile: meson.build: remove unused CONFIG_I2C_SUPPORT CONFIG_I2C_SUPPORT has no mention in the source code. No need to pass it to the compiler. Change-Id: I2e19335e1b8d39f44dda14edc0a496dda6bc8c9c Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de> --- M Makefile M meson.build 2 files changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/95/58495/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/58495 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2e19335e1b8d39f44dda14edc0a496dda6bc8c9c Gerrit-Change-Number: 58495 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit October 2021